Uncaught TypeError: Cannot read property 'isChanged' of undefined

[borishere]

[Enter steps to reproduce:]

1. Make some differences in your file (remove a few lines)
2. Open your file in Unstaged Changes mode
3. Right mouse click on one of your deleted lines - Discard Selection
4. Right mouse click on another deleted line - error appears

Atom: 1.18.0-beta2 x64
Electron: 1.3.15
OS: Microsoft Windows 10 Enterprise N 2015 LTSB
Thrown From: github package 0.2.0

Stack Trace

Uncaught TypeError: Cannot read property 'isChanged' of undefined

At C:\Users\user\AppData\Local\atom\app-1.18.0-beta2\resources\app\node_modules\github\lib\views\file-patch-selection.js:32

TypeError: Cannot read property 'isChanged' of undefined
    at Object.isItemSelectable (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/file-patch-selection.js:32:109)
    at ListSelection.isItemSelectable (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/list-selection.js:80:31)
    at ListSelection.getSelectedItems (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/list-selection.js:278:24)
    at FilePatchSelection.getSelectedLines (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/file-patch-selection.js:331:40)
    at FilePatchSelection.getSelectedHunks (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/file-patch-selection.js:259:40)
    at FilePatchView.render (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/file-patch-view.js:108:54)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactCompositeComponent.js:799:36)
    at ReactCompositeComponentWrapper._renderValidatedComponent (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactCompositeComponent.js:822:38)
    at ReactCompositeComponentWrapper._updateRenderedComponent (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactCompositeComponent.js:746:42)
    at ReactCompositeComponentWrapper._performComponentUpdate (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactCompositeComponent.js:724:16)
    at ReactCompositeComponentWrapper.updateComponent (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactCompositeComponent.js:645:18)
    at ReactCompositeComponentWrapper.performUpdateIfNecessary (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactCompositeComponent.js:561:18)
    at Object.performUpdateIfNecessary (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactReconciler.js:157:28)
    at runBatchedUpdates (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactUpdates.js:150:27)
    at ReactReconcileTransaction.perform (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/Transaction.js:140:26)
    at ReactUpdatesFlushTransaction.perform (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/Transaction.js:140:26)
    at ReactUpdatesFlushTransaction.perform (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactUpdates.js:89:38)
    at Object.flushBatchedUpdates (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactUpdates.js:172:25)
    at ReactDefaultBatchingStrategyTransaction.closeAll (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/Transaction.js:206:31)
    at ReactDefaultBatchingStrategyTransaction.perform (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/Transaction.js:153:22)
    at Object.batchedUpdates (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactDefaultBatchingStrategy.js:62:32)
    at Object.enqueueUpdate (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactUpdates.js:200:28)
    at enqueueUpdate (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactUpdateQueue.js:24:22)
    at Object.enqueueSetState (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react-dom/lib/ReactUpdateQueue.js:219:11)
    at FilePatchView.ReactComponent.setState (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/react/lib/ReactComponent.js:63:22)
    at FilePatchView.contextMenuOnItem (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/file-patch-view.js:255:18)
    at Object.contextMenuOnItem (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/hunk-view.js:100:65)
    at onWillShowContextMenu (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/views/hunk-view.js:152:58)
    at Function.handle (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/context-menu-interceptor.js:32:15)
    at HTMLDocument.contextMenuHandler (~/AppData/Local/atom/app-1.18.0-beta2/resources/app/node_modules/github/lib/context-menu-interceptor.js:68:32)

Commands

     -0:32.3.0 tree-view:show (atom-workspace.workspace.scrollbars-visible-always)
     -0:14.6.0 github:discard-selected-lines (div.github-HunkView-lineContent)

Non-Core Packages

atom-beautify 0.29.26 
atom-live-server 2.1.2 
atom-unsaved-changes 0.4.0 
autocomplete-paths 1.0.5 
block-comment 0.4.3 
build 0.68.0 
build-sass 0.11.0 
busy 0.7.0 
busy-signal 1.4.1 
color-picker 2.2.5 
console-log 1.10.0 
ctrl-dir-scroll 0.2.3 
cursor-blink-interval 0.3.1 
fake-image-snippets 1.1.0 
file-icons 2.1.6 
file-watcher 1.1.0 
filesize 3.0.0 
fonts 2.1.0 
goto-definition 1.3.3 
highlight-selected 0.13.1 
inc 0.0.4 
intentions 1.1.2 
jquery-snippets 11.0.0 
linter 2.1.4 
linter-eslint 8.2.1 
linter-htmlhint 1.3.3 
linter-jsonlint 1.3.0 
linter-less 2.6.0 
linter-scss-lint 3.1.0 
linter-ui-default 1.6.0 
minimap 4.28.2 
minimap-bookmarks 0.4.2 
minimap-find-and-replace 4.5.2 
minimap-git-diff 4.3.1 
minimap-highlight-selected 4.6.1 
minimap-linter 2.0.0 
minimap-pigments 0.2.2 
minimap-selection 4.4.0 
minimap-split-diff 0.3.7 
my-package 0.0.0 
open-in-browser 0.5.2 
pigments 0.39.1 
project-manager 3.3.5 
random 1.3.0 
split-diff 1.4.0 
sync-settings 0.8.1 
tree-view-autoresize 2.0.0 

[rsese]

Thanks for the report! Can you confirm if the error is reproducible and if so, can you reproduce in safe mode (atom --safe)?

I just made a 1 line change, then right-clicked in the Git tab and selected "Discard Changes" but wasn't able to reproduce on 1.18.0-beta2 and Windows 10.

[borishere]

@rsese Hi, I can reproduce it in safe mode too.

1. Make some differences in your file (remove a few lines)
2. Open your file in Unstaged Changes mode
3. Right mouse click on one of your deleted lines - Discard Selection
4. Right mouse click on another deleted line - error appears

[rsese]

ahhh great, thanks for the detailed steps to reproduce - with these steps I can reproduce. I'll go ahead and update the steps to repro in the OP ✌️

[jtbairdsr]

just FYI, I have reproduced this issue on macOS Sierra, also in Atom 1.18.0-beta2

[deckar01]

I was able to reproduce in Atom 1.19.0-dev-0cd482cbf on OpenSUSE Tumbleweed.

I was not able to reproduce in Atom 1.19.0-beta0 on MacOS 10.12.

[fteotini]

same err on windows 10

[danicr83]

Same for me (Windows 7, Atom 1.18.0 x64) and closing tooltip with error is almost impossible: wherever you click you got it again and again untill you close the tab

[brunetton]

Same on 1.18.0 x64 (Debian)

[deckar01]

Here is an alternate set of repro steps:

1. Modify more than one line in a file
2. View the "Unstaged Changes" diff for the file using the "Git Tab"
3. Select 2 or more modified lines
4. Right click on the selected lines

Before the context menu even opens the exception occurs. Selecting a single line does not seem to have this problem.

[Volcanic-Penguin]

I was seriously wondering if the "Discard Selection" button in the upper right corner just meant deselecting, as nothing was happening.

[MCOfficer]

I got the exact same stacktrace, but with different steps.
edit: reproducable even in safe mode.

[Enter steps to reproduce:]

1. make changes
2. enter show hunk mode
3. stage/unstage selections

Atom: 1.18.0 x64
Electron: 1.3.15
OS: Linux Mint
Thrown From: github package 0.3.3

Commands

     -2:26.3.0 core:move-right (input.hidden-input)
     -2:16 intentions:highlight (input.hidden-input)
     -2:15.4.0 core:select-all (input.hidden-input)
     -2:14.4.0 intentions:highlight (input.hidden-input)
     -2:13.2.0 core:save (input.hidden-input)
  2x -1:30.6.0 core:confirm (span.github-HunkView-plusMinus)

Non-Core Packages

atom-beautify 0.30.3 
atom-python-run 0.7.3 
busy-signal 1.4.3 
Hydrogen 1.18.0 
intentions 1.1.2 
linter 2.2.0 
linter-flake8 2.2.1 
linter-ui-default 1.6.2 
minimap 4.28.2 
save-session 0.15.7