Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Improved GitHub tab blank-slate behavior - #2111

Merged
smashwilson merged 16 commits into
masterfrom
aw/fr/blank-slate
Nov 15, 2019
Merged

Improved GitHub tab blank-slate behavior#2111
smashwilson merged 16 commits into
masterfrom
aw/fr/blank-slate

Conversation

@smashwilson

@smashwilsonsmashwilson commented May 1, 2019

Copy link
Copy Markdown
Contributor

The current behavior of the GitHub tab when you have no repository or a repository with no GitHub remotes is really unhelpful: we either show a blank tab or a message saying "no remotes" that you can't do anything about until you go to the command line. We also don't have good support for the fairly common scenario where a user wants to push new branches to a different remote than the one they want to see pull requests from (say, when they've forked an open-source repository to contribute).

I'd like to redesign the GitHub tab's "empty" states to be more friendly, informative and actionable.

Prototypes

To access the prototypes I've used to create the screenshots in this feature request, check out the branch prototypes/aw/blank-slate, then:

  • For the GitHub tab blank states: Open the GitHub package settings in the Settings view. Find the "Prototype scenario" setting and choose a value other than "none" to see the different mocks.
  • For the dialog mocks: Run one of the following commands from the command palette. Focus the dialog and press esc to dismiss.
    • github:proto-clone-dialog-empty-search
    • github:proto-clone-dialog-search-results
    • github:proto-clone-dialog-github
    • github:proto-clone-dialog-nongithub
    • github:proto-create-dialog
    • github:proto-publish-dialog

View rendered docs/feature-requests/005-blank-slate.md

@smashwilsonsmashwilson added the feature request Propose new features or design label May 1, 2019
@codecov

codecovBot commented May 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2111 +/- ##
=======================================
Coverage 92.75% 92.75% =======================================
Files 219 219 Lines 12322 12322 Branches 1793 1793 =======================================
Hits 11429 11429 Misses 893 893

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8aa3b8...c9925e3. Read the comment docs.

@smashwilson

Copy link
Copy Markdown
ContributorAuthor

Note to self: I should add an https/git protocol toggle to the clone and connect dialogs.

@smashwilson
smashwilson marked this pull request as ready for review May 6, 2019 19:39
@smashwilson
smashwilson requested a review from a teamMay 6, 2019 19:39
@smashwilson

Copy link
Copy Markdown
ContributorAuthor

I think this is ready for more eyes 👀

@vanessayuennvanessayuenn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing this up @smashwilson ✨! A lot of use cases are covered and is very thoroughly thought out. Since the main objective of this feature is to make it easier for users who are unfamiliar with git/GitHub workflow to get started, I think keeping any new UI and workflow simple would be crucial. I suggested some ways to further simplify the UI, as well as my thoughts on excluding the forking workflow on this iteration.

Comment threaddocs/feature-requests/005-blank-slate.md Outdated
Comment threaddocs/feature-requests/005-blank-slate.md
Comment threaddocs/feature-requests/005-blank-slate.md
Comment threaddocs/feature-requests/005-blank-slate.md Outdated
Comment threaddocs/feature-requests/005-blank-slate.md Outdated
Comment threaddocs/feature-requests/005-blank-slate.md
Comment threaddocs/feature-requests/005-blank-slate.md
@smashwilson

Copy link
Copy Markdown
ContributorAuthor

Thanks for the feedback, @vanessayuenn! As usual the UX is feeling worlds better after your comments 😁

@smashwilsonsmashwilson mentioned this pull request Jul 17, 2019
5 tasks
@smashwilsonsmashwilson mentioned this pull request Jul 23, 2019
18 tasks
@smashwilsonsmashwilson mentioned this pull request Nov 6, 2019
4 tasks
@smashwilson

Copy link
Copy Markdown
ContributorAuthor

I'm going to punt on the clone dialog enhancements, at least for now. It feels like searching for repos in Atom wouldn't be as much of a high-demand operation... pasting in a clone URL isn't that bad, for the additional complexity of the new dialog I was thinking about.

Calling this otherwise complete 🎉

@smashwilson
smashwilson merged commit 0b19e6d into masterNov 15, 2019
@smashwilson
smashwilson deleted the aw/fr/blank-slate branch November 15, 2019 22:20
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature requestPropose new features or design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@smashwilson@vanessayuenn@rsese