This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Namespaces, definitions, dynamic variables, metadata and #13
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6b01452
Detecting namespaced symbols (e.g. string/join), and trying to distin…
a7f22f6
Understanding metadata and dynamic variables.
bf4e563
Biting the bullet and copy-and-pasting #symbol to generate entity.glo…
33ccde1
Reversing package.json for a pull request.
e068127
Properly rendering namespaced variables; detecting the beginning and …
6116204
Merge branch 'master' of https://github.com/atom/language-clojure int…
1bb409b
Removing an unnecessary \n pattern.
bdac0e1
Scopes for the beginnings/ends of maps/sets are now punctuation.secti…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to have these all escaped since they are already in a character class. The only ones for sure would be things like
\wand-to differentiate it from a range.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. I copied it from somewhere else in the grammar; maybe the
#keyworddefinition. Works well enough 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, lets just leave it then