Update tree-sitter-python + Add missing tree-sitter scopes by aminya · Pull Request #325 · atom/language-python

aminya · 2020-10-28T23:21:35Z

Description of the Change

This updates tree-sitter python dependency.

Benefits

Bug fixes: tree-sitter/tree-sitter-python@v0.15.1...v0.17.0

Applicable Issues

Solves some of the open issues regarding syntax highlighting.

Fixes#324
Fixes#134
Fixes#273
Fixes#312

Allows removing the Kite's workaround for tree-sitter:
https://github.com/kiteco/atom-plugin/pull/704

aminya · 2021-01-08T16:54:25Z

@sadick254 @darangi Please take a look.

Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

tree-sitter/tree-sitter-python#96

chbk · 2021-01-12T04:58:19Z

As a heads-up, #313 also fixes the missing scopes mentioned here. That said, it's part of a larger ecosystem of PRs that might take time to (hopefully) get merged, so I'm glad to see this fixed now.

aminya · 2021-01-12T05:14:04Z

As a heads-up, #313 also fixes the missing scopes mentioned here. That said, it's part of a larger ecosystem of PRs that might take time to (hopefully) get merged, so I'm glad to see this fixed now.

Thanks for the PR. I only need a few of these commits in my PR so I can close many things here and there. If you can rebase after me, that would be great.

cc: @sadick254

ThatXliner · 2021-01-15T23:35:33Z

What’s the status on this? Because once this is merged, kite should also merge the “remove workaround” (a.k.a. Stop it nagging me). Then I get to enjoy performing atom 😎

aminya · 2021-01-15T23:46:30Z

This is ready to go. We are awaiting one of the maintainers to merge this.
@sadick254 @darangi

ThatXliner · 2021-01-18T00:50:59Z

@jeff-hykin (the reviewer)

jeff-hykin · 2021-01-18T16:32:16Z

@ThatXliner Not sure why I'm reviewer, but I added a review 😁

darangi · 2021-01-18T16:35:27Z

Thanks @aminya , We will look into this

darangi · 2021-01-27T18:12:10Z

@aminya could you resolve this conflict so I merge this in? Thanks for your contributions 🙇🏾

aminya · 2021-01-27T18:36:49Z

Thank you! The conflict was only the deleted travis file.

jeff-hykin · 2021-01-18T16:29:26Z

 '^(BaseException|Exception|TypeError|StopAsyncIteration|StopIteration|ImportError|ModuleNotFoundError|OSError|ConnectionError|BrokenPipeError|ConnectionAbortedError|ConnectionRefusedError|ConnectionResetError|BlockingIOError|ChildProcessError|FileExistsError|FileNotFoundError|IsADirectoryError|NotADirectoryError|InterruptedError|PermissionError|ProcessLookupError|TimeoutError|EOFError|RuntimeError|RecursionError|NotImplementedError|NameError|UnboundLocalError|AttributeError|SyntaxError|IndentationError|TabError|LookupError|IndexError|KeyError|ValueError|UnicodeError|UnicodeEncodeError|UnicodeDecodeError|UnicodeTranslateError|AssertionError|ArithmeticError|FloatingPointError|OverflowError|ZeroDivisionError|SystemError|ReferenceError|BufferError|MemoryError|Warning|UserWarning|DeprecationWarning|PendingDeprecationWarning|SyntaxWarning|RuntimeWarning|FutureWarning|ImportWarning|UnicodeWarning|BytesWarning|ResourceWarning|GeneratorExit|SystemExit|KeyboardInterrupt)$'
- scopes: 'support.type.exception'}
+ scopes: 'support.type.exception'},
+ {match: '^(self)', scopes: 'entity.name.variable.self'}


This needs ^(self)\\b otherwise it'll match the self in selfserve and other things

jeff-hykin · 2021-01-18T16:31:12Z

 'default_parameter > identifier:nth-child(0)': 'variable.parameter.function'
 'keyword_argument > identifier:nth-child(0)': 'variable.parameter.function'
+ 'lambda_parameters > identifier': 'variable.parameter.function'
+ 'typed_parameter > identifier': 'variable.parameter.function'


Not sure why .function is on there (aren't parameters always part of a function?)

jeff-hykin · 2021-02-13T02:31:58Z

(😬 I was cleaning out my notifications and realized I commented "but I added a review" without clicking "submit" on my review)

aminya · 2021-02-13T03:05:35Z

Thanks for the review. Do you want to make a PR to fix these?

jeff-hykin · 2021-02-13T20:45:17Z

The first comment should probably be a PR, although that edgecase bug I'm describing probably happens other places too. Its a really common bug with a very very small edgecase. The other comment was just clarification.

MdAbulHossain1

@aminya

⬆️ Update tree-sitter-python
faf1e57

aminya changed the title ~~⬆️ Update tree-sitter-python~~Update tree-sitter-python Oct 28, 2020

Update Travis linux distro
ad4b980

aminya mentioned this pull request Nov 21, 2020
GitHub Actions atom/language-java#238
Open

⬆️ bump tree-sitter-python to 0.17.0
ebe8830

aminyaand others added 5 commits January 8, 2021 11:59

Add keyword.control.return
d989f9a
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Add punctuations
c2b79f1
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Use function.def for function_definition
6325ed1
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Use function.call for call
89351c1
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Support constructor
b0a77d5
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

aminya changed the title ~~Update tree-sitter-python~~ Update tree-sitter-python + Add missing tree-sitter scopesJan 8, 2021

aminyaand others added 3 commits January 8, 2021 12:15

Support lambda parameters
37c8e1d
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Support typed parameters
98cab19
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

Support self matching
6e5de57
Co-Authored-By: Eric Shimizu Karbstein <17973728+GrayJack@users.noreply.github.com>

aminya mentioned this pull request Jan 8, 2021
Matching method call tree-sitter/tree-sitter-python#96
Closed

Support argument list
4d96607
tree-sitter/tree-sitter-python#96

jeff-hykin reviewed Jan 8, 2021
View reviewed changes

Comment threadgrammars/tree-sitter-python.cson Outdated

use entity.name.function.definition
5d54870

darangi added under-review and removed under-review labels Jan 18, 2021

darangi added the triaged label Jan 18, 2021

Merge remote-tracking branch 'upstream/master'
9314882

darangi merged commit 6d7026e into atom:masterJan 27, 2021

ThatXliner mentioned this pull request Feb 1, 2021
Language Ruby atom/atom#21915
Closed

aminya mentioned this pull request Feb 1, 2021
Release a new version #330
Closed

jeff-hykin reviewed Feb 13, 2021
View reviewed changes

MdAbulHossain1 reviewed Jan 17, 2022
View reviewed changes

Uh oh!

Conversation

aminya commented Oct 28, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the Change

Benefits

Applicable Issues

Uh oh!

aminya commented Jan 8, 2021

Uh oh!

Uh oh!

chbk commented Jan 12, 2021

Uh oh!

aminya commented Jan 12, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThatXliner commented Jan 15, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aminya commented Jan 15, 2021

Uh oh!

ThatXliner commented Jan 18, 2021

Uh oh!

jeff-hykin commented Jan 18, 2021

Uh oh!

darangi commented Jan 18, 2021

Uh oh!

darangi commented Jan 27, 2021

Uh oh!

aminya commented Jan 27, 2021

Uh oh!

jeff-hykinJan 18, 2021

Choose a reason for hiding this comment

Uh oh!

jeff-hykinJan 18, 2021

Choose a reason for hiding this comment

Uh oh!

jeff-hykin commented Feb 13, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aminya commented Feb 13, 2021

Uh oh!

jeff-hykin commented Feb 13, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MdAbulHossain1 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aminya commented Oct 28, 2020•
edited
Loading

aminya commented Jan 12, 2021•
edited
Loading

ThatXliner commented Jan 15, 2021•
edited
Loading

jeff-hykin commented Feb 13, 2021•
edited
Loading

jeff-hykin commented Feb 13, 2021•
edited
Loading