Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fix memory leaks on macOS and memory exposure vulnerability - #293

Merged
shiftkey merged 1 commit into
atom:masterfrom
appden:master
Oct 12, 2020
Merged

Fix memory leaks on macOS and memory exposure vulnerability#293
shiftkey merged 1 commit into
atom:masterfrom
appden:master

Conversation

@appden

@appden appden commented Aug 1, 2020

Copy link
Copy Markdown
Contributor

This fix memory leaks that were found with the Xcode memory leak tool. This also upgrades bl to fix a remote memory exposure vulnerability: https://snyk.io/vuln/SNYK-JS-BL-608877

@appden

appden commented Aug 31, 2020

Copy link
Copy Markdown
Contributor Author

@shiftkey Would you mind reviewing this one? Thanks!

@appden appden changed the title Fix memory leaks on macOS Fix memory leaks on macOS and memory exposure vulnerability Aug 31, 2020
@shiftkey

Copy link
Copy Markdown
Contributor

@appden apologies for the delay - I must have missed this notification.

It looks like bl was updated in #306 which I merged so I'm going to try and rebase this on top of master and review the other changes.

These leaks popped up in the Xcode memory leak tool.

@shiftkey shiftkey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough - thanks for the contribution @appden!

@shiftkey
shiftkey merged commit a6ee40c into atom:master Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants