Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add support for Electron 10 - #307

Merged
shiftkey merged 1 commit into
atom:masterfrom
romansp:patch-1
Oct 12, 2020
Merged

Add support for Electron 10#307
shiftkey merged 1 commit into
atom:masterfrom
romansp:patch-1

Conversation

@romansp

@romansp romansp commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

Add new prebuild targets as Electron 10 has been released:
https://github.com/electron/electron/releases/tag/v10.0.0

@Kupstas

Kupstas commented Jan 26, 2021

Copy link
Copy Markdown

I still have an error at electron 10. Are you sure that prebuild version exists?

@shiftkey

Copy link
Copy Markdown
Contributor

@Kupstas please ensure that you are on v7.0.0 or later, to get the prebuild version

@Kupstas

Kupstas commented Jan 27, 2021

Copy link
Copy Markdown

I tried 7.3.0

@Kupstas

Kupstas commented Jan 27, 2021

Copy link
Copy Markdown

BTW do you have prebuild version for electron 11?

@shiftkey

Copy link
Copy Markdown
Contributor

I tried 7.3.0

Please open a fresh issue with repro details

BTW do you have prebuild version for electron 11?

Not currently. I'm not following the Node/Electron ecosystems closely these days to track when these new releases happen...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants