This repository was archived by the owner on Dec 15, 2022. It is now read-only.
fix: add missing handlescope - #332
Merged
Merged
Conversation
Contributor
Author
|
/cc @shiftkey |
shiftkey
approved these changes
Nov 19, 2020
shiftkey
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix @deepak1556!
Contributor
Author
|
Thanks for merging! I see that master is bumped to 7.2.0, can I expect a new npm release today ? |
Contributor
|
@deepak1556 oops, I forgot to publish to NPM. |
Contributor
Author
|
great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
With Electron 10 and higher , there is no longer a global handlescope in the browser process electron/electron#22531 . With recent upgrade to Electron 11 in vscode we saw a crash in keytar module due to missing handlescope microsoft/vscode#110906
Release Notes