Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

CI: Add prebuilt binaries for alpine - #354

Merged
shiftkey merged 1 commit into
atom:masterfrom
orgads:build-alpine
Mar 25, 2021
Merged

CI: Add prebuilt binaries for alpine#354
shiftkey merged 1 commit into
atom:masterfrom
orgads:build-alpine

Conversation

@orgads

@orgads orgads commented Feb 8, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@orgads

orgads commented Feb 8, 2021

Copy link
Copy Markdown
Contributor Author

How do you deploy the binaries to github? Is it done by travis? Should I add alpine there too?

@orgads

orgads commented Feb 11, 2021

Copy link
Copy Markdown
Contributor Author

@dennisameling @shiftkey Can you please review this?

By the way - Why do you use both travis and github actions?

@shiftkey

Copy link
Copy Markdown
Contributor

How do you deploy the binaries to github? Is it done by travis? Should I add alpine there too?

Yes, that's the current situation. If you're willing to wire up Travis CI that'll help me get a release out sooner for this.

By the way - Why do you use both travis and github actions?

It's a transition period and I've not had bandwidth to get this wrapped. #320 has been tracking that work but it's been stuck for a while as #334 needs to be merged which is a significant chunk of the remaining work.

@shiftkey shiftkey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this @orgads! I resolved some conflicts so I could see this in action, and I think there's a path forward to getting this ready to merge for our next release...

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated

@shiftkey shiftkey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @orgads!

This support will be part of the next release, hopefully on the weekend unless something has gone awry with the rest of the Actions automation in the update I just published.

@shiftkey
shiftkey merged commit d820296 into atom:master Mar 25, 2021
@orgads
orgads deleted the build-alpine branch March 25, 2021 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants