Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Added support for armv7l arch (Raspberry Pi 32bit) - #446

Merged
sergiou87 merged 2 commits into
atom:masterfrom
nzapponi:master
Feb 11, 2022
Merged

Added support for armv7l arch (Raspberry Pi 32bit)#446
sergiou87 merged 2 commits into
atom:masterfrom
nzapponi:master

Conversation

@nzapponi

@nzapponi nzapponi commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

Requirements for Adding, Changing, or Removing a Feature

Issue or RFC Endorsed by Atom's Maintainers

#401

Description of the Change

Added support for prebuilt binaries for 32 bit ARM architecture. This is useful when compiling Electron apps that are supposed to also work on Raspberry Pi (most userlands are 32 bit there).

Alternate Designs

Not having a prebuilt binary means that every app needs to be compiled on a separate machine, which is painful.

Possible Drawbacks

None that I can think of

Verification Process

Release Notes

@nzapponi

nzapponi commented Feb 9, 2022

Copy link
Copy Markdown
Contributor Author

@sergiou87 would you mind taking a look at this when you have a minute please?

@sergiou87

Copy link
Copy Markdown
Collaborator

Yes, sorry! It's all looking good, let's see if CI gives us all 🟢

@sergiou87

Copy link
Copy Markdown
Collaborator

@nzapponi

Copy link
Copy Markdown
Contributor Author

Whoops, sorry, my bad. Let me fix that

@nzapponi

Copy link
Copy Markdown
Contributor Author

This should do it @sergiou87

@sergiou87 sergiou87 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your contribution! ❤️

@sergiou87
sergiou87 merged commit 6887662 into atom:master Feb 11, 2022
@nzapponi

Copy link
Copy Markdown
Contributor Author

@sergiou87 do you have any plans to release a new version including this PR anytime soon? Thanks!

@sergiou87

Copy link
Copy Markdown
Collaborator

No plans, but I will do one soon (hopefully this week). We're kind of busy with GitHub Desktop releases at the moment, sorry, but I will let you know 😄

@sergiou87 sergiou87 mentioned this pull request Feb 17, 2022
@sergiou87

Copy link
Copy Markdown
Collaborator

@nzapponi 7.9.0 should be ready and include armv7l binaries 😄 Please let me know if that works

@nzapponi

Copy link
Copy Markdown
Contributor Author

That's awesome, thank you!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants