Decaf /lib

[Aerijo]

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• All new code requires tests to ensure against regressions

Description of the Change

Decaffeinates the CoffeeScript files inside the /lib directory.

Also fixes a spec that expected 1 console warning, but mine was giving 5 (it didn't say what they were). As the spec tests the message wording however, it should be safe to change toBe 1 to toBeGreaterThan 0

Alternate Designs

NA

Benefits

I can understand them now & work on PRs

Possible Drawbacks

FIrst time decaffeinating. May have missed some safe manual conversions. I did note a lot of foo != null, so I wasn't sure if values would be coming in as null or undefined and left them mostly alone.

Similar with return values (I hate implicit return...). All the specs passed, but that's as much as I can really guarantee. Presumably the return value of a method would be tested if it's important or can vary.

Applicable Issues

[Arcanemagus]

Looks like the AppVeyor container for the beta build had networking issues, I restarted the build for that.

[Arcanemagus]

Almost all of this is just changing for (let ...) to for (const ...) loops. decaffeinate emits for (let ...) since that's the safer option, and expects ESLint to be used to catch (and fix) cases where it can be written as for (const ...). Unfortunately the ESLint configuration used within standard is too simple to catch these automatically.

Other than that I saw a few minor style issues and a few things that actually require changes.

[Aerijo]

@Arcanemagus I hope you didn't write out every comment each time... I'd have understood even with no comment 😄

[Arcanemagus]

Copy/paste meant it wasn't much more than the Ctrl + F to find them 😆.

[Arcanemagus]

LGTM at least, now we just need somebody to give final approval.

[rafeca]

Thanks a lot!

I've glimpsed through the changes and didn't spot anything wrong, so we're good to go 😃