Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

npm install fails with Node 12 #75

Description

@akurtakov

Description

npm install with Node 12 fails

Steps to Reproduce

  1. clone the repo
  2. make sure you are using Node 12.x
  3. npm install

Expected behavior:

Installs just fine

Actual behavior:

../src/bindings/marker-index-wrapper.cc:350:43: error: no matching function for call to ‘v8::Integer::NumberValue()’
350 | max_count = js_max_count->NumberValue();
| ^
Is the last error but there are previous too.

Reproduces how often:

Always

Versions

Current master

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions