Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix compile script on Windows - #280
Merged
Merged
Conversation
Arcanemagus
commented
Dec 11, 2017
ContributorAuthor
WARNING: That looks like an excessive amount of deletions in the |
winstliu
commented
Dec 11, 2017
Contributor
Arcanemagus
commented
Dec 11, 2017
ContributorAuthor
I am, so it must not fix it... if it's actually a problem? |
npm uses a `CMD` based environment for running scripts on Windows, which has no emulation of the `cp` command. Bring in a development dependency on `cpy-cli` and use that in the `compile` script to allow errorless installation on Windows.
Arcanemagusforce-pushed
the
fix-windows-install
branch
from
February 13, 2018 21:34
8cabcd8 to
38e3a32CompareArcanemagus
commented
Feb 13, 2018
ContributorAuthor
Rebased on |
smashwilson
commented
Mar 29, 2018
Contributor
👍 |
This was referenced Apr 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npmuses aCMDbased environment for running scripts on Windows, which has no emulation of thecpcommand. Bring in a development dependency oncpy-cliand use that in thecompilescript to allow errorless installation on Windows.Alternative options:
copyfilesis more downloaded, butcpy-cliseems to actually duplicate the behavior ofcpFixes#219.