Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add support for TreeView decorators - #658
Open
philschatz wants to merge 1 commit into
Open
Conversation
philschatzforce-pushed
the
update-icon-status
branch
from
March 2, 2016 15:01
325e849 to
4302d46Comparephilschatz
commented
Mar 9, 2016
Author
Any updates on this? I noticed other Pull Requests were given tags but maybe this one was skipped? Also, there was a merge conflict in the tests but I rebased to remove the conflict. Thanks for making such a hackable editor! |
lee-dohm
commented
Mar 9, 2016
Contributor
I've put it in the queue for review. I'm not sure when the team will be able to get to it, but it looks interesting! |
dac09
commented
Apr 2, 2016
I've not dived into writing atom plugins yet - so can't comment on the code, but going to request the atom team to have a look 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows a package to add/remove a class on the
DirectoryorFilesimilar to theFileIconand the VCSupdateStatusmethods intree-view.FileIconand the VCSupdateStatusannotate the files/directories in different ways:FileIconsets the class once based on the filename but does not allow other packages to change the class on their own.TreeViewcould be abstracted as a provider for decorating files and directories; most of the code so far in this Pull Request is copy/pasta fromFile::updateStatus.Any thoughts on consolidating
FileIconandupdateStatusmethods by adding a decorator similar (but much simpler) toTextEditor::markBufferRangeandTextEditor::decorateMarker?This is a spike, mostly to see if there is interest before continuing
See the pull-requests package for the motivation for adding decorators: