Skip to content
This repository was archived by the owner on Jul 24, 2019. It is now read-only.

feat: Horizon Add development setting, exposing the service via a NodePort. - #111

Closed
intlabs wants to merge 1 commit into
att-comdev:masterfrom
portdirect:horizon/developer_mode
Closed

feat: Horizon Add development setting, exposing the service via a NodePort.#111
intlabs wants to merge 1 commit into
att-comdev:masterfrom
portdirect:horizon/developer_mode

Conversation

@intlabs

@intlabsintlabs commented Jan 12, 2017

Copy link
Copy Markdown
Contributor

This commit adds a development option similar to MariaDB. It simply exposes Horizon using a NodePort@31537/tcp to make is a bit more user-friendly to get going in Minikube.


This change is Reviewable

@alanmeadowsalanmeadows left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@intlabs Pete, a 0.1.0 option was added hastily to support exposing keystone for a demo. I think your approach is better. If you wouldn't mind a quick refactor and unwind my change, I'd be happy to accept this instead.

@v1k0d3n

Copy link
Copy Markdown
Collaborator

@intlabs these are good changes that we'd like to see. if you have a moment to refactor, i'll pull them in.

@v1k0d3n

Copy link
Copy Markdown
Collaborator

this got left out on an island, and there is an issue/PR that will supersede this PR. in fact #258 should've referenced this previous work. @intlabs what are your thoughts? i'll leave it up to you, and you can coordinate with @wilkers-steve on what you guys are deciding to do here.

@wilkers-steve

Copy link
Copy Markdown
Contributor

@v1k0d3n the approach for nodeports proposed in PR #261 conflicts with how it's handled for Horizon here. I'm a fan of using the approach in #261 because it doesn't tie nodeports directly to development mode. If we want that to be the case, we should address it in the node port PR and propose a tree structure that would scope them under development.

@v1k0d3n

Copy link
Copy Markdown
Collaborator

@wilkers-steve of course...this was just a quick PR to address having horizon exposed for development. i just don't like closing peoples PR's without getting their feedback first. ;)

@v1k0d3nv1k0d3n changed the title Horizon: Add development setting, exposing the service via a NodePort.feat: Horizon Add development setting, exposing the service via a NodePort.Mar 14, 2017
@intlabs

Copy link
Copy Markdown
ContributorAuthor

This has been superseded a number of times, by various methods ;) I'm good with closing this, cheers @v1k0d3n

@intlabsintlabs closed this Mar 16, 2017
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@intlabs@v1k0d3n@wilkers-steve@alanmeadows