Uh oh!
There was an error while loading. Please reload this page.
[Chart] adding-swift-chart - #197
Conversation
| images: | ||
| db_init: quay.io/stackanetes/stackanetes-kolla-toolbox:newton | ||
| db_sync: quay.io/stackanetes/stackanetes-swift-api:newton |
There was a problem hiding this comment.
Stackanetes doesn't support swift :P
There was a problem hiding this comment.
no stackanetes doesn't support we will have to create in our quay. this is currently a placeholder.
There was a problem hiding this comment.
@gardlt you can use kolla for now as a placeholder like our other charts.
| db_init: quay.io/stackanetes/stackanetes-kolla-toolbox:newton | ||
| db_sync: quay.io/stackanetes/stackanetes-swift-api:newton | ||
| api: quay.io/stackanetes/stackanetes-swift-api:newton | ||
| dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.1.0 |
There was a problem hiding this comment.
please use v0.1.1 instead of v0.1.0
There was a problem hiding this comment.
i saw this comment i will update.
There was a problem hiding this comment.
@DTadrzak good point...we should really start updating this across the project. 👍
| configmap-bin-hash: {{ tuple "configmap-bin.yaml" . | include "hash" }} | ||
| configmap-etc-hash: {{ tuple "configmap-etc.yaml" . | include "hash" }} | ||
| pod.beta.kubernetes.io/init-containers: '[ | ||
| {{ tuple $envAll $dependecies | include "dep_check_init_cont" | indent 10 }} |
There was a problem hiding this comment.
This {{ }} should not be indented so the | indent 10 would work.
gardlt
commented
Feb 20, 2017
This chart is ready to go under review. Dependencies: |
| # limitations under the License. | ||
| {{- $envAll := . }} | ||
| {{- $dependecies := .Values.dependencies.account }} |
| configmap-bin-hash: {{ tuple "configmap-bin.yaml" . | include "hash" }} | ||
| configmap-etc-hash: {{ tuple "configmap-etc.yaml" . | include "hash" }} | ||
| pod.beta.kubernetes.io/init-containers: '[ | ||
| {{ tuple $envAll $dependecies | include "helm-toolkit.kubernetes_entrypoint_init_container" | indent 10 }} |
| # limitations under the License. | ||
| {{- $envAll := . }} | ||
| {{- $dependecies := .Values.dependencies.db_sync }} |
| metadata: | ||
| annotations: | ||
| pod.beta.kubernetes.io/init-containers: '[ | ||
| {{ tuple $envAll $dependecies | include "dep_check_init_cont" | indent 10 }} |
| cpu: {{ .Values.resources.jobs.db_sync.requests.cpu | quote }} | ||
| memory: {{ .Values.resources.jobs.db_sync.requests.memory | quote }} | ||
| {{- end }} | ||
| command: |
There was a problem hiding this comment.
For consistency, we should handle db-sync here similar to how it's handled in glance: https://github.com/att-comdev/openstack-helm/blob/master/glance/templates/job-db-sync.yaml#L45
There was a problem hiding this comment.
So i been trying to look into this, but I do not believe that swift has anything like a swift-manage db_sync. you would maybe re-balance the rings. @v1k0d3n@alanmeadows
| {{- if .Values.resources.enabled }} | ||
| resources: | ||
| limits: | ||
| cpu: {{ .Values.resources.jobs.init.limits.cpu }} |
There was a problem hiding this comment.
The limits here should have | quote appended to the end of the value to maintain consistency
| images: | ||
| db_init: quay.io/stackanetes/stackanetes-kolla-toolbox:newton | ||
| db_sync: quay.io/tetrasol/centos-binary-swift-proxy-server:newton |
There was a problem hiding this comment.
For images not available through Stackanetes, we should pull these from Kolla instead since those images are reasonably maintained and they're upstream images
There was a problem hiding this comment.
does the kolla group have a docker hub or a quay registry that i can pull the images from?
There was a problem hiding this comment.
Yeah, they do. You can find them here: https://hub.docker.com/u/kolla/. I think the swift entries start on page 9.
There was a problem hiding this comment.
using kolla images. thank you for the link. 👍
wilkers-steve
left a comment
There was a problem hiding this comment.
Thanks for getting this started @gardlt. Some comments inline
* created chart for swift support * keystone swift user db endpoint creation * kolla-images * updated-values file * create swift config templates * added README * updated helm with min updates Closes-Feature: #177
wilkers-steve
commented
Apr 7, 2017
Thanks for this work @gardlt. We'll file a blueprint once we're in OpenStack to track this work going forward. Until then, we'll leave this PR open for you to reference after that point. |
v1k0d3n
commented
Apr 13, 2017
closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm |
Closes-Feature: #177
What is the purpose of this pull request?:
What issue does this pull request address?: Fixes#177
Notes for reviewers to consider:
Specific reviewers for pull request: