Uh oh!
There was an error while loading. Please reload this page.
KS endpoint type lookup for Keystone, Cinder & Glance Charts - #240
Hidden character warning
Conversation
This commit adds the revised helm lookup functions from cinder to Helm-Toolkit.
@alanmeadows If you could review at this stage it would be really appreciated. |
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: {{ .Values.service.api.name }} |
There was a problem hiding this comment.
Though I would like the service name to be configurable, I removed that option here to be consistent with other charts.
There was a problem hiding this comment.
i think that's fine. we can address/discuss once we're in openstack.
v1k0d3n
left a comment
There was a problem hiding this comment.
@intlabs looks go to me. once we get @alanmeadows 'ok' i'd like to get this in and documented before importing into OpenStack.
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: {{ .Values.service.api.name }} |
There was a problem hiding this comment.
i think that's fine. we can address/discuss once we're in openstack.
@v1k0d3n / @alanmeadows I'm fine with either merging this PR and then hitting the follow up charts in a series of rapid PRs before we move, or accumulating all of this work under this one. Though before progressing on either path I'd like to ensure that the work to date makes the grade :) |
v1k0d3n
commented
Mar 2, 2017
since @alanmeadows is out, @wilkers-steve and @larryrensing can you review this as well? @intlabs as long as we have commitment to keep driving these child PR's (please submit an Issue, as a show of intent), then I'm fine with pulling this in as is...just need the commitment. |
@v1k0d3n, I'll see it through, to the sweet ( and hopefully not bitter! ) end. I should have Glance ready to go this evening (GMT), with the remainder following tomorrow. Cheers, and thanks for your patience on this. :) |
@larryrensing or @wilkers-steve: i know you're getting a 500 when using the "Commits" tab, but can you review by selecting the "Files Changed" tab as a workaround? There are 17 files committed in this PR (at the moment), and we can still review and get merged. From the "Files Changed" tab, you can still select individual commits by using the drop-down "Changes from x commits". I think @intlabs and I are saying that things look good, but I'd like to get another set of eyes on it formally. btw: an issue has been submitted with the github team. i'm sure that this is a bug related to their UI changes this past week. |
wilkers-steve
left a comment
There was a problem hiding this comment.
Clicking the "files changed" tab is what's giving the 500.
Pete experienced the same issue with the tab, but pointed out that the mobile site works fine. From what I can see, this looks fine. LGTM
v1k0d3n
commented
Mar 4, 2017
@wilkers-steve strange, but thanks for checking it out. hopefully we don't run into this issue again. thanks @intlabs! nice cleanup. |
What is the purpose of this pull request?: To implement Keystone endpoint lookups by type for the Keystone & Cinder Charts
What issue does this pull request address?: Superceeds #208
Notes for reviewers to consider:
This is part of a series of PR's that will change each chart to use the Endpoint Type lookup method over the Endpoint Name for Keystone Endpoints.
Specific reviewers for pull request:
@alanmeadows@v1k0d3n@wilkers-steve@larryrensing@gardlt