Uh oh!
There was an error while loading. Please reload this page.
Simplify SessionTable with ConcurrentHashMap for thread safety - #2
Open
LipiLee wants to merge 3 commits into
Open
Simplify SessionTable with ConcurrentHashMap for thread safety#2LipiLee wants to merge 3 commits into
LipiLee wants to merge 3 commits into
Conversation
…below warning DataCollectorsClients/VpnCollector/app/src/main/AndroidManifest.xml:23:5-67 Warning: Element uses-permission#android.permission.INTERNET at AndroidManifest.xml:23:5-67 duplicated with element declared at AndroidManifest.xml:11:5-67
Delete synchronized when handling a modified SessionTable and change some for loops to foreachs
LipiLee
commented
Jul 4, 2017
Author
Please review this, @dn538j |
dn538j
commented
Jul 14, 2017
Collaborator
@LipiLee Sorry, I was away for a couple of days. Will complete the review soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify SessionTable with ConcurrentHashMap for thread safety
Android recommends to use ConcurrentHashMap in place of HashTable for thread safe implementation(https://developer.android.com/reference/java/util/Hashtable.html).
Remove a duplicated INTERNET permission as the build have gotten the below warning
DataCollectorsClients/VpnCollector/app/src/main/AndroidManifest.xml:23:5-67 Warning:
Element uses-permission#android.permission.INTERNET at AndroidManifest.xml:23:5-67 duplicated with element declared at AndroidManifest.xml:11:5-67