Disable animation for NO_COLOR + TERM=dumb - #584

Open
hagenw wants to merge 2 commits into
mainfrom
disable-shimmer-via-env
Open

Disable animation for NO_COLOR + TERM=dumb#584
hagenw wants to merge 2 commits into
mainfrom
disable-shimmer-via-env

Conversation

@hagenw

@hagenwhagenw commented Jul 20, 2026

Copy link
Copy Markdown
Member

Closes#582

Skips the shimmer animation if the environment variable NO_COLOR is set or the environment variable TERM is set to dumb.

@hagenwhagenw self-assigned this Jul 20, 2026
@sourcery-ai

sourcery-aiBot commented Jul 20, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Implements environment-controlled disabling of shimmer animations via NO_COLOR and TERM=dumb, centralizes the logic in a new helper, and adds tests/fixtures to ensure shimmer becomes a no-op while still printing static text once when animations are disabled.

Sequence diagram for shimmer.start behavior with NO_COLOR and TERM=dumb

sequenceDiagram
actor User
participant Shimmer
participant sys_stdout
participant animations_enabled
User->>Shimmer: start()
Shimmer->>sys_stdout: hasattr(sys_stdout, isatty)
Shimmer->>sys_stdout: isatty()
Shimmer->>animations_enabled: animations_enabled()
alt interactive_tty and animations_enabled
Shimmer->>Shimmer: _start_animation_thread()
else non_interactive or animations_disabled
Shimmer->>sys_stdout: write(prefix + text + suffix + "\n")
Shimmer->>sys_stdout: flush()
Shimmer->>Shimmer: _noop = True
end
Loading

File-Level Changes

ChangeDetailsFiles
Add centralized environment check to determine whether terminal animations are allowed and use it in Shimmer.start.
  • Introduce animations_enabled() helper that disables animations when NO_COLOR is set to a non-empty value or TERM is 'dumb', otherwise returns True
  • Update Shimmer.start() to also skip animations when animations_enabled() is False, while still printing the static text once and marking the instance as a no-op
  • Extend shimmer() context manager docstring to document that animations are skipped in non-interactive environments and when NO_COLOR or TERM=dumb disables them
audb/core/shimmer.py
Add tests ensuring shimmer behavior respects NO_COLOR/TERM=dumb and isolate tests from ambient environment.
  • Import pytest and the new animations_enabled() helper into the shimmer tests
  • Add an autouse fixture that clears NO_COLOR and sets TERM to a sane default so external environment does not influence tests
  • Add tests for animations_enabled() behavior across different NO_COLOR and TERM combinations
  • Add parametrized test verifying that shimmer becomes a no-op (no stdout.write patching) but still prints the static line exactly once when NO_COLOR or TERM=dumb are set, even when stdout is a TTY
tests/test_shimmer.py

Assessment against linked issues

IssueObjectiveAddressedExplanation
#582Disable the shimmer animation when the environment indicates that animations/colors should not be used (e.g., NO_COLOR set, TERM=dumb), while still printing the static text once.✅
#582Add or update tests to cover the new environment-based shimmer disabling behavior to prevent shimmer output from appearing in logs.✅
#582Document the new behavior of shimmer being skipped in environments disabling animations (NO_COLOR, TERM=dumb) in the shimmer implementation docstrings.✅

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@hagenwhagenw changed the title Disable shimmer animation for NO_COLOR + TERM=dumbDisable animation for NO_COLOR + TERM=dumbJul 20, 2026
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view

@hagenw

hagenw commented Jul 20, 2026

Copy link
Copy Markdown
MemberAuthor

@frankenjoe this branch should disable the animation if you run NO_COLOR=1 screen -L .... Maybe you can check if the progress bar is still appearing in the logs and we also need to disable it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

@hagenwhagenw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shimmer animation can appear in logs

1 participant

@hagenw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Disable animation for NO_COLOR + TERM=dumb - #584
Open
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Open
Disable animation for NO_COLOR + TERM=dumb#584
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Conversation
@hagenw
@hagenwhagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

Member
Closes#582
Skips the shimmer animation if the environment variable NO_COLOR is set or the environment variable TERM is set to dumb.
@hagenwhagenw
self-assigned this
Jul 20, 2026
@sourcery-ai
sourcery-aiBot
commented
Jul 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Reviewer's Guide
Implements environment-controlled disabling of shimmer animations via NO_COLOR and TERM=dumb, centralizes the logic in a new helper, and adds tests/fixtures to ensure shimmer becomes a no-op while still printing static text once when animations are disabled.
Sequence diagram for shimmer.start behavior with NO_COLOR and TERM=dumb
sequenceDiagram
actor User
participant Shimmer
participant sys_stdout
participant animations_enabled
User->>Shimmer: start()
Shimmer->>sys_stdout: hasattr(sys_stdout, isatty)
Shimmer->>sys_stdout: isatty()
Shimmer->>animations_enabled: animations_enabled()
alt interactive_tty and animations_enabled
Shimmer->>Shimmer: _start_animation_thread()
else non_interactive or animations_disabled
Shimmer->>sys_stdout: write(prefix + text + suffix + "\n")
Shimmer->>sys_stdout: flush()
Shimmer->>Shimmer: _noop = True
end

Loading
File-Level Changes
ChangeDetailsFiles
Add centralized environment check to determine whether terminal animations are allowed and use it in Shimmer.start.
  • Introduce animations_enabled() helper that disables animations when NO_COLOR is set to a non-empty value or TERM is 'dumb', otherwise returns True
  • Update Shimmer.start() to also skip animations when animations_enabled() is False, while still printing the static text once and marking the instance as a no-op
  • Extend shimmer() context manager docstring to document that animations are skipped in non-interactive environments and when NO_COLOR or TERM=dumb disables them
audb/core/shimmer.py
Add tests ensuring shimmer behavior respects NO_COLOR/TERM=dumb and isolate tests from ambient environment.
  • Import pytest and the new animations_enabled() helper into the shimmer tests
  • Add an autouse fixture that clears NO_COLOR and sets TERM to a sane default so external environment does not influence tests
  • Add tests for animations_enabled() behavior across different NO_COLOR and TERM combinations
  • Add parametrized test verifying that shimmer becomes a no-op (no stdout.write patching) but still prints the static line exactly once when NO_COLOR or TERM=dumb are set, even when stdout is a TTY
tests/test_shimmer.py
Assessment against linked issues
IssueObjectiveAddressedExplanation
#582Disable the shimmer animation when the environment indicates that animations/colors should not be used (e.g., NO_COLOR set, TERM=dumb), while still printing the static text once.✅
#582Add or update tests to cover the new environment-based shimmer disabling behavior to prevent shimmer output from appearing in logs.✅
#582Document the new behavior of shimmer being skipped in environments disabling animations (NO_COLOR, TERM=dumb) in the shimmer implementation docstrings.✅
Possibly linked issues
Tips and commands
Interacting with Sourcery
  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    
issue from a review comment by replying to it. You can also reply to a
    
review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    
request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    
the pull request body to generate a PR summary at any time exactly where you
    
want it. You can also comment @sourcery-ai summary on the pull request to
    
(re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    
request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    
pull request to resolve all Sourcery comments. Useful if you've already
    
addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    
request to dismiss all existing Sourcery reviews. Especially useful if you
    
want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
Customizing Your Experience
Access your dashboard to:
  • Enable or disable review features such as the Sourcery-generated pull request
    
summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.
Getting Help
@hagenwhagenw
changed the title
Disable shimmer animation for NO_COLOR + TERM=dumbDisable animation for NO_COLOR + TERM=dumbJul 20, 2026
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view
@hagenw
hagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

MemberAuthor
@frankenjoe this branch should disable the animation if you run NO_COLOR=1 screen -L .... Maybe you can check if the progress bar is still appearing in the logs and we also need to disable it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

@hagenwhagenw

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Shimmer animation can appear in logs


1 participant

@hagenw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable animation for NO_COLOR + TERM=dumb - #584
Open
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Open
Disable animation for NO_COLOR + TERM=dumb#584
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Conversation
@hagenw
@hagenwhagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

Member
Closes#582
Skips the shimmer animation if the environment variable NO_COLOR is set or the environment variable TERM is set to dumb.
@hagenwhagenw
self-assigned this
Jul 20, 2026
@sourcery-ai
sourcery-aiBot
commented
Jul 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Reviewer's Guide
Implements environment-controlled disabling of shimmer animations via NO_COLOR and TERM=dumb, centralizes the logic in a new helper, and adds tests/fixtures to ensure shimmer becomes a no-op while still printing static text once when animations are disabled.
Sequence diagram for shimmer.start behavior with NO_COLOR and TERM=dumb
sequenceDiagram
actor User
participant Shimmer
participant sys_stdout
participant animations_enabled
User->>Shimmer: start()
Shimmer->>sys_stdout: hasattr(sys_stdout, isatty)
Shimmer->>sys_stdout: isatty()
Shimmer->>animations_enabled: animations_enabled()
alt interactive_tty and animations_enabled
Shimmer->>Shimmer: _start_animation_thread()
else non_interactive or animations_disabled
Shimmer->>sys_stdout: write(prefix + text + suffix + "\n")
Shimmer->>sys_stdout: flush()
Shimmer->>Shimmer: _noop = True
end

Loading
File-Level Changes
ChangeDetailsFiles
Add centralized environment check to determine whether terminal animations are allowed and use it in Shimmer.start.
  • Introduce animations_enabled() helper that disables animations when NO_COLOR is set to a non-empty value or TERM is 'dumb', otherwise returns True
  • Update Shimmer.start() to also skip animations when animations_enabled() is False, while still printing the static text once and marking the instance as a no-op
  • Extend shimmer() context manager docstring to document that animations are skipped in non-interactive environments and when NO_COLOR or TERM=dumb disables them
audb/core/shimmer.py
Add tests ensuring shimmer behavior respects NO_COLOR/TERM=dumb and isolate tests from ambient environment.
  • Import pytest and the new animations_enabled() helper into the shimmer tests
  • Add an autouse fixture that clears NO_COLOR and sets TERM to a sane default so external environment does not influence tests
  • Add tests for animations_enabled() behavior across different NO_COLOR and TERM combinations
  • Add parametrized test verifying that shimmer becomes a no-op (no stdout.write patching) but still prints the static line exactly once when NO_COLOR or TERM=dumb are set, even when stdout is a TTY
tests/test_shimmer.py
Assessment against linked issues
IssueObjectiveAddressedExplanation
#582Disable the shimmer animation when the environment indicates that animations/colors should not be used (e.g., NO_COLOR set, TERM=dumb), while still printing the static text once.✅
#582Add or update tests to cover the new environment-based shimmer disabling behavior to prevent shimmer output from appearing in logs.✅
#582Document the new behavior of shimmer being skipped in environments disabling animations (NO_COLOR, TERM=dumb) in the shimmer implementation docstrings.✅
Possibly linked issues
Tips and commands
Interacting with Sourcery
  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    
issue from a review comment by replying to it. You can also reply to a
    
review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    
request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    
the pull request body to generate a PR summary at any time exactly where you
    
want it. You can also comment @sourcery-ai summary on the pull request to
    
(re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    
request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    
pull request to resolve all Sourcery comments. Useful if you've already
    
addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    
request to dismiss all existing Sourcery reviews. Especially useful if you
    
want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
Customizing Your Experience
Access your dashboard to:
  • Enable or disable review features such as the Sourcery-generated pull request
    
summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.
Getting Help
@hagenwhagenw
changed the title
Disable shimmer animation for NO_COLOR + TERM=dumbDisable animation for NO_COLOR + TERM=dumbJul 20, 2026
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view
@hagenw
hagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

MemberAuthor
@frankenjoe this branch should disable the animation if you run NO_COLOR=1 screen -L .... Maybe you can check if the progress bar is still appearing in the logs and we also need to disable it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

@hagenwhagenw

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Shimmer animation can appear in logs


1 participant

@hagenw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable animation for NO_COLOR + TERM=dumb - #584
Open
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Open
Disable animation for NO_COLOR + TERM=dumb#584
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Conversation
@hagenw
@hagenwhagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

Member
Closes#582
Skips the shimmer animation if the environment variable NO_COLOR is set or the environment variable TERM is set to dumb.
@hagenwhagenw
self-assigned this
Jul 20, 2026
@sourcery-ai
sourcery-aiBot
commented
Jul 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Reviewer's Guide
Implements environment-controlled disabling of shimmer animations via NO_COLOR and TERM=dumb, centralizes the logic in a new helper, and adds tests/fixtures to ensure shimmer becomes a no-op while still printing static text once when animations are disabled.
Sequence diagram for shimmer.start behavior with NO_COLOR and TERM=dumb
sequenceDiagram
actor User
participant Shimmer
participant sys_stdout
participant animations_enabled
User->>Shimmer: start()
Shimmer->>sys_stdout: hasattr(sys_stdout, isatty)
Shimmer->>sys_stdout: isatty()
Shimmer->>animations_enabled: animations_enabled()
alt interactive_tty and animations_enabled
Shimmer->>Shimmer: _start_animation_thread()
else non_interactive or animations_disabled
Shimmer->>sys_stdout: write(prefix + text + suffix + "\n")
Shimmer->>sys_stdout: flush()
Shimmer->>Shimmer: _noop = True
end

Loading
File-Level Changes
ChangeDetailsFiles
Add centralized environment check to determine whether terminal animations are allowed and use it in Shimmer.start.
  • Introduce animations_enabled() helper that disables animations when NO_COLOR is set to a non-empty value or TERM is 'dumb', otherwise returns True
  • Update Shimmer.start() to also skip animations when animations_enabled() is False, while still printing the static text once and marking the instance as a no-op
  • Extend shimmer() context manager docstring to document that animations are skipped in non-interactive environments and when NO_COLOR or TERM=dumb disables them
audb/core/shimmer.py
Add tests ensuring shimmer behavior respects NO_COLOR/TERM=dumb and isolate tests from ambient environment.
  • Import pytest and the new animations_enabled() helper into the shimmer tests
  • Add an autouse fixture that clears NO_COLOR and sets TERM to a sane default so external environment does not influence tests
  • Add tests for animations_enabled() behavior across different NO_COLOR and TERM combinations
  • Add parametrized test verifying that shimmer becomes a no-op (no stdout.write patching) but still prints the static line exactly once when NO_COLOR or TERM=dumb are set, even when stdout is a TTY
tests/test_shimmer.py
Assessment against linked issues
IssueObjectiveAddressedExplanation
#582Disable the shimmer animation when the environment indicates that animations/colors should not be used (e.g., NO_COLOR set, TERM=dumb), while still printing the static text once.✅
#582Add or update tests to cover the new environment-based shimmer disabling behavior to prevent shimmer output from appearing in logs.✅
#582Document the new behavior of shimmer being skipped in environments disabling animations (NO_COLOR, TERM=dumb) in the shimmer implementation docstrings.✅
Possibly linked issues
Tips and commands
Interacting with Sourcery
  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    
issue from a review comment by replying to it. You can also reply to a
    
review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    
request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    
the pull request body to generate a PR summary at any time exactly where you
    
want it. You can also comment @sourcery-ai summary on the pull request to
    
(re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    
request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    
pull request to resolve all Sourcery comments. Useful if you've already
    
addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    
request to dismiss all existing Sourcery reviews. Especially useful if you
    
want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
Customizing Your Experience
Access your dashboard to:
  • Enable or disable review features such as the Sourcery-generated pull request
    
summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.
Getting Help
@hagenwhagenw
changed the title
Disable shimmer animation for NO_COLOR + TERM=dumbDisable animation for NO_COLOR + TERM=dumbJul 20, 2026
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view
@hagenw
hagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

MemberAuthor
@frankenjoe this branch should disable the animation if you run NO_COLOR=1 screen -L .... Maybe you can check if the progress bar is still appearing in the logs and we also need to disable it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

@hagenwhagenw

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Shimmer animation can appear in logs


1 participant

@hagenw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Disable animation for NO_COLOR + TERM=dumb - #584
Open
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Open
Disable animation for NO_COLOR + TERM=dumb#584
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Conversation
@hagenw
@hagenwhagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

Member
Closes#582
Skips the shimmer animation if the environment variable NO_COLOR is set or the environment variable TERM is set to dumb.
@hagenwhagenw
self-assigned this
Jul 20, 2026
@sourcery-ai
sourcery-aiBot
commented
Jul 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Reviewer's Guide
Implements environment-controlled disabling of shimmer animations via NO_COLOR and TERM=dumb, centralizes the logic in a new helper, and adds tests/fixtures to ensure shimmer becomes a no-op while still printing static text once when animations are disabled.
Sequence diagram for shimmer.start behavior with NO_COLOR and TERM=dumb
sequenceDiagram
actor User
participant Shimmer
participant sys_stdout
participant animations_enabled
User->>Shimmer: start()
Shimmer->>sys_stdout: hasattr(sys_stdout, isatty)
Shimmer->>sys_stdout: isatty()
Shimmer->>animations_enabled: animations_enabled()
alt interactive_tty and animations_enabled
Shimmer->>Shimmer: _start_animation_thread()
else non_interactive or animations_disabled
Shimmer->>sys_stdout: write(prefix + text + suffix + "\n")
Shimmer->>sys_stdout: flush()
Shimmer->>Shimmer: _noop = True
end

Loading
File-Level Changes
ChangeDetailsFiles
Add centralized environment check to determine whether terminal animations are allowed and use it in Shimmer.start.
  • Introduce animations_enabled() helper that disables animations when NO_COLOR is set to a non-empty value or TERM is 'dumb', otherwise returns True
  • Update Shimmer.start() to also skip animations when animations_enabled() is False, while still printing the static text once and marking the instance as a no-op
  • Extend shimmer() context manager docstring to document that animations are skipped in non-interactive environments and when NO_COLOR or TERM=dumb disables them
audb/core/shimmer.py
Add tests ensuring shimmer behavior respects NO_COLOR/TERM=dumb and isolate tests from ambient environment.
  • Import pytest and the new animations_enabled() helper into the shimmer tests
  • Add an autouse fixture that clears NO_COLOR and sets TERM to a sane default so external environment does not influence tests
  • Add tests for animations_enabled() behavior across different NO_COLOR and TERM combinations
  • Add parametrized test verifying that shimmer becomes a no-op (no stdout.write patching) but still prints the static line exactly once when NO_COLOR or TERM=dumb are set, even when stdout is a TTY
tests/test_shimmer.py
Assessment against linked issues
IssueObjectiveAddressedExplanation
#582Disable the shimmer animation when the environment indicates that animations/colors should not be used (e.g., NO_COLOR set, TERM=dumb), while still printing the static text once.✅
#582Add or update tests to cover the new environment-based shimmer disabling behavior to prevent shimmer output from appearing in logs.✅
#582Document the new behavior of shimmer being skipped in environments disabling animations (NO_COLOR, TERM=dumb) in the shimmer implementation docstrings.✅
Possibly linked issues
Tips and commands
Interacting with Sourcery
  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    
issue from a review comment by replying to it. You can also reply to a
    
review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    
request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    
the pull request body to generate a PR summary at any time exactly where you
    
want it. You can also comment @sourcery-ai summary on the pull request to
    
(re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    
request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    
pull request to resolve all Sourcery comments. Useful if you've already
    
addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    
request to dismiss all existing Sourcery reviews. Especially useful if you
    
want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
Customizing Your Experience
Access your dashboard to:
  • Enable or disable review features such as the Sourcery-generated pull request
    
summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.
Getting Help
@hagenwhagenw
changed the title
Disable shimmer animation for NO_COLOR + TERM=dumbDisable animation for NO_COLOR + TERM=dumbJul 20, 2026
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view
@hagenw
hagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

MemberAuthor
@frankenjoe this branch should disable the animation if you run NO_COLOR=1 screen -L .... Maybe you can check if the progress bar is still appearing in the logs and we also need to disable it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

@hagenwhagenw

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Shimmer animation can appear in logs


1 participant

@hagenw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable animation for NO_COLOR + TERM=dumb - #584
Open
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Open
Disable animation for NO_COLOR + TERM=dumb#584
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Conversation
@hagenw
@hagenwhagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

Member
Closes#582
Skips the shimmer animation if the environment variable NO_COLOR is set or the environment variable TERM is set to dumb.
@hagenwhagenw
self-assigned this
Jul 20, 2026
@sourcery-ai
sourcery-aiBot
commented
Jul 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Reviewer's Guide
Implements environment-controlled disabling of shimmer animations via NO_COLOR and TERM=dumb, centralizes the logic in a new helper, and adds tests/fixtures to ensure shimmer becomes a no-op while still printing static text once when animations are disabled.
Sequence diagram for shimmer.start behavior with NO_COLOR and TERM=dumb
sequenceDiagram
actor User
participant Shimmer
participant sys_stdout
participant animations_enabled
User->>Shimmer: start()
Shimmer->>sys_stdout: hasattr(sys_stdout, isatty)
Shimmer->>sys_stdout: isatty()
Shimmer->>animations_enabled: animations_enabled()
alt interactive_tty and animations_enabled
Shimmer->>Shimmer: _start_animation_thread()
else non_interactive or animations_disabled
Shimmer->>sys_stdout: write(prefix + text + suffix + "\n")
Shimmer->>sys_stdout: flush()
Shimmer->>Shimmer: _noop = True
end

Loading
File-Level Changes
ChangeDetailsFiles
Add centralized environment check to determine whether terminal animations are allowed and use it in Shimmer.start.
  • Introduce animations_enabled() helper that disables animations when NO_COLOR is set to a non-empty value or TERM is 'dumb', otherwise returns True
  • Update Shimmer.start() to also skip animations when animations_enabled() is False, while still printing the static text once and marking the instance as a no-op
  • Extend shimmer() context manager docstring to document that animations are skipped in non-interactive environments and when NO_COLOR or TERM=dumb disables them
audb/core/shimmer.py
Add tests ensuring shimmer behavior respects NO_COLOR/TERM=dumb and isolate tests from ambient environment.
  • Import pytest and the new animations_enabled() helper into the shimmer tests
  • Add an autouse fixture that clears NO_COLOR and sets TERM to a sane default so external environment does not influence tests
  • Add tests for animations_enabled() behavior across different NO_COLOR and TERM combinations
  • Add parametrized test verifying that shimmer becomes a no-op (no stdout.write patching) but still prints the static line exactly once when NO_COLOR or TERM=dumb are set, even when stdout is a TTY
tests/test_shimmer.py
Assessment against linked issues
IssueObjectiveAddressedExplanation
#582Disable the shimmer animation when the environment indicates that animations/colors should not be used (e.g., NO_COLOR set, TERM=dumb), while still printing the static text once.✅
#582Add or update tests to cover the new environment-based shimmer disabling behavior to prevent shimmer output from appearing in logs.✅
#582Document the new behavior of shimmer being skipped in environments disabling animations (NO_COLOR, TERM=dumb) in the shimmer implementation docstrings.✅
Possibly linked issues
Tips and commands
Interacting with Sourcery
  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    
issue from a review comment by replying to it. You can also reply to a
    
review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    
request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    
the pull request body to generate a PR summary at any time exactly where you
    
want it. You can also comment @sourcery-ai summary on the pull request to
    
(re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    
request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    
pull request to resolve all Sourcery comments. Useful if you've already
    
addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    
request to dismiss all existing Sourcery reviews. Especially useful if you
    
want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
Customizing Your Experience
Access your dashboard to:
  • Enable or disable review features such as the Sourcery-generated pull request
    
summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.
Getting Help
@hagenwhagenw
changed the title
Disable shimmer animation for NO_COLOR + TERM=dumbDisable animation for NO_COLOR + TERM=dumbJul 20, 2026
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view
@hagenw
hagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

MemberAuthor
@frankenjoe this branch should disable the animation if you run NO_COLOR=1 screen -L .... Maybe you can check if the progress bar is still appearing in the logs and we also need to disable it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

@hagenwhagenw

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Shimmer animation can appear in logs


1 participant

@hagenw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Disable animation for NO_COLOR + TERM=dumb - #584
Open
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Open
Disable animation for NO_COLOR + TERM=dumb#584
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Conversation
@hagenw
@hagenwhagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

Member
Closes#582
Skips the shimmer animation if the environment variable NO_COLOR is set or the environment variable TERM is set to dumb.
@hagenwhagenw
self-assigned this
Jul 20, 2026
@sourcery-ai
sourcery-aiBot
commented
Jul 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Reviewer's Guide
Implements environment-controlled disabling of shimmer animations via NO_COLOR and TERM=dumb, centralizes the logic in a new helper, and adds tests/fixtures to ensure shimmer becomes a no-op while still printing static text once when animations are disabled.
Sequence diagram for shimmer.start behavior with NO_COLOR and TERM=dumb
sequenceDiagram
actor User
participant Shimmer
participant sys_stdout
participant animations_enabled
User->>Shimmer: start()
Shimmer->>sys_stdout: hasattr(sys_stdout, isatty)
Shimmer->>sys_stdout: isatty()
Shimmer->>animations_enabled: animations_enabled()
alt interactive_tty and animations_enabled
Shimmer->>Shimmer: _start_animation_thread()
else non_interactive or animations_disabled
Shimmer->>sys_stdout: write(prefix + text + suffix + "\n")
Shimmer->>sys_stdout: flush()
Shimmer->>Shimmer: _noop = True
end

Loading
File-Level Changes
ChangeDetailsFiles
Add centralized environment check to determine whether terminal animations are allowed and use it in Shimmer.start.
  • Introduce animations_enabled() helper that disables animations when NO_COLOR is set to a non-empty value or TERM is 'dumb', otherwise returns True
  • Update Shimmer.start() to also skip animations when animations_enabled() is False, while still printing the static text once and marking the instance as a no-op
  • Extend shimmer() context manager docstring to document that animations are skipped in non-interactive environments and when NO_COLOR or TERM=dumb disables them
audb/core/shimmer.py
Add tests ensuring shimmer behavior respects NO_COLOR/TERM=dumb and isolate tests from ambient environment.
  • Import pytest and the new animations_enabled() helper into the shimmer tests
  • Add an autouse fixture that clears NO_COLOR and sets TERM to a sane default so external environment does not influence tests
  • Add tests for animations_enabled() behavior across different NO_COLOR and TERM combinations
  • Add parametrized test verifying that shimmer becomes a no-op (no stdout.write patching) but still prints the static line exactly once when NO_COLOR or TERM=dumb are set, even when stdout is a TTY
tests/test_shimmer.py
Assessment against linked issues
IssueObjectiveAddressedExplanation
#582Disable the shimmer animation when the environment indicates that animations/colors should not be used (e.g., NO_COLOR set, TERM=dumb), while still printing the static text once.✅
#582Add or update tests to cover the new environment-based shimmer disabling behavior to prevent shimmer output from appearing in logs.✅
#582Document the new behavior of shimmer being skipped in environments disabling animations (NO_COLOR, TERM=dumb) in the shimmer implementation docstrings.✅
Possibly linked issues
Tips and commands
Interacting with Sourcery
  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    
issue from a review comment by replying to it. You can also reply to a
    
review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    
request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    
the pull request body to generate a PR summary at any time exactly where you
    
want it. You can also comment @sourcery-ai summary on the pull request to
    
(re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    
request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    
pull request to resolve all Sourcery comments. Useful if you've already
    
addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    
request to dismiss all existing Sourcery reviews. Especially useful if you
    
want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
Customizing Your Experience
Access your dashboard to:
  • Enable or disable review features such as the Sourcery-generated pull request
    
summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.
Getting Help
@hagenwhagenw
changed the title
Disable shimmer animation for NO_COLOR + TERM=dumbDisable animation for NO_COLOR + TERM=dumbJul 20, 2026
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view
@hagenw
hagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

MemberAuthor
@frankenjoe this branch should disable the animation if you run NO_COLOR=1 screen -L .... Maybe you can check if the progress bar is still appearing in the logs and we also need to disable it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

@hagenwhagenw

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Shimmer animation can appear in logs


1 participant

@hagenw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Disable animation for NO_COLOR + TERM=dumb - #584
Open
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Open
Disable animation for NO_COLOR + TERM=dumb#584
hagenw wants to merge 2 commits into
mainfrom 
disable-shimmer-via-env
Conversation
@hagenw
@hagenwhagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

Member
Closes#582
Skips the shimmer animation if the environment variable NO_COLOR is set or the environment variable TERM is set to dumb.
@hagenwhagenw
self-assigned this
Jul 20, 2026
@sourcery-ai
sourcery-aiBot
commented
Jul 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Reviewer's Guide
Implements environment-controlled disabling of shimmer animations via NO_COLOR and TERM=dumb, centralizes the logic in a new helper, and adds tests/fixtures to ensure shimmer becomes a no-op while still printing static text once when animations are disabled.
Sequence diagram for shimmer.start behavior with NO_COLOR and TERM=dumb
sequenceDiagram
actor User
participant Shimmer
participant sys_stdout
participant animations_enabled
User->>Shimmer: start()
Shimmer->>sys_stdout: hasattr(sys_stdout, isatty)
Shimmer->>sys_stdout: isatty()
Shimmer->>animations_enabled: animations_enabled()
alt interactive_tty and animations_enabled
Shimmer->>Shimmer: _start_animation_thread()
else non_interactive or animations_disabled
Shimmer->>sys_stdout: write(prefix + text + suffix + "\n")
Shimmer->>sys_stdout: flush()
Shimmer->>Shimmer: _noop = True
end

Loading
File-Level Changes
ChangeDetailsFiles
Add centralized environment check to determine whether terminal animations are allowed and use it in Shimmer.start.
  • Introduce animations_enabled() helper that disables animations when NO_COLOR is set to a non-empty value or TERM is 'dumb', otherwise returns True
  • Update Shimmer.start() to also skip animations when animations_enabled() is False, while still printing the static text once and marking the instance as a no-op
  • Extend shimmer() context manager docstring to document that animations are skipped in non-interactive environments and when NO_COLOR or TERM=dumb disables them
audb/core/shimmer.py
Add tests ensuring shimmer behavior respects NO_COLOR/TERM=dumb and isolate tests from ambient environment.
  • Import pytest and the new animations_enabled() helper into the shimmer tests
  • Add an autouse fixture that clears NO_COLOR and sets TERM to a sane default so external environment does not influence tests
  • Add tests for animations_enabled() behavior across different NO_COLOR and TERM combinations
  • Add parametrized test verifying that shimmer becomes a no-op (no stdout.write patching) but still prints the static line exactly once when NO_COLOR or TERM=dumb are set, even when stdout is a TTY
tests/test_shimmer.py
Assessment against linked issues
IssueObjectiveAddressedExplanation
#582Disable the shimmer animation when the environment indicates that animations/colors should not be used (e.g., NO_COLOR set, TERM=dumb), while still printing the static text once.✅
#582Add or update tests to cover the new environment-based shimmer disabling behavior to prevent shimmer output from appearing in logs.✅
#582Document the new behavior of shimmer being skipped in environments disabling animations (NO_COLOR, TERM=dumb) in the shimmer implementation docstrings.✅
Possibly linked issues
Tips and commands
Interacting with Sourcery
  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    
issue from a review comment by replying to it. You can also reply to a
    
review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    
request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    
the pull request body to generate a PR summary at any time exactly where you
    
want it. You can also comment @sourcery-ai summary on the pull request to
    
(re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    
request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    
pull request to resolve all Sourcery comments. Useful if you've already
    
addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    
request to dismiss all existing Sourcery reviews. Especially useful if you
    
want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
Customizing Your Experience
Access your dashboard to:
  • Enable or disable review features such as the Sourcery-generated pull request
    
summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.
Getting Help
@hagenwhagenw
changed the title
Disable shimmer animation for NO_COLOR + TERM=dumbDisable animation for NO_COLOR + TERM=dumbJul 20, 2026
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view
@hagenw
hagenw
commented
Jul 20, 2026

Copy link


Copy Markdown

MemberAuthor
@frankenjoe this branch should disable the animation if you run NO_COLOR=1 screen -L .... Maybe you can check if the progress bar is still appearing in the logs and we also need to disable it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sourcery-aisourcery-ai[bot]sourcery-ai[bot] left review comments

Assignees

@hagenwhagenw

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Shimmer animation can appear in logs


1 participant

@hagenw