Uh oh!
There was an error while loading. Please reload this page.
Added is09-13 configs - #124
Conversation
Reviewer's GuideThis PR integrates support for the IS09–IS13 openSMILE feature sets by registering new FeatureSet values, packaging a new config directory, and importing the standard config files (adapted to external I/O) under opensmile/core/config/is09-13. ER diagram for FeatureSet and config fileserDiagram
FEATURESET ||--o{ CONFIG_FILE : uses
FEATURESET {
string name
string config_path
}
CONFIG_FILE {
string filename
string path
}
Class diagram for updated FeatureSet enumclassDiagram
class FeatureSet {
<<enum>>
ComParE_2016
GeMAPS
eGeMAPS
emobase
IS09
IS10
IS11
IS12
IS13
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ATriantafyllopoulos - I've reviewed your changes - here's some feedback:
- Consider splitting this large PR into smaller, logical commits (e.g. enum updates, setup changes, then each feature‐set config) to make the review more manageable.
- There’s substantial repetition across the new config files; extract shared headers and repeated component definitions into common include files to reduce duplication and simplify future maintenance.
- In setup.py, ensure the 'config/is09-13/' glob recursively captures all nested directories and files (or switch to a '**/' pattern) so no configs are accidentally omitted.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments- Consider splitting this large PR into smaller, logical commits (e.g. enum updates, setup changes, then each feature‐set config) to make the review more manageable.
- There’s substantial repetition across the new config files; extract shared headers and repeated component definitions into common include files to reduce duplication and simplify future maintenance.
- In setup.py, ensure the 'config/is09-13/*' glob recursively captures all nested directories and files (or switch to a '**/*' pattern) so no configs are accidentally omitted.
## Individual Comments### Comment 1
<location> `opensmile/core/config/is09-13/IS12_speaker_trait_compat.conf:339` </location>
<code_context>
+instance[melspecMfcc].type=cMelspec
+instance[mfcc].type=cMfcc
+
+[melspecMfcc:cMelspec]
+reader.dmLevel=fftmagH25
+writer.dmLevel=melspecMfcc
+copyInputName = 1
+processArrayFields = 1
+; htk compatible sample value scaling
+htkcompatible = 1
+nBands = 26s
+; use power spectrum instead of magnitude spectrum
+usePower = 1
</code_context>
<issue_to_address>
Possible typo: 'nBands = 26s' contains an unexpected 's'.
Please check if 'nBands' should be set to an integer value, such as 26, instead of '26s'.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
nBands = 26s
=======
nBands = 26
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Uh oh!
There was an error while loading. Please reload this page.
hagenw
commented
Jul 22, 2025
@ATriantafyllopoulos what is the usecase for those configs? |
ATriantafyllopoulos
commented
Jul 25, 2025
I want to finally make a paper I wrote for Interspeech last year fully reproducible.. Also, these are the standard config files used in the early versions of the ComParE challenge. If someone wants to reproduce these results with modern tools (Python), this will be useful |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
hagenw
commented
Jul 25, 2025
 An easy fix would be to add the whole config folder to the # ----- codespell ---------------------------------------------------------
[tool.codespell]
builtin = 'clear,rare,informal,usage,names'skip = './opensmile.egg-info,./build,./docs/api,./docs/_templates,./docs/examples','opensmile/core/config' |
hagenw
commented
Jul 25, 2025
For the other |
ATriantafyllopoulos
commented
Jul 30, 2025
cf378dc (the syntax for the fix was a bit different but I followed your recommendation) |
hagenw
commented
Jul 31, 2025
Great, thanks for fixing the tests, I will merge this now and prepare a new release. |
Uh oh!
There was an error while loading. Please reload this page.
hagenw
commented
Jul 31, 2025
Maybe the README is still slightly misleading:  But doesn't matter, I released version 2.6.0, so you should now be able to use your configs by installing this package. |
This PR adds standard config files for the IS09-13 feature sets. The config files are all taken from the original repo with the only change being the use of external source and sink components for reading/writing.
Summary by Sourcery
Add standardized openSMILE config files for the IS09-13 feature sets, update the FeatureSet enum to include IS09--IS13, and include the new configs in the package distribution.
New Features:
Enhancements:
Build: