Skip to content

fix: proxyplease does not appear to honor system bypass list#8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webbrain-one wants to merge 1 commit into
base:master
Choose a base branch
from
Open

fix: proxyplease does not appear to honor system bypass list #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion proxy.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,12 @@ func NewDialContext(p Proxy) DialContext {
// if no provided Proxy.URL, infer from system settings
if p.URL == nil || p.URL.String() == "" {
debugf("proxy> No proxy provided. Attempting to infer from system.")
systemProxy := ggp.NewProvider("").GetProxy(p.TargetURL.Scheme, p.TargetURL.String())
systemProxy, err := ggp.NewProvider("").GetProxy(p.TargetURL.Scheme, p.TargetURL.String())
if err != nil {
debugf("proxy> Error inferring proxy from system: %v", err)
d := net.Dialer{}
return d.DialContext
}
// if no Proxy.URL was provided and no URL could be determined from system,
// then assume connection is direct.
if systemProxy == nil {
Expand Down