Skip to content

Empty string audience claim should be deserialized as empty string - #663

Merged
jimmyjames merged 1 commit into
masterfrom
aud-empty-string-fix
Jun 9, 2023
Merged

Empty string audience claim should be deserialized as empty string#663
jimmyjames merged 1 commit into
masterfrom
aud-empty-string-fix

Conversation

@jimmyjames

Copy link
Copy Markdown
Contributor

Changes

Fixes#662 - an empty audience string was being deserialized as an empty list, instead of a list with an empty string.

@jimmyjames
jimmyjames requested a review from a team as a code ownerJune 2, 2023 01:58

@poovamrajpoovamraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good if this is behaviour is what we would be going for

@andrewrigasandrewrigas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmyjames
jimmyjames merged commit d8fe9a2 into masterJun 9, 2023
@jimmyjames
jimmyjames deleted the aud-empty-string-fix branch June 9, 2023 02:15
This was referenced Jan 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aud with empty string returns empty List

3 participants

@jimmyjames@poovamraj@andrewrigas