Uh oh!
There was an error while loading. Please reload this page.
fix(site): add --url to the homepage copy command - #24
Open
lakhansamani wants to merge 1 commit into
Open
Conversation
The server exits at boot without --url (authorizerdev/authorizer#764). These commands could not start as written.
✅ Deploy Preview for authorizer-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DEMO_COPY_COMMANDincomponents/Hero.tsxis the command visitors copy straight off the homepage. It omitted--url, which authorizerdev/authorizer#764 made required — so the first thing a new user runs exits immediately:That is the worst possible place for this bug: it is the landing page's single call to action.
Verified
Replayed the command exactly as rendered against a build of
authorizermain— it now reaches the HTTP listener instead of exiting:npx tsc --noEmitclean.Note
The file already carries a comment saying "Keep this in step with docs.authorizer.dev/core/server-config" — that is exactly the drift that happened here, so it is worth treating this snippet as release-blocking whenever a required flag changes.
Companion fixes for the same root cause are in
authorizer(README, MIGRATION, perf),authorizer-docs,examples,authorizer-goand the RAG demos.Refs authorizerdev/authorizer#764