Uh oh!
There was an error while loading. Please reload this page.
fix(cmd): --url help still said it was optional - #767
Merged
Conversation
The flag description told operators they could leave --url empty and keep "legacy header-based derivation". #764 removed that option — the server refuses to start without it — so `--help` documented a configuration the binary rejects. Also names the distinction operators actually get wrong: --url is this server's own address, --allowed-origins is the apps it may redirect to.
This was referenced Aug 14, 2026
Merged
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One-line fix to the
--urlflag description.Was: "Leaving it empty keeps legacy header-based derivation but exposes host-header-injection account takeover (CWE-640) — set this in production"
Is: "REQUIRED: the server refuses to start without it, because deriving its own host from request headers exposes host-header-injection account takeover (CWE-640). This is not
--allowed-origins:--urlis this server's own address,--allowed-originsis the apps it may redirect to"Why
#764 made
--urlmandatory viavalidateAuthorizerURL, but left the flag's own help text describing the pre-#764 behaviour.authorizer --helptherefore documents a configuration the binary rejects at startup — telling operators that omitting it is a supported (if unwise) choice, when it is now a hard failure.The added
--allowed-originscontrast is the same disambiguation the startup error already carries; it belongs in--helptoo, since confusing the two is the common misconfiguration.Verification
Text-only change to a flag description; no behaviour change.
Related
--urlbecoming mandatory #766 records the same requirement in the changelog--urlRefs #764