This repository was archived by the owner on Feb 21, 2023. It is now read-only.
Conversation
Signed-off-by: Gyuho Lee <gyuho.lee@avalabs.org>
Signed-off-by: Gyuho Lee <gyuho.lee@avalabs.org>
| cmd.PersistentFlags().StringVar(&privKeyPath, "private-key-path", ".subnet-cli.pk", "private key file path") | ||
| cmd.PersistentFlags().BoolVarP(&useLedger, "ledger", "l", false, "use ledger to sign transactions") | ||
| cmd.PersistentFlags().StringVar(&privKeyPath, "private-key-path", ".subnet-cli.pk", "hexadecimal-encoded private key file (either must be set between '--private-key-path' or '--ledger' but not both)") | ||
| cmd.PersistentFlags().BoolVarP(&useLedger, "ledger", "l", false, "use ledger to sign transactions (either must be set between '--private-key-path' or '--ledger' but not both)") |
Contributor
There was a problem hiding this comment.
Can we switch to using ledger by default and use a private key file if it's set to a non-empty string?
| cancel() | ||
|
|
||
| var took time.Duration | ||
| if baseWallet != nil { |
Contributor
There was a problem hiding this comment.
Can InitClient return a nil base wallet and a nil error? If not, can we remove this check?
Contributor
There was a problem hiding this comment.
Is there any reason we can't change the behavior so that failing to create the base wallet will result in returning a non-nil error?
| cmd.PersistentFlags().StringVar(&publicURI, "public-uri", "https://api.avax-test.network", "URI for avalanche network endpoints") | ||
| cmd.PersistentFlags().StringVar(&privKeyPath, "private-key-path", ".subnet-cli.pk", "private key file path") | ||
| cmd.PersistentFlags().BoolVarP(&useLedger, "ledger", "l", false, "use ledger to sign transactions") | ||
| cmd.PersistentFlags().StringVar(&privKeyPath, "private-key-path", ".subnet-cli.pk", "hexadecimal-encoded private key file (either must be set between '--private-key-path' or '--ledger' but not both)") |
Contributor
There was a problem hiding this comment.
Can we re-use the code for these flags?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found some weird behavior in our avalanchego wallet code (where
GetTxfails if the subnet TX is not found in the cache, e.g., runadd subnetandadd subnet-validatorseparately... existing internal/wallet library works)