Skip to content

Align with new version of attrs lib and fix tests - #40

Merged
Luminaar merged 3 commits into
avast:masterfrom
lukas-bednar:fix-attrs
Dec 11, 2019
Merged

Luminaar merged 3 commits into
avast:masterfrom
lukas-bednar:fix-attrs

Conversation

@lukas-bednar

@lukas-bednar lukas-bednar commented Oct 30, 2019

Copy link
Copy Markdown
Contributor

A keyword convert was deprecated and converter should be used instead.
python-attrs/attrs#307

Fixes: #39
Fixes: #35

Signed-off-by: Lukas Bednar lbednar@redhat.com

A keyword convert was deprecated and converter should be used instead.
python-attrs/attrs#307

Fixes: avast#39

Signed-off-by: Lukas Bednar <lbednar@redhat.com>
Signed-off-by: Lukas Bednar <lbednar@redhat.com>
Signed-off-by: Lukas Bednar <lbednar@redhat.com>
@lukas-bednar lukas-bednar changed the title Align with new version of attrs lib Align with new version of attrs lib and fix tests Oct 30, 2019
@Luminaar
Luminaar merged commit 93a596e into avast:master Dec 11, 2019
@lukas-bednar
lukas-bednar deleted the fix-attrs branch December 11, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

attr.ib() no longer accepts "convert" but "converter" instead Tests broken because of calling fixture functions directly

2 participants