Repeatable tests - #3
Open
wconrad wants to merge 2 commits into
Open
Conversation
* Monkey-patch built-sorts to force them to be unstable in all Rubies. Some rubies (such as MRI >= 2.2) have stable sorts, which can cause the tests to pass erroneously. See https://stackoverflow.com/a/44486562/238886 for more about sort stability in Ruby * Set the random number seed in order to make tests repeatable. Since the tests sort relatively short arrays, random chance would sometimes cause erroneous test failures. * Some tests checked that Ruby's built-in sort is unstable. Those checks were moved into their own sections and expanded. Now every Ruby built-in sort method is tested for to ensure that it is unstable.
coveralls
commented
Jun 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause tests to be repeatable for all MRI versions from 2.0 through 2.4.
Monkey-patch built-sorts to force them to be unstable in all Rubies.
Some rubies (such as MRI >= 2.2) have stable sorts, which can cause
the tests to pass erroneously. See
https://stackoverflow.com/a/44486562/238886 for more about sort
stability in Ruby
Set the random number seed in order to make tests repeatable. Since
the tests sort relatively short arrays, random chance would
sometimes cause erroneous test failures.
Some tests checked that Ruby's built-in sort is unstable. Those
checks were moved into their own sections and expanded. Now every
Ruby built-in sort method is tested for to ensure that it is
unstable.