Skip to content

added compression to handler response stream - #255

Merged
ammokhov merged 4 commits into
aws-cloudformation:masterfrom
ammokhov:cw-response-compress
May 7, 2020
Merged

added compression to handler response stream#255
ammokhov merged 4 commits into
aws-cloudformation:masterfrom
ammokhov:cw-response-compress

Conversation

@ammokhov

@ammokhovammokhov commented May 5, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

added response compression. new format ->

{
'__COMPRESSED__': gziped_base64_compressed_string,
'__COMPRESSION_METHOD__': 'gzip_base64'
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammokhov
ammokhovforce-pushed the cw-response-compress branch from 72971f7 to 4b48514CompareMay 6, 2020 04:48
@ammokhov
ammokhovforce-pushed the cw-response-compress branch from 4b48514 to 6b03b1eCompareMay 6, 2020 04:54
@ammokhovammokhov self-assigned this May 6, 2020
@ammokhovammokhov added the bug Something isn't working label May 6, 2020
wbingli
wbingli reviewed May 6, 2020
View reviewed changes
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
@ammokhov
ammokhov requested a review from wbingliMay 6, 2020 21:04
wbingli
wbingli reviewed May 7, 2020
View reviewed changes
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
wbingli
wbingli reviewed May 7, 2020
View reviewed changes
Comment threadsrc/main/java/software/amazon/cloudformation/resource/Serializer.java Outdated
@ammokhov
ammokhov merged commit a64e61e into aws-cloudformation:masterMay 7, 2020
@ammokhov
ammokhov deleted the cw-response-compress branch May 7, 2020 07:48
@ammokhovammokhov mentioned this pull request Sep 23, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjlohanrjlohanAwaiting requested review from rjlohan
@dchakrav-githubdchakrav-githubAwaiting requested review from dchakrav-github
2 more reviewers
@wbingliwbingliwbingli approved these changes
@johnttompkinsjohnttompkinsjohnttompkins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ammokhovammokhov

Labels

bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ammokhov@wbingli@johnttompkins