Uh oh!
There was an error while loading. Please reload this page.
added generic type for multiple type support - #278
Merged
Conversation
wbingli
reviewed
Jun 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
wbingli
approved these changes
Jun 14, 2020
Uh oh!
There was an error while loading. Please reload this page.
sungkkim
self-requested a review
June 16, 2020 21:29
sungkkim
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
travis build fails because it requires this to get merged aws-cloudformation/cloudformation-cli#454
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.