Uh oh!
There was an error while loading. Please reload this page.
Retains writeOnlyProperties through reinvocations - #284
Merged
Conversation
wbingli
approved these changes
Jul 7, 2020
johnttompkins
approved these changes
Jul 7, 2020
ammokhov
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Protocol v2.0.0 changes mean that when we strip
writeOnlyPropertiesthey are not passed back on reinvoke. This PR addresses that issue - the redaction is only required for completedProgressEvents, in particular results of directReadrequests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.