Uh oh!
There was an error while loading. Please reload this page.
additional cw-metrics - #298
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6c97349 to
62d3e8bCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| if (this.metricsPublisherProxy != null) { | ||
| EnumSet.allOf(HandlerErrorCode.class).stream() | ||
| // publishing 0 value for all (if not thrown) otherwise filtered | ||
| .filter(errorCode -> errorCode.equals(handlerErrorCode) || !thrown) |
There was a problem hiding this comment.
This line can be removed. We actually want to do forEach for all ErrorCode, not match in what cases.
In case of in a Failed cases, this will only emit metric 1 for the one equals to the ErrorCode, but won't emit 0 metric for other metrics.
Issue #, if available:#297
Description of changes:
Added some extra metrics so to create cw alarms upon.
Metric No. 1
Metric No. 2 - not added: the reason being is that operation status for uncaught exceptions is always
FAILED, so this metrics seems to be redundant; we have enough of the exact same information in other dimensions;Metric No. 3
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.