Skip to content

chore(ci): add the Idempotency feature to nox tests - #4585

Merged
leandrodamascena merged 1 commit into
aws-powertools:developfrom
leandrodamascena:feat/ci-idempotency
Jun 20, 2024
Merged

chore(ci): add the Idempotency feature to nox tests#4585
leandrodamascena merged 1 commit into
aws-powertools:developfrom
leandrodamascena:feat/ci-idempotency

Conversation

@leandrodamascena

Copy link
Copy Markdown
Contributor

Issue number:#4560

Summary

Changes

Adding the Idempotency feature to nox tests

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena
leandrodamascena requested a review from a teamJune 20, 2024 10:41
@pull-request-sizepull-request-sizeBot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 20, 2024
@leandrodamascenaleandrodamascena linked an issue Jun 20, 2024 that may be closed by this pull request
@github-actionsgithub-actionsBot added the internal Maintenance changes label Jun 20, 2024
Comment threadnoxfile.py

@nox.session()
@nox.parametrize("pydantic", ["1.10", "2.0"])
def test_with_boto3_and_pydantic_required_package(session: nox.Session, pydantic: str):

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to install pydantic + boto3 because we export the DynamoDBPersistenceLayer at top level and it requires boto3.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant you only needed boto3 when using DynamoDBPersistenceLayer, whereas for this test you also need pydantic because it'll use serializers and models.

Comment threadnoxfile.py
@codecov

codecovBot commented Jun 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (e14e768) to head (09f1e9e).
Report is 622 commits behind head on develop.

Additional details and impacted files
@@ Coverage Diff @@## develop #4585 +/- ##
===========================================
+ Coverage 96.38% 96.43% +0.05% 
===========================================
Files 214 219 +5 Lines 10030 10628 +598 Branches 1846 1976 +130 ===========================================
+ Hits 9667 10249 +582 - Misses 259 267 +8 - Partials 104 112 +8 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena
leandrodamascena merged commit 9486472 into aws-powertools:developJun 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internalMaintenance changessize/LDenotes a PR that changes 100-499 lines, ignoring generated files.tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: add the Idempotency feature to nox tests

2 participants

@leandrodamascena@heitorlessa