Uh oh!
There was an error while loading. Please reload this page.
improv: update metrics interface to resemble other core utils - #60
Conversation
Codecov Report
@@ Coverage Diff @@## develop #60 +/- ##
========================================
Coverage 99.38% 99.39% ========================================
Files 15 15 Lines 489 492 +3 Branches 44 44 ========================================
+ Hits 486 489 +3
Misses 3 3
Continue to review full report at Codecov.
|
heitorlessa
left a comment
There was a problem hiding this comment.
LGTM - Minor typo only
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
heitorlessa
commented
Jun 6, 2020
Are you still planning to add the Could you also change docstring in line 89 in metrics.py: Thanks again, Tom!! |
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
to-mc
commented
Jun 6, 2020
I'm in two minds about adding a dimension with the service name. I'll create a separate issue/PR for that to discuss.
Done!
|
improv: update metrics interface to resemble other core utils
Issue #, if available:#33
Description of changes: