Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { spawnAndCollect } from '../src/test-utils/cli-runner.js';
import { runCLI } from '../src/test-utils/index.js';
import { describe, expect, it } from 'vitest';
import { readdirSync } from 'node:fs';
import { mkdir, readFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

const COMMANDS = [
'create',
Expand DownExpand Up@@ -38,3 +43,59 @@ describe('CLI help', () => {
}
});
});

describe('help modes telemetry', () => {
let testConfigDir: string;
const cliPath = join(__dirname, '..', 'dist', 'cli', 'index.mjs');

beforeAll(async () => {
testConfigDir = join(tmpdir(), `agentcore-help-telemetry-${Date.now()}`);
await mkdir(testConfigDir, { recursive: true });
});
afterAll(() => rm(testConfigDir, { recursive: true, force: true }));

function run(args: string[], extraEnv: Record<string, string> = {}) {
return spawnAndCollect('node', [cliPath, ...args], tmpdir(), {
AGENTCORE_SKIP_INSTALL: '1',
AGENTCORE_CONFIG_DIR: testConfigDir,
...extraEnv,
});
}

it('writes JSONL audit file when audit is enabled via env var', async () => {
const result = await run(['help', 'modes'], { AGENTCORE_TELEMETRY_AUDIT: '1' });
expect(result.exitCode).toBe(0);

const telemetryDir = join(testConfigDir, 'telemetry');
const files = readdirSync(telemetryDir).filter(f => f.startsWith('help-'));
expect(files).toHaveLength(1);

const content = await readFile(join(telemetryDir, files[0]!), 'utf-8');
const entry = JSON.parse(content.trim());
expect(entry.attrs).toMatchObject({
'service.name': 'agentcore-cli',
'agentcore-cli.mode': 'cli',
command_group: 'help',
command: 'help.modes',
exit_reason: 'success',
});
expect(entry.attrs['agentcore-cli.session_id']).toBeDefined();
expect(entry.attrs['os.type']).toBeDefined();
expect(entry.value).toBeGreaterThanOrEqual(0);
});

it('does not write audit file when audit is not enabled', async () => {
const telemetryDir = join(testConfigDir, 'telemetry');
await rm(telemetryDir, { recursive: true, force: true });

const result = await run(['help', 'modes']);
expect(result.exitCode).toBe(0);

try {
const files = readdirSync(telemetryDir);
expect(files).toHaveLength(0);
} catch {
// telemetry dir doesn't exist — correct
}
});
});
8 changes: 7 additions & 1 deletion src/cli/cli.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ import { registerValidate } from './commands/validate';
import { PACKAGE_VERSION } from './constants';
import { getOrCreateInstallationId } from './global-config';
import { ALL_PRIMITIVES } from './primitives';
import { TelemetryClientAccessor } from './telemetry';
import { App } from './tui/App';
import { LayoutProvider } from './tui/context';
import { COMMAND_DESCRIPTIONS } from './tui/copy';
Expand DownExpand Up@@ -222,7 +223,12 @@ export const main = async (argv: string[]) => {
printTelemetryNotice();
}

await program.parseAsync(argv);
TelemetryClientAccessor.init(args[0] ?? 'unknown');
try {
await program.parseAsync(argv);
} finally {
await TelemetryClientAccessor.shutdown();
}

// Telemetry notice already printed above; only run update check here.
await printPostCommandNotices(false, updateCheck);
Expand Down
19 changes: 14 additions & 5 deletions src/cli/commands/help/command.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { TelemetryClientAccessor } from '../../telemetry/client-accessor.js';
import type { Command } from '@commander-js/extra-typings';

const MODES_HELP = `
Expand DownExpand Up@@ -41,15 +42,23 @@ export const registerHelp = (program: Command) => {
const helpCmd = program
.command('help')
.description('Display help topics')
.action(() => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help', () => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
return {};
});
});

helpCmd
.command('modes')
.description('Explain interactive vs non-interactive modes')
.action(() => {
console.log(MODES_HELP);
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help.modes', () => {
console.log(MODES_HELP);
return {};
});
});
};
95 changes: 95 additions & 0 deletions src/cli/telemetry/__tests__/filesystem-sink.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
import { createTempConfig } from '../../__tests__/helpers/temp-config';
import { resolveAuditFilePath } from '../config';
import { FileSystemSink } from '../sinks/filesystem-sink';
import { readFile } from 'fs/promises';
import { join } from 'node:path';
import { afterAll, beforeEach, describe, expect, it } from 'vitest';

const tmp = createTempConfig('fs-sink');
const outputDir = join(tmp.configDir, 'telemetry');

function createSink(opts: { dir?: string; log?: (msg: string) => void } = {}) {
const filePath = join(opts.dir ?? outputDir, 'test-session.json');
return new FileSystemSink({ filePath, log: opts.log });
}

function readJsonl(path: string): Promise<unknown[]> {
return readFile(path, 'utf-8').then(data =>
data
.trim()
.split('\n')
.map(line => JSON.parse(line))
);
}

describe('FileSystemSink', () => {
beforeEach(() => tmp.setup());
afterAll(() => tmp.cleanup());

it('writes each record as a JSONL line on disk', async () => {
const sink = createSink();
sink.record(42, { command_group: 'deploy', command: 'deploy', exit_reason: 'success' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(1);
expect(entries[0]).toMatchObject({
value: 42,
attrs: { command_group: 'deploy', command: 'deploy', exit_reason: 'success' },
});
});

it('appends multiple records as separate lines', async () => {
const sink = createSink();
sink.record(10, { command_group: 'add', command: 'add.agent' });
sink.record(20, { command_group: 'add', command: 'add.memory' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(2);
expect(entries[0]).toMatchObject({ value: 10 });
expect(entries[1]).toMatchObject({ value: 20 });
});

it('creates output directory if it does not exist', async () => {
const nested = join(tmp.testDir, 'deep', 'nested', 'telemetry');
const filePath = join(nested, 'test.json');
const sink = new FileSystemSink({ filePath });
sink.record(1, { command_group: 'status', command: 'status' });
await sink.flush();

const entries = await readJsonl(filePath);
expect(entries).toHaveLength(1);
});

it('flush is a no-op when no records exist', async () => {
const sink = createSink();
await expect(sink.flush()).resolves.toBeUndefined();
});

it('shutdown logs audit message when records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
sink.record(99, { command_group: 'invoke', command: 'invoke' });
await sink.shutdown();

expect(logged).toHaveLength(1);
expect(logged[0]).toContain('[audit mode]');
expect(logged[0]).toContain('test-session.json');
});

it('shutdown does not log when no records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
await sink.shutdown();

expect(logged).toHaveLength(0);
});
});

describe('resolveAuditFilePath', () => {
it('joins outputDir, entrypoint, and sessionId into a JSON file path', () => {
const path = resolveAuditFilePath('/home/user/.agentcore/telemetry', 'deploy', 'abc-123');
expect(path).toBe('/home/user/.agentcore/telemetry/deploy-abc-123.json');
});
});
49 changes: 49 additions & 0 deletions src/cli/telemetry/client-accessor.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import { GLOBAL_CONFIG_DIR, readGlobalConfig } from '../global-config.js';
import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { join } from 'path';

/**
* Manages a singleton TelemetryClient. Call init() at startup to configure,
* get() from command handlers to obtain the client, and shutdown() on exit.
* get() lazily initializes if init() was never called.
*/
export class TelemetryClientAccessor {
private static clientPromise: Promise<TelemetryClient> | undefined;

static init(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): void {
this.clientPromise = createClient(entrypoint, mode);
}

static get(): Promise<TelemetryClient> {
this.clientPromise ??= createClient('unknown');
return this.clientPromise;
}

static async shutdown(): Promise<void> {
if (this.clientPromise) {
const client = await this.clientPromise;
await client.shutdown();
}
}
}

async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Promise<TelemetryClient> {
const [resource, config] = await Promise.all([resolveResourceAttributes(mode), readGlobalConfig()]);

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;

if (audit) {
const filePath = resolveAuditFilePath(
join(GLOBAL_CONFIG_DIR, 'telemetry'),
entrypoint,
resource['agentcore-cli.session_id']
);
sinks.push(new FileSystemSink({ filePath, resource }));
}

return new TelemetryClient(new CompositeSink(sinks));
}
5 changes: 5 additions & 0 deletions src/cli/telemetry/config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { getOrCreateInstallationId, readGlobalConfig } from '../global-config.js
import { type ResourceAttributes, ResourceAttributesSchema } from './schemas/common-attributes.js';
import { randomUUID } from 'crypto';
import os from 'os';
import { join } from 'path';

// ---------------------------------------------------------------------------
// Telemetry preference (opt-in / opt-out)
Expand DownExpand Up@@ -59,3 +60,7 @@ export async function resolveResourceAttributes(mode: 'cli' | 'tui'): Promise<Re
'node.version': process.version,
});
}

export function resolveAuditFilePath(outputDir: string, entrypoint: string, sessionId: string): string {
return join(outputDir, `${entrypoint}-${sessionId}.json`);
}
4 changes: 3 additions & 1 deletion src/cli/telemetry/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
export { resolveTelemetryPreference, resolveResourceAttributes } from './config.js';
export { resolveTelemetryPreference, resolveResourceAttributes, resolveAuditFilePath } from './config.js';
export type { TelemetryPreference } from './config.js';
export { TelemetryClientAccessor } from './client-accessor.js';
export { TelemetryClient, CANCELLED } from './client.js';
export { type MetricSink, CompositeSink } from './sinks/metric-sink.js';
export { OtelMetricSink, type OtelMetricSinkConfig } from './sinks/otel-metric-sink.js';
export { FileSystemSink, type FileSystemSinkConfig } from './sinks/filesystem-sink.js';
export { classifyError, isUserError } from './error-classification.js';
1 change: 1 addition & 0 deletions src/cli/telemetry/schemas/command-run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,6 +193,7 @@ export const COMMAND_SCHEMAS = {
package: NoAttrs,
validate: NoAttrs,
'help.modes': NoAttrs,
help: NoAttrs,
'remove.agent': NoAttrs,
'remove.memory': NoAttrs,
'remove.credential': NoAttrs,
Expand Down
48 changes: 48 additions & 0 deletions src/cli/telemetry/sinks/filesystem-sink.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
import type { MetricSink } from './metric-sink.js';
import { appendFile, mkdir } from 'fs/promises';
import { dirname } from 'path';

export interface FileSystemSinkConfig {
filePath: string;
resource?: Record<string, string | number>;
log?: (message: string) => void;
}

export class FileSystemSink implements MetricSink {
private readonly filePath: string;
private readonly resource: Record<string, string | number>;
private readonly log: (message: string) => void;
private hasRecords = false;

constructor(config: FileSystemSinkConfig) {
this.filePath = config.filePath;
this.resource = config.resource ?? {};
this.log = config.log ?? (msg => console.log(msg));
}

record(value: number, attrs: Record<string, string | number>): void {
this.hasRecords = true;
this.pendingWrite = this.pendingWrite.then(() =>
this.appendEntry({ value, attrs: { ...this.resource, ...attrs } })
);
}

async flush(): Promise<void> {
await this.pendingWrite;
}

async shutdown(): Promise<void> {
await this.pendingWrite;
if (this.hasRecords) {
this.log(`[audit mode] Telemetry written to ${this.filePath}`);
}
}

// Promise chain that serializes async writes so record() can stay synchronous.
private pendingWrite: Promise<void> = Promise.resolve();

private async appendEntry(entry: { value: number; attrs: Record<string, string | number> }): Promise<void> {
await mkdir(dirname(this.filePath), { recursive: true });
await appendFile(this.filePath, JSON.stringify(entry) + '\n');
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { spawnAndCollect } from '../src/test-utils/cli-runner.js';
import { runCLI } from '../src/test-utils/index.js';
import { describe, expect, it } from 'vitest';
import { readdirSync } from 'node:fs';
import { mkdir, readFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

const COMMANDS = [
'create',
Expand DownExpand Up@@ -38,3 +43,59 @@ describe('CLI help', () => {
}
});
});

describe('help modes telemetry', () => {
let testConfigDir: string;
const cliPath = join(__dirname, '..', 'dist', 'cli', 'index.mjs');

beforeAll(async () => {
testConfigDir = join(tmpdir(), `agentcore-help-telemetry-${Date.now()}`);
await mkdir(testConfigDir, { recursive: true });
});
afterAll(() => rm(testConfigDir, { recursive: true, force: true }));

function run(args: string[], extraEnv: Record<string, string> = {}) {
return spawnAndCollect('node', [cliPath, ...args], tmpdir(), {
AGENTCORE_SKIP_INSTALL: '1',
AGENTCORE_CONFIG_DIR: testConfigDir,
...extraEnv,
});
}

it('writes JSONL audit file when audit is enabled via env var', async () => {
const result = await run(['help', 'modes'], { AGENTCORE_TELEMETRY_AUDIT: '1' });
expect(result.exitCode).toBe(0);

const telemetryDir = join(testConfigDir, 'telemetry');
const files = readdirSync(telemetryDir).filter(f => f.startsWith('help-'));
expect(files).toHaveLength(1);

const content = await readFile(join(telemetryDir, files[0]!), 'utf-8');
const entry = JSON.parse(content.trim());
expect(entry.attrs).toMatchObject({
'service.name': 'agentcore-cli',
'agentcore-cli.mode': 'cli',
command_group: 'help',
command: 'help.modes',
exit_reason: 'success',
});
expect(entry.attrs['agentcore-cli.session_id']).toBeDefined();
expect(entry.attrs['os.type']).toBeDefined();
expect(entry.value).toBeGreaterThanOrEqual(0);
});

it('does not write audit file when audit is not enabled', async () => {
const telemetryDir = join(testConfigDir, 'telemetry');
await rm(telemetryDir, { recursive: true, force: true });

const result = await run(['help', 'modes']);
expect(result.exitCode).toBe(0);

try {
const files = readdirSync(telemetryDir);
expect(files).toHaveLength(0);
} catch {
// telemetry dir doesn't exist — correct
}
});
});
8 changes: 7 additions & 1 deletion src/cli/cli.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ import { registerValidate } from './commands/validate';
import { PACKAGE_VERSION } from './constants';
import { getOrCreateInstallationId } from './global-config';
import { ALL_PRIMITIVES } from './primitives';
import { TelemetryClientAccessor } from './telemetry';
import { App } from './tui/App';
import { LayoutProvider } from './tui/context';
import { COMMAND_DESCRIPTIONS } from './tui/copy';
Expand DownExpand Up@@ -222,7 +223,12 @@ export const main = async (argv: string[]) => {
printTelemetryNotice();
}

await program.parseAsync(argv);
TelemetryClientAccessor.init(args[0] ?? 'unknown');
try {
await program.parseAsync(argv);
} finally {
await TelemetryClientAccessor.shutdown();
}

// Telemetry notice already printed above; only run update check here.
await printPostCommandNotices(false, updateCheck);
Expand Down
19 changes: 14 additions & 5 deletions src/cli/commands/help/command.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { TelemetryClientAccessor } from '../../telemetry/client-accessor.js';
import type { Command } from '@commander-js/extra-typings';

const MODES_HELP = `
Expand DownExpand Up@@ -41,15 +42,23 @@ export const registerHelp = (program: Command) => {
const helpCmd = program
.command('help')
.description('Display help topics')
.action(() => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help', () => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
return {};
});
});

helpCmd
.command('modes')
.description('Explain interactive vs non-interactive modes')
.action(() => {
console.log(MODES_HELP);
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help.modes', () => {
console.log(MODES_HELP);
return {};
});
});
};
95 changes: 95 additions & 0 deletions src/cli/telemetry/__tests__/filesystem-sink.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
import { createTempConfig } from '../../__tests__/helpers/temp-config';
import { resolveAuditFilePath } from '../config';
import { FileSystemSink } from '../sinks/filesystem-sink';
import { readFile } from 'fs/promises';
import { join } from 'node:path';
import { afterAll, beforeEach, describe, expect, it } from 'vitest';

const tmp = createTempConfig('fs-sink');
const outputDir = join(tmp.configDir, 'telemetry');

function createSink(opts: { dir?: string; log?: (msg: string) => void } = {}) {
const filePath = join(opts.dir ?? outputDir, 'test-session.json');
return new FileSystemSink({ filePath, log: opts.log });
}

function readJsonl(path: string): Promise<unknown[]> {
return readFile(path, 'utf-8').then(data =>
data
.trim()
.split('\n')
.map(line => JSON.parse(line))
);
}

describe('FileSystemSink', () => {
beforeEach(() => tmp.setup());
afterAll(() => tmp.cleanup());

it('writes each record as a JSONL line on disk', async () => {
const sink = createSink();
sink.record(42, { command_group: 'deploy', command: 'deploy', exit_reason: 'success' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(1);
expect(entries[0]).toMatchObject({
value: 42,
attrs: { command_group: 'deploy', command: 'deploy', exit_reason: 'success' },
});
});

it('appends multiple records as separate lines', async () => {
const sink = createSink();
sink.record(10, { command_group: 'add', command: 'add.agent' });
sink.record(20, { command_group: 'add', command: 'add.memory' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(2);
expect(entries[0]).toMatchObject({ value: 10 });
expect(entries[1]).toMatchObject({ value: 20 });
});

it('creates output directory if it does not exist', async () => {
const nested = join(tmp.testDir, 'deep', 'nested', 'telemetry');
const filePath = join(nested, 'test.json');
const sink = new FileSystemSink({ filePath });
sink.record(1, { command_group: 'status', command: 'status' });
await sink.flush();

const entries = await readJsonl(filePath);
expect(entries).toHaveLength(1);
});

it('flush is a no-op when no records exist', async () => {
const sink = createSink();
await expect(sink.flush()).resolves.toBeUndefined();
});

it('shutdown logs audit message when records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
sink.record(99, { command_group: 'invoke', command: 'invoke' });
await sink.shutdown();

expect(logged).toHaveLength(1);
expect(logged[0]).toContain('[audit mode]');
expect(logged[0]).toContain('test-session.json');
});

it('shutdown does not log when no records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
await sink.shutdown();

expect(logged).toHaveLength(0);
});
});

describe('resolveAuditFilePath', () => {
it('joins outputDir, entrypoint, and sessionId into a JSON file path', () => {
const path = resolveAuditFilePath('/home/user/.agentcore/telemetry', 'deploy', 'abc-123');
expect(path).toBe('/home/user/.agentcore/telemetry/deploy-abc-123.json');
});
});
49 changes: 49 additions & 0 deletions src/cli/telemetry/client-accessor.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import { GLOBAL_CONFIG_DIR, readGlobalConfig } from '../global-config.js';
import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { join } from 'path';

/**
* Manages a singleton TelemetryClient. Call init() at startup to configure,
* get() from command handlers to obtain the client, and shutdown() on exit.
* get() lazily initializes if init() was never called.
*/
export class TelemetryClientAccessor {
private static clientPromise: Promise<TelemetryClient> | undefined;

static init(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): void {
this.clientPromise = createClient(entrypoint, mode);
}

static get(): Promise<TelemetryClient> {
this.clientPromise ??= createClient('unknown');
return this.clientPromise;
}

static async shutdown(): Promise<void> {
if (this.clientPromise) {
const client = await this.clientPromise;
await client.shutdown();
}
}
}

async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Promise<TelemetryClient> {
const [resource, config] = await Promise.all([resolveResourceAttributes(mode), readGlobalConfig()]);

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;

if (audit) {
const filePath = resolveAuditFilePath(
join(GLOBAL_CONFIG_DIR, 'telemetry'),
entrypoint,
resource['agentcore-cli.session_id']
);
sinks.push(new FileSystemSink({ filePath, resource }));
}

return new TelemetryClient(new CompositeSink(sinks));
}
5 changes: 5 additions & 0 deletions src/cli/telemetry/config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { getOrCreateInstallationId, readGlobalConfig } from '../global-config.js
import { type ResourceAttributes, ResourceAttributesSchema } from './schemas/common-attributes.js';
import { randomUUID } from 'crypto';
import os from 'os';
import { join } from 'path';

// ---------------------------------------------------------------------------
// Telemetry preference (opt-in / opt-out)
Expand DownExpand Up@@ -59,3 +60,7 @@ export async function resolveResourceAttributes(mode: 'cli' | 'tui'): Promise<Re
'node.version': process.version,
});
}

export function resolveAuditFilePath(outputDir: string, entrypoint: string, sessionId: string): string {
return join(outputDir, `${entrypoint}-${sessionId}.json`);
}
4 changes: 3 additions & 1 deletion src/cli/telemetry/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
export { resolveTelemetryPreference, resolveResourceAttributes } from './config.js';
export { resolveTelemetryPreference, resolveResourceAttributes, resolveAuditFilePath } from './config.js';
export type { TelemetryPreference } from './config.js';
export { TelemetryClientAccessor } from './client-accessor.js';
export { TelemetryClient, CANCELLED } from './client.js';
export { type MetricSink, CompositeSink } from './sinks/metric-sink.js';
export { OtelMetricSink, type OtelMetricSinkConfig } from './sinks/otel-metric-sink.js';
export { FileSystemSink, type FileSystemSinkConfig } from './sinks/filesystem-sink.js';
export { classifyError, isUserError } from './error-classification.js';
1 change: 1 addition & 0 deletions src/cli/telemetry/schemas/command-run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,6 +193,7 @@ export const COMMAND_SCHEMAS = {
package: NoAttrs,
validate: NoAttrs,
'help.modes': NoAttrs,
help: NoAttrs,
'remove.agent': NoAttrs,
'remove.memory': NoAttrs,
'remove.credential': NoAttrs,
Expand Down
48 changes: 48 additions & 0 deletions src/cli/telemetry/sinks/filesystem-sink.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
import type { MetricSink } from './metric-sink.js';
import { appendFile, mkdir } from 'fs/promises';
import { dirname } from 'path';

export interface FileSystemSinkConfig {
filePath: string;
resource?: Record<string, string | number>;
log?: (message: string) => void;
}

export class FileSystemSink implements MetricSink {
private readonly filePath: string;
private readonly resource: Record<string, string | number>;
private readonly log: (message: string) => void;
private hasRecords = false;

constructor(config: FileSystemSinkConfig) {
this.filePath = config.filePath;
this.resource = config.resource ?? {};
this.log = config.log ?? (msg => console.log(msg));
}

record(value: number, attrs: Record<string, string | number>): void {
this.hasRecords = true;
this.pendingWrite = this.pendingWrite.then(() =>
this.appendEntry({ value, attrs: { ...this.resource, ...attrs } })
);
}

async flush(): Promise<void> {
await this.pendingWrite;
}

async shutdown(): Promise<void> {
await this.pendingWrite;
if (this.hasRecords) {
this.log(`[audit mode] Telemetry written to ${this.filePath}`);
}
}

// Promise chain that serializes async writes so record() can stay synchronous.
private pendingWrite: Promise<void> = Promise.resolve();

private async appendEntry(entry: { value: number; attrs: Record<string, string | number> }): Promise<void> {
await mkdir(dirname(this.filePath), { recursive: true });
await appendFile(this.filePath, JSON.stringify(entry) + '\n');
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { spawnAndCollect } from '../src/test-utils/cli-runner.js';
import { runCLI } from '../src/test-utils/index.js';
import { describe, expect, it } from 'vitest';
import { readdirSync } from 'node:fs';
import { mkdir, readFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

const COMMANDS = [
'create',
Expand DownExpand Up@@ -38,3 +43,59 @@ describe('CLI help', () => {
}
});
});

describe('help modes telemetry', () => {
let testConfigDir: string;
const cliPath = join(__dirname, '..', 'dist', 'cli', 'index.mjs');

beforeAll(async () => {
testConfigDir = join(tmpdir(), `agentcore-help-telemetry-${Date.now()}`);
await mkdir(testConfigDir, { recursive: true });
});
afterAll(() => rm(testConfigDir, { recursive: true, force: true }));

function run(args: string[], extraEnv: Record<string, string> = {}) {
return spawnAndCollect('node', [cliPath, ...args], tmpdir(), {
AGENTCORE_SKIP_INSTALL: '1',
AGENTCORE_CONFIG_DIR: testConfigDir,
...extraEnv,
});
}

it('writes JSONL audit file when audit is enabled via env var', async () => {
const result = await run(['help', 'modes'], { AGENTCORE_TELEMETRY_AUDIT: '1' });
expect(result.exitCode).toBe(0);

const telemetryDir = join(testConfigDir, 'telemetry');
const files = readdirSync(telemetryDir).filter(f => f.startsWith('help-'));
expect(files).toHaveLength(1);

const content = await readFile(join(telemetryDir, files[0]!), 'utf-8');
const entry = JSON.parse(content.trim());
expect(entry.attrs).toMatchObject({
'service.name': 'agentcore-cli',
'agentcore-cli.mode': 'cli',
command_group: 'help',
command: 'help.modes',
exit_reason: 'success',
});
expect(entry.attrs['agentcore-cli.session_id']).toBeDefined();
expect(entry.attrs['os.type']).toBeDefined();
expect(entry.value).toBeGreaterThanOrEqual(0);
});

it('does not write audit file when audit is not enabled', async () => {
const telemetryDir = join(testConfigDir, 'telemetry');
await rm(telemetryDir, { recursive: true, force: true });

const result = await run(['help', 'modes']);
expect(result.exitCode).toBe(0);

try {
const files = readdirSync(telemetryDir);
expect(files).toHaveLength(0);
} catch {
// telemetry dir doesn't exist — correct
}
});
});
8 changes: 7 additions & 1 deletion src/cli/cli.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ import { registerValidate } from './commands/validate';
import { PACKAGE_VERSION } from './constants';
import { getOrCreateInstallationId } from './global-config';
import { ALL_PRIMITIVES } from './primitives';
import { TelemetryClientAccessor } from './telemetry';
import { App } from './tui/App';
import { LayoutProvider } from './tui/context';
import { COMMAND_DESCRIPTIONS } from './tui/copy';
Expand DownExpand Up@@ -222,7 +223,12 @@ export const main = async (argv: string[]) => {
printTelemetryNotice();
}

await program.parseAsync(argv);
TelemetryClientAccessor.init(args[0] ?? 'unknown');
try {
await program.parseAsync(argv);
} finally {
await TelemetryClientAccessor.shutdown();
}

// Telemetry notice already printed above; only run update check here.
await printPostCommandNotices(false, updateCheck);
Expand Down
19 changes: 14 additions & 5 deletions src/cli/commands/help/command.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { TelemetryClientAccessor } from '../../telemetry/client-accessor.js';
import type { Command } from '@commander-js/extra-typings';

const MODES_HELP = `
Expand DownExpand Up@@ -41,15 +42,23 @@ export const registerHelp = (program: Command) => {
const helpCmd = program
.command('help')
.description('Display help topics')
.action(() => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help', () => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
return {};
});
});

helpCmd
.command('modes')
.description('Explain interactive vs non-interactive modes')
.action(() => {
console.log(MODES_HELP);
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help.modes', () => {
console.log(MODES_HELP);
return {};
});
});
};
95 changes: 95 additions & 0 deletions src/cli/telemetry/__tests__/filesystem-sink.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
import { createTempConfig } from '../../__tests__/helpers/temp-config';
import { resolveAuditFilePath } from '../config';
import { FileSystemSink } from '../sinks/filesystem-sink';
import { readFile } from 'fs/promises';
import { join } from 'node:path';
import { afterAll, beforeEach, describe, expect, it } from 'vitest';

const tmp = createTempConfig('fs-sink');
const outputDir = join(tmp.configDir, 'telemetry');

function createSink(opts: { dir?: string; log?: (msg: string) => void } = {}) {
const filePath = join(opts.dir ?? outputDir, 'test-session.json');
return new FileSystemSink({ filePath, log: opts.log });
}

function readJsonl(path: string): Promise<unknown[]> {
return readFile(path, 'utf-8').then(data =>
data
.trim()
.split('\n')
.map(line => JSON.parse(line))
);
}

describe('FileSystemSink', () => {
beforeEach(() => tmp.setup());
afterAll(() => tmp.cleanup());

it('writes each record as a JSONL line on disk', async () => {
const sink = createSink();
sink.record(42, { command_group: 'deploy', command: 'deploy', exit_reason: 'success' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(1);
expect(entries[0]).toMatchObject({
value: 42,
attrs: { command_group: 'deploy', command: 'deploy', exit_reason: 'success' },
});
});

it('appends multiple records as separate lines', async () => {
const sink = createSink();
sink.record(10, { command_group: 'add', command: 'add.agent' });
sink.record(20, { command_group: 'add', command: 'add.memory' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(2);
expect(entries[0]).toMatchObject({ value: 10 });
expect(entries[1]).toMatchObject({ value: 20 });
});

it('creates output directory if it does not exist', async () => {
const nested = join(tmp.testDir, 'deep', 'nested', 'telemetry');
const filePath = join(nested, 'test.json');
const sink = new FileSystemSink({ filePath });
sink.record(1, { command_group: 'status', command: 'status' });
await sink.flush();

const entries = await readJsonl(filePath);
expect(entries).toHaveLength(1);
});

it('flush is a no-op when no records exist', async () => {
const sink = createSink();
await expect(sink.flush()).resolves.toBeUndefined();
});

it('shutdown logs audit message when records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
sink.record(99, { command_group: 'invoke', command: 'invoke' });
await sink.shutdown();

expect(logged).toHaveLength(1);
expect(logged[0]).toContain('[audit mode]');
expect(logged[0]).toContain('test-session.json');
});

it('shutdown does not log when no records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
await sink.shutdown();

expect(logged).toHaveLength(0);
});
});

describe('resolveAuditFilePath', () => {
it('joins outputDir, entrypoint, and sessionId into a JSON file path', () => {
const path = resolveAuditFilePath('/home/user/.agentcore/telemetry', 'deploy', 'abc-123');
expect(path).toBe('/home/user/.agentcore/telemetry/deploy-abc-123.json');
});
});
49 changes: 49 additions & 0 deletions src/cli/telemetry/client-accessor.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import { GLOBAL_CONFIG_DIR, readGlobalConfig } from '../global-config.js';
import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { join } from 'path';

/**
* Manages a singleton TelemetryClient. Call init() at startup to configure,
* get() from command handlers to obtain the client, and shutdown() on exit.
* get() lazily initializes if init() was never called.
*/
export class TelemetryClientAccessor {
private static clientPromise: Promise<TelemetryClient> | undefined;

static init(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): void {
this.clientPromise = createClient(entrypoint, mode);
}

static get(): Promise<TelemetryClient> {
this.clientPromise ??= createClient('unknown');
return this.clientPromise;
}

static async shutdown(): Promise<void> {
if (this.clientPromise) {
const client = await this.clientPromise;
await client.shutdown();
}
}
}

async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Promise<TelemetryClient> {
const [resource, config] = await Promise.all([resolveResourceAttributes(mode), readGlobalConfig()]);

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;

if (audit) {
const filePath = resolveAuditFilePath(
join(GLOBAL_CONFIG_DIR, 'telemetry'),
entrypoint,
resource['agentcore-cli.session_id']
);
sinks.push(new FileSystemSink({ filePath, resource }));
}

return new TelemetryClient(new CompositeSink(sinks));
}
5 changes: 5 additions & 0 deletions src/cli/telemetry/config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { getOrCreateInstallationId, readGlobalConfig } from '../global-config.js
import { type ResourceAttributes, ResourceAttributesSchema } from './schemas/common-attributes.js';
import { randomUUID } from 'crypto';
import os from 'os';
import { join } from 'path';

// ---------------------------------------------------------------------------
// Telemetry preference (opt-in / opt-out)
Expand DownExpand Up@@ -59,3 +60,7 @@ export async function resolveResourceAttributes(mode: 'cli' | 'tui'): Promise<Re
'node.version': process.version,
});
}

export function resolveAuditFilePath(outputDir: string, entrypoint: string, sessionId: string): string {
return join(outputDir, `${entrypoint}-${sessionId}.json`);
}
4 changes: 3 additions & 1 deletion src/cli/telemetry/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
export { resolveTelemetryPreference, resolveResourceAttributes } from './config.js';
export { resolveTelemetryPreference, resolveResourceAttributes, resolveAuditFilePath } from './config.js';
export type { TelemetryPreference } from './config.js';
export { TelemetryClientAccessor } from './client-accessor.js';
export { TelemetryClient, CANCELLED } from './client.js';
export { type MetricSink, CompositeSink } from './sinks/metric-sink.js';
export { OtelMetricSink, type OtelMetricSinkConfig } from './sinks/otel-metric-sink.js';
export { FileSystemSink, type FileSystemSinkConfig } from './sinks/filesystem-sink.js';
export { classifyError, isUserError } from './error-classification.js';
1 change: 1 addition & 0 deletions src/cli/telemetry/schemas/command-run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,6 +193,7 @@ export const COMMAND_SCHEMAS = {
package: NoAttrs,
validate: NoAttrs,
'help.modes': NoAttrs,
help: NoAttrs,
'remove.agent': NoAttrs,
'remove.memory': NoAttrs,
'remove.credential': NoAttrs,
Expand Down
48 changes: 48 additions & 0 deletions src/cli/telemetry/sinks/filesystem-sink.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
import type { MetricSink } from './metric-sink.js';
import { appendFile, mkdir } from 'fs/promises';
import { dirname } from 'path';

export interface FileSystemSinkConfig {
filePath: string;
resource?: Record<string, string | number>;
log?: (message: string) => void;
}

export class FileSystemSink implements MetricSink {
private readonly filePath: string;
private readonly resource: Record<string, string | number>;
private readonly log: (message: string) => void;
private hasRecords = false;

constructor(config: FileSystemSinkConfig) {
this.filePath = config.filePath;
this.resource = config.resource ?? {};
this.log = config.log ?? (msg => console.log(msg));
}

record(value: number, attrs: Record<string, string | number>): void {
this.hasRecords = true;
this.pendingWrite = this.pendingWrite.then(() =>
this.appendEntry({ value, attrs: { ...this.resource, ...attrs } })
);
}

async flush(): Promise<void> {
await this.pendingWrite;
}

async shutdown(): Promise<void> {
await this.pendingWrite;
if (this.hasRecords) {
this.log(`[audit mode] Telemetry written to ${this.filePath}`);
}
}

// Promise chain that serializes async writes so record() can stay synchronous.
private pendingWrite: Promise<void> = Promise.resolve();

private async appendEntry(entry: { value: number; attrs: Record<string, string | number> }): Promise<void> {
await mkdir(dirname(this.filePath), { recursive: true });
await appendFile(this.filePath, JSON.stringify(entry) + '\n');
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { spawnAndCollect } from '../src/test-utils/cli-runner.js';
import { runCLI } from '../src/test-utils/index.js';
import { describe, expect, it } from 'vitest';
import { readdirSync } from 'node:fs';
import { mkdir, readFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

const COMMANDS = [
'create',
Expand DownExpand Up@@ -38,3 +43,59 @@ describe('CLI help', () => {
}
});
});

describe('help modes telemetry', () => {
let testConfigDir: string;
const cliPath = join(__dirname, '..', 'dist', 'cli', 'index.mjs');

beforeAll(async () => {
testConfigDir = join(tmpdir(), `agentcore-help-telemetry-${Date.now()}`);
await mkdir(testConfigDir, { recursive: true });
});
afterAll(() => rm(testConfigDir, { recursive: true, force: true }));

function run(args: string[], extraEnv: Record<string, string> = {}) {
return spawnAndCollect('node', [cliPath, ...args], tmpdir(), {
AGENTCORE_SKIP_INSTALL: '1',
AGENTCORE_CONFIG_DIR: testConfigDir,
...extraEnv,
});
}

it('writes JSONL audit file when audit is enabled via env var', async () => {
const result = await run(['help', 'modes'], { AGENTCORE_TELEMETRY_AUDIT: '1' });
expect(result.exitCode).toBe(0);

const telemetryDir = join(testConfigDir, 'telemetry');
const files = readdirSync(telemetryDir).filter(f => f.startsWith('help-'));
expect(files).toHaveLength(1);

const content = await readFile(join(telemetryDir, files[0]!), 'utf-8');
const entry = JSON.parse(content.trim());
expect(entry.attrs).toMatchObject({
'service.name': 'agentcore-cli',
'agentcore-cli.mode': 'cli',
command_group: 'help',
command: 'help.modes',
exit_reason: 'success',
});
expect(entry.attrs['agentcore-cli.session_id']).toBeDefined();
expect(entry.attrs['os.type']).toBeDefined();
expect(entry.value).toBeGreaterThanOrEqual(0);
});

it('does not write audit file when audit is not enabled', async () => {
const telemetryDir = join(testConfigDir, 'telemetry');
await rm(telemetryDir, { recursive: true, force: true });

const result = await run(['help', 'modes']);
expect(result.exitCode).toBe(0);

try {
const files = readdirSync(telemetryDir);
expect(files).toHaveLength(0);
} catch {
// telemetry dir doesn't exist — correct
}
});
});
8 changes: 7 additions & 1 deletion src/cli/cli.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ import { registerValidate } from './commands/validate';
import { PACKAGE_VERSION } from './constants';
import { getOrCreateInstallationId } from './global-config';
import { ALL_PRIMITIVES } from './primitives';
import { TelemetryClientAccessor } from './telemetry';
import { App } from './tui/App';
import { LayoutProvider } from './tui/context';
import { COMMAND_DESCRIPTIONS } from './tui/copy';
Expand DownExpand Up@@ -222,7 +223,12 @@ export const main = async (argv: string[]) => {
printTelemetryNotice();
}

await program.parseAsync(argv);
TelemetryClientAccessor.init(args[0] ?? 'unknown');
try {
await program.parseAsync(argv);
} finally {
await TelemetryClientAccessor.shutdown();
}

// Telemetry notice already printed above; only run update check here.
await printPostCommandNotices(false, updateCheck);
Expand Down
19 changes: 14 additions & 5 deletions src/cli/commands/help/command.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { TelemetryClientAccessor } from '../../telemetry/client-accessor.js';
import type { Command } from '@commander-js/extra-typings';

const MODES_HELP = `
Expand DownExpand Up@@ -41,15 +42,23 @@ export const registerHelp = (program: Command) => {
const helpCmd = program
.command('help')
.description('Display help topics')
.action(() => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help', () => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
return {};
});
});

helpCmd
.command('modes')
.description('Explain interactive vs non-interactive modes')
.action(() => {
console.log(MODES_HELP);
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help.modes', () => {
console.log(MODES_HELP);
return {};
});
});
};
95 changes: 95 additions & 0 deletions src/cli/telemetry/__tests__/filesystem-sink.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
import { createTempConfig } from '../../__tests__/helpers/temp-config';
import { resolveAuditFilePath } from '../config';
import { FileSystemSink } from '../sinks/filesystem-sink';
import { readFile } from 'fs/promises';
import { join } from 'node:path';
import { afterAll, beforeEach, describe, expect, it } from 'vitest';

const tmp = createTempConfig('fs-sink');
const outputDir = join(tmp.configDir, 'telemetry');

function createSink(opts: { dir?: string; log?: (msg: string) => void } = {}) {
const filePath = join(opts.dir ?? outputDir, 'test-session.json');
return new FileSystemSink({ filePath, log: opts.log });
}

function readJsonl(path: string): Promise<unknown[]> {
return readFile(path, 'utf-8').then(data =>
data
.trim()
.split('\n')
.map(line => JSON.parse(line))
);
}

describe('FileSystemSink', () => {
beforeEach(() => tmp.setup());
afterAll(() => tmp.cleanup());

it('writes each record as a JSONL line on disk', async () => {
const sink = createSink();
sink.record(42, { command_group: 'deploy', command: 'deploy', exit_reason: 'success' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(1);
expect(entries[0]).toMatchObject({
value: 42,
attrs: { command_group: 'deploy', command: 'deploy', exit_reason: 'success' },
});
});

it('appends multiple records as separate lines', async () => {
const sink = createSink();
sink.record(10, { command_group: 'add', command: 'add.agent' });
sink.record(20, { command_group: 'add', command: 'add.memory' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(2);
expect(entries[0]).toMatchObject({ value: 10 });
expect(entries[1]).toMatchObject({ value: 20 });
});

it('creates output directory if it does not exist', async () => {
const nested = join(tmp.testDir, 'deep', 'nested', 'telemetry');
const filePath = join(nested, 'test.json');
const sink = new FileSystemSink({ filePath });
sink.record(1, { command_group: 'status', command: 'status' });
await sink.flush();

const entries = await readJsonl(filePath);
expect(entries).toHaveLength(1);
});

it('flush is a no-op when no records exist', async () => {
const sink = createSink();
await expect(sink.flush()).resolves.toBeUndefined();
});

it('shutdown logs audit message when records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
sink.record(99, { command_group: 'invoke', command: 'invoke' });
await sink.shutdown();

expect(logged).toHaveLength(1);
expect(logged[0]).toContain('[audit mode]');
expect(logged[0]).toContain('test-session.json');
});

it('shutdown does not log when no records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
await sink.shutdown();

expect(logged).toHaveLength(0);
});
});

describe('resolveAuditFilePath', () => {
it('joins outputDir, entrypoint, and sessionId into a JSON file path', () => {
const path = resolveAuditFilePath('/home/user/.agentcore/telemetry', 'deploy', 'abc-123');
expect(path).toBe('/home/user/.agentcore/telemetry/deploy-abc-123.json');
});
});
49 changes: 49 additions & 0 deletions src/cli/telemetry/client-accessor.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import { GLOBAL_CONFIG_DIR, readGlobalConfig } from '../global-config.js';
import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { join } from 'path';

/**
* Manages a singleton TelemetryClient. Call init() at startup to configure,
* get() from command handlers to obtain the client, and shutdown() on exit.
* get() lazily initializes if init() was never called.
*/
export class TelemetryClientAccessor {
private static clientPromise: Promise<TelemetryClient> | undefined;

static init(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): void {
this.clientPromise = createClient(entrypoint, mode);
}

static get(): Promise<TelemetryClient> {
this.clientPromise ??= createClient('unknown');
return this.clientPromise;
}

static async shutdown(): Promise<void> {
if (this.clientPromise) {
const client = await this.clientPromise;
await client.shutdown();
}
}
}

async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Promise<TelemetryClient> {
const [resource, config] = await Promise.all([resolveResourceAttributes(mode), readGlobalConfig()]);

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;

if (audit) {
const filePath = resolveAuditFilePath(
join(GLOBAL_CONFIG_DIR, 'telemetry'),
entrypoint,
resource['agentcore-cli.session_id']
);
sinks.push(new FileSystemSink({ filePath, resource }));
}

return new TelemetryClient(new CompositeSink(sinks));
}
5 changes: 5 additions & 0 deletions src/cli/telemetry/config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { getOrCreateInstallationId, readGlobalConfig } from '../global-config.js
import { type ResourceAttributes, ResourceAttributesSchema } from './schemas/common-attributes.js';
import { randomUUID } from 'crypto';
import os from 'os';
import { join } from 'path';

// ---------------------------------------------------------------------------
// Telemetry preference (opt-in / opt-out)
Expand DownExpand Up@@ -59,3 +60,7 @@ export async function resolveResourceAttributes(mode: 'cli' | 'tui'): Promise<Re
'node.version': process.version,
});
}

export function resolveAuditFilePath(outputDir: string, entrypoint: string, sessionId: string): string {
return join(outputDir, `${entrypoint}-${sessionId}.json`);
}
4 changes: 3 additions & 1 deletion src/cli/telemetry/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
export { resolveTelemetryPreference, resolveResourceAttributes } from './config.js';
export { resolveTelemetryPreference, resolveResourceAttributes, resolveAuditFilePath } from './config.js';
export type { TelemetryPreference } from './config.js';
export { TelemetryClientAccessor } from './client-accessor.js';
export { TelemetryClient, CANCELLED } from './client.js';
export { type MetricSink, CompositeSink } from './sinks/metric-sink.js';
export { OtelMetricSink, type OtelMetricSinkConfig } from './sinks/otel-metric-sink.js';
export { FileSystemSink, type FileSystemSinkConfig } from './sinks/filesystem-sink.js';
export { classifyError, isUserError } from './error-classification.js';
1 change: 1 addition & 0 deletions src/cli/telemetry/schemas/command-run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,6 +193,7 @@ export const COMMAND_SCHEMAS = {
package: NoAttrs,
validate: NoAttrs,
'help.modes': NoAttrs,
help: NoAttrs,
'remove.agent': NoAttrs,
'remove.memory': NoAttrs,
'remove.credential': NoAttrs,
Expand Down
48 changes: 48 additions & 0 deletions src/cli/telemetry/sinks/filesystem-sink.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
import type { MetricSink } from './metric-sink.js';
import { appendFile, mkdir } from 'fs/promises';
import { dirname } from 'path';

export interface FileSystemSinkConfig {
filePath: string;
resource?: Record<string, string | number>;
log?: (message: string) => void;
}

export class FileSystemSink implements MetricSink {
private readonly filePath: string;
private readonly resource: Record<string, string | number>;
private readonly log: (message: string) => void;
private hasRecords = false;

constructor(config: FileSystemSinkConfig) {
this.filePath = config.filePath;
this.resource = config.resource ?? {};
this.log = config.log ?? (msg => console.log(msg));
}

record(value: number, attrs: Record<string, string | number>): void {
this.hasRecords = true;
this.pendingWrite = this.pendingWrite.then(() =>
this.appendEntry({ value, attrs: { ...this.resource, ...attrs } })
);
}

async flush(): Promise<void> {
await this.pendingWrite;
}

async shutdown(): Promise<void> {
await this.pendingWrite;
if (this.hasRecords) {
this.log(`[audit mode] Telemetry written to ${this.filePath}`);
}
}

// Promise chain that serializes async writes so record() can stay synchronous.
private pendingWrite: Promise<void> = Promise.resolve();

private async appendEntry(entry: { value: number; attrs: Record<string, string | number> }): Promise<void> {
await mkdir(dirname(this.filePath), { recursive: true });
await appendFile(this.filePath, JSON.stringify(entry) + '\n');
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { spawnAndCollect } from '../src/test-utils/cli-runner.js';
import { runCLI } from '../src/test-utils/index.js';
import { describe, expect, it } from 'vitest';
import { readdirSync } from 'node:fs';
import { mkdir, readFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

const COMMANDS = [
'create',
Expand DownExpand Up@@ -38,3 +43,59 @@ describe('CLI help', () => {
}
});
});

describe('help modes telemetry', () => {
let testConfigDir: string;
const cliPath = join(__dirname, '..', 'dist', 'cli', 'index.mjs');

beforeAll(async () => {
testConfigDir = join(tmpdir(), `agentcore-help-telemetry-${Date.now()}`);
await mkdir(testConfigDir, { recursive: true });
});
afterAll(() => rm(testConfigDir, { recursive: true, force: true }));

function run(args: string[], extraEnv: Record<string, string> = {}) {
return spawnAndCollect('node', [cliPath, ...args], tmpdir(), {
AGENTCORE_SKIP_INSTALL: '1',
AGENTCORE_CONFIG_DIR: testConfigDir,
...extraEnv,
});
}

it('writes JSONL audit file when audit is enabled via env var', async () => {
const result = await run(['help', 'modes'], { AGENTCORE_TELEMETRY_AUDIT: '1' });
expect(result.exitCode).toBe(0);

const telemetryDir = join(testConfigDir, 'telemetry');
const files = readdirSync(telemetryDir).filter(f => f.startsWith('help-'));
expect(files).toHaveLength(1);

const content = await readFile(join(telemetryDir, files[0]!), 'utf-8');
const entry = JSON.parse(content.trim());
expect(entry.attrs).toMatchObject({
'service.name': 'agentcore-cli',
'agentcore-cli.mode': 'cli',
command_group: 'help',
command: 'help.modes',
exit_reason: 'success',
});
expect(entry.attrs['agentcore-cli.session_id']).toBeDefined();
expect(entry.attrs['os.type']).toBeDefined();
expect(entry.value).toBeGreaterThanOrEqual(0);
});

it('does not write audit file when audit is not enabled', async () => {
const telemetryDir = join(testConfigDir, 'telemetry');
await rm(telemetryDir, { recursive: true, force: true });

const result = await run(['help', 'modes']);
expect(result.exitCode).toBe(0);

try {
const files = readdirSync(telemetryDir);
expect(files).toHaveLength(0);
} catch {
// telemetry dir doesn't exist — correct
}
});
});
8 changes: 7 additions & 1 deletion src/cli/cli.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ import { registerValidate } from './commands/validate';
import { PACKAGE_VERSION } from './constants';
import { getOrCreateInstallationId } from './global-config';
import { ALL_PRIMITIVES } from './primitives';
import { TelemetryClientAccessor } from './telemetry';
import { App } from './tui/App';
import { LayoutProvider } from './tui/context';
import { COMMAND_DESCRIPTIONS } from './tui/copy';
Expand DownExpand Up@@ -222,7 +223,12 @@ export const main = async (argv: string[]) => {
printTelemetryNotice();
}

await program.parseAsync(argv);
TelemetryClientAccessor.init(args[0] ?? 'unknown');
try {
await program.parseAsync(argv);
} finally {
await TelemetryClientAccessor.shutdown();
}

// Telemetry notice already printed above; only run update check here.
await printPostCommandNotices(false, updateCheck);
Expand Down
19 changes: 14 additions & 5 deletions src/cli/commands/help/command.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { TelemetryClientAccessor } from '../../telemetry/client-accessor.js';
import type { Command } from '@commander-js/extra-typings';

const MODES_HELP = `
Expand DownExpand Up@@ -41,15 +42,23 @@ export const registerHelp = (program: Command) => {
const helpCmd = program
.command('help')
.description('Display help topics')
.action(() => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help', () => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
return {};
});
});

helpCmd
.command('modes')
.description('Explain interactive vs non-interactive modes')
.action(() => {
console.log(MODES_HELP);
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help.modes', () => {
console.log(MODES_HELP);
return {};
});
});
};
95 changes: 95 additions & 0 deletions src/cli/telemetry/__tests__/filesystem-sink.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
import { createTempConfig } from '../../__tests__/helpers/temp-config';
import { resolveAuditFilePath } from '../config';
import { FileSystemSink } from '../sinks/filesystem-sink';
import { readFile } from 'fs/promises';
import { join } from 'node:path';
import { afterAll, beforeEach, describe, expect, it } from 'vitest';

const tmp = createTempConfig('fs-sink');
const outputDir = join(tmp.configDir, 'telemetry');

function createSink(opts: { dir?: string; log?: (msg: string) => void } = {}) {
const filePath = join(opts.dir ?? outputDir, 'test-session.json');
return new FileSystemSink({ filePath, log: opts.log });
}

function readJsonl(path: string): Promise<unknown[]> {
return readFile(path, 'utf-8').then(data =>
data
.trim()
.split('\n')
.map(line => JSON.parse(line))
);
}

describe('FileSystemSink', () => {
beforeEach(() => tmp.setup());
afterAll(() => tmp.cleanup());

it('writes each record as a JSONL line on disk', async () => {
const sink = createSink();
sink.record(42, { command_group: 'deploy', command: 'deploy', exit_reason: 'success' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(1);
expect(entries[0]).toMatchObject({
value: 42,
attrs: { command_group: 'deploy', command: 'deploy', exit_reason: 'success' },
});
});

it('appends multiple records as separate lines', async () => {
const sink = createSink();
sink.record(10, { command_group: 'add', command: 'add.agent' });
sink.record(20, { command_group: 'add', command: 'add.memory' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(2);
expect(entries[0]).toMatchObject({ value: 10 });
expect(entries[1]).toMatchObject({ value: 20 });
});

it('creates output directory if it does not exist', async () => {
const nested = join(tmp.testDir, 'deep', 'nested', 'telemetry');
const filePath = join(nested, 'test.json');
const sink = new FileSystemSink({ filePath });
sink.record(1, { command_group: 'status', command: 'status' });
await sink.flush();

const entries = await readJsonl(filePath);
expect(entries).toHaveLength(1);
});

it('flush is a no-op when no records exist', async () => {
const sink = createSink();
await expect(sink.flush()).resolves.toBeUndefined();
});

it('shutdown logs audit message when records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
sink.record(99, { command_group: 'invoke', command: 'invoke' });
await sink.shutdown();

expect(logged).toHaveLength(1);
expect(logged[0]).toContain('[audit mode]');
expect(logged[0]).toContain('test-session.json');
});

it('shutdown does not log when no records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
await sink.shutdown();

expect(logged).toHaveLength(0);
});
});

describe('resolveAuditFilePath', () => {
it('joins outputDir, entrypoint, and sessionId into a JSON file path', () => {
const path = resolveAuditFilePath('/home/user/.agentcore/telemetry', 'deploy', 'abc-123');
expect(path).toBe('/home/user/.agentcore/telemetry/deploy-abc-123.json');
});
});
49 changes: 49 additions & 0 deletions src/cli/telemetry/client-accessor.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import { GLOBAL_CONFIG_DIR, readGlobalConfig } from '../global-config.js';
import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { join } from 'path';

/**
* Manages a singleton TelemetryClient. Call init() at startup to configure,
* get() from command handlers to obtain the client, and shutdown() on exit.
* get() lazily initializes if init() was never called.
*/
export class TelemetryClientAccessor {
private static clientPromise: Promise<TelemetryClient> | undefined;

static init(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): void {
this.clientPromise = createClient(entrypoint, mode);
}

static get(): Promise<TelemetryClient> {
this.clientPromise ??= createClient('unknown');
return this.clientPromise;
}

static async shutdown(): Promise<void> {
if (this.clientPromise) {
const client = await this.clientPromise;
await client.shutdown();
}
}
}

async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Promise<TelemetryClient> {
const [resource, config] = await Promise.all([resolveResourceAttributes(mode), readGlobalConfig()]);

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;

if (audit) {
const filePath = resolveAuditFilePath(
join(GLOBAL_CONFIG_DIR, 'telemetry'),
entrypoint,
resource['agentcore-cli.session_id']
);
sinks.push(new FileSystemSink({ filePath, resource }));
}

return new TelemetryClient(new CompositeSink(sinks));
}
5 changes: 5 additions & 0 deletions src/cli/telemetry/config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { getOrCreateInstallationId, readGlobalConfig } from '../global-config.js
import { type ResourceAttributes, ResourceAttributesSchema } from './schemas/common-attributes.js';
import { randomUUID } from 'crypto';
import os from 'os';
import { join } from 'path';

// ---------------------------------------------------------------------------
// Telemetry preference (opt-in / opt-out)
Expand DownExpand Up@@ -59,3 +60,7 @@ export async function resolveResourceAttributes(mode: 'cli' | 'tui'): Promise<Re
'node.version': process.version,
});
}

export function resolveAuditFilePath(outputDir: string, entrypoint: string, sessionId: string): string {
return join(outputDir, `${entrypoint}-${sessionId}.json`);
}
4 changes: 3 additions & 1 deletion src/cli/telemetry/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
export { resolveTelemetryPreference, resolveResourceAttributes } from './config.js';
export { resolveTelemetryPreference, resolveResourceAttributes, resolveAuditFilePath } from './config.js';
export type { TelemetryPreference } from './config.js';
export { TelemetryClientAccessor } from './client-accessor.js';
export { TelemetryClient, CANCELLED } from './client.js';
export { type MetricSink, CompositeSink } from './sinks/metric-sink.js';
export { OtelMetricSink, type OtelMetricSinkConfig } from './sinks/otel-metric-sink.js';
export { FileSystemSink, type FileSystemSinkConfig } from './sinks/filesystem-sink.js';
export { classifyError, isUserError } from './error-classification.js';
1 change: 1 addition & 0 deletions src/cli/telemetry/schemas/command-run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,6 +193,7 @@ export const COMMAND_SCHEMAS = {
package: NoAttrs,
validate: NoAttrs,
'help.modes': NoAttrs,
help: NoAttrs,
'remove.agent': NoAttrs,
'remove.memory': NoAttrs,
'remove.credential': NoAttrs,
Expand Down
48 changes: 48 additions & 0 deletions src/cli/telemetry/sinks/filesystem-sink.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
import type { MetricSink } from './metric-sink.js';
import { appendFile, mkdir } from 'fs/promises';
import { dirname } from 'path';

export interface FileSystemSinkConfig {
filePath: string;
resource?: Record<string, string | number>;
log?: (message: string) => void;
}

export class FileSystemSink implements MetricSink {
private readonly filePath: string;
private readonly resource: Record<string, string | number>;
private readonly log: (message: string) => void;
private hasRecords = false;

constructor(config: FileSystemSinkConfig) {
this.filePath = config.filePath;
this.resource = config.resource ?? {};
this.log = config.log ?? (msg => console.log(msg));
}

record(value: number, attrs: Record<string, string | number>): void {
this.hasRecords = true;
this.pendingWrite = this.pendingWrite.then(() =>
this.appendEntry({ value, attrs: { ...this.resource, ...attrs } })
);
}

async flush(): Promise<void> {
await this.pendingWrite;
}

async shutdown(): Promise<void> {
await this.pendingWrite;
if (this.hasRecords) {
this.log(`[audit mode] Telemetry written to ${this.filePath}`);
}
}

// Promise chain that serializes async writes so record() can stay synchronous.
private pendingWrite: Promise<void> = Promise.resolve();

private async appendEntry(entry: { value: number; attrs: Record<string, string | number> }): Promise<void> {
await mkdir(dirname(this.filePath), { recursive: true });
await appendFile(this.filePath, JSON.stringify(entry) + '\n');
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { spawnAndCollect } from '../src/test-utils/cli-runner.js';
import { runCLI } from '../src/test-utils/index.js';
import { describe, expect, it } from 'vitest';
import { readdirSync } from 'node:fs';
import { mkdir, readFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

const COMMANDS = [
'create',
Expand DownExpand Up@@ -38,3 +43,59 @@ describe('CLI help', () => {
}
});
});

describe('help modes telemetry', () => {
let testConfigDir: string;
const cliPath = join(__dirname, '..', 'dist', 'cli', 'index.mjs');

beforeAll(async () => {
testConfigDir = join(tmpdir(), `agentcore-help-telemetry-${Date.now()}`);
await mkdir(testConfigDir, { recursive: true });
});
afterAll(() => rm(testConfigDir, { recursive: true, force: true }));

function run(args: string[], extraEnv: Record<string, string> = {}) {
return spawnAndCollect('node', [cliPath, ...args], tmpdir(), {
AGENTCORE_SKIP_INSTALL: '1',
AGENTCORE_CONFIG_DIR: testConfigDir,
...extraEnv,
});
}

it('writes JSONL audit file when audit is enabled via env var', async () => {
const result = await run(['help', 'modes'], { AGENTCORE_TELEMETRY_AUDIT: '1' });
expect(result.exitCode).toBe(0);

const telemetryDir = join(testConfigDir, 'telemetry');
const files = readdirSync(telemetryDir).filter(f => f.startsWith('help-'));
expect(files).toHaveLength(1);

const content = await readFile(join(telemetryDir, files[0]!), 'utf-8');
const entry = JSON.parse(content.trim());
expect(entry.attrs).toMatchObject({
'service.name': 'agentcore-cli',
'agentcore-cli.mode': 'cli',
command_group: 'help',
command: 'help.modes',
exit_reason: 'success',
});
expect(entry.attrs['agentcore-cli.session_id']).toBeDefined();
expect(entry.attrs['os.type']).toBeDefined();
expect(entry.value).toBeGreaterThanOrEqual(0);
});

it('does not write audit file when audit is not enabled', async () => {
const telemetryDir = join(testConfigDir, 'telemetry');
await rm(telemetryDir, { recursive: true, force: true });

const result = await run(['help', 'modes']);
expect(result.exitCode).toBe(0);

try {
const files = readdirSync(telemetryDir);
expect(files).toHaveLength(0);
} catch {
// telemetry dir doesn't exist — correct
}
});
});
8 changes: 7 additions & 1 deletion src/cli/cli.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ import { registerValidate } from './commands/validate';
import { PACKAGE_VERSION } from './constants';
import { getOrCreateInstallationId } from './global-config';
import { ALL_PRIMITIVES } from './primitives';
import { TelemetryClientAccessor } from './telemetry';
import { App } from './tui/App';
import { LayoutProvider } from './tui/context';
import { COMMAND_DESCRIPTIONS } from './tui/copy';
Expand DownExpand Up@@ -222,7 +223,12 @@ export const main = async (argv: string[]) => {
printTelemetryNotice();
}

await program.parseAsync(argv);
TelemetryClientAccessor.init(args[0] ?? 'unknown');
try {
await program.parseAsync(argv);
} finally {
await TelemetryClientAccessor.shutdown();
}

// Telemetry notice already printed above; only run update check here.
await printPostCommandNotices(false, updateCheck);
Expand Down
19 changes: 14 additions & 5 deletions src/cli/commands/help/command.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { TelemetryClientAccessor } from '../../telemetry/client-accessor.js';
import type { Command } from '@commander-js/extra-typings';

const MODES_HELP = `
Expand DownExpand Up@@ -41,15 +42,23 @@ export const registerHelp = (program: Command) => {
const helpCmd = program
.command('help')
.description('Display help topics')
.action(() => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help', () => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
return {};
});
});

helpCmd
.command('modes')
.description('Explain interactive vs non-interactive modes')
.action(() => {
console.log(MODES_HELP);
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help.modes', () => {
console.log(MODES_HELP);
return {};
});
});
};
95 changes: 95 additions & 0 deletions src/cli/telemetry/__tests__/filesystem-sink.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
import { createTempConfig } from '../../__tests__/helpers/temp-config';
import { resolveAuditFilePath } from '../config';
import { FileSystemSink } from '../sinks/filesystem-sink';
import { readFile } from 'fs/promises';
import { join } from 'node:path';
import { afterAll, beforeEach, describe, expect, it } from 'vitest';

const tmp = createTempConfig('fs-sink');
const outputDir = join(tmp.configDir, 'telemetry');

function createSink(opts: { dir?: string; log?: (msg: string) => void } = {}) {
const filePath = join(opts.dir ?? outputDir, 'test-session.json');
return new FileSystemSink({ filePath, log: opts.log });
}

function readJsonl(path: string): Promise<unknown[]> {
return readFile(path, 'utf-8').then(data =>
data
.trim()
.split('\n')
.map(line => JSON.parse(line))
);
}

describe('FileSystemSink', () => {
beforeEach(() => tmp.setup());
afterAll(() => tmp.cleanup());

it('writes each record as a JSONL line on disk', async () => {
const sink = createSink();
sink.record(42, { command_group: 'deploy', command: 'deploy', exit_reason: 'success' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(1);
expect(entries[0]).toMatchObject({
value: 42,
attrs: { command_group: 'deploy', command: 'deploy', exit_reason: 'success' },
});
});

it('appends multiple records as separate lines', async () => {
const sink = createSink();
sink.record(10, { command_group: 'add', command: 'add.agent' });
sink.record(20, { command_group: 'add', command: 'add.memory' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(2);
expect(entries[0]).toMatchObject({ value: 10 });
expect(entries[1]).toMatchObject({ value: 20 });
});

it('creates output directory if it does not exist', async () => {
const nested = join(tmp.testDir, 'deep', 'nested', 'telemetry');
const filePath = join(nested, 'test.json');
const sink = new FileSystemSink({ filePath });
sink.record(1, { command_group: 'status', command: 'status' });
await sink.flush();

const entries = await readJsonl(filePath);
expect(entries).toHaveLength(1);
});

it('flush is a no-op when no records exist', async () => {
const sink = createSink();
await expect(sink.flush()).resolves.toBeUndefined();
});

it('shutdown logs audit message when records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
sink.record(99, { command_group: 'invoke', command: 'invoke' });
await sink.shutdown();

expect(logged).toHaveLength(1);
expect(logged[0]).toContain('[audit mode]');
expect(logged[0]).toContain('test-session.json');
});

it('shutdown does not log when no records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
await sink.shutdown();

expect(logged).toHaveLength(0);
});
});

describe('resolveAuditFilePath', () => {
it('joins outputDir, entrypoint, and sessionId into a JSON file path', () => {
const path = resolveAuditFilePath('/home/user/.agentcore/telemetry', 'deploy', 'abc-123');
expect(path).toBe('/home/user/.agentcore/telemetry/deploy-abc-123.json');
});
});
49 changes: 49 additions & 0 deletions src/cli/telemetry/client-accessor.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import { GLOBAL_CONFIG_DIR, readGlobalConfig } from '../global-config.js';
import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { join } from 'path';

/**
* Manages a singleton TelemetryClient. Call init() at startup to configure,
* get() from command handlers to obtain the client, and shutdown() on exit.
* get() lazily initializes if init() was never called.
*/
export class TelemetryClientAccessor {
private static clientPromise: Promise<TelemetryClient> | undefined;

static init(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): void {
this.clientPromise = createClient(entrypoint, mode);
}

static get(): Promise<TelemetryClient> {
this.clientPromise ??= createClient('unknown');
return this.clientPromise;
}

static async shutdown(): Promise<void> {
if (this.clientPromise) {
const client = await this.clientPromise;
await client.shutdown();
}
}
}

async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Promise<TelemetryClient> {
const [resource, config] = await Promise.all([resolveResourceAttributes(mode), readGlobalConfig()]);

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;

if (audit) {
const filePath = resolveAuditFilePath(
join(GLOBAL_CONFIG_DIR, 'telemetry'),
entrypoint,
resource['agentcore-cli.session_id']
);
sinks.push(new FileSystemSink({ filePath, resource }));
}

return new TelemetryClient(new CompositeSink(sinks));
}
5 changes: 5 additions & 0 deletions src/cli/telemetry/config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { getOrCreateInstallationId, readGlobalConfig } from '../global-config.js
import { type ResourceAttributes, ResourceAttributesSchema } from './schemas/common-attributes.js';
import { randomUUID } from 'crypto';
import os from 'os';
import { join } from 'path';

// ---------------------------------------------------------------------------
// Telemetry preference (opt-in / opt-out)
Expand DownExpand Up@@ -59,3 +60,7 @@ export async function resolveResourceAttributes(mode: 'cli' | 'tui'): Promise<Re
'node.version': process.version,
});
}

export function resolveAuditFilePath(outputDir: string, entrypoint: string, sessionId: string): string {
return join(outputDir, `${entrypoint}-${sessionId}.json`);
}
4 changes: 3 additions & 1 deletion src/cli/telemetry/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
export { resolveTelemetryPreference, resolveResourceAttributes } from './config.js';
export { resolveTelemetryPreference, resolveResourceAttributes, resolveAuditFilePath } from './config.js';
export type { TelemetryPreference } from './config.js';
export { TelemetryClientAccessor } from './client-accessor.js';
export { TelemetryClient, CANCELLED } from './client.js';
export { type MetricSink, CompositeSink } from './sinks/metric-sink.js';
export { OtelMetricSink, type OtelMetricSinkConfig } from './sinks/otel-metric-sink.js';
export { FileSystemSink, type FileSystemSinkConfig } from './sinks/filesystem-sink.js';
export { classifyError, isUserError } from './error-classification.js';
1 change: 1 addition & 0 deletions src/cli/telemetry/schemas/command-run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,6 +193,7 @@ export const COMMAND_SCHEMAS = {
package: NoAttrs,
validate: NoAttrs,
'help.modes': NoAttrs,
help: NoAttrs,
'remove.agent': NoAttrs,
'remove.memory': NoAttrs,
'remove.credential': NoAttrs,
Expand Down
48 changes: 48 additions & 0 deletions src/cli/telemetry/sinks/filesystem-sink.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
import type { MetricSink } from './metric-sink.js';
import { appendFile, mkdir } from 'fs/promises';
import { dirname } from 'path';

export interface FileSystemSinkConfig {
filePath: string;
resource?: Record<string, string | number>;
log?: (message: string) => void;
}

export class FileSystemSink implements MetricSink {
private readonly filePath: string;
private readonly resource: Record<string, string | number>;
private readonly log: (message: string) => void;
private hasRecords = false;

constructor(config: FileSystemSinkConfig) {
this.filePath = config.filePath;
this.resource = config.resource ?? {};
this.log = config.log ?? (msg => console.log(msg));
}

record(value: number, attrs: Record<string, string | number>): void {
this.hasRecords = true;
this.pendingWrite = this.pendingWrite.then(() =>
this.appendEntry({ value, attrs: { ...this.resource, ...attrs } })
);
}

async flush(): Promise<void> {
await this.pendingWrite;
}

async shutdown(): Promise<void> {
await this.pendingWrite;
if (this.hasRecords) {
this.log(`[audit mode] Telemetry written to ${this.filePath}`);
}
}

// Promise chain that serializes async writes so record() can stay synchronous.
private pendingWrite: Promise<void> = Promise.resolve();

private async appendEntry(entry: { value: number; attrs: Record<string, string | number> }): Promise<void> {
await mkdir(dirname(this.filePath), { recursive: true });
await appendFile(this.filePath, JSON.stringify(entry) + '\n');
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { spawnAndCollect } from '../src/test-utils/cli-runner.js';
import { runCLI } from '../src/test-utils/index.js';
import { describe, expect, it } from 'vitest';
import { readdirSync } from 'node:fs';
import { mkdir, readFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

const COMMANDS = [
'create',
Expand DownExpand Up@@ -38,3 +43,59 @@ describe('CLI help', () => {
}
});
});

describe('help modes telemetry', () => {
let testConfigDir: string;
const cliPath = join(__dirname, '..', 'dist', 'cli', 'index.mjs');

beforeAll(async () => {
testConfigDir = join(tmpdir(), `agentcore-help-telemetry-${Date.now()}`);
await mkdir(testConfigDir, { recursive: true });
});
afterAll(() => rm(testConfigDir, { recursive: true, force: true }));

function run(args: string[], extraEnv: Record<string, string> = {}) {
return spawnAndCollect('node', [cliPath, ...args], tmpdir(), {
AGENTCORE_SKIP_INSTALL: '1',
AGENTCORE_CONFIG_DIR: testConfigDir,
...extraEnv,
});
}

it('writes JSONL audit file when audit is enabled via env var', async () => {
const result = await run(['help', 'modes'], { AGENTCORE_TELEMETRY_AUDIT: '1' });
expect(result.exitCode).toBe(0);

const telemetryDir = join(testConfigDir, 'telemetry');
const files = readdirSync(telemetryDir).filter(f => f.startsWith('help-'));
expect(files).toHaveLength(1);

const content = await readFile(join(telemetryDir, files[0]!), 'utf-8');
const entry = JSON.parse(content.trim());
expect(entry.attrs).toMatchObject({
'service.name': 'agentcore-cli',
'agentcore-cli.mode': 'cli',
command_group: 'help',
command: 'help.modes',
exit_reason: 'success',
});
expect(entry.attrs['agentcore-cli.session_id']).toBeDefined();
expect(entry.attrs['os.type']).toBeDefined();
expect(entry.value).toBeGreaterThanOrEqual(0);
});

it('does not write audit file when audit is not enabled', async () => {
const telemetryDir = join(testConfigDir, 'telemetry');
await rm(telemetryDir, { recursive: true, force: true });

const result = await run(['help', 'modes']);
expect(result.exitCode).toBe(0);

try {
const files = readdirSync(telemetryDir);
expect(files).toHaveLength(0);
} catch {
// telemetry dir doesn't exist — correct
}
});
});
8 changes: 7 additions & 1 deletion src/cli/cli.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ import { registerValidate } from './commands/validate';
import { PACKAGE_VERSION } from './constants';
import { getOrCreateInstallationId } from './global-config';
import { ALL_PRIMITIVES } from './primitives';
import { TelemetryClientAccessor } from './telemetry';
import { App } from './tui/App';
import { LayoutProvider } from './tui/context';
import { COMMAND_DESCRIPTIONS } from './tui/copy';
Expand DownExpand Up@@ -222,7 +223,12 @@ export const main = async (argv: string[]) => {
printTelemetryNotice();
}

await program.parseAsync(argv);
TelemetryClientAccessor.init(args[0] ?? 'unknown');
try {
await program.parseAsync(argv);
} finally {
await TelemetryClientAccessor.shutdown();
}

// Telemetry notice already printed above; only run update check here.
await printPostCommandNotices(false, updateCheck);
Expand Down
19 changes: 14 additions & 5 deletions src/cli/commands/help/command.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { TelemetryClientAccessor } from '../../telemetry/client-accessor.js';
import type { Command } from '@commander-js/extra-typings';

const MODES_HELP = `
Expand DownExpand Up@@ -41,15 +42,23 @@ export const registerHelp = (program: Command) => {
const helpCmd = program
.command('help')
.description('Display help topics')
.action(() => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help', () => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
return {};
});
});

helpCmd
.command('modes')
.description('Explain interactive vs non-interactive modes')
.action(() => {
console.log(MODES_HELP);
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help.modes', () => {
console.log(MODES_HELP);
return {};
});
});
};
95 changes: 95 additions & 0 deletions src/cli/telemetry/__tests__/filesystem-sink.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
import { createTempConfig } from '../../__tests__/helpers/temp-config';
import { resolveAuditFilePath } from '../config';
import { FileSystemSink } from '../sinks/filesystem-sink';
import { readFile } from 'fs/promises';
import { join } from 'node:path';
import { afterAll, beforeEach, describe, expect, it } from 'vitest';

const tmp = createTempConfig('fs-sink');
const outputDir = join(tmp.configDir, 'telemetry');

function createSink(opts: { dir?: string; log?: (msg: string) => void } = {}) {
const filePath = join(opts.dir ?? outputDir, 'test-session.json');
return new FileSystemSink({ filePath, log: opts.log });
}

function readJsonl(path: string): Promise<unknown[]> {
return readFile(path, 'utf-8').then(data =>
data
.trim()
.split('\n')
.map(line => JSON.parse(line))
);
}

describe('FileSystemSink', () => {
beforeEach(() => tmp.setup());
afterAll(() => tmp.cleanup());

it('writes each record as a JSONL line on disk', async () => {
const sink = createSink();
sink.record(42, { command_group: 'deploy', command: 'deploy', exit_reason: 'success' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(1);
expect(entries[0]).toMatchObject({
value: 42,
attrs: { command_group: 'deploy', command: 'deploy', exit_reason: 'success' },
});
});

it('appends multiple records as separate lines', async () => {
const sink = createSink();
sink.record(10, { command_group: 'add', command: 'add.agent' });
sink.record(20, { command_group: 'add', command: 'add.memory' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(2);
expect(entries[0]).toMatchObject({ value: 10 });
expect(entries[1]).toMatchObject({ value: 20 });
});

it('creates output directory if it does not exist', async () => {
const nested = join(tmp.testDir, 'deep', 'nested', 'telemetry');
const filePath = join(nested, 'test.json');
const sink = new FileSystemSink({ filePath });
sink.record(1, { command_group: 'status', command: 'status' });
await sink.flush();

const entries = await readJsonl(filePath);
expect(entries).toHaveLength(1);
});

it('flush is a no-op when no records exist', async () => {
const sink = createSink();
await expect(sink.flush()).resolves.toBeUndefined();
});

it('shutdown logs audit message when records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
sink.record(99, { command_group: 'invoke', command: 'invoke' });
await sink.shutdown();

expect(logged).toHaveLength(1);
expect(logged[0]).toContain('[audit mode]');
expect(logged[0]).toContain('test-session.json');
});

it('shutdown does not log when no records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
await sink.shutdown();

expect(logged).toHaveLength(0);
});
});

describe('resolveAuditFilePath', () => {
it('joins outputDir, entrypoint, and sessionId into a JSON file path', () => {
const path = resolveAuditFilePath('/home/user/.agentcore/telemetry', 'deploy', 'abc-123');
expect(path).toBe('/home/user/.agentcore/telemetry/deploy-abc-123.json');
});
});
49 changes: 49 additions & 0 deletions src/cli/telemetry/client-accessor.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import { GLOBAL_CONFIG_DIR, readGlobalConfig } from '../global-config.js';
import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { join } from 'path';

/**
* Manages a singleton TelemetryClient. Call init() at startup to configure,
* get() from command handlers to obtain the client, and shutdown() on exit.
* get() lazily initializes if init() was never called.
*/
export class TelemetryClientAccessor {
private static clientPromise: Promise<TelemetryClient> | undefined;

static init(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): void {
this.clientPromise = createClient(entrypoint, mode);
}

static get(): Promise<TelemetryClient> {
this.clientPromise ??= createClient('unknown');
return this.clientPromise;
}

static async shutdown(): Promise<void> {
if (this.clientPromise) {
const client = await this.clientPromise;
await client.shutdown();
}
}
}

async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Promise<TelemetryClient> {
const [resource, config] = await Promise.all([resolveResourceAttributes(mode), readGlobalConfig()]);

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;

if (audit) {
const filePath = resolveAuditFilePath(
join(GLOBAL_CONFIG_DIR, 'telemetry'),
entrypoint,
resource['agentcore-cli.session_id']
);
sinks.push(new FileSystemSink({ filePath, resource }));
}

return new TelemetryClient(new CompositeSink(sinks));
}
5 changes: 5 additions & 0 deletions src/cli/telemetry/config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { getOrCreateInstallationId, readGlobalConfig } from '../global-config.js
import { type ResourceAttributes, ResourceAttributesSchema } from './schemas/common-attributes.js';
import { randomUUID } from 'crypto';
import os from 'os';
import { join } from 'path';

// ---------------------------------------------------------------------------
// Telemetry preference (opt-in / opt-out)
Expand DownExpand Up@@ -59,3 +60,7 @@ export async function resolveResourceAttributes(mode: 'cli' | 'tui'): Promise<Re
'node.version': process.version,
});
}

export function resolveAuditFilePath(outputDir: string, entrypoint: string, sessionId: string): string {
return join(outputDir, `${entrypoint}-${sessionId}.json`);
}
4 changes: 3 additions & 1 deletion src/cli/telemetry/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
export { resolveTelemetryPreference, resolveResourceAttributes } from './config.js';
export { resolveTelemetryPreference, resolveResourceAttributes, resolveAuditFilePath } from './config.js';
export type { TelemetryPreference } from './config.js';
export { TelemetryClientAccessor } from './client-accessor.js';
export { TelemetryClient, CANCELLED } from './client.js';
export { type MetricSink, CompositeSink } from './sinks/metric-sink.js';
export { OtelMetricSink, type OtelMetricSinkConfig } from './sinks/otel-metric-sink.js';
export { FileSystemSink, type FileSystemSinkConfig } from './sinks/filesystem-sink.js';
export { classifyError, isUserError } from './error-classification.js';
1 change: 1 addition & 0 deletions src/cli/telemetry/schemas/command-run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,6 +193,7 @@ export const COMMAND_SCHEMAS = {
package: NoAttrs,
validate: NoAttrs,
'help.modes': NoAttrs,
help: NoAttrs,
'remove.agent': NoAttrs,
'remove.memory': NoAttrs,
'remove.credential': NoAttrs,
Expand Down
48 changes: 48 additions & 0 deletions src/cli/telemetry/sinks/filesystem-sink.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
import type { MetricSink } from './metric-sink.js';
import { appendFile, mkdir } from 'fs/promises';
import { dirname } from 'path';

export interface FileSystemSinkConfig {
filePath: string;
resource?: Record<string, string | number>;
log?: (message: string) => void;
}

export class FileSystemSink implements MetricSink {
private readonly filePath: string;
private readonly resource: Record<string, string | number>;
private readonly log: (message: string) => void;
private hasRecords = false;

constructor(config: FileSystemSinkConfig) {
this.filePath = config.filePath;
this.resource = config.resource ?? {};
this.log = config.log ?? (msg => console.log(msg));
}

record(value: number, attrs: Record<string, string | number>): void {
this.hasRecords = true;
this.pendingWrite = this.pendingWrite.then(() =>
this.appendEntry({ value, attrs: { ...this.resource, ...attrs } })
);
}

async flush(): Promise<void> {
await this.pendingWrite;
}

async shutdown(): Promise<void> {
await this.pendingWrite;
if (this.hasRecords) {
this.log(`[audit mode] Telemetry written to ${this.filePath}`);
}
}

// Promise chain that serializes async writes so record() can stay synchronous.
private pendingWrite: Promise<void> = Promise.resolve();

private async appendEntry(entry: { value: number; attrs: Record<string, string | number> }): Promise<void> {
await mkdir(dirname(this.filePath), { recursive: true });
await appendFile(this.filePath, JSON.stringify(entry) + '\n');
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 62 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
import { spawnAndCollect } from '../src/test-utils/cli-runner.js';
import { runCLI } from '../src/test-utils/index.js';
import { describe, expect, it } from 'vitest';
import { readdirSync } from 'node:fs';
import { mkdir, readFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

const COMMANDS = [
'create',
Expand DownExpand Up@@ -38,3 +43,59 @@ describe('CLI help', () => {
}
});
});

describe('help modes telemetry', () => {
let testConfigDir: string;
const cliPath = join(__dirname, '..', 'dist', 'cli', 'index.mjs');

beforeAll(async () => {
testConfigDir = join(tmpdir(), `agentcore-help-telemetry-${Date.now()}`);
await mkdir(testConfigDir, { recursive: true });
});
afterAll(() => rm(testConfigDir, { recursive: true, force: true }));

function run(args: string[], extraEnv: Record<string, string> = {}) {
return spawnAndCollect('node', [cliPath, ...args], tmpdir(), {
AGENTCORE_SKIP_INSTALL: '1',
AGENTCORE_CONFIG_DIR: testConfigDir,
...extraEnv,
});
}

it('writes JSONL audit file when audit is enabled via env var', async () => {
const result = await run(['help', 'modes'], { AGENTCORE_TELEMETRY_AUDIT: '1' });
expect(result.exitCode).toBe(0);

const telemetryDir = join(testConfigDir, 'telemetry');
const files = readdirSync(telemetryDir).filter(f => f.startsWith('help-'));
expect(files).toHaveLength(1);

const content = await readFile(join(telemetryDir, files[0]!), 'utf-8');
const entry = JSON.parse(content.trim());
expect(entry.attrs).toMatchObject({
'service.name': 'agentcore-cli',
'agentcore-cli.mode': 'cli',
command_group: 'help',
command: 'help.modes',
exit_reason: 'success',
});
expect(entry.attrs['agentcore-cli.session_id']).toBeDefined();
expect(entry.attrs['os.type']).toBeDefined();
expect(entry.value).toBeGreaterThanOrEqual(0);
});

it('does not write audit file when audit is not enabled', async () => {
const telemetryDir = join(testConfigDir, 'telemetry');
await rm(telemetryDir, { recursive: true, force: true });

const result = await run(['help', 'modes']);
expect(result.exitCode).toBe(0);

try {
const files = readdirSync(telemetryDir);
expect(files).toHaveLength(0);
} catch {
// telemetry dir doesn't exist — correct
}
});
});
8 changes: 7 additions & 1 deletion src/cli/cli.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ import { registerValidate } from './commands/validate';
import { PACKAGE_VERSION } from './constants';
import { getOrCreateInstallationId } from './global-config';
import { ALL_PRIMITIVES } from './primitives';
import { TelemetryClientAccessor } from './telemetry';
import { App } from './tui/App';
import { LayoutProvider } from './tui/context';
import { COMMAND_DESCRIPTIONS } from './tui/copy';
Expand DownExpand Up@@ -222,7 +223,12 @@ export const main = async (argv: string[]) => {
printTelemetryNotice();
}

await program.parseAsync(argv);
TelemetryClientAccessor.init(args[0] ?? 'unknown');
try {
await program.parseAsync(argv);
} finally {
await TelemetryClientAccessor.shutdown();
}

// Telemetry notice already printed above; only run update check here.
await printPostCommandNotices(false, updateCheck);
Expand Down
19 changes: 14 additions & 5 deletions src/cli/commands/help/command.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { TelemetryClientAccessor } from '../../telemetry/client-accessor.js';
import type { Command } from '@commander-js/extra-typings';

const MODES_HELP = `
Expand DownExpand Up@@ -41,15 +42,23 @@ export const registerHelp = (program: Command) => {
const helpCmd = program
.command('help')
.description('Display help topics')
.action(() => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help', () => {
console.log('Available help topics: modes');
console.log('Run `agentcore help <topic>` for details.');
return {};
});
});

helpCmd
.command('modes')
.description('Explain interactive vs non-interactive modes')
.action(() => {
console.log(MODES_HELP);
.action(async () => {
const client = await TelemetryClientAccessor.get();
await client.withCommandRun('help.modes', () => {
console.log(MODES_HELP);
return {};
});
});
};
95 changes: 95 additions & 0 deletions src/cli/telemetry/__tests__/filesystem-sink.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
import { createTempConfig } from '../../__tests__/helpers/temp-config';
import { resolveAuditFilePath } from '../config';
import { FileSystemSink } from '../sinks/filesystem-sink';
import { readFile } from 'fs/promises';
import { join } from 'node:path';
import { afterAll, beforeEach, describe, expect, it } from 'vitest';

const tmp = createTempConfig('fs-sink');
const outputDir = join(tmp.configDir, 'telemetry');

function createSink(opts: { dir?: string; log?: (msg: string) => void } = {}) {
const filePath = join(opts.dir ?? outputDir, 'test-session.json');
return new FileSystemSink({ filePath, log: opts.log });
}

function readJsonl(path: string): Promise<unknown[]> {
return readFile(path, 'utf-8').then(data =>
data
.trim()
.split('\n')
.map(line => JSON.parse(line))
);
}

describe('FileSystemSink', () => {
beforeEach(() => tmp.setup());
afterAll(() => tmp.cleanup());

it('writes each record as a JSONL line on disk', async () => {
const sink = createSink();
sink.record(42, { command_group: 'deploy', command: 'deploy', exit_reason: 'success' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(1);
expect(entries[0]).toMatchObject({
value: 42,
attrs: { command_group: 'deploy', command: 'deploy', exit_reason: 'success' },
});
});

it('appends multiple records as separate lines', async () => {
const sink = createSink();
sink.record(10, { command_group: 'add', command: 'add.agent' });
sink.record(20, { command_group: 'add', command: 'add.memory' });
await sink.flush();

const entries = await readJsonl(join(outputDir, 'test-session.json'));
expect(entries).toHaveLength(2);
expect(entries[0]).toMatchObject({ value: 10 });
expect(entries[1]).toMatchObject({ value: 20 });
});

it('creates output directory if it does not exist', async () => {
const nested = join(tmp.testDir, 'deep', 'nested', 'telemetry');
const filePath = join(nested, 'test.json');
const sink = new FileSystemSink({ filePath });
sink.record(1, { command_group: 'status', command: 'status' });
await sink.flush();

const entries = await readJsonl(filePath);
expect(entries).toHaveLength(1);
});

it('flush is a no-op when no records exist', async () => {
const sink = createSink();
await expect(sink.flush()).resolves.toBeUndefined();
});

it('shutdown logs audit message when records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
sink.record(99, { command_group: 'invoke', command: 'invoke' });
await sink.shutdown();

expect(logged).toHaveLength(1);
expect(logged[0]).toContain('[audit mode]');
expect(logged[0]).toContain('test-session.json');
});

it('shutdown does not log when no records were written', async () => {
const logged: string[] = [];
const sink = createSink({ log: msg => logged.push(msg) });
await sink.shutdown();

expect(logged).toHaveLength(0);
});
});

describe('resolveAuditFilePath', () => {
it('joins outputDir, entrypoint, and sessionId into a JSON file path', () => {
const path = resolveAuditFilePath('/home/user/.agentcore/telemetry', 'deploy', 'abc-123');
expect(path).toBe('/home/user/.agentcore/telemetry/deploy-abc-123.json');
});
});
49 changes: 49 additions & 0 deletions src/cli/telemetry/client-accessor.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
import { GLOBAL_CONFIG_DIR, readGlobalConfig } from '../global-config.js';
import { TelemetryClient } from './client.js';
import { resolveAuditFilePath, resolveResourceAttributes } from './config.js';
import { FileSystemSink } from './sinks/filesystem-sink.js';
import { CompositeSink } from './sinks/metric-sink.js';
import { join } from 'path';

/**
* Manages a singleton TelemetryClient. Call init() at startup to configure,
* get() from command handlers to obtain the client, and shutdown() on exit.
* get() lazily initializes if init() was never called.
*/
export class TelemetryClientAccessor {
private static clientPromise: Promise<TelemetryClient> | undefined;

static init(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): void {
this.clientPromise = createClient(entrypoint, mode);
}

static get(): Promise<TelemetryClient> {
this.clientPromise ??= createClient('unknown');
return this.clientPromise;
}

static async shutdown(): Promise<void> {
if (this.clientPromise) {
const client = await this.clientPromise;
await client.shutdown();
}
}
}

async function createClient(entrypoint: string, mode: 'cli' | 'tui' = 'cli'): Promise<TelemetryClient> {
const [resource, config] = await Promise.all([resolveResourceAttributes(mode), readGlobalConfig()]);

const sinks = [];
const audit = process.env.AGENTCORE_TELEMETRY_AUDIT === '1' || config.telemetry?.audit === true;

if (audit) {
const filePath = resolveAuditFilePath(
join(GLOBAL_CONFIG_DIR, 'telemetry'),
entrypoint,
resource['agentcore-cli.session_id']
);
sinks.push(new FileSystemSink({ filePath, resource }));
}

return new TelemetryClient(new CompositeSink(sinks));
}
5 changes: 5 additions & 0 deletions src/cli/telemetry/config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import { getOrCreateInstallationId, readGlobalConfig } from '../global-config.js
import { type ResourceAttributes, ResourceAttributesSchema } from './schemas/common-attributes.js';
import { randomUUID } from 'crypto';
import os from 'os';
import { join } from 'path';

// ---------------------------------------------------------------------------
// Telemetry preference (opt-in / opt-out)
Expand DownExpand Up@@ -59,3 +60,7 @@ export async function resolveResourceAttributes(mode: 'cli' | 'tui'): Promise<Re
'node.version': process.version,
});
}

export function resolveAuditFilePath(outputDir: string, entrypoint: string, sessionId: string): string {
return join(outputDir, `${entrypoint}-${sessionId}.json`);
}
4 changes: 3 additions & 1 deletion src/cli/telemetry/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
export { resolveTelemetryPreference, resolveResourceAttributes } from './config.js';
export { resolveTelemetryPreference, resolveResourceAttributes, resolveAuditFilePath } from './config.js';
export type { TelemetryPreference } from './config.js';
export { TelemetryClientAccessor } from './client-accessor.js';
export { TelemetryClient, CANCELLED } from './client.js';
export { type MetricSink, CompositeSink } from './sinks/metric-sink.js';
export { OtelMetricSink, type OtelMetricSinkConfig } from './sinks/otel-metric-sink.js';
export { FileSystemSink, type FileSystemSinkConfig } from './sinks/filesystem-sink.js';
export { classifyError, isUserError } from './error-classification.js';
1 change: 1 addition & 0 deletions src/cli/telemetry/schemas/command-run.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,6 +193,7 @@ export const COMMAND_SCHEMAS = {
package: NoAttrs,
validate: NoAttrs,
'help.modes': NoAttrs,
help: NoAttrs,
'remove.agent': NoAttrs,
'remove.memory': NoAttrs,
'remove.credential': NoAttrs,
Expand Down
48 changes: 48 additions & 0 deletions src/cli/telemetry/sinks/filesystem-sink.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
import type { MetricSink } from './metric-sink.js';
import { appendFile, mkdir } from 'fs/promises';
import { dirname } from 'path';

export interface FileSystemSinkConfig {
filePath: string;
resource?: Record<string, string | number>;
log?: (message: string) => void;
}

export class FileSystemSink implements MetricSink {
private readonly filePath: string;
private readonly resource: Record<string, string | number>;
private readonly log: (message: string) => void;
private hasRecords = false;

constructor(config: FileSystemSinkConfig) {
this.filePath = config.filePath;
this.resource = config.resource ?? {};
this.log = config.log ?? (msg => console.log(msg));
}

record(value: number, attrs: Record<string, string | number>): void {
this.hasRecords = true;
this.pendingWrite = this.pendingWrite.then(() =>
this.appendEntry({ value, attrs: { ...this.resource, ...attrs } })
);
}

async flush(): Promise<void> {
await this.pendingWrite;
}

async shutdown(): Promise<void> {
await this.pendingWrite;
if (this.hasRecords) {
this.log(`[audit mode] Telemetry written to ${this.filePath}`);
}
}

// Promise chain that serializes async writes so record() can stay synchronous.
private pendingWrite: Promise<void> = Promise.resolve();

private async appendEntry(entry: { value: number; attrs: Record<string, string | number> }): Promise<void> {
await mkdir(dirname(this.filePath), { recursive: true });
await appendFile(this.filePath, JSON.stringify(entry) + '\n');
}
}
Loading