Skip to content

sync-preview: merge main into preview - #1017

Merged
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900
Apr 29, 2026
Merged

sync-preview: merge main into preview#1017
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The automated sync-preview workflow could not cleanly merge main into preview.

This PR contains the merge with conflict markers. To resolve:

  1. Check out this branch locally:
    gh pr checkout <this-pr-number>
  2. Search for conflict markers and resolve them:
    grep -rn '<<<<<<< HEAD'.
  3. Keep preview-specific values (package version, preview tests, etc.) — accept main's changes for everything else.
  4. Commit and push, then merge this PR.

This must be resolved before the next coordinated release.

cc @53349492+notgitika

Opened automatically by the sync-preview workflow.

github-actionsBotand others added 8 commits April 28, 2026 16:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: remove 44 render-only and framework-testing tests
Delete TUI component test files that only verify prop passthrough or
framework behavior (Ink rendering, setInterval lifecycle) without
testing any application logic:
- Cursor.test.tsx (5 tests): setInterval/clearInterval assertions
- Header.test.tsx (4 tests): title/subtitle string presence
- HelpText.test.tsx (2 tests): static string rendering
- AwsTargetConfigUI.test.tsx (7 tests): help text string lookups
- ConfirmReview.test.tsx (6 tests): field label rendering
- LogLink.test.tsx (4 tests): prop passthrough
- ScreenHeader.test.tsx (3 tests): prop passthrough
- FatalError.test.tsx (5 tests): prop passthrough
Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only
tests that verify real logic: border structure, responsive width
adaptation, keyboard exit handling, and exitEnabled guard.
Remove tautological expect(true).toBe(true) tests from
assets.snapshot.test.ts; use describe.skipIf for empty asset dirs.
Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps,
LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as
framework tests but they verify real conditional/interaction logic.
* fix: restore AwsTargetConfigUI tests — pure function, not render test
getAwsConfigHelpText is a switch over AwsConfigPhase that maps states
to help strings. The undefined return for loading/terminal phases is a
contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests
guard that fallback, not framework rendering behavior.
…#1011)
The import gateway command used NAME_REGEX which only allowed
underscores and max 48 chars, rejecting valid gateway names with
hyphens like "agentcore-gateway". Switch to GatewayNameSchema which
matches the actual AWS API: alphanumeric with hyphens, up to 100 chars.
Constraint: AWS CreateGateway API allows [0-9a-zA-Z] with hyphens
Rejected: Updating NAME_REGEX | it is shared with other import commands that have different naming rules
Confidence: high
Scope-risk: narrow
…y agentcore/ packages (#1015)
PR #844 correctly removed the flat name-based agentcore exclusion and
threaded rootDir through copySourceTree, but the same CONFIG_DIR check
remained in collectFiles/collectFilesSync (the zip stage). Since the zip
stage operates on the staging directory — not the project root — the
check incorrectly stripped any top-level agentcore/ Python package
installed by uv (e.g., langgraph_checkpoint_aws/agentcore/) from the
deployment artifact, causing ModuleNotFoundError at runtime.
The CONFIG_DIR exclusion is only needed in copySourceTree (which copies
from the project root into staging). By the time we zip, the project
config dir was already filtered out — the only agentcore/ in staging is
a legitimate dependency package.
Closes#843
* ci: add coordinated main + preview release workflow
Adds a single workflow_dispatch that releases both branches together,
ensuring they stay in sync on npm.
* fix: address review — bump script compat, pre-publish verification, drop unused artifacts
- Preview bump now uses `prerelease --prerelease-tag preview` which the
bump-version.ts script actually accepts
- Added verify-merges job that checks both main and preview have the
expected versions before either publish runs (prevents drift)
- Both publish jobs now depend on verify-merges instead of each other,
so neither publishes unless both PRs are confirmed merged
- Removed upload-artifact steps from test jobs since publish jobs
rebuild from source post-merge
* fix: auto-rebase preview onto main in preflight step
Instead of failing when preview isn't rebased, the workflow now
rebases automatically. If there are conflicts, it aborts and
directs the user to resolve manually.
* ci: add sync-preview workflow, simplify release preflight
- New sync-preview.yml: runs on every push to main, auto-rebases
preview onto main. Silently skips on conflicts (no failure).
- Release workflow preflight reverted to a simple check — relies
on sync-preview having already done the rebase.
* fix: use merge instead of rebase for preview sync
Rebase overwrites preview-specific values (package version, tests).
Merge preserves preview's divergent files and only conflicts when
both branches touch the same lines.
* fix: concurrency control, conflict notifications, CDK tag TODO
- Add concurrency group to sync-preview to prevent parallel race
- On merge conflict, auto-create a GitHub issue (deduplicated) instead
of silently skipping
- Add TODO comment for CDK preview dist-tag in prepare-preview
* fix: create PR with conflict markers instead of issue on merge conflict
On conflict, sync-preview now:
- Creates a branch with the merge conflict markers committed
- Opens a PR targeting preview with resolution instructions
- Tags the original commit author for visibility
- Deduplicates (skips if a sync PR is already open)
Keep preview-specific values (version 1.0.0-preview.3, resolveAgentOrHarness,
harness CloudWatch trace support, preview changelog entries). Accept main's
changes for everything else (as RouteContext in test).
@aidandaly24
aidandaly24 merged commit 1c726d8 into previewApr 29, 2026
@aidandaly24
aidandaly24 deleted the sync-preview/merge-main-20260429-155900 branch April 29, 2026 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avi-alpert@aidandaly24@tejaskash@jesseturner21@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
sync-preview: merge main into preview by github-actions[bot] · Pull Request #1017 · aws/agentcore-cli · GitHub
Skip to content

sync-preview: merge main into preview - #1017

Merged
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900
Apr 29, 2026
Merged

sync-preview: merge main into preview#1017
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The automated sync-preview workflow could not cleanly merge main into preview.

This PR contains the merge with conflict markers. To resolve:

  1. Check out this branch locally:
    gh pr checkout <this-pr-number>
  2. Search for conflict markers and resolve them:
    grep -rn '<<<<<<< HEAD'.
  3. Keep preview-specific values (package version, preview tests, etc.) — accept main's changes for everything else.
  4. Commit and push, then merge this PR.

This must be resolved before the next coordinated release.

cc @53349492+notgitika

Opened automatically by the sync-preview workflow.

github-actionsBotand others added 8 commits April 28, 2026 16:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: remove 44 render-only and framework-testing tests
Delete TUI component test files that only verify prop passthrough or
framework behavior (Ink rendering, setInterval lifecycle) without
testing any application logic:
- Cursor.test.tsx (5 tests): setInterval/clearInterval assertions
- Header.test.tsx (4 tests): title/subtitle string presence
- HelpText.test.tsx (2 tests): static string rendering
- AwsTargetConfigUI.test.tsx (7 tests): help text string lookups
- ConfirmReview.test.tsx (6 tests): field label rendering
- LogLink.test.tsx (4 tests): prop passthrough
- ScreenHeader.test.tsx (3 tests): prop passthrough
- FatalError.test.tsx (5 tests): prop passthrough
Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only
tests that verify real logic: border structure, responsive width
adaptation, keyboard exit handling, and exitEnabled guard.
Remove tautological expect(true).toBe(true) tests from
assets.snapshot.test.ts; use describe.skipIf for empty asset dirs.
Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps,
LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as
framework tests but they verify real conditional/interaction logic.
* fix: restore AwsTargetConfigUI tests — pure function, not render test
getAwsConfigHelpText is a switch over AwsConfigPhase that maps states
to help strings. The undefined return for loading/terminal phases is a
contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests
guard that fallback, not framework rendering behavior.
…#1011)
The import gateway command used NAME_REGEX which only allowed
underscores and max 48 chars, rejecting valid gateway names with
hyphens like "agentcore-gateway". Switch to GatewayNameSchema which
matches the actual AWS API: alphanumeric with hyphens, up to 100 chars.
Constraint: AWS CreateGateway API allows [0-9a-zA-Z] with hyphens
Rejected: Updating NAME_REGEX | it is shared with other import commands that have different naming rules
Confidence: high
Scope-risk: narrow
…y agentcore/ packages (#1015)
PR #844 correctly removed the flat name-based agentcore exclusion and
threaded rootDir through copySourceTree, but the same CONFIG_DIR check
remained in collectFiles/collectFilesSync (the zip stage). Since the zip
stage operates on the staging directory — not the project root — the
check incorrectly stripped any top-level agentcore/ Python package
installed by uv (e.g., langgraph_checkpoint_aws/agentcore/) from the
deployment artifact, causing ModuleNotFoundError at runtime.
The CONFIG_DIR exclusion is only needed in copySourceTree (which copies
from the project root into staging). By the time we zip, the project
config dir was already filtered out — the only agentcore/ in staging is
a legitimate dependency package.
Closes#843
* ci: add coordinated main + preview release workflow
Adds a single workflow_dispatch that releases both branches together,
ensuring they stay in sync on npm.
* fix: address review — bump script compat, pre-publish verification, drop unused artifacts
- Preview bump now uses `prerelease --prerelease-tag preview` which the
bump-version.ts script actually accepts
- Added verify-merges job that checks both main and preview have the
expected versions before either publish runs (prevents drift)
- Both publish jobs now depend on verify-merges instead of each other,
so neither publishes unless both PRs are confirmed merged
- Removed upload-artifact steps from test jobs since publish jobs
rebuild from source post-merge
* fix: auto-rebase preview onto main in preflight step
Instead of failing when preview isn't rebased, the workflow now
rebases automatically. If there are conflicts, it aborts and
directs the user to resolve manually.
* ci: add sync-preview workflow, simplify release preflight
- New sync-preview.yml: runs on every push to main, auto-rebases
preview onto main. Silently skips on conflicts (no failure).
- Release workflow preflight reverted to a simple check — relies
on sync-preview having already done the rebase.
* fix: use merge instead of rebase for preview sync
Rebase overwrites preview-specific values (package version, tests).
Merge preserves preview's divergent files and only conflicts when
both branches touch the same lines.
* fix: concurrency control, conflict notifications, CDK tag TODO
- Add concurrency group to sync-preview to prevent parallel race
- On merge conflict, auto-create a GitHub issue (deduplicated) instead
of silently skipping
- Add TODO comment for CDK preview dist-tag in prepare-preview
* fix: create PR with conflict markers instead of issue on merge conflict
On conflict, sync-preview now:
- Creates a branch with the merge conflict markers committed
- Opens a PR targeting preview with resolution instructions
- Tags the original commit author for visibility
- Deduplicates (skips if a sync PR is already open)
Keep preview-specific values (version 1.0.0-preview.3, resolveAgentOrHarness,
harness CloudWatch trace support, preview changelog entries). Accept main's
changes for everything else (as RouteContext in test).
@aidandaly24
aidandaly24 merged commit 1c726d8 into previewApr 29, 2026
@aidandaly24
aidandaly24 deleted the sync-preview/merge-main-20260429-155900 branch April 29, 2026 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avi-alpert@aidandaly24@tejaskash@jesseturner21@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' sync-preview: merge main into preview by github-actions[bot] · Pull Request #1017 · aws/agentcore-cli · GitHub
Skip to content

sync-preview: merge main into preview - #1017

Merged
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900
Apr 29, 2026
Merged

sync-preview: merge main into preview#1017
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The automated sync-preview workflow could not cleanly merge main into preview.

This PR contains the merge with conflict markers. To resolve:

  1. Check out this branch locally:
    gh pr checkout <this-pr-number>
  2. Search for conflict markers and resolve them:
    grep -rn '<<<<<<< HEAD'.
  3. Keep preview-specific values (package version, preview tests, etc.) — accept main's changes for everything else.
  4. Commit and push, then merge this PR.

This must be resolved before the next coordinated release.

cc @53349492+notgitika

Opened automatically by the sync-preview workflow.

github-actionsBotand others added 8 commits April 28, 2026 16:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: remove 44 render-only and framework-testing tests
Delete TUI component test files that only verify prop passthrough or
framework behavior (Ink rendering, setInterval lifecycle) without
testing any application logic:
- Cursor.test.tsx (5 tests): setInterval/clearInterval assertions
- Header.test.tsx (4 tests): title/subtitle string presence
- HelpText.test.tsx (2 tests): static string rendering
- AwsTargetConfigUI.test.tsx (7 tests): help text string lookups
- ConfirmReview.test.tsx (6 tests): field label rendering
- LogLink.test.tsx (4 tests): prop passthrough
- ScreenHeader.test.tsx (3 tests): prop passthrough
- FatalError.test.tsx (5 tests): prop passthrough
Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only
tests that verify real logic: border structure, responsive width
adaptation, keyboard exit handling, and exitEnabled guard.
Remove tautological expect(true).toBe(true) tests from
assets.snapshot.test.ts; use describe.skipIf for empty asset dirs.
Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps,
LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as
framework tests but they verify real conditional/interaction logic.
* fix: restore AwsTargetConfigUI tests — pure function, not render test
getAwsConfigHelpText is a switch over AwsConfigPhase that maps states
to help strings. The undefined return for loading/terminal phases is a
contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests
guard that fallback, not framework rendering behavior.
…#1011)
The import gateway command used NAME_REGEX which only allowed
underscores and max 48 chars, rejecting valid gateway names with
hyphens like "agentcore-gateway". Switch to GatewayNameSchema which
matches the actual AWS API: alphanumeric with hyphens, up to 100 chars.
Constraint: AWS CreateGateway API allows [0-9a-zA-Z] with hyphens
Rejected: Updating NAME_REGEX | it is shared with other import commands that have different naming rules
Confidence: high
Scope-risk: narrow
…y agentcore/ packages (#1015)
PR #844 correctly removed the flat name-based agentcore exclusion and
threaded rootDir through copySourceTree, but the same CONFIG_DIR check
remained in collectFiles/collectFilesSync (the zip stage). Since the zip
stage operates on the staging directory — not the project root — the
check incorrectly stripped any top-level agentcore/ Python package
installed by uv (e.g., langgraph_checkpoint_aws/agentcore/) from the
deployment artifact, causing ModuleNotFoundError at runtime.
The CONFIG_DIR exclusion is only needed in copySourceTree (which copies
from the project root into staging). By the time we zip, the project
config dir was already filtered out — the only agentcore/ in staging is
a legitimate dependency package.
Closes#843
* ci: add coordinated main + preview release workflow
Adds a single workflow_dispatch that releases both branches together,
ensuring they stay in sync on npm.
* fix: address review — bump script compat, pre-publish verification, drop unused artifacts
- Preview bump now uses `prerelease --prerelease-tag preview` which the
bump-version.ts script actually accepts
- Added verify-merges job that checks both main and preview have the
expected versions before either publish runs (prevents drift)
- Both publish jobs now depend on verify-merges instead of each other,
so neither publishes unless both PRs are confirmed merged
- Removed upload-artifact steps from test jobs since publish jobs
rebuild from source post-merge
* fix: auto-rebase preview onto main in preflight step
Instead of failing when preview isn't rebased, the workflow now
rebases automatically. If there are conflicts, it aborts and
directs the user to resolve manually.
* ci: add sync-preview workflow, simplify release preflight
- New sync-preview.yml: runs on every push to main, auto-rebases
preview onto main. Silently skips on conflicts (no failure).
- Release workflow preflight reverted to a simple check — relies
on sync-preview having already done the rebase.
* fix: use merge instead of rebase for preview sync
Rebase overwrites preview-specific values (package version, tests).
Merge preserves preview's divergent files and only conflicts when
both branches touch the same lines.
* fix: concurrency control, conflict notifications, CDK tag TODO
- Add concurrency group to sync-preview to prevent parallel race
- On merge conflict, auto-create a GitHub issue (deduplicated) instead
of silently skipping
- Add TODO comment for CDK preview dist-tag in prepare-preview
* fix: create PR with conflict markers instead of issue on merge conflict
On conflict, sync-preview now:
- Creates a branch with the merge conflict markers committed
- Opens a PR targeting preview with resolution instructions
- Tags the original commit author for visibility
- Deduplicates (skips if a sync PR is already open)
Keep preview-specific values (version 1.0.0-preview.3, resolveAgentOrHarness,
harness CloudWatch trace support, preview changelog entries). Accept main's
changes for everything else (as RouteContext in test).
@aidandaly24
aidandaly24 merged commit 1c726d8 into previewApr 29, 2026
@aidandaly24
aidandaly24 deleted the sync-preview/merge-main-20260429-155900 branch April 29, 2026 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avi-alpert@aidandaly24@tejaskash@jesseturner21@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' sync-preview: merge main into preview by github-actions[bot] · Pull Request #1017 · aws/agentcore-cli · GitHub
Skip to content

sync-preview: merge main into preview - #1017

Merged
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900
Apr 29, 2026
Merged

sync-preview: merge main into preview#1017
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The automated sync-preview workflow could not cleanly merge main into preview.

This PR contains the merge with conflict markers. To resolve:

  1. Check out this branch locally:
    gh pr checkout <this-pr-number>
  2. Search for conflict markers and resolve them:
    grep -rn '<<<<<<< HEAD'.
  3. Keep preview-specific values (package version, preview tests, etc.) — accept main's changes for everything else.
  4. Commit and push, then merge this PR.

This must be resolved before the next coordinated release.

cc @53349492+notgitika

Opened automatically by the sync-preview workflow.

github-actionsBotand others added 8 commits April 28, 2026 16:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: remove 44 render-only and framework-testing tests
Delete TUI component test files that only verify prop passthrough or
framework behavior (Ink rendering, setInterval lifecycle) without
testing any application logic:
- Cursor.test.tsx (5 tests): setInterval/clearInterval assertions
- Header.test.tsx (4 tests): title/subtitle string presence
- HelpText.test.tsx (2 tests): static string rendering
- AwsTargetConfigUI.test.tsx (7 tests): help text string lookups
- ConfirmReview.test.tsx (6 tests): field label rendering
- LogLink.test.tsx (4 tests): prop passthrough
- ScreenHeader.test.tsx (3 tests): prop passthrough
- FatalError.test.tsx (5 tests): prop passthrough
Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only
tests that verify real logic: border structure, responsive width
adaptation, keyboard exit handling, and exitEnabled guard.
Remove tautological expect(true).toBe(true) tests from
assets.snapshot.test.ts; use describe.skipIf for empty asset dirs.
Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps,
LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as
framework tests but they verify real conditional/interaction logic.
* fix: restore AwsTargetConfigUI tests — pure function, not render test
getAwsConfigHelpText is a switch over AwsConfigPhase that maps states
to help strings. The undefined return for loading/terminal phases is a
contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests
guard that fallback, not framework rendering behavior.
…#1011)
The import gateway command used NAME_REGEX which only allowed
underscores and max 48 chars, rejecting valid gateway names with
hyphens like "agentcore-gateway". Switch to GatewayNameSchema which
matches the actual AWS API: alphanumeric with hyphens, up to 100 chars.
Constraint: AWS CreateGateway API allows [0-9a-zA-Z] with hyphens
Rejected: Updating NAME_REGEX | it is shared with other import commands that have different naming rules
Confidence: high
Scope-risk: narrow
…y agentcore/ packages (#1015)
PR #844 correctly removed the flat name-based agentcore exclusion and
threaded rootDir through copySourceTree, but the same CONFIG_DIR check
remained in collectFiles/collectFilesSync (the zip stage). Since the zip
stage operates on the staging directory — not the project root — the
check incorrectly stripped any top-level agentcore/ Python package
installed by uv (e.g., langgraph_checkpoint_aws/agentcore/) from the
deployment artifact, causing ModuleNotFoundError at runtime.
The CONFIG_DIR exclusion is only needed in copySourceTree (which copies
from the project root into staging). By the time we zip, the project
config dir was already filtered out — the only agentcore/ in staging is
a legitimate dependency package.
Closes#843
* ci: add coordinated main + preview release workflow
Adds a single workflow_dispatch that releases both branches together,
ensuring they stay in sync on npm.
* fix: address review — bump script compat, pre-publish verification, drop unused artifacts
- Preview bump now uses `prerelease --prerelease-tag preview` which the
bump-version.ts script actually accepts
- Added verify-merges job that checks both main and preview have the
expected versions before either publish runs (prevents drift)
- Both publish jobs now depend on verify-merges instead of each other,
so neither publishes unless both PRs are confirmed merged
- Removed upload-artifact steps from test jobs since publish jobs
rebuild from source post-merge
* fix: auto-rebase preview onto main in preflight step
Instead of failing when preview isn't rebased, the workflow now
rebases automatically. If there are conflicts, it aborts and
directs the user to resolve manually.
* ci: add sync-preview workflow, simplify release preflight
- New sync-preview.yml: runs on every push to main, auto-rebases
preview onto main. Silently skips on conflicts (no failure).
- Release workflow preflight reverted to a simple check — relies
on sync-preview having already done the rebase.
* fix: use merge instead of rebase for preview sync
Rebase overwrites preview-specific values (package version, tests).
Merge preserves preview's divergent files and only conflicts when
both branches touch the same lines.
* fix: concurrency control, conflict notifications, CDK tag TODO
- Add concurrency group to sync-preview to prevent parallel race
- On merge conflict, auto-create a GitHub issue (deduplicated) instead
of silently skipping
- Add TODO comment for CDK preview dist-tag in prepare-preview
* fix: create PR with conflict markers instead of issue on merge conflict
On conflict, sync-preview now:
- Creates a branch with the merge conflict markers committed
- Opens a PR targeting preview with resolution instructions
- Tags the original commit author for visibility
- Deduplicates (skips if a sync PR is already open)
Keep preview-specific values (version 1.0.0-preview.3, resolveAgentOrHarness,
harness CloudWatch trace support, preview changelog entries). Accept main's
changes for everything else (as RouteContext in test).
@aidandaly24
aidandaly24 merged commit 1c726d8 into previewApr 29, 2026
@aidandaly24
aidandaly24 deleted the sync-preview/merge-main-20260429-155900 branch April 29, 2026 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avi-alpert@aidandaly24@tejaskash@jesseturner21@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' sync-preview: merge main into preview by github-actions[bot] · Pull Request #1017 · aws/agentcore-cli · GitHub
Skip to content

sync-preview: merge main into preview - #1017

Merged
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900
Apr 29, 2026
Merged

sync-preview: merge main into preview#1017
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The automated sync-preview workflow could not cleanly merge main into preview.

This PR contains the merge with conflict markers. To resolve:

  1. Check out this branch locally:
    gh pr checkout <this-pr-number>
  2. Search for conflict markers and resolve them:
    grep -rn '<<<<<<< HEAD'.
  3. Keep preview-specific values (package version, preview tests, etc.) — accept main's changes for everything else.
  4. Commit and push, then merge this PR.

This must be resolved before the next coordinated release.

cc @53349492+notgitika

Opened automatically by the sync-preview workflow.

github-actionsBotand others added 8 commits April 28, 2026 16:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: remove 44 render-only and framework-testing tests
Delete TUI component test files that only verify prop passthrough or
framework behavior (Ink rendering, setInterval lifecycle) without
testing any application logic:
- Cursor.test.tsx (5 tests): setInterval/clearInterval assertions
- Header.test.tsx (4 tests): title/subtitle string presence
- HelpText.test.tsx (2 tests): static string rendering
- AwsTargetConfigUI.test.tsx (7 tests): help text string lookups
- ConfirmReview.test.tsx (6 tests): field label rendering
- LogLink.test.tsx (4 tests): prop passthrough
- ScreenHeader.test.tsx (3 tests): prop passthrough
- FatalError.test.tsx (5 tests): prop passthrough
Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only
tests that verify real logic: border structure, responsive width
adaptation, keyboard exit handling, and exitEnabled guard.
Remove tautological expect(true).toBe(true) tests from
assets.snapshot.test.ts; use describe.skipIf for empty asset dirs.
Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps,
LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as
framework tests but they verify real conditional/interaction logic.
* fix: restore AwsTargetConfigUI tests — pure function, not render test
getAwsConfigHelpText is a switch over AwsConfigPhase that maps states
to help strings. The undefined return for loading/terminal phases is a
contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests
guard that fallback, not framework rendering behavior.
…#1011)
The import gateway command used NAME_REGEX which only allowed
underscores and max 48 chars, rejecting valid gateway names with
hyphens like "agentcore-gateway". Switch to GatewayNameSchema which
matches the actual AWS API: alphanumeric with hyphens, up to 100 chars.
Constraint: AWS CreateGateway API allows [0-9a-zA-Z] with hyphens
Rejected: Updating NAME_REGEX | it is shared with other import commands that have different naming rules
Confidence: high
Scope-risk: narrow
…y agentcore/ packages (#1015)
PR #844 correctly removed the flat name-based agentcore exclusion and
threaded rootDir through copySourceTree, but the same CONFIG_DIR check
remained in collectFiles/collectFilesSync (the zip stage). Since the zip
stage operates on the staging directory — not the project root — the
check incorrectly stripped any top-level agentcore/ Python package
installed by uv (e.g., langgraph_checkpoint_aws/agentcore/) from the
deployment artifact, causing ModuleNotFoundError at runtime.
The CONFIG_DIR exclusion is only needed in copySourceTree (which copies
from the project root into staging). By the time we zip, the project
config dir was already filtered out — the only agentcore/ in staging is
a legitimate dependency package.
Closes#843
* ci: add coordinated main + preview release workflow
Adds a single workflow_dispatch that releases both branches together,
ensuring they stay in sync on npm.
* fix: address review — bump script compat, pre-publish verification, drop unused artifacts
- Preview bump now uses `prerelease --prerelease-tag preview` which the
bump-version.ts script actually accepts
- Added verify-merges job that checks both main and preview have the
expected versions before either publish runs (prevents drift)
- Both publish jobs now depend on verify-merges instead of each other,
so neither publishes unless both PRs are confirmed merged
- Removed upload-artifact steps from test jobs since publish jobs
rebuild from source post-merge
* fix: auto-rebase preview onto main in preflight step
Instead of failing when preview isn't rebased, the workflow now
rebases automatically. If there are conflicts, it aborts and
directs the user to resolve manually.
* ci: add sync-preview workflow, simplify release preflight
- New sync-preview.yml: runs on every push to main, auto-rebases
preview onto main. Silently skips on conflicts (no failure).
- Release workflow preflight reverted to a simple check — relies
on sync-preview having already done the rebase.
* fix: use merge instead of rebase for preview sync
Rebase overwrites preview-specific values (package version, tests).
Merge preserves preview's divergent files and only conflicts when
both branches touch the same lines.
* fix: concurrency control, conflict notifications, CDK tag TODO
- Add concurrency group to sync-preview to prevent parallel race
- On merge conflict, auto-create a GitHub issue (deduplicated) instead
of silently skipping
- Add TODO comment for CDK preview dist-tag in prepare-preview
* fix: create PR with conflict markers instead of issue on merge conflict
On conflict, sync-preview now:
- Creates a branch with the merge conflict markers committed
- Opens a PR targeting preview with resolution instructions
- Tags the original commit author for visibility
- Deduplicates (skips if a sync PR is already open)
Keep preview-specific values (version 1.0.0-preview.3, resolveAgentOrHarness,
harness CloudWatch trace support, preview changelog entries). Accept main's
changes for everything else (as RouteContext in test).
@aidandaly24
aidandaly24 merged commit 1c726d8 into previewApr 29, 2026
@aidandaly24
aidandaly24 deleted the sync-preview/merge-main-20260429-155900 branch April 29, 2026 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avi-alpert@aidandaly24@tejaskash@jesseturner21@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' sync-preview: merge main into preview by github-actions[bot] · Pull Request #1017 · aws/agentcore-cli · GitHub
Skip to content

sync-preview: merge main into preview - #1017

Merged
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900
Apr 29, 2026
Merged

sync-preview: merge main into preview#1017
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The automated sync-preview workflow could not cleanly merge main into preview.

This PR contains the merge with conflict markers. To resolve:

  1. Check out this branch locally:
    gh pr checkout <this-pr-number>
  2. Search for conflict markers and resolve them:
    grep -rn '<<<<<<< HEAD'.
  3. Keep preview-specific values (package version, preview tests, etc.) — accept main's changes for everything else.
  4. Commit and push, then merge this PR.

This must be resolved before the next coordinated release.

cc @53349492+notgitika

Opened automatically by the sync-preview workflow.

github-actionsBotand others added 8 commits April 28, 2026 16:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: remove 44 render-only and framework-testing tests
Delete TUI component test files that only verify prop passthrough or
framework behavior (Ink rendering, setInterval lifecycle) without
testing any application logic:
- Cursor.test.tsx (5 tests): setInterval/clearInterval assertions
- Header.test.tsx (4 tests): title/subtitle string presence
- HelpText.test.tsx (2 tests): static string rendering
- AwsTargetConfigUI.test.tsx (7 tests): help text string lookups
- ConfirmReview.test.tsx (6 tests): field label rendering
- LogLink.test.tsx (4 tests): prop passthrough
- ScreenHeader.test.tsx (3 tests): prop passthrough
- FatalError.test.tsx (5 tests): prop passthrough
Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only
tests that verify real logic: border structure, responsive width
adaptation, keyboard exit handling, and exitEnabled guard.
Remove tautological expect(true).toBe(true) tests from
assets.snapshot.test.ts; use describe.skipIf for empty asset dirs.
Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps,
LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as
framework tests but they verify real conditional/interaction logic.
* fix: restore AwsTargetConfigUI tests — pure function, not render test
getAwsConfigHelpText is a switch over AwsConfigPhase that maps states
to help strings. The undefined return for loading/terminal phases is a
contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests
guard that fallback, not framework rendering behavior.
…#1011)
The import gateway command used NAME_REGEX which only allowed
underscores and max 48 chars, rejecting valid gateway names with
hyphens like "agentcore-gateway". Switch to GatewayNameSchema which
matches the actual AWS API: alphanumeric with hyphens, up to 100 chars.
Constraint: AWS CreateGateway API allows [0-9a-zA-Z] with hyphens
Rejected: Updating NAME_REGEX | it is shared with other import commands that have different naming rules
Confidence: high
Scope-risk: narrow
…y agentcore/ packages (#1015)
PR #844 correctly removed the flat name-based agentcore exclusion and
threaded rootDir through copySourceTree, but the same CONFIG_DIR check
remained in collectFiles/collectFilesSync (the zip stage). Since the zip
stage operates on the staging directory — not the project root — the
check incorrectly stripped any top-level agentcore/ Python package
installed by uv (e.g., langgraph_checkpoint_aws/agentcore/) from the
deployment artifact, causing ModuleNotFoundError at runtime.
The CONFIG_DIR exclusion is only needed in copySourceTree (which copies
from the project root into staging). By the time we zip, the project
config dir was already filtered out — the only agentcore/ in staging is
a legitimate dependency package.
Closes#843
* ci: add coordinated main + preview release workflow
Adds a single workflow_dispatch that releases both branches together,
ensuring they stay in sync on npm.
* fix: address review — bump script compat, pre-publish verification, drop unused artifacts
- Preview bump now uses `prerelease --prerelease-tag preview` which the
bump-version.ts script actually accepts
- Added verify-merges job that checks both main and preview have the
expected versions before either publish runs (prevents drift)
- Both publish jobs now depend on verify-merges instead of each other,
so neither publishes unless both PRs are confirmed merged
- Removed upload-artifact steps from test jobs since publish jobs
rebuild from source post-merge
* fix: auto-rebase preview onto main in preflight step
Instead of failing when preview isn't rebased, the workflow now
rebases automatically. If there are conflicts, it aborts and
directs the user to resolve manually.
* ci: add sync-preview workflow, simplify release preflight
- New sync-preview.yml: runs on every push to main, auto-rebases
preview onto main. Silently skips on conflicts (no failure).
- Release workflow preflight reverted to a simple check — relies
on sync-preview having already done the rebase.
* fix: use merge instead of rebase for preview sync
Rebase overwrites preview-specific values (package version, tests).
Merge preserves preview's divergent files and only conflicts when
both branches touch the same lines.
* fix: concurrency control, conflict notifications, CDK tag TODO
- Add concurrency group to sync-preview to prevent parallel race
- On merge conflict, auto-create a GitHub issue (deduplicated) instead
of silently skipping
- Add TODO comment for CDK preview dist-tag in prepare-preview
* fix: create PR with conflict markers instead of issue on merge conflict
On conflict, sync-preview now:
- Creates a branch with the merge conflict markers committed
- Opens a PR targeting preview with resolution instructions
- Tags the original commit author for visibility
- Deduplicates (skips if a sync PR is already open)
Keep preview-specific values (version 1.0.0-preview.3, resolveAgentOrHarness,
harness CloudWatch trace support, preview changelog entries). Accept main's
changes for everything else (as RouteContext in test).
@aidandaly24
aidandaly24 merged commit 1c726d8 into previewApr 29, 2026
@aidandaly24
aidandaly24 deleted the sync-preview/merge-main-20260429-155900 branch April 29, 2026 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avi-alpert@aidandaly24@tejaskash@jesseturner21@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' sync-preview: merge main into preview by github-actions[bot] · Pull Request #1017 · aws/agentcore-cli · GitHub
Skip to content

sync-preview: merge main into preview - #1017

Merged
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900
Apr 29, 2026
Merged

sync-preview: merge main into preview#1017
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The automated sync-preview workflow could not cleanly merge main into preview.

This PR contains the merge with conflict markers. To resolve:

  1. Check out this branch locally:
    gh pr checkout <this-pr-number>
  2. Search for conflict markers and resolve them:
    grep -rn '<<<<<<< HEAD'.
  3. Keep preview-specific values (package version, preview tests, etc.) — accept main's changes for everything else.
  4. Commit and push, then merge this PR.

This must be resolved before the next coordinated release.

cc @53349492+notgitika

Opened automatically by the sync-preview workflow.

github-actionsBotand others added 8 commits April 28, 2026 16:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: remove 44 render-only and framework-testing tests
Delete TUI component test files that only verify prop passthrough or
framework behavior (Ink rendering, setInterval lifecycle) without
testing any application logic:
- Cursor.test.tsx (5 tests): setInterval/clearInterval assertions
- Header.test.tsx (4 tests): title/subtitle string presence
- HelpText.test.tsx (2 tests): static string rendering
- AwsTargetConfigUI.test.tsx (7 tests): help text string lookups
- ConfirmReview.test.tsx (6 tests): field label rendering
- LogLink.test.tsx (4 tests): prop passthrough
- ScreenHeader.test.tsx (3 tests): prop passthrough
- FatalError.test.tsx (5 tests): prop passthrough
Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only
tests that verify real logic: border structure, responsive width
adaptation, keyboard exit handling, and exitEnabled guard.
Remove tautological expect(true).toBe(true) tests from
assets.snapshot.test.ts; use describe.skipIf for empty asset dirs.
Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps,
LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as
framework tests but they verify real conditional/interaction logic.
* fix: restore AwsTargetConfigUI tests — pure function, not render test
getAwsConfigHelpText is a switch over AwsConfigPhase that maps states
to help strings. The undefined return for loading/terminal phases is a
contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests
guard that fallback, not framework rendering behavior.
…#1011)
The import gateway command used NAME_REGEX which only allowed
underscores and max 48 chars, rejecting valid gateway names with
hyphens like "agentcore-gateway". Switch to GatewayNameSchema which
matches the actual AWS API: alphanumeric with hyphens, up to 100 chars.
Constraint: AWS CreateGateway API allows [0-9a-zA-Z] with hyphens
Rejected: Updating NAME_REGEX | it is shared with other import commands that have different naming rules
Confidence: high
Scope-risk: narrow
…y agentcore/ packages (#1015)
PR #844 correctly removed the flat name-based agentcore exclusion and
threaded rootDir through copySourceTree, but the same CONFIG_DIR check
remained in collectFiles/collectFilesSync (the zip stage). Since the zip
stage operates on the staging directory — not the project root — the
check incorrectly stripped any top-level agentcore/ Python package
installed by uv (e.g., langgraph_checkpoint_aws/agentcore/) from the
deployment artifact, causing ModuleNotFoundError at runtime.
The CONFIG_DIR exclusion is only needed in copySourceTree (which copies
from the project root into staging). By the time we zip, the project
config dir was already filtered out — the only agentcore/ in staging is
a legitimate dependency package.
Closes#843
* ci: add coordinated main + preview release workflow
Adds a single workflow_dispatch that releases both branches together,
ensuring they stay in sync on npm.
* fix: address review — bump script compat, pre-publish verification, drop unused artifacts
- Preview bump now uses `prerelease --prerelease-tag preview` which the
bump-version.ts script actually accepts
- Added verify-merges job that checks both main and preview have the
expected versions before either publish runs (prevents drift)
- Both publish jobs now depend on verify-merges instead of each other,
so neither publishes unless both PRs are confirmed merged
- Removed upload-artifact steps from test jobs since publish jobs
rebuild from source post-merge
* fix: auto-rebase preview onto main in preflight step
Instead of failing when preview isn't rebased, the workflow now
rebases automatically. If there are conflicts, it aborts and
directs the user to resolve manually.
* ci: add sync-preview workflow, simplify release preflight
- New sync-preview.yml: runs on every push to main, auto-rebases
preview onto main. Silently skips on conflicts (no failure).
- Release workflow preflight reverted to a simple check — relies
on sync-preview having already done the rebase.
* fix: use merge instead of rebase for preview sync
Rebase overwrites preview-specific values (package version, tests).
Merge preserves preview's divergent files and only conflicts when
both branches touch the same lines.
* fix: concurrency control, conflict notifications, CDK tag TODO
- Add concurrency group to sync-preview to prevent parallel race
- On merge conflict, auto-create a GitHub issue (deduplicated) instead
of silently skipping
- Add TODO comment for CDK preview dist-tag in prepare-preview
* fix: create PR with conflict markers instead of issue on merge conflict
On conflict, sync-preview now:
- Creates a branch with the merge conflict markers committed
- Opens a PR targeting preview with resolution instructions
- Tags the original commit author for visibility
- Deduplicates (skips if a sync PR is already open)
Keep preview-specific values (version 1.0.0-preview.3, resolveAgentOrHarness,
harness CloudWatch trace support, preview changelog entries). Accept main's
changes for everything else (as RouteContext in test).
@aidandaly24
aidandaly24 merged commit 1c726d8 into previewApr 29, 2026
@aidandaly24
aidandaly24 deleted the sync-preview/merge-main-20260429-155900 branch April 29, 2026 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avi-alpert@aidandaly24@tejaskash@jesseturner21@notgitika
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); sync-preview: merge main into preview by github-actions[bot] · Pull Request #1017 · aws/agentcore-cli · GitHub
Skip to content

sync-preview: merge main into preview - #1017

Merged
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900
Apr 29, 2026
Merged

sync-preview: merge main into preview#1017
aidandaly24 merged 8 commits into
previewfrom
sync-preview/merge-main-20260429-155900

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

The automated sync-preview workflow could not cleanly merge main into preview.

This PR contains the merge with conflict markers. To resolve:

  1. Check out this branch locally:
    gh pr checkout <this-pr-number>
  2. Search for conflict markers and resolve them:
    grep -rn '<<<<<<< HEAD'.
  3. Keep preview-specific values (package version, preview tests, etc.) — accept main's changes for everything else.
  4. Commit and push, then merge this PR.

This must be resolved before the next coordinated release.

cc @53349492+notgitika

Opened automatically by the sync-preview workflow.

github-actionsBotand others added 8 commits April 28, 2026 16:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* test: remove 44 render-only and framework-testing tests
Delete TUI component test files that only verify prop passthrough or
framework behavior (Ink rendering, setInterval lifecycle) without
testing any application logic:
- Cursor.test.tsx (5 tests): setInterval/clearInterval assertions
- Header.test.tsx (4 tests): title/subtitle string presence
- HelpText.test.tsx (2 tests): static string rendering
- AwsTargetConfigUI.test.tsx (7 tests): help text string lookups
- ConfirmReview.test.tsx (6 tests): field label rendering
- LogLink.test.tsx (4 tests): prop passthrough
- ScreenHeader.test.tsx (3 tests): prop passthrough
- FatalError.test.tsx (5 tests): prop passthrough
Trim Panel.test.tsx (6→3) and Screen.test.tsx (8→3), keeping only
tests that verify real logic: border structure, responsive width
adaptation, keyboard exit handling, and exitEnabled guard.
Remove tautological expect(true).toBe(true) tests from
assets.snapshot.test.ts; use describe.skipIf for empty asset dirs.
Kept all tests in StepIndicator, ScreenLayout, TwoColumn, NextSteps,
LogPanel, PathInput, and useFetchAccessFlow — audit flagged some as
framework tests but they verify real conditional/interaction logic.
* fix: restore AwsTargetConfigUI tests — pure function, not render test
getAwsConfigHelpText is a switch over AwsConfigPhase that maps states
to help strings. The undefined return for loading/terminal phases is a
contract consumed by DeployScreen.tsx via ?? HELP_TEXT.EXIT. These tests
guard that fallback, not framework rendering behavior.
…#1011)
The import gateway command used NAME_REGEX which only allowed
underscores and max 48 chars, rejecting valid gateway names with
hyphens like "agentcore-gateway". Switch to GatewayNameSchema which
matches the actual AWS API: alphanumeric with hyphens, up to 100 chars.
Constraint: AWS CreateGateway API allows [0-9a-zA-Z] with hyphens
Rejected: Updating NAME_REGEX | it is shared with other import commands that have different naming rules
Confidence: high
Scope-risk: narrow
…y agentcore/ packages (#1015)
PR #844 correctly removed the flat name-based agentcore exclusion and
threaded rootDir through copySourceTree, but the same CONFIG_DIR check
remained in collectFiles/collectFilesSync (the zip stage). Since the zip
stage operates on the staging directory — not the project root — the
check incorrectly stripped any top-level agentcore/ Python package
installed by uv (e.g., langgraph_checkpoint_aws/agentcore/) from the
deployment artifact, causing ModuleNotFoundError at runtime.
The CONFIG_DIR exclusion is only needed in copySourceTree (which copies
from the project root into staging). By the time we zip, the project
config dir was already filtered out — the only agentcore/ in staging is
a legitimate dependency package.
Closes#843
* ci: add coordinated main + preview release workflow
Adds a single workflow_dispatch that releases both branches together,
ensuring they stay in sync on npm.
* fix: address review — bump script compat, pre-publish verification, drop unused artifacts
- Preview bump now uses `prerelease --prerelease-tag preview` which the
bump-version.ts script actually accepts
- Added verify-merges job that checks both main and preview have the
expected versions before either publish runs (prevents drift)
- Both publish jobs now depend on verify-merges instead of each other,
so neither publishes unless both PRs are confirmed merged
- Removed upload-artifact steps from test jobs since publish jobs
rebuild from source post-merge
* fix: auto-rebase preview onto main in preflight step
Instead of failing when preview isn't rebased, the workflow now
rebases automatically. If there are conflicts, it aborts and
directs the user to resolve manually.
* ci: add sync-preview workflow, simplify release preflight
- New sync-preview.yml: runs on every push to main, auto-rebases
preview onto main. Silently skips on conflicts (no failure).
- Release workflow preflight reverted to a simple check — relies
on sync-preview having already done the rebase.
* fix: use merge instead of rebase for preview sync
Rebase overwrites preview-specific values (package version, tests).
Merge preserves preview's divergent files and only conflicts when
both branches touch the same lines.
* fix: concurrency control, conflict notifications, CDK tag TODO
- Add concurrency group to sync-preview to prevent parallel race
- On merge conflict, auto-create a GitHub issue (deduplicated) instead
of silently skipping
- Add TODO comment for CDK preview dist-tag in prepare-preview
* fix: create PR with conflict markers instead of issue on merge conflict
On conflict, sync-preview now:
- Creates a branch with the merge conflict markers committed
- Opens a PR targeting preview with resolution instructions
- Tags the original commit author for visibility
- Deduplicates (skips if a sync PR is already open)
Keep preview-specific values (version 1.0.0-preview.3, resolveAgentOrHarness,
harness CloudWatch trace support, preview changelog entries). Accept main's
changes for everything else (as RouteContext in test).
@aidandaly24
aidandaly24 merged commit 1c726d8 into previewApr 29, 2026
@aidandaly24
aidandaly24 deleted the sync-preview/merge-main-20260429-155900 branch April 29, 2026 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avi-alpert@aidandaly24@tejaskash@jesseturner21@notgitika