fix: make configBundles, abTests, httpGateways optional in schema by notgitika · Pull Request #1073 · aws/agentcore-cli

notgitika · 2026-04-30T23:44:53Z

Summary

Change configBundles, abTests, and httpGateways from .default([]) to .optional() in the AgentCoreProjectSpec schema. This prevents empty preview-feature arrays from appearing in agentcore.json for users who haven't opted into those features.

All access sites updated with ?? [] for iteration or ??= for initialization before .push().

Test plan

npm run typecheck passes (zero errors)
Pre-commit hooks pass (eslint, prettier, secretlint)
agentcore create does not write configBundles/abTests/httpGateways to agentcore.json
agentcore add config-bundle writes configBundles to agentcore.json
Existing projects with these fields still work

…a fields - Preflight: remove config bundle type patching entirely — the CDK schema does not have a type field, so the patch was dead code - Teardown: delegate to deleteOrphanedABTests and deleteOrphanedHttpGateways instead of raw API calls — reuses stop/poll/delete/role-cleanup logic. Correct ordering: AB tests first (they create rules on gateways), then gateways, then config bundles. - Schema: change configBundles, abTests, httpGateways from .default([]) to .optional() so they don't appear in agentcore.json unless the user opts into those preview features. All access sites updated with ?? [] or ??= guards. Closes#1070

github-actions · 2026-04-30T23:48:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.9%	8938 / 20832
🔵	Statements	42.16%	9484 / 22490
🔵	Functions	39.71%	1540 / 3878
🔵	Branches	39.84%	5772 / 14486

Generated in workflow #2255 for commit fb9622c by the Vitest Coverage Report Action

agentcore-cli-automation · 2026-04-30T23:48:44Z

The stated goal of this PR — "agentcore create does not write configBundles/abTests/httpGateways to agentcore.json" — is not actually achieved by the current changes. The schema was updated to make these fields optional, but several places that produce a fresh project spec still hardcode them as empty arrays, so they will continue to appear in agentcore.json for newly-created projects:

src/cli/project.ts — createDefaultProjectSpec() (lines 21–23) returns configBundles: [], abTests: [], httpGateways: []. This is the spec used by agentcore create (both the TUI flow in useCreateFlow.ts and the non-interactive command in commands/create/action.ts), and also by the remove flow in useRemoveFlow.ts when resetting a project.
src/cli/operations/agent/generate/write-agent-to-project.ts (lines 75–77) — the "create new project" branch of writeAgentToProject also hardcodes these empty arrays.

Since writeProjectSpec runs the data through safeParse and then JSON.stringify, any [] present in the input object is preserved on write — optional-in-schema only strips a field when it is undefined, not when it is []. Result: agentcore create will still write these fields.

To actually achieve the PR goal, drop these three keys from both createDefaultProjectSpec and the new-project branch in write-agent-to-project.ts (or explicitly set them to undefined — but omitting them is cleaner).

It would also be worth adding a test that asserts agentcore.json after agentcore create does not contain these keys, since the unchecked item in the PR's test plan ("agentcore create does not write configBundles/abTests/httpGateways to agentcore.json") is exactly the regression this PR is supposed to prevent.

… write (#1074) The .optional() change from #1073 breaks Zod JSON Schema generation ("Undefined cannot be represented in JSON Schema"). Revert to .default([]) so schema generation and parsing work, but strip empty configBundles/abTests/httpGateways in writeProjectSpec before writing to disk so preview features don't pollute agentcore.json.

notgitika · 2026-04-30T23:44:53Z

Summary

Change configBundles, abTests, and httpGateways from .default([]) to .optional() in the AgentCoreProjectSpec schema. This prevents empty preview-feature arrays from appearing in agentcore.json for users who haven't opted into those features.

All access sites updated with ?? [] for iteration or ??= for initialization before .push().

Test plan

npm run typecheck passes (zero errors)
Pre-commit hooks pass (eslint, prettier, secretlint)
agentcore create does not write configBundles/abTests/httpGateways to agentcore.json
agentcore add config-bundle writes configBundles to agentcore.json
Existing projects with these fields still work

…a fields - Preflight: remove config bundle type patching entirely — the CDK schema does not have a type field, so the patch was dead code - Teardown: delegate to deleteOrphanedABTests and deleteOrphanedHttpGateways instead of raw API calls — reuses stop/poll/delete/role-cleanup logic. Correct ordering: AB tests first (they create rules on gateways), then gateways, then config bundles. - Schema: change configBundles, abTests, httpGateways from .default([]) to .optional() so they don't appear in agentcore.json unless the user opts into those preview features. All access sites updated with ?? [] or ??= guards. Closes#1070

github-actions · 2026-04-30T23:48:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.9%	8938 / 20832
🔵	Statements	42.16%	9484 / 22490
🔵	Functions	39.71%	1540 / 3878
🔵	Branches	39.84%	5772 / 14486

Generated in workflow #2255 for commit fb9622c by the Vitest Coverage Report Action

agentcore-cli-automation · 2026-04-30T23:48:44Z

The stated goal of this PR — "agentcore create does not write configBundles/abTests/httpGateways to agentcore.json" — is not actually achieved by the current changes. The schema was updated to make these fields optional, but several places that produce a fresh project spec still hardcode them as empty arrays, so they will continue to appear in agentcore.json for newly-created projects:

src/cli/project.ts — createDefaultProjectSpec() (lines 21–23) returns configBundles: [], abTests: [], httpGateways: []. This is the spec used by agentcore create (both the TUI flow in useCreateFlow.ts and the non-interactive command in commands/create/action.ts), and also by the remove flow in useRemoveFlow.ts when resetting a project.
src/cli/operations/agent/generate/write-agent-to-project.ts (lines 75–77) — the "create new project" branch of writeAgentToProject also hardcodes these empty arrays.

Since writeProjectSpec runs the data through safeParse and then JSON.stringify, any [] present in the input object is preserved on write — optional-in-schema only strips a field when it is undefined, not when it is []. Result: agentcore create will still write these fields.

To actually achieve the PR goal, drop these three keys from both createDefaultProjectSpec and the new-project branch in write-agent-to-project.ts (or explicitly set them to undefined — but omitting them is cleaner).

It would also be worth adding a test that asserts agentcore.json after agentcore create does not contain these keys, since the unchecked item in the PR's test plan ("agentcore create does not write configBundles/abTests/httpGateways to agentcore.json") is exactly the regression this PR is supposed to prevent.

… write (#1074) The .optional() change from #1073 breaks Zod JSON Schema generation ("Undefined cannot be represented in JSON Schema"). Revert to .default([]) so schema generation and parsing work, but strip empty configBundles/abTests/httpGateways in writeProjectSpec before writing to disk so preview features don't pollute agentcore.json.

notgitika · 2026-04-30T23:44:53Z

Summary

Change configBundles, abTests, and httpGateways from .default([]) to .optional() in the AgentCoreProjectSpec schema. This prevents empty preview-feature arrays from appearing in agentcore.json for users who haven't opted into those features.

All access sites updated with ?? [] for iteration or ??= for initialization before .push().

Test plan

npm run typecheck passes (zero errors)
Pre-commit hooks pass (eslint, prettier, secretlint)
agentcore create does not write configBundles/abTests/httpGateways to agentcore.json
agentcore add config-bundle writes configBundles to agentcore.json
Existing projects with these fields still work

…a fields - Preflight: remove config bundle type patching entirely — the CDK schema does not have a type field, so the patch was dead code - Teardown: delegate to deleteOrphanedABTests and deleteOrphanedHttpGateways instead of raw API calls — reuses stop/poll/delete/role-cleanup logic. Correct ordering: AB tests first (they create rules on gateways), then gateways, then config bundles. - Schema: change configBundles, abTests, httpGateways from .default([]) to .optional() so they don't appear in agentcore.json unless the user opts into those preview features. All access sites updated with ?? [] or ??= guards. Closes#1070

github-actions · 2026-04-30T23:48:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.9%	8938 / 20832
🔵	Statements	42.16%	9484 / 22490
🔵	Functions	39.71%	1540 / 3878
🔵	Branches	39.84%	5772 / 14486

Generated in workflow #2255 for commit fb9622c by the Vitest Coverage Report Action

agentcore-cli-automation · 2026-04-30T23:48:44Z

The stated goal of this PR — "agentcore create does not write configBundles/abTests/httpGateways to agentcore.json" — is not actually achieved by the current changes. The schema was updated to make these fields optional, but several places that produce a fresh project spec still hardcode them as empty arrays, so they will continue to appear in agentcore.json for newly-created projects:

src/cli/project.ts — createDefaultProjectSpec() (lines 21–23) returns configBundles: [], abTests: [], httpGateways: []. This is the spec used by agentcore create (both the TUI flow in useCreateFlow.ts and the non-interactive command in commands/create/action.ts), and also by the remove flow in useRemoveFlow.ts when resetting a project.
src/cli/operations/agent/generate/write-agent-to-project.ts (lines 75–77) — the "create new project" branch of writeAgentToProject also hardcodes these empty arrays.

Since writeProjectSpec runs the data through safeParse and then JSON.stringify, any [] present in the input object is preserved on write — optional-in-schema only strips a field when it is undefined, not when it is []. Result: agentcore create will still write these fields.

To actually achieve the PR goal, drop these three keys from both createDefaultProjectSpec and the new-project branch in write-agent-to-project.ts (or explicitly set them to undefined — but omitting them is cleaner).

It would also be worth adding a test that asserts agentcore.json after agentcore create does not contain these keys, since the unchecked item in the PR's test plan ("agentcore create does not write configBundles/abTests/httpGateways to agentcore.json") is exactly the regression this PR is supposed to prevent.

… write (#1074) The .optional() change from #1073 breaks Zod JSON Schema generation ("Undefined cannot be represented in JSON Schema"). Revert to .default([]) so schema generation and parsing work, but strip empty configBundles/abTests/httpGateways in writeProjectSpec before writing to disk so preview features don't pollute agentcore.json.

notgitika · 2026-04-30T23:44:53Z

Summary

Change configBundles, abTests, and httpGateways from .default([]) to .optional() in the AgentCoreProjectSpec schema. This prevents empty preview-feature arrays from appearing in agentcore.json for users who haven't opted into those features.

All access sites updated with ?? [] for iteration or ??= for initialization before .push().

Test plan

npm run typecheck passes (zero errors)
Pre-commit hooks pass (eslint, prettier, secretlint)
agentcore create does not write configBundles/abTests/httpGateways to agentcore.json
agentcore add config-bundle writes configBundles to agentcore.json
Existing projects with these fields still work

…a fields - Preflight: remove config bundle type patching entirely — the CDK schema does not have a type field, so the patch was dead code - Teardown: delegate to deleteOrphanedABTests and deleteOrphanedHttpGateways instead of raw API calls — reuses stop/poll/delete/role-cleanup logic. Correct ordering: AB tests first (they create rules on gateways), then gateways, then config bundles. - Schema: change configBundles, abTests, httpGateways from .default([]) to .optional() so they don't appear in agentcore.json unless the user opts into those preview features. All access sites updated with ?? [] or ??= guards. Closes#1070

github-actions · 2026-04-30T23:48:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.9%	8938 / 20832
🔵	Statements	42.16%	9484 / 22490
🔵	Functions	39.71%	1540 / 3878
🔵	Branches	39.84%	5772 / 14486

Generated in workflow #2255 for commit fb9622c by the Vitest Coverage Report Action

agentcore-cli-automation · 2026-04-30T23:48:44Z

The stated goal of this PR — "agentcore create does not write configBundles/abTests/httpGateways to agentcore.json" — is not actually achieved by the current changes. The schema was updated to make these fields optional, but several places that produce a fresh project spec still hardcode them as empty arrays, so they will continue to appear in agentcore.json for newly-created projects:

src/cli/project.ts — createDefaultProjectSpec() (lines 21–23) returns configBundles: [], abTests: [], httpGateways: []. This is the spec used by agentcore create (both the TUI flow in useCreateFlow.ts and the non-interactive command in commands/create/action.ts), and also by the remove flow in useRemoveFlow.ts when resetting a project.
src/cli/operations/agent/generate/write-agent-to-project.ts (lines 75–77) — the "create new project" branch of writeAgentToProject also hardcodes these empty arrays.

Since writeProjectSpec runs the data through safeParse and then JSON.stringify, any [] present in the input object is preserved on write — optional-in-schema only strips a field when it is undefined, not when it is []. Result: agentcore create will still write these fields.

To actually achieve the PR goal, drop these three keys from both createDefaultProjectSpec and the new-project branch in write-agent-to-project.ts (or explicitly set them to undefined — but omitting them is cleaner).

It would also be worth adding a test that asserts agentcore.json after agentcore create does not contain these keys, since the unchecked item in the PR's test plan ("agentcore create does not write configBundles/abTests/httpGateways to agentcore.json") is exactly the regression this PR is supposed to prevent.

… write (#1074) The .optional() change from #1073 breaks Zod JSON Schema generation ("Undefined cannot be represented in JSON Schema"). Revert to .default([]) so schema generation and parsing work, but strip empty configBundles/abTests/httpGateways in writeProjectSpec before writing to disk so preview features don't pollute agentcore.json.

notgitika · 2026-04-30T23:44:53Z

Summary

Change configBundles, abTests, and httpGateways from .default([]) to .optional() in the AgentCoreProjectSpec schema. This prevents empty preview-feature arrays from appearing in agentcore.json for users who haven't opted into those features.

All access sites updated with ?? [] for iteration or ??= for initialization before .push().

Test plan

npm run typecheck passes (zero errors)
Pre-commit hooks pass (eslint, prettier, secretlint)
agentcore create does not write configBundles/abTests/httpGateways to agentcore.json
agentcore add config-bundle writes configBundles to agentcore.json
Existing projects with these fields still work

…a fields - Preflight: remove config bundle type patching entirely — the CDK schema does not have a type field, so the patch was dead code - Teardown: delegate to deleteOrphanedABTests and deleteOrphanedHttpGateways instead of raw API calls — reuses stop/poll/delete/role-cleanup logic. Correct ordering: AB tests first (they create rules on gateways), then gateways, then config bundles. - Schema: change configBundles, abTests, httpGateways from .default([]) to .optional() so they don't appear in agentcore.json unless the user opts into those preview features. All access sites updated with ?? [] or ??= guards. Closes#1070

github-actions · 2026-04-30T23:48:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.9%	8938 / 20832
🔵	Statements	42.16%	9484 / 22490
🔵	Functions	39.71%	1540 / 3878
🔵	Branches	39.84%	5772 / 14486

Generated in workflow #2255 for commit fb9622c by the Vitest Coverage Report Action

agentcore-cli-automation · 2026-04-30T23:48:44Z

The stated goal of this PR — "agentcore create does not write configBundles/abTests/httpGateways to agentcore.json" — is not actually achieved by the current changes. The schema was updated to make these fields optional, but several places that produce a fresh project spec still hardcode them as empty arrays, so they will continue to appear in agentcore.json for newly-created projects:

src/cli/project.ts — createDefaultProjectSpec() (lines 21–23) returns configBundles: [], abTests: [], httpGateways: []. This is the spec used by agentcore create (both the TUI flow in useCreateFlow.ts and the non-interactive command in commands/create/action.ts), and also by the remove flow in useRemoveFlow.ts when resetting a project.
src/cli/operations/agent/generate/write-agent-to-project.ts (lines 75–77) — the "create new project" branch of writeAgentToProject also hardcodes these empty arrays.

Since writeProjectSpec runs the data through safeParse and then JSON.stringify, any [] present in the input object is preserved on write — optional-in-schema only strips a field when it is undefined, not when it is []. Result: agentcore create will still write these fields.

To actually achieve the PR goal, drop these three keys from both createDefaultProjectSpec and the new-project branch in write-agent-to-project.ts (or explicitly set them to undefined — but omitting them is cleaner).

It would also be worth adding a test that asserts agentcore.json after agentcore create does not contain these keys, since the unchecked item in the PR's test plan ("agentcore create does not write configBundles/abTests/httpGateways to agentcore.json") is exactly the regression this PR is supposed to prevent.

… write (#1074) The .optional() change from #1073 breaks Zod JSON Schema generation ("Undefined cannot be represented in JSON Schema"). Revert to .default([]) so schema generation and parsing work, but strip empty configBundles/abTests/httpGateways in writeProjectSpec before writing to disk so preview features don't pollute agentcore.json.

notgitika · 2026-04-30T23:44:53Z

Summary

Change configBundles, abTests, and httpGateways from .default([]) to .optional() in the AgentCoreProjectSpec schema. This prevents empty preview-feature arrays from appearing in agentcore.json for users who haven't opted into those features.

All access sites updated with ?? [] for iteration or ??= for initialization before .push().

Test plan

npm run typecheck passes (zero errors)
Pre-commit hooks pass (eslint, prettier, secretlint)
agentcore create does not write configBundles/abTests/httpGateways to agentcore.json
agentcore add config-bundle writes configBundles to agentcore.json
Existing projects with these fields still work

…a fields - Preflight: remove config bundle type patching entirely — the CDK schema does not have a type field, so the patch was dead code - Teardown: delegate to deleteOrphanedABTests and deleteOrphanedHttpGateways instead of raw API calls — reuses stop/poll/delete/role-cleanup logic. Correct ordering: AB tests first (they create rules on gateways), then gateways, then config bundles. - Schema: change configBundles, abTests, httpGateways from .default([]) to .optional() so they don't appear in agentcore.json unless the user opts into those preview features. All access sites updated with ?? [] or ??= guards. Closes#1070

github-actions · 2026-04-30T23:48:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.9%	8938 / 20832
🔵	Statements	42.16%	9484 / 22490
🔵	Functions	39.71%	1540 / 3878
🔵	Branches	39.84%	5772 / 14486

Generated in workflow #2255 for commit fb9622c by the Vitest Coverage Report Action

agentcore-cli-automation · 2026-04-30T23:48:44Z

The stated goal of this PR — "agentcore create does not write configBundles/abTests/httpGateways to agentcore.json" — is not actually achieved by the current changes. The schema was updated to make these fields optional, but several places that produce a fresh project spec still hardcode them as empty arrays, so they will continue to appear in agentcore.json for newly-created projects:

src/cli/project.ts — createDefaultProjectSpec() (lines 21–23) returns configBundles: [], abTests: [], httpGateways: []. This is the spec used by agentcore create (both the TUI flow in useCreateFlow.ts and the non-interactive command in commands/create/action.ts), and also by the remove flow in useRemoveFlow.ts when resetting a project.
src/cli/operations/agent/generate/write-agent-to-project.ts (lines 75–77) — the "create new project" branch of writeAgentToProject also hardcodes these empty arrays.

Since writeProjectSpec runs the data through safeParse and then JSON.stringify, any [] present in the input object is preserved on write — optional-in-schema only strips a field when it is undefined, not when it is []. Result: agentcore create will still write these fields.

To actually achieve the PR goal, drop these three keys from both createDefaultProjectSpec and the new-project branch in write-agent-to-project.ts (or explicitly set them to undefined — but omitting them is cleaner).

It would also be worth adding a test that asserts agentcore.json after agentcore create does not contain these keys, since the unchecked item in the PR's test plan ("agentcore create does not write configBundles/abTests/httpGateways to agentcore.json") is exactly the regression this PR is supposed to prevent.

… write (#1074) The .optional() change from #1073 breaks Zod JSON Schema generation ("Undefined cannot be represented in JSON Schema"). Revert to .default([]) so schema generation and parsing work, but strip empty configBundles/abTests/httpGateways in writeProjectSpec before writing to disk so preview features don't pollute agentcore.json.

notgitika · 2026-04-30T23:44:53Z

Summary

Change configBundles, abTests, and httpGateways from .default([]) to .optional() in the AgentCoreProjectSpec schema. This prevents empty preview-feature arrays from appearing in agentcore.json for users who haven't opted into those features.

All access sites updated with ?? [] for iteration or ??= for initialization before .push().

Test plan

npm run typecheck passes (zero errors)
Pre-commit hooks pass (eslint, prettier, secretlint)
agentcore create does not write configBundles/abTests/httpGateways to agentcore.json
agentcore add config-bundle writes configBundles to agentcore.json
Existing projects with these fields still work

…a fields - Preflight: remove config bundle type patching entirely — the CDK schema does not have a type field, so the patch was dead code - Teardown: delegate to deleteOrphanedABTests and deleteOrphanedHttpGateways instead of raw API calls — reuses stop/poll/delete/role-cleanup logic. Correct ordering: AB tests first (they create rules on gateways), then gateways, then config bundles. - Schema: change configBundles, abTests, httpGateways from .default([]) to .optional() so they don't appear in agentcore.json unless the user opts into those preview features. All access sites updated with ?? [] or ??= guards. Closes#1070

github-actions · 2026-04-30T23:48:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.9%	8938 / 20832
🔵	Statements	42.16%	9484 / 22490
🔵	Functions	39.71%	1540 / 3878
🔵	Branches	39.84%	5772 / 14486

Generated in workflow #2255 for commit fb9622c by the Vitest Coverage Report Action

agentcore-cli-automation · 2026-04-30T23:48:44Z

The stated goal of this PR — "agentcore create does not write configBundles/abTests/httpGateways to agentcore.json" — is not actually achieved by the current changes. The schema was updated to make these fields optional, but several places that produce a fresh project spec still hardcode them as empty arrays, so they will continue to appear in agentcore.json for newly-created projects:

src/cli/project.ts — createDefaultProjectSpec() (lines 21–23) returns configBundles: [], abTests: [], httpGateways: []. This is the spec used by agentcore create (both the TUI flow in useCreateFlow.ts and the non-interactive command in commands/create/action.ts), and also by the remove flow in useRemoveFlow.ts when resetting a project.
src/cli/operations/agent/generate/write-agent-to-project.ts (lines 75–77) — the "create new project" branch of writeAgentToProject also hardcodes these empty arrays.

Since writeProjectSpec runs the data through safeParse and then JSON.stringify, any [] present in the input object is preserved on write — optional-in-schema only strips a field when it is undefined, not when it is []. Result: agentcore create will still write these fields.

To actually achieve the PR goal, drop these three keys from both createDefaultProjectSpec and the new-project branch in write-agent-to-project.ts (or explicitly set them to undefined — but omitting them is cleaner).

It would also be worth adding a test that asserts agentcore.json after agentcore create does not contain these keys, since the unchecked item in the PR's test plan ("agentcore create does not write configBundles/abTests/httpGateways to agentcore.json") is exactly the regression this PR is supposed to prevent.

… write (#1074) The .optional() change from #1073 breaks Zod JSON Schema generation ("Undefined cannot be represented in JSON Schema"). Revert to .default([]) so schema generation and parsing work, but strip empty configBundles/abTests/httpGateways in writeProjectSpec before writing to disk so preview features don't pollute agentcore.json.

notgitika · 2026-04-30T23:44:53Z

Summary

Change configBundles, abTests, and httpGateways from .default([]) to .optional() in the AgentCoreProjectSpec schema. This prevents empty preview-feature arrays from appearing in agentcore.json for users who haven't opted into those features.

All access sites updated with ?? [] for iteration or ??= for initialization before .push().

Test plan

npm run typecheck passes (zero errors)
Pre-commit hooks pass (eslint, prettier, secretlint)
agentcore create does not write configBundles/abTests/httpGateways to agentcore.json
agentcore add config-bundle writes configBundles to agentcore.json
Existing projects with these fields still work

…a fields - Preflight: remove config bundle type patching entirely — the CDK schema does not have a type field, so the patch was dead code - Teardown: delegate to deleteOrphanedABTests and deleteOrphanedHttpGateways instead of raw API calls — reuses stop/poll/delete/role-cleanup logic. Correct ordering: AB tests first (they create rules on gateways), then gateways, then config bundles. - Schema: change configBundles, abTests, httpGateways from .default([]) to .optional() so they don't appear in agentcore.json unless the user opts into those preview features. All access sites updated with ?? [] or ??= guards. Closes#1070

github-actions · 2026-04-30T23:48:21Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.9%	8938 / 20832
🔵	Statements	42.16%	9484 / 22490
🔵	Functions	39.71%	1540 / 3878
🔵	Branches	39.84%	5772 / 14486

Generated in workflow #2255 for commit fb9622c by the Vitest Coverage Report Action

agentcore-cli-automation · 2026-04-30T23:48:44Z

The stated goal of this PR — "agentcore create does not write configBundles/abTests/httpGateways to agentcore.json" — is not actually achieved by the current changes. The schema was updated to make these fields optional, but several places that produce a fresh project spec still hardcode them as empty arrays, so they will continue to appear in agentcore.json for newly-created projects:

src/cli/project.ts — createDefaultProjectSpec() (lines 21–23) returns configBundles: [], abTests: [], httpGateways: []. This is the spec used by agentcore create (both the TUI flow in useCreateFlow.ts and the non-interactive command in commands/create/action.ts), and also by the remove flow in useRemoveFlow.ts when resetting a project.
src/cli/operations/agent/generate/write-agent-to-project.ts (lines 75–77) — the "create new project" branch of writeAgentToProject also hardcodes these empty arrays.

Since writeProjectSpec runs the data through safeParse and then JSON.stringify, any [] present in the input object is preserved on write — optional-in-schema only strips a field when it is undefined, not when it is []. Result: agentcore create will still write these fields.

To actually achieve the PR goal, drop these three keys from both createDefaultProjectSpec and the new-project branch in write-agent-to-project.ts (or explicitly set them to undefined — but omitting them is cleaner).

It would also be worth adding a test that asserts agentcore.json after agentcore create does not contain these keys, since the unchecked item in the PR's test plan ("agentcore create does not write configBundles/abTests/httpGateways to agentcore.json") is exactly the regression this PR is supposed to prevent.

… write (#1074) The .optional() change from #1073 breaks Zod JSON Schema generation ("Undefined cannot be represented in JSON Schema"). Revert to .default([]) so schema generation and parsing work, but strip empty configBundles/abTests/httpGateways in writeProjectSpec before writing to disk so preview features don't pollute agentcore.json.

notgitika requested a review from a teamApril 30, 2026 23:44

github-actionsBot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress labels Apr 30, 2026

jariy17 approved these changes Apr 30, 2026
View reviewed changes

padmak30 approved these changes Apr 30, 2026
View reviewed changes

notgitika merged commit 839b32b into mainApr 30, 2026
25 checks passed

notgitika deleted the fix/optional-evo-schema-fields branch April 30, 2026 23:48

github-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Apr 30, 2026

notgitika mentioned this pull request May 1, 2026
fix: revert .optional() to .default([]) and strip empty evo arrays on write #1074
Merged
5 tasks