Skip to content

chore: sync main into preview (post-v0.13.0 fixes) - #1108

Closed
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504
Closed

chore: sync main into preview (post-v0.13.0 fixes)#1108
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504

Conversation

@notgitika

@notgitikanotgitika commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks 7 commits from main that landed after the last sync (PR #1077 / v0.13.0):

All cherry-picks applied cleanly with no conflicts.

Test plan

  • All 7 cherry-picks applied without conflicts
  • CI passes (typecheck, lint, unit tests)
  • E2E tests pass

jesseturner21and others added 6 commits May 4, 2026 14:26
CrewAI is not implemented as a framework option in the CLI — it does not
exist in SDKFrameworkSchema, has no template assets, and is not in the
SDK_MODEL_PROVIDER_MATRIX. Remove it from README and docs/frameworks.md
to match the actual CLI capabilities.
Constraint: Only frameworks in src/schema/constants.ts SDKFrameworkSchema are valid
Rejected: Mark CrewAI as "BYO only" | no special BYO treatment exists for it
Confidence: high
Scope-risk: narrow
…ing (#1008)
Co-authored-by: minorun365 <minorun365@users.noreply.github.com>
HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@notgitika
notgitika requested a review from a teamMay 4, 2026 18:27
@github-actionsgithub-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Reviewed — looks good to merge.

Verified:

  • All 6 cherry-picks match their originals on main byte-for-byte (only blob SHAs differ due to preview's different base).
  • The test fix in config-bundle-eval-rec.test.ts aligns with current code:
    • run eval uses --days (command.tsx:88) ✓
    • run recommend still uses --lookback (command.tsx:288) ✓
    • batchEvaluationId matches the API response shape in agentcore-batch-evaluation.ts
  • glob: ^13.0.0 override is additive and doesn't collide with preview's existing minimatch/fast-xml-parser/@aws-sdk/xml-builder overrides.
  • No user-facing CrewAI references remain; the one leftover hit in src/cli/operations/dev/otel/transforms.ts is an OTEL scope-name hint for parsing external traces, unrelated to CLI framework support.
  • IAM policy additions are purely additive.

@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@github-actions

github-actionsBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines43.45%9904 / 22794
🔵Statements42.72%10519 / 24619
🔵Functions40.36%1667 / 4130
🔵Branches40.16%6401 / 15935
Generated in workflow #2361 for commit af54208 by the Vitest Coverage Report Action

…1094)
The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notgitika@agentcore-cli-automation@jesseturner21@minorun365@Hweinstock@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore: sync main into preview (post-v0.13.0 fixes) by notgitika · Pull Request #1108 · aws/agentcore-cli · GitHub
Skip to content

chore: sync main into preview (post-v0.13.0 fixes) - #1108

Closed
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504
Closed

chore: sync main into preview (post-v0.13.0 fixes)#1108
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504

Conversation

@notgitika

@notgitikanotgitika commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks 7 commits from main that landed after the last sync (PR #1077 / v0.13.0):

All cherry-picks applied cleanly with no conflicts.

Test plan

  • All 7 cherry-picks applied without conflicts
  • CI passes (typecheck, lint, unit tests)
  • E2E tests pass

jesseturner21and others added 6 commits May 4, 2026 14:26
CrewAI is not implemented as a framework option in the CLI — it does not
exist in SDKFrameworkSchema, has no template assets, and is not in the
SDK_MODEL_PROVIDER_MATRIX. Remove it from README and docs/frameworks.md
to match the actual CLI capabilities.
Constraint: Only frameworks in src/schema/constants.ts SDKFrameworkSchema are valid
Rejected: Mark CrewAI as "BYO only" | no special BYO treatment exists for it
Confidence: high
Scope-risk: narrow
…ing (#1008)
Co-authored-by: minorun365 <minorun365@users.noreply.github.com>
HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@notgitika
notgitika requested a review from a teamMay 4, 2026 18:27
@github-actionsgithub-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Reviewed — looks good to merge.

Verified:

  • All 6 cherry-picks match their originals on main byte-for-byte (only blob SHAs differ due to preview's different base).
  • The test fix in config-bundle-eval-rec.test.ts aligns with current code:
    • run eval uses --days (command.tsx:88) ✓
    • run recommend still uses --lookback (command.tsx:288) ✓
    • batchEvaluationId matches the API response shape in agentcore-batch-evaluation.ts
  • glob: ^13.0.0 override is additive and doesn't collide with preview's existing minimatch/fast-xml-parser/@aws-sdk/xml-builder overrides.
  • No user-facing CrewAI references remain; the one leftover hit in src/cli/operations/dev/otel/transforms.ts is an OTEL scope-name hint for parsing external traces, unrelated to CLI framework support.
  • IAM policy additions are purely additive.

@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@github-actions

github-actionsBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines43.45%9904 / 22794
🔵Statements42.72%10519 / 24619
🔵Functions40.36%1667 / 4130
🔵Branches40.16%6401 / 15935
Generated in workflow #2361 for commit af54208 by the Vitest Coverage Report Action

…1094)
The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notgitika@agentcore-cli-automation@jesseturner21@minorun365@Hweinstock@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: sync main into preview (post-v0.13.0 fixes) by notgitika · Pull Request #1108 · aws/agentcore-cli · GitHub
Skip to content

chore: sync main into preview (post-v0.13.0 fixes) - #1108

Closed
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504
Closed

chore: sync main into preview (post-v0.13.0 fixes)#1108
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504

Conversation

@notgitika

@notgitikanotgitika commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks 7 commits from main that landed after the last sync (PR #1077 / v0.13.0):

All cherry-picks applied cleanly with no conflicts.

Test plan

  • All 7 cherry-picks applied without conflicts
  • CI passes (typecheck, lint, unit tests)
  • E2E tests pass

jesseturner21and others added 6 commits May 4, 2026 14:26
CrewAI is not implemented as a framework option in the CLI — it does not
exist in SDKFrameworkSchema, has no template assets, and is not in the
SDK_MODEL_PROVIDER_MATRIX. Remove it from README and docs/frameworks.md
to match the actual CLI capabilities.
Constraint: Only frameworks in src/schema/constants.ts SDKFrameworkSchema are valid
Rejected: Mark CrewAI as "BYO only" | no special BYO treatment exists for it
Confidence: high
Scope-risk: narrow
…ing (#1008)
Co-authored-by: minorun365 <minorun365@users.noreply.github.com>
HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@notgitika
notgitika requested a review from a teamMay 4, 2026 18:27
@github-actionsgithub-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Reviewed — looks good to merge.

Verified:

  • All 6 cherry-picks match their originals on main byte-for-byte (only blob SHAs differ due to preview's different base).
  • The test fix in config-bundle-eval-rec.test.ts aligns with current code:
    • run eval uses --days (command.tsx:88) ✓
    • run recommend still uses --lookback (command.tsx:288) ✓
    • batchEvaluationId matches the API response shape in agentcore-batch-evaluation.ts
  • glob: ^13.0.0 override is additive and doesn't collide with preview's existing minimatch/fast-xml-parser/@aws-sdk/xml-builder overrides.
  • No user-facing CrewAI references remain; the one leftover hit in src/cli/operations/dev/otel/transforms.ts is an OTEL scope-name hint for parsing external traces, unrelated to CLI framework support.
  • IAM policy additions are purely additive.

@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@github-actions

github-actionsBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines43.45%9904 / 22794
🔵Statements42.72%10519 / 24619
🔵Functions40.36%1667 / 4130
🔵Branches40.16%6401 / 15935
Generated in workflow #2361 for commit af54208 by the Vitest Coverage Report Action

…1094)
The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notgitika@agentcore-cli-automation@jesseturner21@minorun365@Hweinstock@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: sync main into preview (post-v0.13.0 fixes) by notgitika · Pull Request #1108 · aws/agentcore-cli · GitHub
Skip to content

chore: sync main into preview (post-v0.13.0 fixes) - #1108

Closed
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504
Closed

chore: sync main into preview (post-v0.13.0 fixes)#1108
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504

Conversation

@notgitika

@notgitikanotgitika commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks 7 commits from main that landed after the last sync (PR #1077 / v0.13.0):

All cherry-picks applied cleanly with no conflicts.

Test plan

  • All 7 cherry-picks applied without conflicts
  • CI passes (typecheck, lint, unit tests)
  • E2E tests pass

jesseturner21and others added 6 commits May 4, 2026 14:26
CrewAI is not implemented as a framework option in the CLI — it does not
exist in SDKFrameworkSchema, has no template assets, and is not in the
SDK_MODEL_PROVIDER_MATRIX. Remove it from README and docs/frameworks.md
to match the actual CLI capabilities.
Constraint: Only frameworks in src/schema/constants.ts SDKFrameworkSchema are valid
Rejected: Mark CrewAI as "BYO only" | no special BYO treatment exists for it
Confidence: high
Scope-risk: narrow
…ing (#1008)
Co-authored-by: minorun365 <minorun365@users.noreply.github.com>
HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@notgitika
notgitika requested a review from a teamMay 4, 2026 18:27
@github-actionsgithub-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Reviewed — looks good to merge.

Verified:

  • All 6 cherry-picks match their originals on main byte-for-byte (only blob SHAs differ due to preview's different base).
  • The test fix in config-bundle-eval-rec.test.ts aligns with current code:
    • run eval uses --days (command.tsx:88) ✓
    • run recommend still uses --lookback (command.tsx:288) ✓
    • batchEvaluationId matches the API response shape in agentcore-batch-evaluation.ts
  • glob: ^13.0.0 override is additive and doesn't collide with preview's existing minimatch/fast-xml-parser/@aws-sdk/xml-builder overrides.
  • No user-facing CrewAI references remain; the one leftover hit in src/cli/operations/dev/otel/transforms.ts is an OTEL scope-name hint for parsing external traces, unrelated to CLI framework support.
  • IAM policy additions are purely additive.

@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@github-actions

github-actionsBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines43.45%9904 / 22794
🔵Statements42.72%10519 / 24619
🔵Functions40.36%1667 / 4130
🔵Branches40.16%6401 / 15935
Generated in workflow #2361 for commit af54208 by the Vitest Coverage Report Action

…1094)
The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notgitika@agentcore-cli-automation@jesseturner21@minorun365@Hweinstock@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' chore: sync main into preview (post-v0.13.0 fixes) by notgitika · Pull Request #1108 · aws/agentcore-cli · GitHub
Skip to content

chore: sync main into preview (post-v0.13.0 fixes) - #1108

Closed
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504
Closed

chore: sync main into preview (post-v0.13.0 fixes)#1108
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504

Conversation

@notgitika

@notgitikanotgitika commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks 7 commits from main that landed after the last sync (PR #1077 / v0.13.0):

All cherry-picks applied cleanly with no conflicts.

Test plan

  • All 7 cherry-picks applied without conflicts
  • CI passes (typecheck, lint, unit tests)
  • E2E tests pass

jesseturner21and others added 6 commits May 4, 2026 14:26
CrewAI is not implemented as a framework option in the CLI — it does not
exist in SDKFrameworkSchema, has no template assets, and is not in the
SDK_MODEL_PROVIDER_MATRIX. Remove it from README and docs/frameworks.md
to match the actual CLI capabilities.
Constraint: Only frameworks in src/schema/constants.ts SDKFrameworkSchema are valid
Rejected: Mark CrewAI as "BYO only" | no special BYO treatment exists for it
Confidence: high
Scope-risk: narrow
…ing (#1008)
Co-authored-by: minorun365 <minorun365@users.noreply.github.com>
HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@notgitika
notgitika requested a review from a teamMay 4, 2026 18:27
@github-actionsgithub-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Reviewed — looks good to merge.

Verified:

  • All 6 cherry-picks match their originals on main byte-for-byte (only blob SHAs differ due to preview's different base).
  • The test fix in config-bundle-eval-rec.test.ts aligns with current code:
    • run eval uses --days (command.tsx:88) ✓
    • run recommend still uses --lookback (command.tsx:288) ✓
    • batchEvaluationId matches the API response shape in agentcore-batch-evaluation.ts
  • glob: ^13.0.0 override is additive and doesn't collide with preview's existing minimatch/fast-xml-parser/@aws-sdk/xml-builder overrides.
  • No user-facing CrewAI references remain; the one leftover hit in src/cli/operations/dev/otel/transforms.ts is an OTEL scope-name hint for parsing external traces, unrelated to CLI framework support.
  • IAM policy additions are purely additive.

@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@github-actions

github-actionsBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines43.45%9904 / 22794
🔵Statements42.72%10519 / 24619
🔵Functions40.36%1667 / 4130
🔵Branches40.16%6401 / 15935
Generated in workflow #2361 for commit af54208 by the Vitest Coverage Report Action

…1094)
The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notgitika@agentcore-cli-automation@jesseturner21@minorun365@Hweinstock@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: sync main into preview (post-v0.13.0 fixes) by notgitika · Pull Request #1108 · aws/agentcore-cli · GitHub
Skip to content

chore: sync main into preview (post-v0.13.0 fixes) - #1108

Closed
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504
Closed

chore: sync main into preview (post-v0.13.0 fixes)#1108
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504

Conversation

@notgitika

@notgitikanotgitika commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks 7 commits from main that landed after the last sync (PR #1077 / v0.13.0):

All cherry-picks applied cleanly with no conflicts.

Test plan

  • All 7 cherry-picks applied without conflicts
  • CI passes (typecheck, lint, unit tests)
  • E2E tests pass

jesseturner21and others added 6 commits May 4, 2026 14:26
CrewAI is not implemented as a framework option in the CLI — it does not
exist in SDKFrameworkSchema, has no template assets, and is not in the
SDK_MODEL_PROVIDER_MATRIX. Remove it from README and docs/frameworks.md
to match the actual CLI capabilities.
Constraint: Only frameworks in src/schema/constants.ts SDKFrameworkSchema are valid
Rejected: Mark CrewAI as "BYO only" | no special BYO treatment exists for it
Confidence: high
Scope-risk: narrow
…ing (#1008)
Co-authored-by: minorun365 <minorun365@users.noreply.github.com>
HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@notgitika
notgitika requested a review from a teamMay 4, 2026 18:27
@github-actionsgithub-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Reviewed — looks good to merge.

Verified:

  • All 6 cherry-picks match their originals on main byte-for-byte (only blob SHAs differ due to preview's different base).
  • The test fix in config-bundle-eval-rec.test.ts aligns with current code:
    • run eval uses --days (command.tsx:88) ✓
    • run recommend still uses --lookback (command.tsx:288) ✓
    • batchEvaluationId matches the API response shape in agentcore-batch-evaluation.ts
  • glob: ^13.0.0 override is additive and doesn't collide with preview's existing minimatch/fast-xml-parser/@aws-sdk/xml-builder overrides.
  • No user-facing CrewAI references remain; the one leftover hit in src/cli/operations/dev/otel/transforms.ts is an OTEL scope-name hint for parsing external traces, unrelated to CLI framework support.
  • IAM policy additions are purely additive.

@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@github-actions

github-actionsBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines43.45%9904 / 22794
🔵Statements42.72%10519 / 24619
🔵Functions40.36%1667 / 4130
🔵Branches40.16%6401 / 15935
Generated in workflow #2361 for commit af54208 by the Vitest Coverage Report Action

…1094)
The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notgitika@agentcore-cli-automation@jesseturner21@minorun365@Hweinstock@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: sync main into preview (post-v0.13.0 fixes) by notgitika · Pull Request #1108 · aws/agentcore-cli · GitHub
Skip to content

chore: sync main into preview (post-v0.13.0 fixes) - #1108

Closed
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504
Closed

chore: sync main into preview (post-v0.13.0 fixes)#1108
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504

Conversation

@notgitika

@notgitikanotgitika commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks 7 commits from main that landed after the last sync (PR #1077 / v0.13.0):

All cherry-picks applied cleanly with no conflicts.

Test plan

  • All 7 cherry-picks applied without conflicts
  • CI passes (typecheck, lint, unit tests)
  • E2E tests pass

jesseturner21and others added 6 commits May 4, 2026 14:26
CrewAI is not implemented as a framework option in the CLI — it does not
exist in SDKFrameworkSchema, has no template assets, and is not in the
SDK_MODEL_PROVIDER_MATRIX. Remove it from README and docs/frameworks.md
to match the actual CLI capabilities.
Constraint: Only frameworks in src/schema/constants.ts SDKFrameworkSchema are valid
Rejected: Mark CrewAI as "BYO only" | no special BYO treatment exists for it
Confidence: high
Scope-risk: narrow
…ing (#1008)
Co-authored-by: minorun365 <minorun365@users.noreply.github.com>
HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@notgitika
notgitika requested a review from a teamMay 4, 2026 18:27
@github-actionsgithub-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Reviewed — looks good to merge.

Verified:

  • All 6 cherry-picks match their originals on main byte-for-byte (only blob SHAs differ due to preview's different base).
  • The test fix in config-bundle-eval-rec.test.ts aligns with current code:
    • run eval uses --days (command.tsx:88) ✓
    • run recommend still uses --lookback (command.tsx:288) ✓
    • batchEvaluationId matches the API response shape in agentcore-batch-evaluation.ts
  • glob: ^13.0.0 override is additive and doesn't collide with preview's existing minimatch/fast-xml-parser/@aws-sdk/xml-builder overrides.
  • No user-facing CrewAI references remain; the one leftover hit in src/cli/operations/dev/otel/transforms.ts is an OTEL scope-name hint for parsing external traces, unrelated to CLI framework support.
  • IAM policy additions are purely additive.

@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@github-actions

github-actionsBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines43.45%9904 / 22794
🔵Statements42.72%10519 / 24619
🔵Functions40.36%1667 / 4130
🔵Branches40.16%6401 / 15935
Generated in workflow #2361 for commit af54208 by the Vitest Coverage Report Action

…1094)
The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notgitika@agentcore-cli-automation@jesseturner21@minorun365@Hweinstock@jariy17
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); chore: sync main into preview (post-v0.13.0 fixes) by notgitika · Pull Request #1108 · aws/agentcore-cli · GitHub
Skip to content

chore: sync main into preview (post-v0.13.0 fixes) - #1108

Closed
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504
Closed

chore: sync main into preview (post-v0.13.0 fixes)#1108
notgitika wants to merge 7 commits into
previewfrom
sync/main-to-preview-20260504

Conversation

@notgitika

@notgitikanotgitika commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks 7 commits from main that landed after the last sync (PR #1077 / v0.13.0):

All cherry-picks applied cleanly with no conflicts.

Test plan

  • All 7 cherry-picks applied without conflicts
  • CI passes (typecheck, lint, unit tests)
  • E2E tests pass

jesseturner21and others added 6 commits May 4, 2026 14:26
CrewAI is not implemented as a framework option in the CLI — it does not
exist in SDKFrameworkSchema, has no template assets, and is not in the
SDK_MODEL_PROVIDER_MATRIX. Remove it from README and docs/frameworks.md
to match the actual CLI capabilities.
Constraint: Only frameworks in src/schema/constants.ts SDKFrameworkSchema are valid
Rejected: Mark CrewAI as "BYO only" | no special BYO treatment exists for it
Confidence: high
Scope-risk: narrow
…ing (#1008)
Co-authored-by: minorun365 <minorun365@users.noreply.github.com>
HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@notgitika
notgitika requested a review from a teamMay 4, 2026 18:27
@github-actionsgithub-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation

Copy link
Copy Markdown

Reviewed — looks good to merge.

Verified:

  • All 6 cherry-picks match their originals on main byte-for-byte (only blob SHAs differ due to preview's different base).
  • The test fix in config-bundle-eval-rec.test.ts aligns with current code:
    • run eval uses --days (command.tsx:88) ✓
    • run recommend still uses --lookback (command.tsx:288) ✓
    • batchEvaluationId matches the API response shape in agentcore-batch-evaluation.ts
  • glob: ^13.0.0 override is additive and doesn't collide with preview's existing minimatch/fast-xml-parser/@aws-sdk/xml-builder overrides.
  • No user-facing CrewAI references remain; the one leftover hit in src/cli/operations/dev/otel/transforms.ts is an OTEL scope-name hint for parsing external traces, unrelated to CLI framework support.
  • IAM policy additions are purely additive.

@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@github-actions

github-actionsBot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines43.45%9904 / 22794
🔵Statements42.72%10519 / 24619
🔵Functions40.36%1667 / 4130
🔵Branches40.16%6401 / 15935
Generated in workflow #2361 for commit af54208 by the Vitest Coverage Report Action

…1094)
The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notgitika@agentcore-cli-automation@jesseturner21@minorun365@Hweinstock@jariy17