fix(status): show 'No target configured' instead of empty '(target: )' in status header#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aidandaly24 wants to merge 1 commit into from
Closed

fix(status): show 'No target configured' instead of empty '(target: )' in status header #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/cli/commands/status/__tests__/action.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,6 +631,20 @@ describe('handleProjectStatus — live enrichment', () => {
expect(evalEntry!.deploymentState).toBe('local-only');
expect(mockGetEvaluator).not.toHaveBeenCalled();
});

it('returns empty targetName when no targets are configured (regression for #985)', async () => {
const ctx = makeContext({
awsTargets: [] as unknown as StatusContext['awsTargets'],
deployedState: {
targets: {},
} as unknown as StatusContext['deployedState'],
});

const result = await handleProjectStatus(ctx);

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test verifies the handleProjectStatus contract (empty targetName when no targets are configured), but the code change in this PR is on the runtime-status path that calls handleRuntimeLookup. So the test doesn't actually exercise the render line you modified.

It's a fine regression guard for the default-path fix that landed in #1068, but if the goal is to lock in the behavior that this PR changes, consider adding a test for handleRuntimeLookup or a rendering test for the runtime-status header — otherwise nothing in the test suite prevents a future regression of line 113–114.

Also, minor: this test is inside describe('handleProjectStatus — live enrichment', ...) but has nothing to do with live enrichment. Consider moving it to a more appropriate describe block (e.g. the existing handleProjectStatus block that covers target resolution).

expect(result.success).toBe(true);
expect(result.targetName).toBe('');
});
});

describe('buildRuntimeInvocationUrl', () => {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/status/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,8 @@

render(
<Text>
AgentCore Status - {result.runtimeId} (target: {result.targetName})
AgentCore Status - {result.runtimeId} (target:{' '}
{result.targetName && result.targetName.length > 0 ? result.targetName : 'No target configured'})

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleRuntimeLookup in action.ts returns success: false early (lines 409–414) when awsTargets is empty, and on the success path selectedTargetName = options.targetName ?? targetNames[0]! (line 416) is guaranteed to be a non-empty string because targetNames.length > 0 is required to reach this point. So on the success branch that reaches this render, result.targetName cannot actually be empty or undefined today — this guard is purely defensive against a future refactor of handleRuntimeLookup.

That's not wrong, but it contradicts the PR description, which frames this as fixing "the same latent bug for that code path." There's no latent bug here right now — the reproducer in #985 (agentcore status with no --runtime) lands in the default path at line 157, which was already fixed in #1068.

Options:

  1. Leave the guard as defense-in-depth but update the PR description (and maybe a code comment here) to say "defensive guard in case handleRuntimeLookup's contract changes" rather than claiming it fixes a latent bug.
  2. Drop this render change entirely since the state is unreachable, and just keep the regression test on handleProjectStatus.
  3. If you want the guard to mean something today, tighten RuntimeLookupResult.targetName from string | undefined to string (since the success path always provides it) — that removes the need for this check and makes the contract explicit.

{runtimeStatus ? ` - ${runtimeStatus}` : ''}
</Text>
);
Expand DownExpand Up@@ -299,7 +300,7 @@
});
};

function ResourceEntry({ entry, showRuntime }: { entry: ResourceStatusEntry; showRuntime?: boolean }) {

Check warning on line 303 in src/cli/commands/status/command.tsx

View workflow job for this annotation

GitHub Actions/ lint

Fast refresh only works when a file only exports components. Move your component(s) to a separate file. If all exports are HOCs, add them to the `extraHOCs` option
return (
<Text>
{' '}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(status): show 'No target configured' instead of empty '(target: )' in status header#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

aidandaly24
wants to merge
1
commit into

from

 Closed


fix(status): show 'No target configured' instead of empty '(target: )' in status header
#1171
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
src/cli/commands/status/__tests__/action.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -631,6 +631,20 @@ describe('handleProjectStatus — live enrichment', () => {
 expect(evalEntry!.deploymentState).toBe('local-only');
 expect(mockGetEvaluator).not.toHaveBeenCalled();
 });

 it('returns empty targetName when no targets are configured (regression for #985)', async () => {
 const ctx = makeContext({
 awsTargets: [] as unknown as StatusContext['awsTargets'],
 deployedState: {
 targets: {},
 } as unknown as StatusContext['deployedState'],
 });

 const result = await handleProjectStatus(ctx);

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test verifies the handleProjectStatus contract (empty targetName when no targets are configured), but the code change in this PR is on the runtime-status path that calls handleRuntimeLookup. So the test doesn't actually exercise the render line you modified.
It's a fine regression guard for the default-path fix that landed in #1068, but if the goal is to lock in the behavior that this PR changes, consider adding a test for handleRuntimeLookup or a rendering test for the runtime-status header — otherwise nothing in the test suite prevents a future regression of line 113–114.
Also, minor: this test is inside describe('handleProjectStatus — live enrichment', ...) but has nothing to do with live enrichment. Consider moving it to a more appropriate describe block (e.g. the existing handleProjectStatus block that covers target resolution).
 expect(result.success).toBe(true);
 expect(result.targetName).toBe('');
 });
});

describe('buildRuntimeInvocationUrl', () => {
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/commands/status/command.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,8 @@

 render(
 <Text>
 AgentCore Status - {result.runtimeId} (target: {result.targetName})
 AgentCore Status - {result.runtimeId} (target:{' '}
 {result.targetName && result.targetName.length > 0 ? result.targetName : 'No target configured'})
@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleRuntimeLookup in action.ts returns success: false early (lines 409–414) when awsTargets is empty, and on the success path selectedTargetName = options.targetName ?? targetNames[0]! (line 416) is guaranteed to be a non-empty string because targetNames.length > 0 is required to reach this point. So on the success branch that reaches this render, result.targetName cannot actually be empty or undefined today — this guard is purely defensive against a future refactor of handleRuntimeLookup.
That's not wrong, but it contradicts the PR description, which frames this as fixing "the same latent bug for that code path." There's no latent bug here right now — the reproducer in #985 (agentcore status with no --runtime) lands in the default path at line 157, which was already fixed in #1068.
Options:
  1. Leave the guard as defense-in-depth but update the PR description (and maybe a code comment here) to say "defensive guard in case handleRuntimeLookup's contract changes" rather than claiming it fixes a latent bug.
  2. Drop this render change entirely since the state is unreachable, and just keep the regression test on handleProjectStatus.
  3. If you want the guard to mean something today, tighten RuntimeLookupResult.targetName from string | undefined to string (since the success path always provides it) — that removes the need for this check and makes the contract explicit.
 {runtimeStatus ? ` - ${runtimeStatus}` : ''}
 </Text>
 );
Expand DownExpand Up@@ -299,7 +300,7 @@
 });
};

function ResourceEntry({ entry, showRuntime }: { entry: ResourceStatusEntry; showRuntime?: boolean }) {

Check warning
on line 303
in src/cli/commands/status/command.tsx

View workflow job for this annotation
GitHub Actions/ lint
Fast refresh only works when a file only exports components. Move your component(s) to a separate file. If all exports are HOCs, add them to the `extraHOCs` option
 return (
 <Text>
 {' '}
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(status): show 'No target configured' instead of empty '(target: )' in status header#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

aidandaly24
wants to merge
1
commit into

from

 Closed


fix(status): show 'No target configured' instead of empty '(target: )' in status header
#1171
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
src/cli/commands/status/__tests__/action.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -631,6 +631,20 @@ describe('handleProjectStatus — live enrichment', () => {
 expect(evalEntry!.deploymentState).toBe('local-only');
 expect(mockGetEvaluator).not.toHaveBeenCalled();
 });

 it('returns empty targetName when no targets are configured (regression for #985)', async () => {
 const ctx = makeContext({
 awsTargets: [] as unknown as StatusContext['awsTargets'],
 deployedState: {
 targets: {},
 } as unknown as StatusContext['deployedState'],
 });

 const result = await handleProjectStatus(ctx);

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test verifies the handleProjectStatus contract (empty targetName when no targets are configured), but the code change in this PR is on the runtime-status path that calls handleRuntimeLookup. So the test doesn't actually exercise the render line you modified.
It's a fine regression guard for the default-path fix that landed in #1068, but if the goal is to lock in the behavior that this PR changes, consider adding a test for handleRuntimeLookup or a rendering test for the runtime-status header — otherwise nothing in the test suite prevents a future regression of line 113–114.
Also, minor: this test is inside describe('handleProjectStatus — live enrichment', ...) but has nothing to do with live enrichment. Consider moving it to a more appropriate describe block (e.g. the existing handleProjectStatus block that covers target resolution).
 expect(result.success).toBe(true);
 expect(result.targetName).toBe('');
 });
});

describe('buildRuntimeInvocationUrl', () => {
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/commands/status/command.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,8 @@

 render(
 <Text>
 AgentCore Status - {result.runtimeId} (target: {result.targetName})
 AgentCore Status - {result.runtimeId} (target:{' '}
 {result.targetName && result.targetName.length > 0 ? result.targetName : 'No target configured'})
@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleRuntimeLookup in action.ts returns success: false early (lines 409–414) when awsTargets is empty, and on the success path selectedTargetName = options.targetName ?? targetNames[0]! (line 416) is guaranteed to be a non-empty string because targetNames.length > 0 is required to reach this point. So on the success branch that reaches this render, result.targetName cannot actually be empty or undefined today — this guard is purely defensive against a future refactor of handleRuntimeLookup.
That's not wrong, but it contradicts the PR description, which frames this as fixing "the same latent bug for that code path." There's no latent bug here right now — the reproducer in #985 (agentcore status with no --runtime) lands in the default path at line 157, which was already fixed in #1068.
Options:
  1. Leave the guard as defense-in-depth but update the PR description (and maybe a code comment here) to say "defensive guard in case handleRuntimeLookup's contract changes" rather than claiming it fixes a latent bug.
  2. Drop this render change entirely since the state is unreachable, and just keep the regression test on handleProjectStatus.
  3. If you want the guard to mean something today, tighten RuntimeLookupResult.targetName from string | undefined to string (since the success path always provides it) — that removes the need for this check and makes the contract explicit.
 {runtimeStatus ? ` - ${runtimeStatus}` : ''}
 </Text>
 );
Expand DownExpand Up@@ -299,7 +300,7 @@
 });
};

function ResourceEntry({ entry, showRuntime }: { entry: ResourceStatusEntry; showRuntime?: boolean }) {

Check warning
on line 303
in src/cli/commands/status/command.tsx

View workflow job for this annotation
GitHub Actions/ lint
Fast refresh only works when a file only exports components. Move your component(s) to a separate file. If all exports are HOCs, add them to the `extraHOCs` option
 return (
 <Text>
 {' '}
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(status): show 'No target configured' instead of empty '(target: )' in status header#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

aidandaly24
wants to merge
1
commit into

from

 Closed


fix(status): show 'No target configured' instead of empty '(target: )' in status header
#1171
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
src/cli/commands/status/__tests__/action.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -631,6 +631,20 @@ describe('handleProjectStatus — live enrichment', () => {
 expect(evalEntry!.deploymentState).toBe('local-only');
 expect(mockGetEvaluator).not.toHaveBeenCalled();
 });

 it('returns empty targetName when no targets are configured (regression for #985)', async () => {
 const ctx = makeContext({
 awsTargets: [] as unknown as StatusContext['awsTargets'],
 deployedState: {
 targets: {},
 } as unknown as StatusContext['deployedState'],
 });

 const result = await handleProjectStatus(ctx);

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test verifies the handleProjectStatus contract (empty targetName when no targets are configured), but the code change in this PR is on the runtime-status path that calls handleRuntimeLookup. So the test doesn't actually exercise the render line you modified.
It's a fine regression guard for the default-path fix that landed in #1068, but if the goal is to lock in the behavior that this PR changes, consider adding a test for handleRuntimeLookup or a rendering test for the runtime-status header — otherwise nothing in the test suite prevents a future regression of line 113–114.
Also, minor: this test is inside describe('handleProjectStatus — live enrichment', ...) but has nothing to do with live enrichment. Consider moving it to a more appropriate describe block (e.g. the existing handleProjectStatus block that covers target resolution).
 expect(result.success).toBe(true);
 expect(result.targetName).toBe('');
 });
});

describe('buildRuntimeInvocationUrl', () => {
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/commands/status/command.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,8 @@

 render(
 <Text>
 AgentCore Status - {result.runtimeId} (target: {result.targetName})
 AgentCore Status - {result.runtimeId} (target:{' '}
 {result.targetName && result.targetName.length > 0 ? result.targetName : 'No target configured'})
@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleRuntimeLookup in action.ts returns success: false early (lines 409–414) when awsTargets is empty, and on the success path selectedTargetName = options.targetName ?? targetNames[0]! (line 416) is guaranteed to be a non-empty string because targetNames.length > 0 is required to reach this point. So on the success branch that reaches this render, result.targetName cannot actually be empty or undefined today — this guard is purely defensive against a future refactor of handleRuntimeLookup.
That's not wrong, but it contradicts the PR description, which frames this as fixing "the same latent bug for that code path." There's no latent bug here right now — the reproducer in #985 (agentcore status with no --runtime) lands in the default path at line 157, which was already fixed in #1068.
Options:
  1. Leave the guard as defense-in-depth but update the PR description (and maybe a code comment here) to say "defensive guard in case handleRuntimeLookup's contract changes" rather than claiming it fixes a latent bug.
  2. Drop this render change entirely since the state is unreachable, and just keep the regression test on handleProjectStatus.
  3. If you want the guard to mean something today, tighten RuntimeLookupResult.targetName from string | undefined to string (since the success path always provides it) — that removes the need for this check and makes the contract explicit.
 {runtimeStatus ? ` - ${runtimeStatus}` : ''}
 </Text>
 );
Expand DownExpand Up@@ -299,7 +300,7 @@
 });
};

function ResourceEntry({ entry, showRuntime }: { entry: ResourceStatusEntry; showRuntime?: boolean }) {

Check warning
on line 303
in src/cli/commands/status/command.tsx

View workflow job for this annotation
GitHub Actions/ lint
Fast refresh only works when a file only exports components. Move your component(s) to a separate file. If all exports are HOCs, add them to the `extraHOCs` option
 return (
 <Text>
 {' '}
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(status): show 'No target configured' instead of empty '(target: )' in status header#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

aidandaly24
wants to merge
1
commit into

from

 Closed


fix(status): show 'No target configured' instead of empty '(target: )' in status header
#1171
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
src/cli/commands/status/__tests__/action.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -631,6 +631,20 @@ describe('handleProjectStatus — live enrichment', () => {
 expect(evalEntry!.deploymentState).toBe('local-only');
 expect(mockGetEvaluator).not.toHaveBeenCalled();
 });

 it('returns empty targetName when no targets are configured (regression for #985)', async () => {
 const ctx = makeContext({
 awsTargets: [] as unknown as StatusContext['awsTargets'],
 deployedState: {
 targets: {},
 } as unknown as StatusContext['deployedState'],
 });

 const result = await handleProjectStatus(ctx);

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test verifies the handleProjectStatus contract (empty targetName when no targets are configured), but the code change in this PR is on the runtime-status path that calls handleRuntimeLookup. So the test doesn't actually exercise the render line you modified.
It's a fine regression guard for the default-path fix that landed in #1068, but if the goal is to lock in the behavior that this PR changes, consider adding a test for handleRuntimeLookup or a rendering test for the runtime-status header — otherwise nothing in the test suite prevents a future regression of line 113–114.
Also, minor: this test is inside describe('handleProjectStatus — live enrichment', ...) but has nothing to do with live enrichment. Consider moving it to a more appropriate describe block (e.g. the existing handleProjectStatus block that covers target resolution).
 expect(result.success).toBe(true);
 expect(result.targetName).toBe('');
 });
});

describe('buildRuntimeInvocationUrl', () => {
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/commands/status/command.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,8 @@

 render(
 <Text>
 AgentCore Status - {result.runtimeId} (target: {result.targetName})
 AgentCore Status - {result.runtimeId} (target:{' '}
 {result.targetName && result.targetName.length > 0 ? result.targetName : 'No target configured'})
@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleRuntimeLookup in action.ts returns success: false early (lines 409–414) when awsTargets is empty, and on the success path selectedTargetName = options.targetName ?? targetNames[0]! (line 416) is guaranteed to be a non-empty string because targetNames.length > 0 is required to reach this point. So on the success branch that reaches this render, result.targetName cannot actually be empty or undefined today — this guard is purely defensive against a future refactor of handleRuntimeLookup.
That's not wrong, but it contradicts the PR description, which frames this as fixing "the same latent bug for that code path." There's no latent bug here right now — the reproducer in #985 (agentcore status with no --runtime) lands in the default path at line 157, which was already fixed in #1068.
Options:
  1. Leave the guard as defense-in-depth but update the PR description (and maybe a code comment here) to say "defensive guard in case handleRuntimeLookup's contract changes" rather than claiming it fixes a latent bug.
  2. Drop this render change entirely since the state is unreachable, and just keep the regression test on handleProjectStatus.
  3. If you want the guard to mean something today, tighten RuntimeLookupResult.targetName from string | undefined to string (since the success path always provides it) — that removes the need for this check and makes the contract explicit.
 {runtimeStatus ? ` - ${runtimeStatus}` : ''}
 </Text>
 );
Expand DownExpand Up@@ -299,7 +300,7 @@
 });
};

function ResourceEntry({ entry, showRuntime }: { entry: ResourceStatusEntry; showRuntime?: boolean }) {

Check warning
on line 303
in src/cli/commands/status/command.tsx

View workflow job for this annotation
GitHub Actions/ lint
Fast refresh only works when a file only exports components. Move your component(s) to a separate file. If all exports are HOCs, add them to the `extraHOCs` option
 return (
 <Text>
 {' '}
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(status): show 'No target configured' instead of empty '(target: )' in status header#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

aidandaly24
wants to merge
1
commit into

from

 Closed


fix(status): show 'No target configured' instead of empty '(target: )' in status header
#1171
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
src/cli/commands/status/__tests__/action.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -631,6 +631,20 @@ describe('handleProjectStatus — live enrichment', () => {
 expect(evalEntry!.deploymentState).toBe('local-only');
 expect(mockGetEvaluator).not.toHaveBeenCalled();
 });

 it('returns empty targetName when no targets are configured (regression for #985)', async () => {
 const ctx = makeContext({
 awsTargets: [] as unknown as StatusContext['awsTargets'],
 deployedState: {
 targets: {},
 } as unknown as StatusContext['deployedState'],
 });

 const result = await handleProjectStatus(ctx);

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test verifies the handleProjectStatus contract (empty targetName when no targets are configured), but the code change in this PR is on the runtime-status path that calls handleRuntimeLookup. So the test doesn't actually exercise the render line you modified.
It's a fine regression guard for the default-path fix that landed in #1068, but if the goal is to lock in the behavior that this PR changes, consider adding a test for handleRuntimeLookup or a rendering test for the runtime-status header — otherwise nothing in the test suite prevents a future regression of line 113–114.
Also, minor: this test is inside describe('handleProjectStatus — live enrichment', ...) but has nothing to do with live enrichment. Consider moving it to a more appropriate describe block (e.g. the existing handleProjectStatus block that covers target resolution).
 expect(result.success).toBe(true);
 expect(result.targetName).toBe('');
 });
});

describe('buildRuntimeInvocationUrl', () => {
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/commands/status/command.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,8 @@

 render(
 <Text>
 AgentCore Status - {result.runtimeId} (target: {result.targetName})
 AgentCore Status - {result.runtimeId} (target:{' '}
 {result.targetName && result.targetName.length > 0 ? result.targetName : 'No target configured'})
@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleRuntimeLookup in action.ts returns success: false early (lines 409–414) when awsTargets is empty, and on the success path selectedTargetName = options.targetName ?? targetNames[0]! (line 416) is guaranteed to be a non-empty string because targetNames.length > 0 is required to reach this point. So on the success branch that reaches this render, result.targetName cannot actually be empty or undefined today — this guard is purely defensive against a future refactor of handleRuntimeLookup.
That's not wrong, but it contradicts the PR description, which frames this as fixing "the same latent bug for that code path." There's no latent bug here right now — the reproducer in #985 (agentcore status with no --runtime) lands in the default path at line 157, which was already fixed in #1068.
Options:
  1. Leave the guard as defense-in-depth but update the PR description (and maybe a code comment here) to say "defensive guard in case handleRuntimeLookup's contract changes" rather than claiming it fixes a latent bug.
  2. Drop this render change entirely since the state is unreachable, and just keep the regression test on handleProjectStatus.
  3. If you want the guard to mean something today, tighten RuntimeLookupResult.targetName from string | undefined to string (since the success path always provides it) — that removes the need for this check and makes the contract explicit.
 {runtimeStatus ? ` - ${runtimeStatus}` : ''}
 </Text>
 );
Expand DownExpand Up@@ -299,7 +300,7 @@
 });
};

function ResourceEntry({ entry, showRuntime }: { entry: ResourceStatusEntry; showRuntime?: boolean }) {

Check warning
on line 303
in src/cli/commands/status/command.tsx

View workflow job for this annotation
GitHub Actions/ lint
Fast refresh only works when a file only exports components. Move your component(s) to a separate file. If all exports are HOCs, add them to the `extraHOCs` option
 return (
 <Text>
 {' '}
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(status): show 'No target configured' instead of empty '(target: )' in status header#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

aidandaly24
wants to merge
1
commit into

from

 Closed


fix(status): show 'No target configured' instead of empty '(target: )' in status header
#1171
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
src/cli/commands/status/__tests__/action.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -631,6 +631,20 @@ describe('handleProjectStatus — live enrichment', () => {
 expect(evalEntry!.deploymentState).toBe('local-only');
 expect(mockGetEvaluator).not.toHaveBeenCalled();
 });

 it('returns empty targetName when no targets are configured (regression for #985)', async () => {
 const ctx = makeContext({
 awsTargets: [] as unknown as StatusContext['awsTargets'],
 deployedState: {
 targets: {},
 } as unknown as StatusContext['deployedState'],
 });

 const result = await handleProjectStatus(ctx);

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test verifies the handleProjectStatus contract (empty targetName when no targets are configured), but the code change in this PR is on the runtime-status path that calls handleRuntimeLookup. So the test doesn't actually exercise the render line you modified.
It's a fine regression guard for the default-path fix that landed in #1068, but if the goal is to lock in the behavior that this PR changes, consider adding a test for handleRuntimeLookup or a rendering test for the runtime-status header — otherwise nothing in the test suite prevents a future regression of line 113–114.
Also, minor: this test is inside describe('handleProjectStatus — live enrichment', ...) but has nothing to do with live enrichment. Consider moving it to a more appropriate describe block (e.g. the existing handleProjectStatus block that covers target resolution).
 expect(result.success).toBe(true);
 expect(result.targetName).toBe('');
 });
});

describe('buildRuntimeInvocationUrl', () => {
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/commands/status/command.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,8 @@

 render(
 <Text>
 AgentCore Status - {result.runtimeId} (target: {result.targetName})
 AgentCore Status - {result.runtimeId} (target:{' '}
 {result.targetName && result.targetName.length > 0 ? result.targetName : 'No target configured'})
@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleRuntimeLookup in action.ts returns success: false early (lines 409–414) when awsTargets is empty, and on the success path selectedTargetName = options.targetName ?? targetNames[0]! (line 416) is guaranteed to be a non-empty string because targetNames.length > 0 is required to reach this point. So on the success branch that reaches this render, result.targetName cannot actually be empty or undefined today — this guard is purely defensive against a future refactor of handleRuntimeLookup.
That's not wrong, but it contradicts the PR description, which frames this as fixing "the same latent bug for that code path." There's no latent bug here right now — the reproducer in #985 (agentcore status with no --runtime) lands in the default path at line 157, which was already fixed in #1068.
Options:
  1. Leave the guard as defense-in-depth but update the PR description (and maybe a code comment here) to say "defensive guard in case handleRuntimeLookup's contract changes" rather than claiming it fixes a latent bug.
  2. Drop this render change entirely since the state is unreachable, and just keep the regression test on handleProjectStatus.
  3. If you want the guard to mean something today, tighten RuntimeLookupResult.targetName from string | undefined to string (since the success path always provides it) — that removes the need for this check and makes the contract explicit.
 {runtimeStatus ? ` - ${runtimeStatus}` : ''}
 </Text>
 );
Expand DownExpand Up@@ -299,7 +300,7 @@
 });
};

function ResourceEntry({ entry, showRuntime }: { entry: ResourceStatusEntry; showRuntime?: boolean }) {

Check warning
on line 303
in src/cli/commands/status/command.tsx

View workflow job for this annotation
GitHub Actions/ lint
Fast refresh only works when a file only exports components. Move your component(s) to a separate file. If all exports are HOCs, add them to the `extraHOCs` option
 return (
 <Text>
 {' '}
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(status): show 'No target configured' instead of empty '(target: )' in status header#1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

aidandaly24
wants to merge
1
commit into

from

 Closed


fix(status): show 'No target configured' instead of empty '(target: )' in status header
#1171
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


14 changes: 14 additions & 0 deletions
src/cli/commands/status/__tests__/action.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -631,6 +631,20 @@ describe('handleProjectStatus — live enrichment', () => {
 expect(evalEntry!.deploymentState).toBe('local-only');
 expect(mockGetEvaluator).not.toHaveBeenCalled();
 });

 it('returns empty targetName when no targets are configured (regression for #985)', async () => {
 const ctx = makeContext({
 awsTargets: [] as unknown as StatusContext['awsTargets'],
 deployedState: {
 targets: {},
 } as unknown as StatusContext['deployedState'],
 });

 const result = await handleProjectStatus(ctx);

@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test verifies the handleProjectStatus contract (empty targetName when no targets are configured), but the code change in this PR is on the runtime-status path that calls handleRuntimeLookup. So the test doesn't actually exercise the render line you modified.
It's a fine regression guard for the default-path fix that landed in #1068, but if the goal is to lock in the behavior that this PR changes, consider adding a test for handleRuntimeLookup or a rendering test for the runtime-status header — otherwise nothing in the test suite prevents a future regression of line 113–114.
Also, minor: this test is inside describe('handleProjectStatus — live enrichment', ...) but has nothing to do with live enrichment. Consider moving it to a more appropriate describe block (e.g. the existing handleProjectStatus block that covers target resolution).
 expect(result.success).toBe(true);
 expect(result.targetName).toBe('');
 });
});

describe('buildRuntimeInvocationUrl', () => {
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/commands/status/command.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -113,7 +113,8 @@

 render(
 <Text>
 AgentCore Status - {result.runtimeId} (target: {result.targetName})
 AgentCore Status - {result.runtimeId} (target:{' '}
 {result.targetName && result.targetName.length > 0 ? result.targetName : 'No target configured'})
@agentcore-cli-automationagentcore-cli-automationMay 7, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleRuntimeLookup in action.ts returns success: false early (lines 409–414) when awsTargets is empty, and on the success path selectedTargetName = options.targetName ?? targetNames[0]! (line 416) is guaranteed to be a non-empty string because targetNames.length > 0 is required to reach this point. So on the success branch that reaches this render, result.targetName cannot actually be empty or undefined today — this guard is purely defensive against a future refactor of handleRuntimeLookup.
That's not wrong, but it contradicts the PR description, which frames this as fixing "the same latent bug for that code path." There's no latent bug here right now — the reproducer in #985 (agentcore status with no --runtime) lands in the default path at line 157, which was already fixed in #1068.
Options:
  1. Leave the guard as defense-in-depth but update the PR description (and maybe a code comment here) to say "defensive guard in case handleRuntimeLookup's contract changes" rather than claiming it fixes a latent bug.
  2. Drop this render change entirely since the state is unreachable, and just keep the regression test on handleProjectStatus.
  3. If you want the guard to mean something today, tighten RuntimeLookupResult.targetName from string | undefined to string (since the success path always provides it) — that removes the need for this check and makes the contract explicit.
 {runtimeStatus ? ` - ${runtimeStatus}` : ''}
 </Text>
 );
Expand DownExpand Up@@ -299,7 +300,7 @@
 });
};

function ResourceEntry({ entry, showRuntime }: { entry: ResourceStatusEntry; showRuntime?: boolean }) {

Check warning
on line 303
in src/cli/commands/status/command.tsx

View workflow job for this annotation
GitHub Actions/ lint
Fast refresh only works when a file only exports components. Move your component(s) to a separate file. If all exports are HOCs, add them to the `extraHOCs` option
 return (
 <Text>
 {' '}
Expand Down
Loading