Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions integ-tests/import.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
import { createTelemetryHelper, runCLI } from '../src/test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, afterEach, beforeAll, describe, expect, it } from 'vitest';

describe('import command', () => {
let testDir: string;
let projectDir: string;
const telemetry = createTelemetryHelper();

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-import-telemetry-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

const projectName = 'ImportTelemetryProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);
});

afterEach(() => {
telemetry.clearEntries();
});

afterAll(async () => {
telemetry.destroy();
await rm(testDir, { recursive: true, force: true });
});

describe('import --source', () => {
it('emits failure telemetry for nonexistent source file', async () => {
const result = await runCLI(['import', '--source', '/nonexistent/file.yaml'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import',
exit_reason: 'failure',
});
});
});

describe('import runtime', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'runtime', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.runtime',
exit_reason: 'failure',
});
});
});

describe('import memory', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'memory', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.memory',
exit_reason: 'failure',
});
});
});

describe('import evaluator', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'evaluator', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.evaluator',
exit_reason: 'failure',
});
});
});

describe('import gateway', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'gateway', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.gateway',
exit_reason: 'failure',
});
});
});
Comment thread
Hweinstock marked this conversation as resolved.

describe('import online-eval', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'online-eval', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.online-eval',
exit_reason: 'failure',
});
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,13 @@ vi.mock('../../../../lib', () => ({
this.name = 'NoProjectError';
}
},
ValidationError: class ValidationError extends Error {
constructor(msg: string) {
super(msg);
this.name = 'ValidationError';
}
},
toError: (err: unknown) => (err instanceof Error ? err : new Error(String(err))),
findConfigRoot: (...args: unknown[]) => mockFindConfigRoot(...args),
}));

Expand Down
6 changes: 3 additions & 3 deletions src/cli/commands/import/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -224,7 +224,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -238,7 +238,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand Down
54 changes: 29 additions & 25 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
import { ValidationError } from '../../../lib';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
Expand DownExpand Up@@ -71,34 +73,36 @@ export const registerImport = (program: Command) => {
return;
}

// Validate source file exists
if (!fs.existsSync(cliOptions.source)) {
console.error(`\x1b[31m[error]${reset} Source file not found: ${cliOptions.source}`);
process.exit(1);
}

const warnings: string[] = [];

const result = await handleImport({
source: cliOptions.source,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}
const result = await withCommandRunTelemetry('import', {}, async () => {
if (!fs.existsSync(cliOptions.source!)) {
return { success: false as const, error: new ValidationError(`Source file not found: ${cliOptions.source}`) };
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
const importResult = await handleImport({
source: cliOptions.source!,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
});

return importResult;
});

if (result.success) {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-evaluator.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllEvaluators,
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -143,7 +144,7 @@ export function registerImportEvaluator(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported evaluator')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportEvaluator(cliOptions);
const result = await withCommandRunTelemetry('import.evaluator', {}, () => handleImportEvaluator(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-gateway.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
listAllGateways,
} from '../../aws/agentcore-control';
import { isAccessDeniedError } from '../../errors';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { executeCdkImportPipeline } from './import-pipeline';
import {
Expand DownExpand Up@@ -667,7 +668,7 @@ export function registerImportGateway(importCmd: Command): void {
.description('Import an existing AgentCore Gateway (with targets) from your AWS account')
.option('--arn <gatewayArn>', 'Gateway ARN to import')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportGateway(cliOptions);
const result = await withCommandRunTelemetry('import.gateway', {}, () => handleImportGateway(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-memory.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { Memory } from '../../../schema';
import type { MemoryDetail, MemorySummary } from '../../aws/agentcore-control';
import { getMemoryDetail, listAllMemories } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -114,7 +115,7 @@ export function registerImportMemory(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported memory')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportMemory(cliOptions);
const result = await withCommandRunTelemetry('import.memory', {}, () => handleImportMemory(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-online-eval.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { arnPrefix } from '../../aws/partition';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, findResourceInDeployedState, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -200,7 +201,7 @@ export function registerImportOnlineEval(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported online eval config')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportOnlineEval(cliOptions);
const result = await withCommandRunTelemetry('import.online-eval', {}, () => handleImportOnlineEval(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-runtime.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { AgentEnvSpec } from '../../../schema';
import type { AgentRuntimeDetail, AgentRuntimeSummary } from '../../aws/agentcore-control';
import { getAgentRuntimeDetail, listAllAgentRuntimes } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { copyAgentSource, failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -211,7 +212,7 @@ export function registerImportRuntime(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported runtime')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: RuntimeImportOptions) => {
const result = await handleImportRuntime(cliOptions);
const result = await withCommandRunTelemetry('import.runtime', {}, () => handleImportRuntime(cliOptions));

if (result.success) {
console.log('');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions integ-tests/import.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
import { createTelemetryHelper, runCLI } from '../src/test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, afterEach, beforeAll, describe, expect, it } from 'vitest';

describe('import command', () => {
let testDir: string;
let projectDir: string;
const telemetry = createTelemetryHelper();

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-import-telemetry-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

const projectName = 'ImportTelemetryProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);
});

afterEach(() => {
telemetry.clearEntries();
});

afterAll(async () => {
telemetry.destroy();
await rm(testDir, { recursive: true, force: true });
});

describe('import --source', () => {
it('emits failure telemetry for nonexistent source file', async () => {
const result = await runCLI(['import', '--source', '/nonexistent/file.yaml'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import',
exit_reason: 'failure',
});
});
});

describe('import runtime', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'runtime', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.runtime',
exit_reason: 'failure',
});
});
});

describe('import memory', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'memory', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.memory',
exit_reason: 'failure',
});
});
});

describe('import evaluator', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'evaluator', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.evaluator',
exit_reason: 'failure',
});
});
});

describe('import gateway', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'gateway', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.gateway',
exit_reason: 'failure',
});
});
});
Comment thread
Hweinstock marked this conversation as resolved.

describe('import online-eval', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'online-eval', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.online-eval',
exit_reason: 'failure',
});
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,13 @@ vi.mock('../../../../lib', () => ({
this.name = 'NoProjectError';
}
},
ValidationError: class ValidationError extends Error {
constructor(msg: string) {
super(msg);
this.name = 'ValidationError';
}
},
toError: (err: unknown) => (err instanceof Error ? err : new Error(String(err))),
findConfigRoot: (...args: unknown[]) => mockFindConfigRoot(...args),
}));

Expand Down
6 changes: 3 additions & 3 deletions src/cli/commands/import/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -224,7 +224,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -238,7 +238,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand Down
54 changes: 29 additions & 25 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
import { ValidationError } from '../../../lib';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
Expand DownExpand Up@@ -71,34 +73,36 @@ export const registerImport = (program: Command) => {
return;
}

// Validate source file exists
if (!fs.existsSync(cliOptions.source)) {
console.error(`\x1b[31m[error]${reset} Source file not found: ${cliOptions.source}`);
process.exit(1);
}

const warnings: string[] = [];

const result = await handleImport({
source: cliOptions.source,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}
const result = await withCommandRunTelemetry('import', {}, async () => {
if (!fs.existsSync(cliOptions.source!)) {
return { success: false as const, error: new ValidationError(`Source file not found: ${cliOptions.source}`) };
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
const importResult = await handleImport({
source: cliOptions.source!,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
});

return importResult;
});

if (result.success) {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-evaluator.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllEvaluators,
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -143,7 +144,7 @@ export function registerImportEvaluator(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported evaluator')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportEvaluator(cliOptions);
const result = await withCommandRunTelemetry('import.evaluator', {}, () => handleImportEvaluator(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-gateway.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
listAllGateways,
} from '../../aws/agentcore-control';
import { isAccessDeniedError } from '../../errors';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { executeCdkImportPipeline } from './import-pipeline';
import {
Expand DownExpand Up@@ -667,7 +668,7 @@ export function registerImportGateway(importCmd: Command): void {
.description('Import an existing AgentCore Gateway (with targets) from your AWS account')
.option('--arn <gatewayArn>', 'Gateway ARN to import')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportGateway(cliOptions);
const result = await withCommandRunTelemetry('import.gateway', {}, () => handleImportGateway(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-memory.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { Memory } from '../../../schema';
import type { MemoryDetail, MemorySummary } from '../../aws/agentcore-control';
import { getMemoryDetail, listAllMemories } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -114,7 +115,7 @@ export function registerImportMemory(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported memory')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportMemory(cliOptions);
const result = await withCommandRunTelemetry('import.memory', {}, () => handleImportMemory(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-online-eval.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { arnPrefix } from '../../aws/partition';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, findResourceInDeployedState, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -200,7 +201,7 @@ export function registerImportOnlineEval(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported online eval config')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportOnlineEval(cliOptions);
const result = await withCommandRunTelemetry('import.online-eval', {}, () => handleImportOnlineEval(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-runtime.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { AgentEnvSpec } from '../../../schema';
import type { AgentRuntimeDetail, AgentRuntimeSummary } from '../../aws/agentcore-control';
import { getAgentRuntimeDetail, listAllAgentRuntimes } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { copyAgentSource, failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -211,7 +212,7 @@ export function registerImportRuntime(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported runtime')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: RuntimeImportOptions) => {
const result = await handleImportRuntime(cliOptions);
const result = await withCommandRunTelemetry('import.runtime', {}, () => handleImportRuntime(cliOptions));

if (result.success) {
console.log('');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions integ-tests/import.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
import { createTelemetryHelper, runCLI } from '../src/test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, afterEach, beforeAll, describe, expect, it } from 'vitest';

describe('import command', () => {
let testDir: string;
let projectDir: string;
const telemetry = createTelemetryHelper();

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-import-telemetry-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

const projectName = 'ImportTelemetryProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);
});

afterEach(() => {
telemetry.clearEntries();
});

afterAll(async () => {
telemetry.destroy();
await rm(testDir, { recursive: true, force: true });
});

describe('import --source', () => {
it('emits failure telemetry for nonexistent source file', async () => {
const result = await runCLI(['import', '--source', '/nonexistent/file.yaml'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import',
exit_reason: 'failure',
});
});
});

describe('import runtime', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'runtime', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.runtime',
exit_reason: 'failure',
});
});
});

describe('import memory', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'memory', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.memory',
exit_reason: 'failure',
});
});
});

describe('import evaluator', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'evaluator', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.evaluator',
exit_reason: 'failure',
});
});
});

describe('import gateway', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'gateway', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.gateway',
exit_reason: 'failure',
});
});
});
Comment thread
Hweinstock marked this conversation as resolved.

describe('import online-eval', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'online-eval', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.online-eval',
exit_reason: 'failure',
});
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,13 @@ vi.mock('../../../../lib', () => ({
this.name = 'NoProjectError';
}
},
ValidationError: class ValidationError extends Error {
constructor(msg: string) {
super(msg);
this.name = 'ValidationError';
}
},
toError: (err: unknown) => (err instanceof Error ? err : new Error(String(err))),
findConfigRoot: (...args: unknown[]) => mockFindConfigRoot(...args),
}));

Expand Down
6 changes: 3 additions & 3 deletions src/cli/commands/import/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -224,7 +224,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -238,7 +238,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand Down
54 changes: 29 additions & 25 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
import { ValidationError } from '../../../lib';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
Expand DownExpand Up@@ -71,34 +73,36 @@ export const registerImport = (program: Command) => {
return;
}

// Validate source file exists
if (!fs.existsSync(cliOptions.source)) {
console.error(`\x1b[31m[error]${reset} Source file not found: ${cliOptions.source}`);
process.exit(1);
}

const warnings: string[] = [];

const result = await handleImport({
source: cliOptions.source,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}
const result = await withCommandRunTelemetry('import', {}, async () => {
if (!fs.existsSync(cliOptions.source!)) {
return { success: false as const, error: new ValidationError(`Source file not found: ${cliOptions.source}`) };
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
const importResult = await handleImport({
source: cliOptions.source!,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
});

return importResult;
});

if (result.success) {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-evaluator.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllEvaluators,
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -143,7 +144,7 @@ export function registerImportEvaluator(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported evaluator')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportEvaluator(cliOptions);
const result = await withCommandRunTelemetry('import.evaluator', {}, () => handleImportEvaluator(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-gateway.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
listAllGateways,
} from '../../aws/agentcore-control';
import { isAccessDeniedError } from '../../errors';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { executeCdkImportPipeline } from './import-pipeline';
import {
Expand DownExpand Up@@ -667,7 +668,7 @@ export function registerImportGateway(importCmd: Command): void {
.description('Import an existing AgentCore Gateway (with targets) from your AWS account')
.option('--arn <gatewayArn>', 'Gateway ARN to import')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportGateway(cliOptions);
const result = await withCommandRunTelemetry('import.gateway', {}, () => handleImportGateway(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-memory.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { Memory } from '../../../schema';
import type { MemoryDetail, MemorySummary } from '../../aws/agentcore-control';
import { getMemoryDetail, listAllMemories } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -114,7 +115,7 @@ export function registerImportMemory(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported memory')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportMemory(cliOptions);
const result = await withCommandRunTelemetry('import.memory', {}, () => handleImportMemory(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-online-eval.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { arnPrefix } from '../../aws/partition';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, findResourceInDeployedState, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -200,7 +201,7 @@ export function registerImportOnlineEval(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported online eval config')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportOnlineEval(cliOptions);
const result = await withCommandRunTelemetry('import.online-eval', {}, () => handleImportOnlineEval(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-runtime.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { AgentEnvSpec } from '../../../schema';
import type { AgentRuntimeDetail, AgentRuntimeSummary } from '../../aws/agentcore-control';
import { getAgentRuntimeDetail, listAllAgentRuntimes } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { copyAgentSource, failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -211,7 +212,7 @@ export function registerImportRuntime(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported runtime')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: RuntimeImportOptions) => {
const result = await handleImportRuntime(cliOptions);
const result = await withCommandRunTelemetry('import.runtime', {}, () => handleImportRuntime(cliOptions));

if (result.success) {
console.log('');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions integ-tests/import.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
import { createTelemetryHelper, runCLI } from '../src/test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, afterEach, beforeAll, describe, expect, it } from 'vitest';

describe('import command', () => {
let testDir: string;
let projectDir: string;
const telemetry = createTelemetryHelper();

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-import-telemetry-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

const projectName = 'ImportTelemetryProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);
});

afterEach(() => {
telemetry.clearEntries();
});

afterAll(async () => {
telemetry.destroy();
await rm(testDir, { recursive: true, force: true });
});

describe('import --source', () => {
it('emits failure telemetry for nonexistent source file', async () => {
const result = await runCLI(['import', '--source', '/nonexistent/file.yaml'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import',
exit_reason: 'failure',
});
});
});

describe('import runtime', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'runtime', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.runtime',
exit_reason: 'failure',
});
});
});

describe('import memory', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'memory', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.memory',
exit_reason: 'failure',
});
});
});

describe('import evaluator', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'evaluator', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.evaluator',
exit_reason: 'failure',
});
});
});

describe('import gateway', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'gateway', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.gateway',
exit_reason: 'failure',
});
});
});
Comment thread
Hweinstock marked this conversation as resolved.

describe('import online-eval', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'online-eval', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.online-eval',
exit_reason: 'failure',
});
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,13 @@ vi.mock('../../../../lib', () => ({
this.name = 'NoProjectError';
}
},
ValidationError: class ValidationError extends Error {
constructor(msg: string) {
super(msg);
this.name = 'ValidationError';
}
},
toError: (err: unknown) => (err instanceof Error ? err : new Error(String(err))),
findConfigRoot: (...args: unknown[]) => mockFindConfigRoot(...args),
}));

Expand Down
6 changes: 3 additions & 3 deletions src/cli/commands/import/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -224,7 +224,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -238,7 +238,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand Down
54 changes: 29 additions & 25 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
import { ValidationError } from '../../../lib';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
Expand DownExpand Up@@ -71,34 +73,36 @@ export const registerImport = (program: Command) => {
return;
}

// Validate source file exists
if (!fs.existsSync(cliOptions.source)) {
console.error(`\x1b[31m[error]${reset} Source file not found: ${cliOptions.source}`);
process.exit(1);
}

const warnings: string[] = [];

const result = await handleImport({
source: cliOptions.source,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}
const result = await withCommandRunTelemetry('import', {}, async () => {
if (!fs.existsSync(cliOptions.source!)) {
return { success: false as const, error: new ValidationError(`Source file not found: ${cliOptions.source}`) };
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
const importResult = await handleImport({
source: cliOptions.source!,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
});

return importResult;
});

if (result.success) {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-evaluator.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllEvaluators,
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -143,7 +144,7 @@ export function registerImportEvaluator(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported evaluator')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportEvaluator(cliOptions);
const result = await withCommandRunTelemetry('import.evaluator', {}, () => handleImportEvaluator(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-gateway.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
listAllGateways,
} from '../../aws/agentcore-control';
import { isAccessDeniedError } from '../../errors';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { executeCdkImportPipeline } from './import-pipeline';
import {
Expand DownExpand Up@@ -667,7 +668,7 @@ export function registerImportGateway(importCmd: Command): void {
.description('Import an existing AgentCore Gateway (with targets) from your AWS account')
.option('--arn <gatewayArn>', 'Gateway ARN to import')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportGateway(cliOptions);
const result = await withCommandRunTelemetry('import.gateway', {}, () => handleImportGateway(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-memory.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { Memory } from '../../../schema';
import type { MemoryDetail, MemorySummary } from '../../aws/agentcore-control';
import { getMemoryDetail, listAllMemories } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -114,7 +115,7 @@ export function registerImportMemory(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported memory')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportMemory(cliOptions);
const result = await withCommandRunTelemetry('import.memory', {}, () => handleImportMemory(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-online-eval.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { arnPrefix } from '../../aws/partition';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, findResourceInDeployedState, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -200,7 +201,7 @@ export function registerImportOnlineEval(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported online eval config')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportOnlineEval(cliOptions);
const result = await withCommandRunTelemetry('import.online-eval', {}, () => handleImportOnlineEval(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-runtime.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { AgentEnvSpec } from '../../../schema';
import type { AgentRuntimeDetail, AgentRuntimeSummary } from '../../aws/agentcore-control';
import { getAgentRuntimeDetail, listAllAgentRuntimes } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { copyAgentSource, failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -211,7 +212,7 @@ export function registerImportRuntime(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported runtime')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: RuntimeImportOptions) => {
const result = await handleImportRuntime(cliOptions);
const result = await withCommandRunTelemetry('import.runtime', {}, () => handleImportRuntime(cliOptions));

if (result.success) {
console.log('');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions integ-tests/import.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
import { createTelemetryHelper, runCLI } from '../src/test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, afterEach, beforeAll, describe, expect, it } from 'vitest';

describe('import command', () => {
let testDir: string;
let projectDir: string;
const telemetry = createTelemetryHelper();

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-import-telemetry-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

const projectName = 'ImportTelemetryProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);
});

afterEach(() => {
telemetry.clearEntries();
});

afterAll(async () => {
telemetry.destroy();
await rm(testDir, { recursive: true, force: true });
});

describe('import --source', () => {
it('emits failure telemetry for nonexistent source file', async () => {
const result = await runCLI(['import', '--source', '/nonexistent/file.yaml'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import',
exit_reason: 'failure',
});
});
});

describe('import runtime', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'runtime', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.runtime',
exit_reason: 'failure',
});
});
});

describe('import memory', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'memory', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.memory',
exit_reason: 'failure',
});
});
});

describe('import evaluator', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'evaluator', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.evaluator',
exit_reason: 'failure',
});
});
});

describe('import gateway', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'gateway', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.gateway',
exit_reason: 'failure',
});
});
});
Comment thread
Hweinstock marked this conversation as resolved.

describe('import online-eval', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'online-eval', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.online-eval',
exit_reason: 'failure',
});
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,13 @@ vi.mock('../../../../lib', () => ({
this.name = 'NoProjectError';
}
},
ValidationError: class ValidationError extends Error {
constructor(msg: string) {
super(msg);
this.name = 'ValidationError';
}
},
toError: (err: unknown) => (err instanceof Error ? err : new Error(String(err))),
findConfigRoot: (...args: unknown[]) => mockFindConfigRoot(...args),
}));

Expand Down
6 changes: 3 additions & 3 deletions src/cli/commands/import/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -224,7 +224,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -238,7 +238,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand Down
54 changes: 29 additions & 25 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
import { ValidationError } from '../../../lib';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
Expand DownExpand Up@@ -71,34 +73,36 @@ export const registerImport = (program: Command) => {
return;
}

// Validate source file exists
if (!fs.existsSync(cliOptions.source)) {
console.error(`\x1b[31m[error]${reset} Source file not found: ${cliOptions.source}`);
process.exit(1);
}

const warnings: string[] = [];

const result = await handleImport({
source: cliOptions.source,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}
const result = await withCommandRunTelemetry('import', {}, async () => {
if (!fs.existsSync(cliOptions.source!)) {
return { success: false as const, error: new ValidationError(`Source file not found: ${cliOptions.source}`) };
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
const importResult = await handleImport({
source: cliOptions.source!,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
});

return importResult;
});

if (result.success) {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-evaluator.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllEvaluators,
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -143,7 +144,7 @@ export function registerImportEvaluator(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported evaluator')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportEvaluator(cliOptions);
const result = await withCommandRunTelemetry('import.evaluator', {}, () => handleImportEvaluator(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-gateway.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
listAllGateways,
} from '../../aws/agentcore-control';
import { isAccessDeniedError } from '../../errors';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { executeCdkImportPipeline } from './import-pipeline';
import {
Expand DownExpand Up@@ -667,7 +668,7 @@ export function registerImportGateway(importCmd: Command): void {
.description('Import an existing AgentCore Gateway (with targets) from your AWS account')
.option('--arn <gatewayArn>', 'Gateway ARN to import')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportGateway(cliOptions);
const result = await withCommandRunTelemetry('import.gateway', {}, () => handleImportGateway(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-memory.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { Memory } from '../../../schema';
import type { MemoryDetail, MemorySummary } from '../../aws/agentcore-control';
import { getMemoryDetail, listAllMemories } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -114,7 +115,7 @@ export function registerImportMemory(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported memory')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportMemory(cliOptions);
const result = await withCommandRunTelemetry('import.memory', {}, () => handleImportMemory(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-online-eval.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { arnPrefix } from '../../aws/partition';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, findResourceInDeployedState, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -200,7 +201,7 @@ export function registerImportOnlineEval(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported online eval config')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportOnlineEval(cliOptions);
const result = await withCommandRunTelemetry('import.online-eval', {}, () => handleImportOnlineEval(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-runtime.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { AgentEnvSpec } from '../../../schema';
import type { AgentRuntimeDetail, AgentRuntimeSummary } from '../../aws/agentcore-control';
import { getAgentRuntimeDetail, listAllAgentRuntimes } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { copyAgentSource, failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -211,7 +212,7 @@ export function registerImportRuntime(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported runtime')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: RuntimeImportOptions) => {
const result = await handleImportRuntime(cliOptions);
const result = await withCommandRunTelemetry('import.runtime', {}, () => handleImportRuntime(cliOptions));

if (result.success) {
console.log('');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions integ-tests/import.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
import { createTelemetryHelper, runCLI } from '../src/test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, afterEach, beforeAll, describe, expect, it } from 'vitest';

describe('import command', () => {
let testDir: string;
let projectDir: string;
const telemetry = createTelemetryHelper();

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-import-telemetry-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

const projectName = 'ImportTelemetryProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);
});

afterEach(() => {
telemetry.clearEntries();
});

afterAll(async () => {
telemetry.destroy();
await rm(testDir, { recursive: true, force: true });
});

describe('import --source', () => {
it('emits failure telemetry for nonexistent source file', async () => {
const result = await runCLI(['import', '--source', '/nonexistent/file.yaml'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import',
exit_reason: 'failure',
});
});
});

describe('import runtime', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'runtime', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.runtime',
exit_reason: 'failure',
});
});
});

describe('import memory', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'memory', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.memory',
exit_reason: 'failure',
});
});
});

describe('import evaluator', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'evaluator', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.evaluator',
exit_reason: 'failure',
});
});
});

describe('import gateway', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'gateway', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.gateway',
exit_reason: 'failure',
});
});
});
Comment thread
Hweinstock marked this conversation as resolved.

describe('import online-eval', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'online-eval', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.online-eval',
exit_reason: 'failure',
});
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,13 @@ vi.mock('../../../../lib', () => ({
this.name = 'NoProjectError';
}
},
ValidationError: class ValidationError extends Error {
constructor(msg: string) {
super(msg);
this.name = 'ValidationError';
}
},
toError: (err: unknown) => (err instanceof Error ? err : new Error(String(err))),
findConfigRoot: (...args: unknown[]) => mockFindConfigRoot(...args),
}));

Expand Down
6 changes: 3 additions & 3 deletions src/cli/commands/import/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -224,7 +224,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -238,7 +238,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand Down
54 changes: 29 additions & 25 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
import { ValidationError } from '../../../lib';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
Expand DownExpand Up@@ -71,34 +73,36 @@ export const registerImport = (program: Command) => {
return;
}

// Validate source file exists
if (!fs.existsSync(cliOptions.source)) {
console.error(`\x1b[31m[error]${reset} Source file not found: ${cliOptions.source}`);
process.exit(1);
}

const warnings: string[] = [];

const result = await handleImport({
source: cliOptions.source,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}
const result = await withCommandRunTelemetry('import', {}, async () => {
if (!fs.existsSync(cliOptions.source!)) {
return { success: false as const, error: new ValidationError(`Source file not found: ${cliOptions.source}`) };
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
const importResult = await handleImport({
source: cliOptions.source!,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
});

return importResult;
});

if (result.success) {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-evaluator.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllEvaluators,
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -143,7 +144,7 @@ export function registerImportEvaluator(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported evaluator')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportEvaluator(cliOptions);
const result = await withCommandRunTelemetry('import.evaluator', {}, () => handleImportEvaluator(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-gateway.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
listAllGateways,
} from '../../aws/agentcore-control';
import { isAccessDeniedError } from '../../errors';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { executeCdkImportPipeline } from './import-pipeline';
import {
Expand DownExpand Up@@ -667,7 +668,7 @@ export function registerImportGateway(importCmd: Command): void {
.description('Import an existing AgentCore Gateway (with targets) from your AWS account')
.option('--arn <gatewayArn>', 'Gateway ARN to import')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportGateway(cliOptions);
const result = await withCommandRunTelemetry('import.gateway', {}, () => handleImportGateway(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-memory.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { Memory } from '../../../schema';
import type { MemoryDetail, MemorySummary } from '../../aws/agentcore-control';
import { getMemoryDetail, listAllMemories } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -114,7 +115,7 @@ export function registerImportMemory(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported memory')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportMemory(cliOptions);
const result = await withCommandRunTelemetry('import.memory', {}, () => handleImportMemory(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-online-eval.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { arnPrefix } from '../../aws/partition';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, findResourceInDeployedState, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -200,7 +201,7 @@ export function registerImportOnlineEval(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported online eval config')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportOnlineEval(cliOptions);
const result = await withCommandRunTelemetry('import.online-eval', {}, () => handleImportOnlineEval(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-runtime.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { AgentEnvSpec } from '../../../schema';
import type { AgentRuntimeDetail, AgentRuntimeSummary } from '../../aws/agentcore-control';
import { getAgentRuntimeDetail, listAllAgentRuntimes } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { copyAgentSource, failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -211,7 +212,7 @@ export function registerImportRuntime(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported runtime')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: RuntimeImportOptions) => {
const result = await handleImportRuntime(cliOptions);
const result = await withCommandRunTelemetry('import.runtime', {}, () => handleImportRuntime(cliOptions));

if (result.success) {
console.log('');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions integ-tests/import.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
import { createTelemetryHelper, runCLI } from '../src/test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, afterEach, beforeAll, describe, expect, it } from 'vitest';

describe('import command', () => {
let testDir: string;
let projectDir: string;
const telemetry = createTelemetryHelper();

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-import-telemetry-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

const projectName = 'ImportTelemetryProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);
});

afterEach(() => {
telemetry.clearEntries();
});

afterAll(async () => {
telemetry.destroy();
await rm(testDir, { recursive: true, force: true });
});

describe('import --source', () => {
it('emits failure telemetry for nonexistent source file', async () => {
const result = await runCLI(['import', '--source', '/nonexistent/file.yaml'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import',
exit_reason: 'failure',
});
});
});

describe('import runtime', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'runtime', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.runtime',
exit_reason: 'failure',
});
});
});

describe('import memory', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'memory', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.memory',
exit_reason: 'failure',
});
});
});

describe('import evaluator', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'evaluator', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.evaluator',
exit_reason: 'failure',
});
});
});

describe('import gateway', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'gateway', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.gateway',
exit_reason: 'failure',
});
});
});
Comment thread
Hweinstock marked this conversation as resolved.

describe('import online-eval', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'online-eval', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.online-eval',
exit_reason: 'failure',
});
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,13 @@ vi.mock('../../../../lib', () => ({
this.name = 'NoProjectError';
}
},
ValidationError: class ValidationError extends Error {
constructor(msg: string) {
super(msg);
this.name = 'ValidationError';
}
},
toError: (err: unknown) => (err instanceof Error ? err : new Error(String(err))),
findConfigRoot: (...args: unknown[]) => mockFindConfigRoot(...args),
}));

Expand Down
6 changes: 3 additions & 3 deletions src/cli/commands/import/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -224,7 +224,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -238,7 +238,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand Down
54 changes: 29 additions & 25 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
import { ValidationError } from '../../../lib';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
Expand DownExpand Up@@ -71,34 +73,36 @@ export const registerImport = (program: Command) => {
return;
}

// Validate source file exists
if (!fs.existsSync(cliOptions.source)) {
console.error(`\x1b[31m[error]${reset} Source file not found: ${cliOptions.source}`);
process.exit(1);
}

const warnings: string[] = [];

const result = await handleImport({
source: cliOptions.source,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}
const result = await withCommandRunTelemetry('import', {}, async () => {
if (!fs.existsSync(cliOptions.source!)) {
return { success: false as const, error: new ValidationError(`Source file not found: ${cliOptions.source}`) };
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
const importResult = await handleImport({
source: cliOptions.source!,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
});

return importResult;
});

if (result.success) {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-evaluator.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllEvaluators,
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -143,7 +144,7 @@ export function registerImportEvaluator(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported evaluator')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportEvaluator(cliOptions);
const result = await withCommandRunTelemetry('import.evaluator', {}, () => handleImportEvaluator(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-gateway.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
listAllGateways,
} from '../../aws/agentcore-control';
import { isAccessDeniedError } from '../../errors';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { executeCdkImportPipeline } from './import-pipeline';
import {
Expand DownExpand Up@@ -667,7 +668,7 @@ export function registerImportGateway(importCmd: Command): void {
.description('Import an existing AgentCore Gateway (with targets) from your AWS account')
.option('--arn <gatewayArn>', 'Gateway ARN to import')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportGateway(cliOptions);
const result = await withCommandRunTelemetry('import.gateway', {}, () => handleImportGateway(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-memory.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { Memory } from '../../../schema';
import type { MemoryDetail, MemorySummary } from '../../aws/agentcore-control';
import { getMemoryDetail, listAllMemories } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -114,7 +115,7 @@ export function registerImportMemory(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported memory')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportMemory(cliOptions);
const result = await withCommandRunTelemetry('import.memory', {}, () => handleImportMemory(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-online-eval.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { arnPrefix } from '../../aws/partition';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, findResourceInDeployedState, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -200,7 +201,7 @@ export function registerImportOnlineEval(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported online eval config')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportOnlineEval(cliOptions);
const result = await withCommandRunTelemetry('import.online-eval', {}, () => handleImportOnlineEval(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-runtime.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { AgentEnvSpec } from '../../../schema';
import type { AgentRuntimeDetail, AgentRuntimeSummary } from '../../aws/agentcore-control';
import { getAgentRuntimeDetail, listAllAgentRuntimes } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { copyAgentSource, failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -211,7 +212,7 @@ export function registerImportRuntime(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported runtime')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: RuntimeImportOptions) => {
const result = await handleImportRuntime(cliOptions);
const result = await withCommandRunTelemetry('import.runtime', {}, () => handleImportRuntime(cliOptions));

if (result.success) {
console.log('');
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions integ-tests/import.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
import { createTelemetryHelper, runCLI } from '../src/test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, afterEach, beforeAll, describe, expect, it } from 'vitest';

describe('import command', () => {
let testDir: string;
let projectDir: string;
const telemetry = createTelemetryHelper();

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-import-telemetry-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

const projectName = 'ImportTelemetryProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);
});

afterEach(() => {
telemetry.clearEntries();
});

afterAll(async () => {
telemetry.destroy();
await rm(testDir, { recursive: true, force: true });
});

describe('import --source', () => {
it('emits failure telemetry for nonexistent source file', async () => {
const result = await runCLI(['import', '--source', '/nonexistent/file.yaml'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import',
exit_reason: 'failure',
});
});
});

describe('import runtime', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'runtime', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.runtime',
exit_reason: 'failure',
});
});
});

describe('import memory', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'memory', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.memory',
exit_reason: 'failure',
});
});
});

describe('import evaluator', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'evaluator', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.evaluator',
exit_reason: 'failure',
});
});
});

describe('import gateway', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'gateway', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.gateway',
exit_reason: 'failure',
});
});
});
Comment thread
Hweinstock marked this conversation as resolved.

describe('import online-eval', () => {
it('emits failure telemetry for invalid ARN', async () => {
const result = await runCLI(['import', 'online-eval', '--arn', 'invalid-arn'], projectDir, {
env: telemetry.env,
});
expect(result.exitCode).toBe(1);
telemetry.assertMetricEmitted({
command: 'import.online-eval',
exit_reason: 'failure',
});
});
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,13 @@ vi.mock('../../../../lib', () => ({
this.name = 'NoProjectError';
}
},
ValidationError: class ValidationError extends Error {
constructor(msg: string) {
super(msg);
this.name = 'ValidationError';
}
},
toError: (err: unknown) => (err instanceof Error ? err : new Error(String(err))),
findConfigRoot: (...args: unknown[]) => mockFindConfigRoot(...args),
}));

Expand Down
6 changes: 3 additions & 3 deletions src/cli/commands/import/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -224,7 +224,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand All@@ -238,7 +238,7 @@ export async function handleImport(options: ImportOptions): Promise<ImportResult
logger.finalize(false);
return {
success: false,
error: new Error(error),
error: new ValidationError(error),
logPath: logger.getRelativeLogPath(),
};
}
Expand Down
54 changes: 29 additions & 25 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
import { ValidationError } from '../../../lib';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
Expand DownExpand Up@@ -71,34 +73,36 @@ export const registerImport = (program: Command) => {
return;
}

// Validate source file exists
if (!fs.existsSync(cliOptions.source)) {
console.error(`\x1b[31m[error]${reset} Source file not found: ${cliOptions.source}`);
process.exit(1);
}

const warnings: string[] = [];

const result = await handleImport({
source: cliOptions.source,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}
const result = await withCommandRunTelemetry('import', {}, async () => {
if (!fs.existsSync(cliOptions.source!)) {
return { success: false as const, error: new ValidationError(`Source file not found: ${cliOptions.source}`) };
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
const importResult = await handleImport({
source: cliOptions.source!,
target: cliOptions.target,
yes: cliOptions.yes,
onProgress: (message: string) => {
// Collect warnings for end-of-output display
if (message.includes('Warning') || message.includes('\x1b[33m')) {
warnings.push(message);
return;
}

// Skipped items shown dimmed
if (message.startsWith('Skipping')) {
console.log(`${dim}[skip]${reset} ${message}`);
return;
}

// Normal progress steps shown as [done]
console.log(`${green}[done]${reset} ${message}`);
},
});

return importResult;
});

if (result.success) {
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-evaluator.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllEvaluators,
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -143,7 +144,7 @@ export function registerImportEvaluator(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported evaluator')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportEvaluator(cliOptions);
const result = await withCommandRunTelemetry('import.evaluator', {}, () => handleImportEvaluator(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-gateway.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
listAllGateways,
} from '../../aws/agentcore-control';
import { isAccessDeniedError } from '../../errors';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { executeCdkImportPipeline } from './import-pipeline';
import {
Expand DownExpand Up@@ -667,7 +668,7 @@ export function registerImportGateway(importCmd: Command): void {
.description('Import an existing AgentCore Gateway (with targets) from your AWS account')
.option('--arn <gatewayArn>', 'Gateway ARN to import')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportGateway(cliOptions);
const result = await withCommandRunTelemetry('import.gateway', {}, () => handleImportGateway(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-memory.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { Memory } from '../../../schema';
import type { MemoryDetail, MemorySummary } from '../../aws/agentcore-control';
import { getMemoryDetail, listAllMemories } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -114,7 +115,7 @@ export function registerImportMemory(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported memory')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportMemory(cliOptions);
const result = await withCommandRunTelemetry('import.memory', {}, () => handleImportMemory(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-online-eval.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import {
listAllOnlineEvaluationConfigs,
} from '../../aws/agentcore-control';
import { arnPrefix } from '../../aws/partition';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { failResult, findResourceInDeployedState, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -200,7 +201,7 @@ export function registerImportOnlineEval(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported online eval config')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: ImportResourceOptions) => {
const result = await handleImportOnlineEval(cliOptions);
const result = await withCommandRunTelemetry('import.online-eval', {}, () => handleImportOnlineEval(cliOptions));

if (result.success) {
console.log('');
Expand Down
3 changes: 2 additions & 1 deletion src/cli/commands/import/import-runtime.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { AgentEnvSpec } from '../../../schema';
import type { AgentRuntimeDetail, AgentRuntimeSummary } from '../../aws/agentcore-control';
import { getAgentRuntimeDetail, listAllAgentRuntimes } from '../../aws/agentcore-control';
import { withCommandRunTelemetry } from '../../telemetry/cli-command-run.js';
import { ANSI } from './constants';
import { copyAgentSource, failResult, parseAndValidateArn } from './import-utils';
import { executeResourceImport } from './resource-import';
Expand DownExpand Up@@ -211,7 +212,7 @@ export function registerImportRuntime(importCmd: Command): void {
.option('--name <name>', 'Local name for the imported runtime')
.option('-y, --yes', 'Auto-confirm prompts')
.action(async (cliOptions: RuntimeImportOptions) => {
const result = await handleImportRuntime(cliOptions);
const result = await withCommandRunTelemetry('import.runtime', {}, () => handleImportRuntime(cliOptions));

if (result.success) {
console.log('');
Expand Down
Loading
Loading