fix(packaging): preserve top-level agentcore Python package in zip

[NishchayMahor]

Summary

Restores the state from #1015. The CONFIG_DIR check in the zip-stage collectFiles / collectFilesSync helpers was reintroduced by the #1068 merge and is currently on main. The zip stage runs against the staging directory, not the project root, and the project config dir is already filtered out at the copy stage, so the check is both unnecessary and harmful: any Python package whose top-level module is named agentcore gets silently dropped from the deployment artifact.

What changed

• Drop the CONFIG_DIR check from collectFiles and collectFilesSync in src/lib/packaging/helpers.ts.
• Drop the now-unused rootDir parameter from both helpers and from the two internal call sites in createZipFromDir / createZipFromDirSync.
• Copy-stage exclusion (the agentcore/ config dir check in copyEntry) is left as-is, since that one is correct.
• Update the existing zip-stage tests under "issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843" so they no longer assert the broken behavior, and add a new test block under issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 that builds a staging fixture with a top-level agentcore/ Python package and asserts it is preserved in both the async and sync zip paths.

Test plan

• npx vitest run src/lib/packaging/__tests__/helpers.test.ts reports 39 passed (including the 2 new issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 cases and the unchanged issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843 copy-stage cases).
• npm run typecheck clean.
• npx eslint src/lib/packaging/helpers.ts src/lib/packaging/__tests__/helpers.test.ts clean.
• npx prettier --check on both files clean.

Closes#1408

[aidandaly24]

Thanks for your contribution.

[NishchayMahor]

Summary

Restores the state from #1015. The CONFIG_DIR check in the zip-stage collectFiles / collectFilesSync helpers was reintroduced by the #1068 merge and is currently on main. The zip stage runs against the staging directory, not the project root, and the project config dir is already filtered out at the copy stage, so the check is both unnecessary and harmful: any Python package whose top-level module is named agentcore gets silently dropped from the deployment artifact.

What changed

• Drop the CONFIG_DIR check from collectFiles and collectFilesSync in src/lib/packaging/helpers.ts.
• Drop the now-unused rootDir parameter from both helpers and from the two internal call sites in createZipFromDir / createZipFromDirSync.
• Copy-stage exclusion (the agentcore/ config dir check in copyEntry) is left as-is, since that one is correct.
• Update the existing zip-stage tests under "issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843" so they no longer assert the broken behavior, and add a new test block under issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 that builds a staging fixture with a top-level agentcore/ Python package and asserts it is preserved in both the async and sync zip paths.

Test plan

• npx vitest run src/lib/packaging/__tests__/helpers.test.ts reports 39 passed (including the 2 new issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 cases and the unchanged issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843 copy-stage cases).
• npm run typecheck clean.
• npx eslint src/lib/packaging/helpers.ts src/lib/packaging/__tests__/helpers.test.ts clean.
• npx prettier --check on both files clean.

Closes#1408

[aidandaly24]

Thanks for your contribution.

[NishchayMahor]

Summary

Restores the state from #1015. The CONFIG_DIR check in the zip-stage collectFiles / collectFilesSync helpers was reintroduced by the #1068 merge and is currently on main. The zip stage runs against the staging directory, not the project root, and the project config dir is already filtered out at the copy stage, so the check is both unnecessary and harmful: any Python package whose top-level module is named agentcore gets silently dropped from the deployment artifact.

What changed

• Drop the CONFIG_DIR check from collectFiles and collectFilesSync in src/lib/packaging/helpers.ts.
• Drop the now-unused rootDir parameter from both helpers and from the two internal call sites in createZipFromDir / createZipFromDirSync.
• Copy-stage exclusion (the agentcore/ config dir check in copyEntry) is left as-is, since that one is correct.
• Update the existing zip-stage tests under "issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843" so they no longer assert the broken behavior, and add a new test block under issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 that builds a staging fixture with a top-level agentcore/ Python package and asserts it is preserved in both the async and sync zip paths.

Test plan

• npx vitest run src/lib/packaging/__tests__/helpers.test.ts reports 39 passed (including the 2 new issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 cases and the unchanged issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843 copy-stage cases).
• npm run typecheck clean.
• npx eslint src/lib/packaging/helpers.ts src/lib/packaging/__tests__/helpers.test.ts clean.
• npx prettier --check on both files clean.

Closes#1408

[aidandaly24]

Thanks for your contribution.

[NishchayMahor]

Summary

Restores the state from #1015. The CONFIG_DIR check in the zip-stage collectFiles / collectFilesSync helpers was reintroduced by the #1068 merge and is currently on main. The zip stage runs against the staging directory, not the project root, and the project config dir is already filtered out at the copy stage, so the check is both unnecessary and harmful: any Python package whose top-level module is named agentcore gets silently dropped from the deployment artifact.

What changed

• Drop the CONFIG_DIR check from collectFiles and collectFilesSync in src/lib/packaging/helpers.ts.
• Drop the now-unused rootDir parameter from both helpers and from the two internal call sites in createZipFromDir / createZipFromDirSync.
• Copy-stage exclusion (the agentcore/ config dir check in copyEntry) is left as-is, since that one is correct.
• Update the existing zip-stage tests under "issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843" so they no longer assert the broken behavior, and add a new test block under issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 that builds a staging fixture with a top-level agentcore/ Python package and asserts it is preserved in both the async and sync zip paths.

Test plan

• npx vitest run src/lib/packaging/__tests__/helpers.test.ts reports 39 passed (including the 2 new issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 cases and the unchanged issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843 copy-stage cases).
• npm run typecheck clean.
• npx eslint src/lib/packaging/helpers.ts src/lib/packaging/__tests__/helpers.test.ts clean.
• npx prettier --check on both files clean.

Closes#1408

[aidandaly24]

Thanks for your contribution.

[NishchayMahor]

Summary

Restores the state from #1015. The CONFIG_DIR check in the zip-stage collectFiles / collectFilesSync helpers was reintroduced by the #1068 merge and is currently on main. The zip stage runs against the staging directory, not the project root, and the project config dir is already filtered out at the copy stage, so the check is both unnecessary and harmful: any Python package whose top-level module is named agentcore gets silently dropped from the deployment artifact.

What changed

• Drop the CONFIG_DIR check from collectFiles and collectFilesSync in src/lib/packaging/helpers.ts.
• Drop the now-unused rootDir parameter from both helpers and from the two internal call sites in createZipFromDir / createZipFromDirSync.
• Copy-stage exclusion (the agentcore/ config dir check in copyEntry) is left as-is, since that one is correct.
• Update the existing zip-stage tests under "issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843" so they no longer assert the broken behavior, and add a new test block under issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 that builds a staging fixture with a top-level agentcore/ Python package and asserts it is preserved in both the async and sync zip paths.

Test plan

• npx vitest run src/lib/packaging/__tests__/helpers.test.ts reports 39 passed (including the 2 new issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 cases and the unchanged issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843 copy-stage cases).
• npm run typecheck clean.
• npx eslint src/lib/packaging/helpers.ts src/lib/packaging/__tests__/helpers.test.ts clean.
• npx prettier --check on both files clean.

Closes#1408

[aidandaly24]

Thanks for your contribution.

[NishchayMahor]

Summary

Restores the state from #1015. The CONFIG_DIR check in the zip-stage collectFiles / collectFilesSync helpers was reintroduced by the #1068 merge and is currently on main. The zip stage runs against the staging directory, not the project root, and the project config dir is already filtered out at the copy stage, so the check is both unnecessary and harmful: any Python package whose top-level module is named agentcore gets silently dropped from the deployment artifact.

What changed

• Drop the CONFIG_DIR check from collectFiles and collectFilesSync in src/lib/packaging/helpers.ts.
• Drop the now-unused rootDir parameter from both helpers and from the two internal call sites in createZipFromDir / createZipFromDirSync.
• Copy-stage exclusion (the agentcore/ config dir check in copyEntry) is left as-is, since that one is correct.
• Update the existing zip-stage tests under "issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843" so they no longer assert the broken behavior, and add a new test block under issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 that builds a staging fixture with a top-level agentcore/ Python package and asserts it is preserved in both the async and sync zip paths.

Test plan

• npx vitest run src/lib/packaging/__tests__/helpers.test.ts reports 39 passed (including the 2 new issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 cases and the unchanged issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843 copy-stage cases).
• npm run typecheck clean.
• npx eslint src/lib/packaging/helpers.ts src/lib/packaging/__tests__/helpers.test.ts clean.
• npx prettier --check on both files clean.

Closes#1408

[aidandaly24]

Thanks for your contribution.

[NishchayMahor]

Summary

Restores the state from #1015. The CONFIG_DIR check in the zip-stage collectFiles / collectFilesSync helpers was reintroduced by the #1068 merge and is currently on main. The zip stage runs against the staging directory, not the project root, and the project config dir is already filtered out at the copy stage, so the check is both unnecessary and harmful: any Python package whose top-level module is named agentcore gets silently dropped from the deployment artifact.

What changed

• Drop the CONFIG_DIR check from collectFiles and collectFilesSync in src/lib/packaging/helpers.ts.
• Drop the now-unused rootDir parameter from both helpers and from the two internal call sites in createZipFromDir / createZipFromDirSync.
• Copy-stage exclusion (the agentcore/ config dir check in copyEntry) is left as-is, since that one is correct.
• Update the existing zip-stage tests under "issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843" so they no longer assert the broken behavior, and add a new test block under issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 that builds a staging fixture with a top-level agentcore/ Python package and asserts it is preserved in both the async and sync zip paths.

Test plan

• npx vitest run src/lib/packaging/__tests__/helpers.test.ts reports 39 passed (including the 2 new issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 cases and the unchanged issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843 copy-stage cases).
• npm run typecheck clean.
• npx eslint src/lib/packaging/helpers.ts src/lib/packaging/__tests__/helpers.test.ts clean.
• npx prettier --check on both files clean.

Closes#1408

[aidandaly24]

Thanks for your contribution.

[NishchayMahor]

Summary

Restores the state from #1015. The CONFIG_DIR check in the zip-stage collectFiles / collectFilesSync helpers was reintroduced by the #1068 merge and is currently on main. The zip stage runs against the staging directory, not the project root, and the project config dir is already filtered out at the copy stage, so the check is both unnecessary and harmful: any Python package whose top-level module is named agentcore gets silently dropped from the deployment artifact.

What changed

• Drop the CONFIG_DIR check from collectFiles and collectFilesSync in src/lib/packaging/helpers.ts.
• Drop the now-unused rootDir parameter from both helpers and from the two internal call sites in createZipFromDir / createZipFromDirSync.
• Copy-stage exclusion (the agentcore/ config dir check in copyEntry) is left as-is, since that one is correct.
• Update the existing zip-stage tests under "issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843" so they no longer assert the broken behavior, and add a new test block under issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 that builds a staging fixture with a top-level agentcore/ Python package and asserts it is preserved in both the async and sync zip paths.

Test plan

• npx vitest run src/lib/packaging/__tests__/helpers.test.ts reports 39 passed (including the 2 new issue Regression in #1068: CONFIG_DIR check re-introduced in zip stage, drops top-level agentcore Python packages from deployment artifact #1408 cases and the unchanged issue agentcore directory incorrectly excluded from CodeZip artifact when used as a Python package name #843 copy-stage cases).
• npm run typecheck clean.
• npx eslint src/lib/packaging/helpers.ts src/lib/packaging/__tests__/helpers.test.ts clean.
• npx prettier --check on both files clean.

Closes#1408

[aidandaly24]

Thanks for your contribution.