fix(run-insights): TUI wizard state, inline name validation, job history by notgitika · Pull Request #1602 · aws/agentcore-cli

notgitika · 2026-06-22T03:06:01Z

Summary

Four fixes to the agentcore run insights interactive wizard, from the Lens-in-CLI bug bash:

Single-agent flow leaves Confirm blank. When the project has exactly one agent, the wizard skipped the agent step but never populated config.agent, so the Confirm screen showed an empty Agent: line. The default config now pre-populates the sole agent so it threads through to confirm and the API call.
Inline name validation. The Name step accepted spaces / hyphens / leading digits and only blew up after submit with a service 400. We now validate inline using the service-side BatchEvaluationName shape (^[a-zA-Z][a-zA-Z0-9_]{0,47}$) from AgentCoreEvaluationCommonModel. Lookback days also validate inline (1-90, integer only) instead of silently coercing 0 → 7.
Preserve config on error. Hitting "Go back" from a launch error reset the entire wizard. The failed config is now stashed in flow state and the wizard re-opens at the Name step with all prior selections intact.
Post-launch "No insights runs found". The wizard wrote to the job-engine store, but the post-launch "View Insights Jobs" screen reads from the legacy .cli/insights/*.json store. We now mirror successful starts to the legacy store after launch so the new job appears immediately.

…inline, surface job in history Multiple fixes to the `agentcore run insights` interactive wizard: - **Single-agent flow** (#4): when the project has exactly one agent, the wizard skipped the agent step but never set `config.agent`, so the Confirm screen showed a blank "Agent:" line. Pre-populate the sole agent in the default config so it's threaded through to confirm and the API call. - **Inline name validation** (aws#6): the Name step accepted invalid values (spaces, hyphens, leading digits) and only failed at submit time when the API returned a 400. Validate inline against the service-side `BatchEvaluationName` pattern (`^[a-zA-Z][a-zA-Z0-9_]{0,47}$`). Lookback days now also validate inline (1-90, integer only) instead of silently coercing 0 to 7. - **Preserve config on error** (aws#16): when the launch failed, hitting "Go back" reset the wizard to the Source step and discarded all selections. Now the failed config is stashed in flow state and the wizard re-opens at the Name step with everything pre-populated. - **Post-launch history** (aws#17): the wizard wrote to the job-engine store but `view insights` reads from the legacy `.cli/insights/*.json` store, so the brand-new job rendered as "No insights runs found". Mirror successful starts to the legacy store after launch. Bug bash items #4, aws#6, aws#16, aws#17 (mix of P1/P2).

github-actions · 2026-06-22T03:06:52Z

Package Tarball

aws-agentcore-0.20.2.tgz

How to install

gh release download pr-1602-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz

agentcore-devx-automation · 2026-06-22T03:06:53Z

Claude Security Review: no high-confidence findings. (run)

agentcore-cli-automation

Nice, focused fixes for the bug bash items. Two things I'd like addressed before merge:

The new forwardRef / useImperativeHandle / jumpToStep surface on RunInsightsScreen appears to be dead code — nothing in the tree passes a ref, and resume-on-error works entirely through the new initialConfig / initialStep props (the screen re-mounts when RunInsightsFlow transitions from error back to wizard). Either wire it up to a caller or drop it; otherwise it adds an API contract that's unused, untested, and (in React 19) unnecessary.
The two new pure validators are good candidates for a small unit test. There are no tests under src/cli/tui/screens/run-insights/ at all, and three of the four fixes here (single-agent default, inline name validation, resume-on-error) are reachable via the wizard hook + pure helpers without any TUI rendering. A small validateJobName / validateLookbackInput / useRunInsightsWizard test file would lock these in cheaply.

One smaller suggestion inline about the silent catch in persistToLegacyStore.

jariy17

I have one blocking comment.

…gine store Addresses review feedback: - Remove unused forwardRef, useImperativeHandle, RunInsightsScreenHandle, and jumpToStep — resume-on-error works through initialConfig/initialStep. - Replace persistToLegacyStore workaround: InsightsJobsScreen now reads directly from the job engine store (listRecords), eliminating the two-source-of-truth problem.

agentcore-devx-automation · 2026-06-29T14:43:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-06-22T03:06:01Z

Summary

Four fixes to the agentcore run insights interactive wizard, from the Lens-in-CLI bug bash:

Single-agent flow leaves Confirm blank. When the project has exactly one agent, the wizard skipped the agent step but never populated config.agent, so the Confirm screen showed an empty Agent: line. The default config now pre-populates the sole agent so it threads through to confirm and the API call.
Inline name validation. The Name step accepted spaces / hyphens / leading digits and only blew up after submit with a service 400. We now validate inline using the service-side BatchEvaluationName shape (^[a-zA-Z][a-zA-Z0-9_]{0,47}$) from AgentCoreEvaluationCommonModel. Lookback days also validate inline (1-90, integer only) instead of silently coercing 0 → 7.
Preserve config on error. Hitting "Go back" from a launch error reset the entire wizard. The failed config is now stashed in flow state and the wizard re-opens at the Name step with all prior selections intact.
Post-launch "No insights runs found". The wizard wrote to the job-engine store, but the post-launch "View Insights Jobs" screen reads from the legacy .cli/insights/*.json store. We now mirror successful starts to the legacy store after launch so the new job appears immediately.

…inline, surface job in history Multiple fixes to the `agentcore run insights` interactive wizard: - **Single-agent flow** (#4): when the project has exactly one agent, the wizard skipped the agent step but never set `config.agent`, so the Confirm screen showed a blank "Agent:" line. Pre-populate the sole agent in the default config so it's threaded through to confirm and the API call. - **Inline name validation** (aws#6): the Name step accepted invalid values (spaces, hyphens, leading digits) and only failed at submit time when the API returned a 400. Validate inline against the service-side `BatchEvaluationName` pattern (`^[a-zA-Z][a-zA-Z0-9_]{0,47}$`). Lookback days now also validate inline (1-90, integer only) instead of silently coercing 0 to 7. - **Preserve config on error** (aws#16): when the launch failed, hitting "Go back" reset the wizard to the Source step and discarded all selections. Now the failed config is stashed in flow state and the wizard re-opens at the Name step with everything pre-populated. - **Post-launch history** (aws#17): the wizard wrote to the job-engine store but `view insights` reads from the legacy `.cli/insights/*.json` store, so the brand-new job rendered as "No insights runs found". Mirror successful starts to the legacy store after launch. Bug bash items #4, aws#6, aws#16, aws#17 (mix of P1/P2).

github-actions · 2026-06-22T03:06:52Z

Package Tarball

aws-agentcore-0.20.2.tgz

How to install

gh release download pr-1602-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz

agentcore-devx-automation · 2026-06-22T03:06:53Z

Claude Security Review: no high-confidence findings. (run)

agentcore-cli-automation

Nice, focused fixes for the bug bash items. Two things I'd like addressed before merge:

The new forwardRef / useImperativeHandle / jumpToStep surface on RunInsightsScreen appears to be dead code — nothing in the tree passes a ref, and resume-on-error works entirely through the new initialConfig / initialStep props (the screen re-mounts when RunInsightsFlow transitions from error back to wizard). Either wire it up to a caller or drop it; otherwise it adds an API contract that's unused, untested, and (in React 19) unnecessary.
The two new pure validators are good candidates for a small unit test. There are no tests under src/cli/tui/screens/run-insights/ at all, and three of the four fixes here (single-agent default, inline name validation, resume-on-error) are reachable via the wizard hook + pure helpers without any TUI rendering. A small validateJobName / validateLookbackInput / useRunInsightsWizard test file would lock these in cheaply.

One smaller suggestion inline about the silent catch in persistToLegacyStore.

jariy17

I have one blocking comment.

…gine store Addresses review feedback: - Remove unused forwardRef, useImperativeHandle, RunInsightsScreenHandle, and jumpToStep — resume-on-error works through initialConfig/initialStep. - Replace persistToLegacyStore workaround: InsightsJobsScreen now reads directly from the job engine store (listRecords), eliminating the two-source-of-truth problem.

agentcore-devx-automation · 2026-06-29T14:43:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-06-22T03:06:01Z

Summary

Four fixes to the agentcore run insights interactive wizard, from the Lens-in-CLI bug bash:

Single-agent flow leaves Confirm blank. When the project has exactly one agent, the wizard skipped the agent step but never populated config.agent, so the Confirm screen showed an empty Agent: line. The default config now pre-populates the sole agent so it threads through to confirm and the API call.
Inline name validation. The Name step accepted spaces / hyphens / leading digits and only blew up after submit with a service 400. We now validate inline using the service-side BatchEvaluationName shape (^[a-zA-Z][a-zA-Z0-9_]{0,47}$) from AgentCoreEvaluationCommonModel. Lookback days also validate inline (1-90, integer only) instead of silently coercing 0 → 7.
Preserve config on error. Hitting "Go back" from a launch error reset the entire wizard. The failed config is now stashed in flow state and the wizard re-opens at the Name step with all prior selections intact.
Post-launch "No insights runs found". The wizard wrote to the job-engine store, but the post-launch "View Insights Jobs" screen reads from the legacy .cli/insights/*.json store. We now mirror successful starts to the legacy store after launch so the new job appears immediately.

…inline, surface job in history Multiple fixes to the `agentcore run insights` interactive wizard: - **Single-agent flow** (#4): when the project has exactly one agent, the wizard skipped the agent step but never set `config.agent`, so the Confirm screen showed a blank "Agent:" line. Pre-populate the sole agent in the default config so it's threaded through to confirm and the API call. - **Inline name validation** (aws#6): the Name step accepted invalid values (spaces, hyphens, leading digits) and only failed at submit time when the API returned a 400. Validate inline against the service-side `BatchEvaluationName` pattern (`^[a-zA-Z][a-zA-Z0-9_]{0,47}$`). Lookback days now also validate inline (1-90, integer only) instead of silently coercing 0 to 7. - **Preserve config on error** (aws#16): when the launch failed, hitting "Go back" reset the wizard to the Source step and discarded all selections. Now the failed config is stashed in flow state and the wizard re-opens at the Name step with everything pre-populated. - **Post-launch history** (aws#17): the wizard wrote to the job-engine store but `view insights` reads from the legacy `.cli/insights/*.json` store, so the brand-new job rendered as "No insights runs found". Mirror successful starts to the legacy store after launch. Bug bash items #4, aws#6, aws#16, aws#17 (mix of P1/P2).

github-actions · 2026-06-22T03:06:52Z

Package Tarball

aws-agentcore-0.20.2.tgz

How to install

gh release download pr-1602-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz

agentcore-devx-automation · 2026-06-22T03:06:53Z

Claude Security Review: no high-confidence findings. (run)

agentcore-cli-automation

Nice, focused fixes for the bug bash items. Two things I'd like addressed before merge:

The new forwardRef / useImperativeHandle / jumpToStep surface on RunInsightsScreen appears to be dead code — nothing in the tree passes a ref, and resume-on-error works entirely through the new initialConfig / initialStep props (the screen re-mounts when RunInsightsFlow transitions from error back to wizard). Either wire it up to a caller or drop it; otherwise it adds an API contract that's unused, untested, and (in React 19) unnecessary.
The two new pure validators are good candidates for a small unit test. There are no tests under src/cli/tui/screens/run-insights/ at all, and three of the four fixes here (single-agent default, inline name validation, resume-on-error) are reachable via the wizard hook + pure helpers without any TUI rendering. A small validateJobName / validateLookbackInput / useRunInsightsWizard test file would lock these in cheaply.

One smaller suggestion inline about the silent catch in persistToLegacyStore.

jariy17

I have one blocking comment.

…gine store Addresses review feedback: - Remove unused forwardRef, useImperativeHandle, RunInsightsScreenHandle, and jumpToStep — resume-on-error works through initialConfig/initialStep. - Replace persistToLegacyStore workaround: InsightsJobsScreen now reads directly from the job engine store (listRecords), eliminating the two-source-of-truth problem.

agentcore-devx-automation · 2026-06-29T14:43:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-06-22T03:06:01Z

Summary

Four fixes to the agentcore run insights interactive wizard, from the Lens-in-CLI bug bash:

Single-agent flow leaves Confirm blank. When the project has exactly one agent, the wizard skipped the agent step but never populated config.agent, so the Confirm screen showed an empty Agent: line. The default config now pre-populates the sole agent so it threads through to confirm and the API call.
Inline name validation. The Name step accepted spaces / hyphens / leading digits and only blew up after submit with a service 400. We now validate inline using the service-side BatchEvaluationName shape (^[a-zA-Z][a-zA-Z0-9_]{0,47}$) from AgentCoreEvaluationCommonModel. Lookback days also validate inline (1-90, integer only) instead of silently coercing 0 → 7.
Preserve config on error. Hitting "Go back" from a launch error reset the entire wizard. The failed config is now stashed in flow state and the wizard re-opens at the Name step with all prior selections intact.
Post-launch "No insights runs found". The wizard wrote to the job-engine store, but the post-launch "View Insights Jobs" screen reads from the legacy .cli/insights/*.json store. We now mirror successful starts to the legacy store after launch so the new job appears immediately.

…inline, surface job in history Multiple fixes to the `agentcore run insights` interactive wizard: - **Single-agent flow** (#4): when the project has exactly one agent, the wizard skipped the agent step but never set `config.agent`, so the Confirm screen showed a blank "Agent:" line. Pre-populate the sole agent in the default config so it's threaded through to confirm and the API call. - **Inline name validation** (aws#6): the Name step accepted invalid values (spaces, hyphens, leading digits) and only failed at submit time when the API returned a 400. Validate inline against the service-side `BatchEvaluationName` pattern (`^[a-zA-Z][a-zA-Z0-9_]{0,47}$`). Lookback days now also validate inline (1-90, integer only) instead of silently coercing 0 to 7. - **Preserve config on error** (aws#16): when the launch failed, hitting "Go back" reset the wizard to the Source step and discarded all selections. Now the failed config is stashed in flow state and the wizard re-opens at the Name step with everything pre-populated. - **Post-launch history** (aws#17): the wizard wrote to the job-engine store but `view insights` reads from the legacy `.cli/insights/*.json` store, so the brand-new job rendered as "No insights runs found". Mirror successful starts to the legacy store after launch. Bug bash items #4, aws#6, aws#16, aws#17 (mix of P1/P2).

github-actions · 2026-06-22T03:06:52Z

Package Tarball

aws-agentcore-0.20.2.tgz

How to install

gh release download pr-1602-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz

agentcore-devx-automation · 2026-06-22T03:06:53Z

Claude Security Review: no high-confidence findings. (run)

agentcore-cli-automation

Nice, focused fixes for the bug bash items. Two things I'd like addressed before merge:

The new forwardRef / useImperativeHandle / jumpToStep surface on RunInsightsScreen appears to be dead code — nothing in the tree passes a ref, and resume-on-error works entirely through the new initialConfig / initialStep props (the screen re-mounts when RunInsightsFlow transitions from error back to wizard). Either wire it up to a caller or drop it; otherwise it adds an API contract that's unused, untested, and (in React 19) unnecessary.
The two new pure validators are good candidates for a small unit test. There are no tests under src/cli/tui/screens/run-insights/ at all, and three of the four fixes here (single-agent default, inline name validation, resume-on-error) are reachable via the wizard hook + pure helpers without any TUI rendering. A small validateJobName / validateLookbackInput / useRunInsightsWizard test file would lock these in cheaply.

One smaller suggestion inline about the silent catch in persistToLegacyStore.

jariy17

I have one blocking comment.

…gine store Addresses review feedback: - Remove unused forwardRef, useImperativeHandle, RunInsightsScreenHandle, and jumpToStep — resume-on-error works through initialConfig/initialStep. - Replace persistToLegacyStore workaround: InsightsJobsScreen now reads directly from the job engine store (listRecords), eliminating the two-source-of-truth problem.

agentcore-devx-automation · 2026-06-29T14:43:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-06-22T03:06:01Z

Summary

Four fixes to the agentcore run insights interactive wizard, from the Lens-in-CLI bug bash:

Single-agent flow leaves Confirm blank. When the project has exactly one agent, the wizard skipped the agent step but never populated config.agent, so the Confirm screen showed an empty Agent: line. The default config now pre-populates the sole agent so it threads through to confirm and the API call.
Inline name validation. The Name step accepted spaces / hyphens / leading digits and only blew up after submit with a service 400. We now validate inline using the service-side BatchEvaluationName shape (^[a-zA-Z][a-zA-Z0-9_]{0,47}$) from AgentCoreEvaluationCommonModel. Lookback days also validate inline (1-90, integer only) instead of silently coercing 0 → 7.
Preserve config on error. Hitting "Go back" from a launch error reset the entire wizard. The failed config is now stashed in flow state and the wizard re-opens at the Name step with all prior selections intact.
Post-launch "No insights runs found". The wizard wrote to the job-engine store, but the post-launch "View Insights Jobs" screen reads from the legacy .cli/insights/*.json store. We now mirror successful starts to the legacy store after launch so the new job appears immediately.

…inline, surface job in history Multiple fixes to the `agentcore run insights` interactive wizard: - **Single-agent flow** (#4): when the project has exactly one agent, the wizard skipped the agent step but never set `config.agent`, so the Confirm screen showed a blank "Agent:" line. Pre-populate the sole agent in the default config so it's threaded through to confirm and the API call. - **Inline name validation** (aws#6): the Name step accepted invalid values (spaces, hyphens, leading digits) and only failed at submit time when the API returned a 400. Validate inline against the service-side `BatchEvaluationName` pattern (`^[a-zA-Z][a-zA-Z0-9_]{0,47}$`). Lookback days now also validate inline (1-90, integer only) instead of silently coercing 0 to 7. - **Preserve config on error** (aws#16): when the launch failed, hitting "Go back" reset the wizard to the Source step and discarded all selections. Now the failed config is stashed in flow state and the wizard re-opens at the Name step with everything pre-populated. - **Post-launch history** (aws#17): the wizard wrote to the job-engine store but `view insights` reads from the legacy `.cli/insights/*.json` store, so the brand-new job rendered as "No insights runs found". Mirror successful starts to the legacy store after launch. Bug bash items #4, aws#6, aws#16, aws#17 (mix of P1/P2).

github-actions · 2026-06-22T03:06:52Z

Package Tarball

aws-agentcore-0.20.2.tgz

How to install

gh release download pr-1602-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz

agentcore-devx-automation · 2026-06-22T03:06:53Z

Claude Security Review: no high-confidence findings. (run)

agentcore-cli-automation

Nice, focused fixes for the bug bash items. Two things I'd like addressed before merge:

The new forwardRef / useImperativeHandle / jumpToStep surface on RunInsightsScreen appears to be dead code — nothing in the tree passes a ref, and resume-on-error works entirely through the new initialConfig / initialStep props (the screen re-mounts when RunInsightsFlow transitions from error back to wizard). Either wire it up to a caller or drop it; otherwise it adds an API contract that's unused, untested, and (in React 19) unnecessary.
The two new pure validators are good candidates for a small unit test. There are no tests under src/cli/tui/screens/run-insights/ at all, and three of the four fixes here (single-agent default, inline name validation, resume-on-error) are reachable via the wizard hook + pure helpers without any TUI rendering. A small validateJobName / validateLookbackInput / useRunInsightsWizard test file would lock these in cheaply.

One smaller suggestion inline about the silent catch in persistToLegacyStore.

jariy17

I have one blocking comment.

…gine store Addresses review feedback: - Remove unused forwardRef, useImperativeHandle, RunInsightsScreenHandle, and jumpToStep — resume-on-error works through initialConfig/initialStep. - Replace persistToLegacyStore workaround: InsightsJobsScreen now reads directly from the job engine store (listRecords), eliminating the two-source-of-truth problem.

agentcore-devx-automation · 2026-06-29T14:43:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-06-22T03:06:01Z

Summary

Four fixes to the agentcore run insights interactive wizard, from the Lens-in-CLI bug bash:

Single-agent flow leaves Confirm blank. When the project has exactly one agent, the wizard skipped the agent step but never populated config.agent, so the Confirm screen showed an empty Agent: line. The default config now pre-populates the sole agent so it threads through to confirm and the API call.
Inline name validation. The Name step accepted spaces / hyphens / leading digits and only blew up after submit with a service 400. We now validate inline using the service-side BatchEvaluationName shape (^[a-zA-Z][a-zA-Z0-9_]{0,47}$) from AgentCoreEvaluationCommonModel. Lookback days also validate inline (1-90, integer only) instead of silently coercing 0 → 7.
Preserve config on error. Hitting "Go back" from a launch error reset the entire wizard. The failed config is now stashed in flow state and the wizard re-opens at the Name step with all prior selections intact.
Post-launch "No insights runs found". The wizard wrote to the job-engine store, but the post-launch "View Insights Jobs" screen reads from the legacy .cli/insights/*.json store. We now mirror successful starts to the legacy store after launch so the new job appears immediately.

…inline, surface job in history Multiple fixes to the `agentcore run insights` interactive wizard: - **Single-agent flow** (#4): when the project has exactly one agent, the wizard skipped the agent step but never set `config.agent`, so the Confirm screen showed a blank "Agent:" line. Pre-populate the sole agent in the default config so it's threaded through to confirm and the API call. - **Inline name validation** (aws#6): the Name step accepted invalid values (spaces, hyphens, leading digits) and only failed at submit time when the API returned a 400. Validate inline against the service-side `BatchEvaluationName` pattern (`^[a-zA-Z][a-zA-Z0-9_]{0,47}$`). Lookback days now also validate inline (1-90, integer only) instead of silently coercing 0 to 7. - **Preserve config on error** (aws#16): when the launch failed, hitting "Go back" reset the wizard to the Source step and discarded all selections. Now the failed config is stashed in flow state and the wizard re-opens at the Name step with everything pre-populated. - **Post-launch history** (aws#17): the wizard wrote to the job-engine store but `view insights` reads from the legacy `.cli/insights/*.json` store, so the brand-new job rendered as "No insights runs found". Mirror successful starts to the legacy store after launch. Bug bash items #4, aws#6, aws#16, aws#17 (mix of P1/P2).

github-actions · 2026-06-22T03:06:52Z

Package Tarball

aws-agentcore-0.20.2.tgz

How to install

gh release download pr-1602-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz

agentcore-devx-automation · 2026-06-22T03:06:53Z

Claude Security Review: no high-confidence findings. (run)

agentcore-cli-automation

Nice, focused fixes for the bug bash items. Two things I'd like addressed before merge:

The new forwardRef / useImperativeHandle / jumpToStep surface on RunInsightsScreen appears to be dead code — nothing in the tree passes a ref, and resume-on-error works entirely through the new initialConfig / initialStep props (the screen re-mounts when RunInsightsFlow transitions from error back to wizard). Either wire it up to a caller or drop it; otherwise it adds an API contract that's unused, untested, and (in React 19) unnecessary.
The two new pure validators are good candidates for a small unit test. There are no tests under src/cli/tui/screens/run-insights/ at all, and three of the four fixes here (single-agent default, inline name validation, resume-on-error) are reachable via the wizard hook + pure helpers without any TUI rendering. A small validateJobName / validateLookbackInput / useRunInsightsWizard test file would lock these in cheaply.

One smaller suggestion inline about the silent catch in persistToLegacyStore.

jariy17

I have one blocking comment.

…gine store Addresses review feedback: - Remove unused forwardRef, useImperativeHandle, RunInsightsScreenHandle, and jumpToStep — resume-on-error works through initialConfig/initialStep. - Replace persistToLegacyStore workaround: InsightsJobsScreen now reads directly from the job engine store (listRecords), eliminating the two-source-of-truth problem.

agentcore-devx-automation · 2026-06-29T14:43:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-06-22T03:06:01Z

Summary

Four fixes to the agentcore run insights interactive wizard, from the Lens-in-CLI bug bash:

Single-agent flow leaves Confirm blank. When the project has exactly one agent, the wizard skipped the agent step but never populated config.agent, so the Confirm screen showed an empty Agent: line. The default config now pre-populates the sole agent so it threads through to confirm and the API call.
Inline name validation. The Name step accepted spaces / hyphens / leading digits and only blew up after submit with a service 400. We now validate inline using the service-side BatchEvaluationName shape (^[a-zA-Z][a-zA-Z0-9_]{0,47}$) from AgentCoreEvaluationCommonModel. Lookback days also validate inline (1-90, integer only) instead of silently coercing 0 → 7.
Preserve config on error. Hitting "Go back" from a launch error reset the entire wizard. The failed config is now stashed in flow state and the wizard re-opens at the Name step with all prior selections intact.
Post-launch "No insights runs found". The wizard wrote to the job-engine store, but the post-launch "View Insights Jobs" screen reads from the legacy .cli/insights/*.json store. We now mirror successful starts to the legacy store after launch so the new job appears immediately.

…inline, surface job in history Multiple fixes to the `agentcore run insights` interactive wizard: - **Single-agent flow** (#4): when the project has exactly one agent, the wizard skipped the agent step but never set `config.agent`, so the Confirm screen showed a blank "Agent:" line. Pre-populate the sole agent in the default config so it's threaded through to confirm and the API call. - **Inline name validation** (aws#6): the Name step accepted invalid values (spaces, hyphens, leading digits) and only failed at submit time when the API returned a 400. Validate inline against the service-side `BatchEvaluationName` pattern (`^[a-zA-Z][a-zA-Z0-9_]{0,47}$`). Lookback days now also validate inline (1-90, integer only) instead of silently coercing 0 to 7. - **Preserve config on error** (aws#16): when the launch failed, hitting "Go back" reset the wizard to the Source step and discarded all selections. Now the failed config is stashed in flow state and the wizard re-opens at the Name step with everything pre-populated. - **Post-launch history** (aws#17): the wizard wrote to the job-engine store but `view insights` reads from the legacy `.cli/insights/*.json` store, so the brand-new job rendered as "No insights runs found". Mirror successful starts to the legacy store after launch. Bug bash items #4, aws#6, aws#16, aws#17 (mix of P1/P2).

github-actions · 2026-06-22T03:06:52Z

Package Tarball

aws-agentcore-0.20.2.tgz

How to install

gh release download pr-1602-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz

agentcore-devx-automation · 2026-06-22T03:06:53Z

Claude Security Review: no high-confidence findings. (run)

agentcore-cli-automation

Nice, focused fixes for the bug bash items. Two things I'd like addressed before merge:

The new forwardRef / useImperativeHandle / jumpToStep surface on RunInsightsScreen appears to be dead code — nothing in the tree passes a ref, and resume-on-error works entirely through the new initialConfig / initialStep props (the screen re-mounts when RunInsightsFlow transitions from error back to wizard). Either wire it up to a caller or drop it; otherwise it adds an API contract that's unused, untested, and (in React 19) unnecessary.
The two new pure validators are good candidates for a small unit test. There are no tests under src/cli/tui/screens/run-insights/ at all, and three of the four fixes here (single-agent default, inline name validation, resume-on-error) are reachable via the wizard hook + pure helpers without any TUI rendering. A small validateJobName / validateLookbackInput / useRunInsightsWizard test file would lock these in cheaply.

One smaller suggestion inline about the silent catch in persistToLegacyStore.

jariy17

I have one blocking comment.

…gine store Addresses review feedback: - Remove unused forwardRef, useImperativeHandle, RunInsightsScreenHandle, and jumpToStep — resume-on-error works through initialConfig/initialStep. - Replace persistToLegacyStore workaround: InsightsJobsScreen now reads directly from the job engine store (listRecords), eliminating the two-source-of-truth problem.

agentcore-devx-automation · 2026-06-29T14:43:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-06-22T03:06:01Z

Summary

Four fixes to the agentcore run insights interactive wizard, from the Lens-in-CLI bug bash:

Single-agent flow leaves Confirm blank. When the project has exactly one agent, the wizard skipped the agent step but never populated config.agent, so the Confirm screen showed an empty Agent: line. The default config now pre-populates the sole agent so it threads through to confirm and the API call.
Inline name validation. The Name step accepted spaces / hyphens / leading digits and only blew up after submit with a service 400. We now validate inline using the service-side BatchEvaluationName shape (^[a-zA-Z][a-zA-Z0-9_]{0,47}$) from AgentCoreEvaluationCommonModel. Lookback days also validate inline (1-90, integer only) instead of silently coercing 0 → 7.
Preserve config on error. Hitting "Go back" from a launch error reset the entire wizard. The failed config is now stashed in flow state and the wizard re-opens at the Name step with all prior selections intact.
Post-launch "No insights runs found". The wizard wrote to the job-engine store, but the post-launch "View Insights Jobs" screen reads from the legacy .cli/insights/*.json store. We now mirror successful starts to the legacy store after launch so the new job appears immediately.

…inline, surface job in history Multiple fixes to the `agentcore run insights` interactive wizard: - **Single-agent flow** (#4): when the project has exactly one agent, the wizard skipped the agent step but never set `config.agent`, so the Confirm screen showed a blank "Agent:" line. Pre-populate the sole agent in the default config so it's threaded through to confirm and the API call. - **Inline name validation** (aws#6): the Name step accepted invalid values (spaces, hyphens, leading digits) and only failed at submit time when the API returned a 400. Validate inline against the service-side `BatchEvaluationName` pattern (`^[a-zA-Z][a-zA-Z0-9_]{0,47}$`). Lookback days now also validate inline (1-90, integer only) instead of silently coercing 0 to 7. - **Preserve config on error** (aws#16): when the launch failed, hitting "Go back" reset the wizard to the Source step and discarded all selections. Now the failed config is stashed in flow state and the wizard re-opens at the Name step with everything pre-populated. - **Post-launch history** (aws#17): the wizard wrote to the job-engine store but `view insights` reads from the legacy `.cli/insights/*.json` store, so the brand-new job rendered as "No insights runs found". Mirror successful starts to the legacy store after launch. Bug bash items #4, aws#6, aws#16, aws#17 (mix of P1/P2).

github-actions · 2026-06-22T03:06:52Z

Package Tarball

aws-agentcore-0.20.2.tgz

How to install

gh release download pr-1602-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.20.2.tgz

agentcore-devx-automation · 2026-06-22T03:06:53Z

Claude Security Review: no high-confidence findings. (run)

agentcore-cli-automation

Nice, focused fixes for the bug bash items. Two things I'd like addressed before merge:

The new forwardRef / useImperativeHandle / jumpToStep surface on RunInsightsScreen appears to be dead code — nothing in the tree passes a ref, and resume-on-error works entirely through the new initialConfig / initialStep props (the screen re-mounts when RunInsightsFlow transitions from error back to wizard). Either wire it up to a caller or drop it; otherwise it adds an API contract that's unused, untested, and (in React 19) unnecessary.
The two new pure validators are good candidates for a small unit test. There are no tests under src/cli/tui/screens/run-insights/ at all, and three of the four fixes here (single-agent default, inline name validation, resume-on-error) are reachable via the wizard hook + pure helpers without any TUI rendering. A small validateJobName / validateLookbackInput / useRunInsightsWizard test file would lock these in cheaply.

One smaller suggestion inline about the silent catch in persistToLegacyStore.

jariy17

I have one blocking comment.

…gine store Addresses review feedback: - Remove unused forwardRef, useImperativeHandle, RunInsightsScreenHandle, and jumpToStep — resume-on-error works through initialConfig/initialStep. - Replace persistToLegacyStore workaround: InsightsJobsScreen now reads directly from the job engine store (listRecords), eliminating the two-source-of-truth problem.

agentcore-devx-automation · 2026-06-29T14:43:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika requested a review from a teamJune 22, 2026 03:06

github-actionsBot added the size/m PR size: M label Jun 22, 2026

notgitika temporarily deployed to e2e-testing June 22, 2026 03:06 — with GitHub Actions Inactive

agentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Jun 22, 2026

github-actionsBot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 22, 2026

agentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 22, 2026

agentcore-cli-automation suggested changes Jun 22, 2026
View reviewed changes

Comment threadsrc/cli/tui/screens/run-insights/RunInsightsScreen.tsx Outdated
Comment threadsrc/cli/tui/screens/run-insights/useRunInsightsWizard.ts Outdated
Comment threadsrc/cli/tui/screens/run-insights/RunInsightsFlow.tsx Outdated

github-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jun 22, 2026

jariy17 requested changes Jun 23, 2026
View reviewed changes

Comment threadsrc/cli/tui/screens/run-insights/RunInsightsFlow.tsx Outdated

github-actionsBot removed the size/m PR size: M label Jun 29, 2026

notgitika temporarily deployed to e2e-testing June 29, 2026 14:43 — with GitHub Actions Inactive

github-actionsBot added the size/m PR size: M label Jun 29, 2026

agentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Jun 29, 2026

agentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Jun 29, 2026

jariy17 approved these changes Jun 29, 2026
View reviewed changes

jariy17 merged commit 3874af6 into aws:mainJun 29, 2026
32 of 33 checks passed