Skip to content

fix: skip framework/language prompts in BYOC flow#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notgitika merged 1 commit into from
Feb 9, 2026
Merged

fix: skip framework/language prompts in BYOC flow #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 14 additions & 66 deletions src/cli/tui/screens/agent/AddAgentScreen.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import type { ModelProvider, SDKFramework, TargetLanguage } from '../../../../schema';
import type { ModelProvider } from '../../../../schema';
import { AgentNameSchema } from '../../../../schema';
import {
ApiKeySecretInput,
Expand All@@ -21,9 +21,7 @@ import {
AGENT_TYPE_OPTIONS,
DEFAULT_ENTRYPOINT,
DEFAULT_PYTHON_VERSION,
FRAMEWORK_OPTIONS,
LANGUAGE_OPTIONS,
getModelProviderOptionsForSdk,
MODEL_PROVIDER_OPTIONS,
} from './types';
import { Box, Text, useInput } from 'ink';
import React, { useCallback, useMemo, useState } from 'react';
Expand All@@ -50,11 +48,11 @@ interface AddAgentScreenProps {

// Steps for the initial phase (before branching to create or byo)
type InitialStep = 'name' | 'agentType';
// Steps for BYO path only
type ByoStep = 'codeLocation' | 'language' | 'framework' | 'modelProvider' | 'apiKey' | 'confirm';
// Steps for BYO path only (no framework/language - user's code already has these baked in)
type ByoStep = 'codeLocation' | 'modelProvider' | 'apiKey' | 'confirm';

const INITIAL_STEPS: InitialStep[] = ['name', 'agentType'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'language', 'framework', 'modelProvider', 'apiKey', 'confirm'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'modelProvider', 'apiKey', 'confirm'];

export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAgentScreenProps) {
// Phase 1: name + agentType selection
Expand All@@ -66,12 +64,11 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
const generateWizard = useGenerateWizard({ initialName: name });

// Phase 2 (byo path): BYO-specific state
// Note: language/framework not needed for BYO - user's code already has these
const [byoStep, setByoStep] = useState<ByoStep>('codeLocation');
const [byoConfig, setByoConfig] = useState({
codeLocation: '',
entrypoint: DEFAULT_ENTRYPOINT,
language: 'Python' as TargetLanguage,
framework: 'Strands' as SDKFramework,
modelProvider: 'Bedrock' as ModelProvider,
apiKey: undefined as string | undefined,
});
Expand DownExpand Up@@ -165,25 +162,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg

const byoCurrentIndex = byoSteps.indexOf(byoStep);

// BYO language options (include "Other" for BYO path)
const languageItems: SelectableItem[] = useMemo(
() => LANGUAGE_OPTIONS.map(o => ({ id: o.id, title: o.title, disabled: 'disabled' in o ? o.disabled : undefined })),
[]
);

const frameworkItems: SelectableItem[] = useMemo(
() => FRAMEWORK_OPTIONS.map(o => ({ id: o.id, title: o.title, description: o.description })),
[]
);

// BYO model provider options - show ALL providers since we don't know the framework
const modelProviderItems: SelectableItem[] = useMemo(
() =>
getModelProviderOptionsForSdk(byoConfig.framework).map(o => ({
MODEL_PROVIDER_OPTIONS.map(o => ({
id: o.id,
title: o.title,
description: o.description,
})),
[byoConfig.framework]
[]
);

const handleByoBack = useCallback(() => {
Expand All@@ -198,13 +185,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
}, [byoCurrentIndex, byoSteps]);

const handleByoComplete = useCallback(() => {
// For BYO, language/framework are not asked - we default to Python/Strands
// since the actual values don't matter for BYO (code already exists)
const config: AddAgentConfig = {
name,
agentType: 'byo',
codeLocation: byoConfig.codeLocation,
entrypoint: byoConfig.entrypoint,
language: byoConfig.language,
framework: byoConfig.framework,
language: 'Python', // Default - not used for BYO agents
framework: 'Strands', // Default - not used for BYO agents
modelProvider: byoConfig.modelProvider,
apiKey: byoConfig.apiKey,
pythonVersion: DEFAULT_PYTHON_VERSION,
Expand All@@ -213,34 +202,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
onComplete(config);
}, [name, byoConfig, onComplete]);

const languageNav = useListNavigation({
items: languageItems,
onSelect: item => {
setByoConfig(c => ({ ...c, language: item.id as TargetLanguage }));
setByoStep('framework');
},
onExit: handleByoBack,
isActive: isByoPath && byoStep === 'language',
isDisabled: item => item.disabled ?? false,
});

const frameworkNav = useListNavigation({
items: frameworkItems,
onSelect: item => {
const newFramework = item.id as SDKFramework;
// Reset modelProvider if it's not supported by the new framework
const supportedProviders = getModelProviderOptionsForSdk(newFramework);
const isCurrentProviderSupported = supportedProviders.some(p => p.id === byoConfig.modelProvider);
const newModelProvider = isCurrentProviderSupported
? byoConfig.modelProvider
: (supportedProviders[0]?.id ?? 'Bedrock');
setByoConfig(c => ({ ...c, framework: newFramework, modelProvider: newModelProvider }));
setByoStep('modelProvider');
},
onExit: handleByoBack,
isActive: isByoPath && byoStep === 'framework',
});

const modelProviderNav = useListNavigation({
items: modelProviderItems,
onSelect: item => {
Expand DownExpand Up@@ -374,21 +335,13 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
initialEntrypoint={byoConfig.entrypoint}
onSubmit={(codeLocation, entrypoint) => {
setByoConfig(c => ({ ...c, codeLocation, entrypoint }));
setByoStep('language');
setByoStep('modelProvider');
return true;
}}
onCancel={handleByoBack}
/>
)}

{byoStep === 'language' && (
<WizardSelect title="Select language" items={languageItems} selectedIndex={languageNav.selectedIndex} />
)}

{byoStep === 'framework' && (
<WizardSelect title="Select framework" items={frameworkItems} selectedIndex={frameworkNav.selectedIndex} />
)}

{byoStep === 'modelProvider' && (
<WizardSelect
title="Select model provider"
Expand DownExpand Up@@ -417,11 +370,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
{ label: 'Type', value: 'Bring my own code' },
{ label: 'Code Location', value: byoConfig.codeLocation },
{ label: 'Entrypoint', value: byoConfig.entrypoint },
{ label: 'Language', value: byoConfig.language },
{
label: 'Framework',
value: FRAMEWORK_OPTIONS.find(o => o.id === byoConfig.framework)?.title ?? byoConfig.framework,
},
{ label: 'Model Provider', value: byoConfig.modelProvider },
...(byoConfig.modelProvider !== 'Bedrock'
? [
Expand Down
3 changes: 2 additions & 1 deletion src/cli/tui/screens/agent/types.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,8 @@ export type AgentType = 'create' | 'byo';
* - language → framework → modelProvider → [apiKey] → memory → confirm
*
* BYO path (agentType = 'byo'):
* - codeLocation → language → framework → modelProvider → [apiKey] → confirm
* - codeLocation → modelProvider → [apiKey] → confirm
* (language/framework not needed for BYO - user's code already has these)
*
* Note: apiKey step only appears for non-Bedrock model providers
*/
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix: skip framework/language prompts in BYOC flow by notgitika · Pull Request #179 · aws/agentcore-cli · GitHub
Skip to content
fix: skip framework/language prompts in BYOC flow#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

notgitika
merged 1 commit into

from

Feb 9, 2026
 Merged


fix: skip framework/language prompts in BYOC flow
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


80 changes: 14 additions & 66 deletions
src/cli/tui/screens/agent/AddAgentScreen.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import type { ModelProvider, SDKFramework, TargetLanguage } from '../../../../schema';
import type { ModelProvider } from '../../../../schema';
import { AgentNameSchema } from '../../../../schema';
import {
 ApiKeySecretInput,
Expand All@@ -21,9 +21,7 @@ import {
 AGENT_TYPE_OPTIONS,
 DEFAULT_ENTRYPOINT,
 DEFAULT_PYTHON_VERSION,
 FRAMEWORK_OPTIONS,
 LANGUAGE_OPTIONS,
 getModelProviderOptionsForSdk,
 MODEL_PROVIDER_OPTIONS,
} from './types';
import { Box, Text, useInput } from 'ink';
import React, { useCallback, useMemo, useState } from 'react';
Expand All@@ -50,11 +48,11 @@ interface AddAgentScreenProps {

// Steps for the initial phase (before branching to create or byo)
type InitialStep = 'name' | 'agentType';
// Steps for BYO path only
type ByoStep = 'codeLocation' | 'language' | 'framework' | 'modelProvider' | 'apiKey' | 'confirm';
// Steps for BYO path only (no framework/language - user's code already has these baked in)
type ByoStep = 'codeLocation' | 'modelProvider' | 'apiKey' | 'confirm';

const INITIAL_STEPS: InitialStep[] = ['name', 'agentType'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'language', 'framework', 'modelProvider', 'apiKey', 'confirm'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'modelProvider', 'apiKey', 'confirm'];

export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAgentScreenProps) {
 // Phase 1: name + agentType selection
Expand All@@ -66,12 +64,11 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 const generateWizard = useGenerateWizard({ initialName: name });

 // Phase 2 (byo path): BYO-specific state
 // Note: language/framework not needed for BYO - user's code already has these
 const [byoStep, setByoStep] = useState<ByoStep>('codeLocation');
 const [byoConfig, setByoConfig] = useState({
 codeLocation: '',
 entrypoint: DEFAULT_ENTRYPOINT,
 language: 'Python' as TargetLanguage,
 framework: 'Strands' as SDKFramework,
 modelProvider: 'Bedrock' as ModelProvider,
 apiKey: undefined as string | undefined,
 });
Expand DownExpand Up@@ -165,25 +162,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg

 const byoCurrentIndex = byoSteps.indexOf(byoStep);

 // BYO language options (include "Other" for BYO path)
 const languageItems: SelectableItem[] = useMemo(
 () => LANGUAGE_OPTIONS.map(o => ({ id: o.id, title: o.title, disabled: 'disabled' in o ? o.disabled : undefined })),
 []
 );

 const frameworkItems: SelectableItem[] = useMemo(
 () => FRAMEWORK_OPTIONS.map(o => ({ id: o.id, title: o.title, description: o.description })),
 []
 );

 // BYO model provider options - show ALL providers since we don't know the framework
 const modelProviderItems: SelectableItem[] = useMemo(
 () =>
getModelProviderOptionsForSdk(byoConfig.framework).map(o => ({
MODEL_PROVIDER_OPTIONS.map(o => ({
 id: o.id,
 title: o.title,
 description: o.description,
 })),
 [byoConfig.framework]
 []
 );

 const handleByoBack = useCallback(() => {
Expand All@@ -198,13 +185,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 }, [byoCurrentIndex, byoSteps]);

 const handleByoComplete = useCallback(() => {
 // For BYO, language/framework are not asked - we default to Python/Strands
 // since the actual values don't matter for BYO (code already exists)
 const config: AddAgentConfig = {
 name,
 agentType: 'byo',
 codeLocation: byoConfig.codeLocation,
 entrypoint: byoConfig.entrypoint,
 language: byoConfig.language,
 framework: byoConfig.framework,
 language: 'Python', // Default - not used for BYO agents
 framework: 'Strands', // Default - not used for BYO agents
 modelProvider: byoConfig.modelProvider,
 apiKey: byoConfig.apiKey,
 pythonVersion: DEFAULT_PYTHON_VERSION,
Expand All@@ -213,34 +202,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 onComplete(config);
 }, [name, byoConfig, onComplete]);

 const languageNav = useListNavigation({
 items: languageItems,
 onSelect: item => {
 setByoConfig(c => ({ ...c, language: item.id as TargetLanguage }));
 setByoStep('framework');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'language',
 isDisabled: item => item.disabled ?? false,
 });

 const frameworkNav = useListNavigation({
 items: frameworkItems,
 onSelect: item => {
 const newFramework = item.id as SDKFramework;
 // Reset modelProvider if it's not supported by the new framework
 const supportedProviders = getModelProviderOptionsForSdk(newFramework);
 const isCurrentProviderSupported = supportedProviders.some(p => p.id === byoConfig.modelProvider);
 const newModelProvider = isCurrentProviderSupported
 ? byoConfig.modelProvider
 : (supportedProviders[0]?.id ?? 'Bedrock');
 setByoConfig(c => ({ ...c, framework: newFramework, modelProvider: newModelProvider }));
 setByoStep('modelProvider');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'framework',
 });

 const modelProviderNav = useListNavigation({
 items: modelProviderItems,
 onSelect: item => {
Expand DownExpand Up@@ -374,21 +335,13 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 initialEntrypoint={byoConfig.entrypoint}
 onSubmit={(codeLocation, entrypoint) => {
 setByoConfig(c => ({ ...c, codeLocation, entrypoint }));
 setByoStep('language');
 setByoStep('modelProvider');
 return true;
 }}
 onCancel={handleByoBack}
 />
 )}

 {byoStep === 'language' && (
 <WizardSelect title="Select language" items={languageItems} selectedIndex={languageNav.selectedIndex} />
 )}

 {byoStep === 'framework' && (
 <WizardSelect title="Select framework" items={frameworkItems} selectedIndex={frameworkNav.selectedIndex} />
 )}

 {byoStep === 'modelProvider' && (
 <WizardSelect
 title="Select model provider"
Expand DownExpand Up@@ -417,11 +370,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 { label: 'Type', value: 'Bring my own code' },
 { label: 'Code Location', value: byoConfig.codeLocation },
 { label: 'Entrypoint', value: byoConfig.entrypoint },
 { label: 'Language', value: byoConfig.language },
 {
 label: 'Framework',
 value: FRAMEWORK_OPTIONS.find(o => o.id === byoConfig.framework)?.title ?? byoConfig.framework,
 },
 { label: 'Model Provider', value: byoConfig.modelProvider },
 ...(byoConfig.modelProvider !== 'Bedrock'
 ? [
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/tui/screens/agent/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,8 @@ export type AgentType = 'create' | 'byo';
 * - language → framework → modelProvider → [apiKey] → memory → confirm
 *
 * BYO path (agentType = 'byo'):
 * - codeLocation → language → framework → modelProvider → [apiKey] → confirm
 * - codeLocation → modelProvider → [apiKey] → confirm
 * (language/framework not needed for BYO - user's code already has these)
 *
 * Note: apiKey step only appears for non-Bedrock model providers
 */
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: skip framework/language prompts in BYOC flow by notgitika · Pull Request #179 · aws/agentcore-cli · GitHub
Skip to content
fix: skip framework/language prompts in BYOC flow#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

notgitika
merged 1 commit into

from

Feb 9, 2026
 Merged


fix: skip framework/language prompts in BYOC flow
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


80 changes: 14 additions & 66 deletions
src/cli/tui/screens/agent/AddAgentScreen.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import type { ModelProvider, SDKFramework, TargetLanguage } from '../../../../schema';
import type { ModelProvider } from '../../../../schema';
import { AgentNameSchema } from '../../../../schema';
import {
 ApiKeySecretInput,
Expand All@@ -21,9 +21,7 @@ import {
 AGENT_TYPE_OPTIONS,
 DEFAULT_ENTRYPOINT,
 DEFAULT_PYTHON_VERSION,
 FRAMEWORK_OPTIONS,
 LANGUAGE_OPTIONS,
 getModelProviderOptionsForSdk,
 MODEL_PROVIDER_OPTIONS,
} from './types';
import { Box, Text, useInput } from 'ink';
import React, { useCallback, useMemo, useState } from 'react';
Expand All@@ -50,11 +48,11 @@ interface AddAgentScreenProps {

// Steps for the initial phase (before branching to create or byo)
type InitialStep = 'name' | 'agentType';
// Steps for BYO path only
type ByoStep = 'codeLocation' | 'language' | 'framework' | 'modelProvider' | 'apiKey' | 'confirm';
// Steps for BYO path only (no framework/language - user's code already has these baked in)
type ByoStep = 'codeLocation' | 'modelProvider' | 'apiKey' | 'confirm';

const INITIAL_STEPS: InitialStep[] = ['name', 'agentType'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'language', 'framework', 'modelProvider', 'apiKey', 'confirm'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'modelProvider', 'apiKey', 'confirm'];

export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAgentScreenProps) {
 // Phase 1: name + agentType selection
Expand All@@ -66,12 +64,11 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 const generateWizard = useGenerateWizard({ initialName: name });

 // Phase 2 (byo path): BYO-specific state
 // Note: language/framework not needed for BYO - user's code already has these
 const [byoStep, setByoStep] = useState<ByoStep>('codeLocation');
 const [byoConfig, setByoConfig] = useState({
 codeLocation: '',
 entrypoint: DEFAULT_ENTRYPOINT,
 language: 'Python' as TargetLanguage,
 framework: 'Strands' as SDKFramework,
 modelProvider: 'Bedrock' as ModelProvider,
 apiKey: undefined as string | undefined,
 });
Expand DownExpand Up@@ -165,25 +162,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg

 const byoCurrentIndex = byoSteps.indexOf(byoStep);

 // BYO language options (include "Other" for BYO path)
 const languageItems: SelectableItem[] = useMemo(
 () => LANGUAGE_OPTIONS.map(o => ({ id: o.id, title: o.title, disabled: 'disabled' in o ? o.disabled : undefined })),
 []
 );

 const frameworkItems: SelectableItem[] = useMemo(
 () => FRAMEWORK_OPTIONS.map(o => ({ id: o.id, title: o.title, description: o.description })),
 []
 );

 // BYO model provider options - show ALL providers since we don't know the framework
 const modelProviderItems: SelectableItem[] = useMemo(
 () =>
getModelProviderOptionsForSdk(byoConfig.framework).map(o => ({
MODEL_PROVIDER_OPTIONS.map(o => ({
 id: o.id,
 title: o.title,
 description: o.description,
 })),
 [byoConfig.framework]
 []
 );

 const handleByoBack = useCallback(() => {
Expand All@@ -198,13 +185,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 }, [byoCurrentIndex, byoSteps]);

 const handleByoComplete = useCallback(() => {
 // For BYO, language/framework are not asked - we default to Python/Strands
 // since the actual values don't matter for BYO (code already exists)
 const config: AddAgentConfig = {
 name,
 agentType: 'byo',
 codeLocation: byoConfig.codeLocation,
 entrypoint: byoConfig.entrypoint,
 language: byoConfig.language,
 framework: byoConfig.framework,
 language: 'Python', // Default - not used for BYO agents
 framework: 'Strands', // Default - not used for BYO agents
 modelProvider: byoConfig.modelProvider,
 apiKey: byoConfig.apiKey,
 pythonVersion: DEFAULT_PYTHON_VERSION,
Expand All@@ -213,34 +202,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 onComplete(config);
 }, [name, byoConfig, onComplete]);

 const languageNav = useListNavigation({
 items: languageItems,
 onSelect: item => {
 setByoConfig(c => ({ ...c, language: item.id as TargetLanguage }));
 setByoStep('framework');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'language',
 isDisabled: item => item.disabled ?? false,
 });

 const frameworkNav = useListNavigation({
 items: frameworkItems,
 onSelect: item => {
 const newFramework = item.id as SDKFramework;
 // Reset modelProvider if it's not supported by the new framework
 const supportedProviders = getModelProviderOptionsForSdk(newFramework);
 const isCurrentProviderSupported = supportedProviders.some(p => p.id === byoConfig.modelProvider);
 const newModelProvider = isCurrentProviderSupported
 ? byoConfig.modelProvider
 : (supportedProviders[0]?.id ?? 'Bedrock');
 setByoConfig(c => ({ ...c, framework: newFramework, modelProvider: newModelProvider }));
 setByoStep('modelProvider');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'framework',
 });

 const modelProviderNav = useListNavigation({
 items: modelProviderItems,
 onSelect: item => {
Expand DownExpand Up@@ -374,21 +335,13 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 initialEntrypoint={byoConfig.entrypoint}
 onSubmit={(codeLocation, entrypoint) => {
 setByoConfig(c => ({ ...c, codeLocation, entrypoint }));
 setByoStep('language');
 setByoStep('modelProvider');
 return true;
 }}
 onCancel={handleByoBack}
 />
 )}

 {byoStep === 'language' && (
 <WizardSelect title="Select language" items={languageItems} selectedIndex={languageNav.selectedIndex} />
 )}

 {byoStep === 'framework' && (
 <WizardSelect title="Select framework" items={frameworkItems} selectedIndex={frameworkNav.selectedIndex} />
 )}

 {byoStep === 'modelProvider' && (
 <WizardSelect
 title="Select model provider"
Expand DownExpand Up@@ -417,11 +370,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 { label: 'Type', value: 'Bring my own code' },
 { label: 'Code Location', value: byoConfig.codeLocation },
 { label: 'Entrypoint', value: byoConfig.entrypoint },
 { label: 'Language', value: byoConfig.language },
 {
 label: 'Framework',
 value: FRAMEWORK_OPTIONS.find(o => o.id === byoConfig.framework)?.title ?? byoConfig.framework,
 },
 { label: 'Model Provider', value: byoConfig.modelProvider },
 ...(byoConfig.modelProvider !== 'Bedrock'
 ? [
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/tui/screens/agent/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,8 @@ export type AgentType = 'create' | 'byo';
 * - language → framework → modelProvider → [apiKey] → memory → confirm
 *
 * BYO path (agentType = 'byo'):
 * - codeLocation → language → framework → modelProvider → [apiKey] → confirm
 * - codeLocation → modelProvider → [apiKey] → confirm
 * (language/framework not needed for BYO - user's code already has these)
 *
 * Note: apiKey step only appears for non-Bedrock model providers
 */
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: skip framework/language prompts in BYOC flow by notgitika · Pull Request #179 · aws/agentcore-cli · GitHub
Skip to content
fix: skip framework/language prompts in BYOC flow#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

notgitika
merged 1 commit into

from

Feb 9, 2026
 Merged


fix: skip framework/language prompts in BYOC flow
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


80 changes: 14 additions & 66 deletions
src/cli/tui/screens/agent/AddAgentScreen.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import type { ModelProvider, SDKFramework, TargetLanguage } from '../../../../schema';
import type { ModelProvider } from '../../../../schema';
import { AgentNameSchema } from '../../../../schema';
import {
 ApiKeySecretInput,
Expand All@@ -21,9 +21,7 @@ import {
 AGENT_TYPE_OPTIONS,
 DEFAULT_ENTRYPOINT,
 DEFAULT_PYTHON_VERSION,
 FRAMEWORK_OPTIONS,
 LANGUAGE_OPTIONS,
 getModelProviderOptionsForSdk,
 MODEL_PROVIDER_OPTIONS,
} from './types';
import { Box, Text, useInput } from 'ink';
import React, { useCallback, useMemo, useState } from 'react';
Expand All@@ -50,11 +48,11 @@ interface AddAgentScreenProps {

// Steps for the initial phase (before branching to create or byo)
type InitialStep = 'name' | 'agentType';
// Steps for BYO path only
type ByoStep = 'codeLocation' | 'language' | 'framework' | 'modelProvider' | 'apiKey' | 'confirm';
// Steps for BYO path only (no framework/language - user's code already has these baked in)
type ByoStep = 'codeLocation' | 'modelProvider' | 'apiKey' | 'confirm';

const INITIAL_STEPS: InitialStep[] = ['name', 'agentType'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'language', 'framework', 'modelProvider', 'apiKey', 'confirm'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'modelProvider', 'apiKey', 'confirm'];

export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAgentScreenProps) {
 // Phase 1: name + agentType selection
Expand All@@ -66,12 +64,11 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 const generateWizard = useGenerateWizard({ initialName: name });

 // Phase 2 (byo path): BYO-specific state
 // Note: language/framework not needed for BYO - user's code already has these
 const [byoStep, setByoStep] = useState<ByoStep>('codeLocation');
 const [byoConfig, setByoConfig] = useState({
 codeLocation: '',
 entrypoint: DEFAULT_ENTRYPOINT,
 language: 'Python' as TargetLanguage,
 framework: 'Strands' as SDKFramework,
 modelProvider: 'Bedrock' as ModelProvider,
 apiKey: undefined as string | undefined,
 });
Expand DownExpand Up@@ -165,25 +162,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg

 const byoCurrentIndex = byoSteps.indexOf(byoStep);

 // BYO language options (include "Other" for BYO path)
 const languageItems: SelectableItem[] = useMemo(
 () => LANGUAGE_OPTIONS.map(o => ({ id: o.id, title: o.title, disabled: 'disabled' in o ? o.disabled : undefined })),
 []
 );

 const frameworkItems: SelectableItem[] = useMemo(
 () => FRAMEWORK_OPTIONS.map(o => ({ id: o.id, title: o.title, description: o.description })),
 []
 );

 // BYO model provider options - show ALL providers since we don't know the framework
 const modelProviderItems: SelectableItem[] = useMemo(
 () =>
getModelProviderOptionsForSdk(byoConfig.framework).map(o => ({
MODEL_PROVIDER_OPTIONS.map(o => ({
 id: o.id,
 title: o.title,
 description: o.description,
 })),
 [byoConfig.framework]
 []
 );

 const handleByoBack = useCallback(() => {
Expand All@@ -198,13 +185,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 }, [byoCurrentIndex, byoSteps]);

 const handleByoComplete = useCallback(() => {
 // For BYO, language/framework are not asked - we default to Python/Strands
 // since the actual values don't matter for BYO (code already exists)
 const config: AddAgentConfig = {
 name,
 agentType: 'byo',
 codeLocation: byoConfig.codeLocation,
 entrypoint: byoConfig.entrypoint,
 language: byoConfig.language,
 framework: byoConfig.framework,
 language: 'Python', // Default - not used for BYO agents
 framework: 'Strands', // Default - not used for BYO agents
 modelProvider: byoConfig.modelProvider,
 apiKey: byoConfig.apiKey,
 pythonVersion: DEFAULT_PYTHON_VERSION,
Expand All@@ -213,34 +202,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 onComplete(config);
 }, [name, byoConfig, onComplete]);

 const languageNav = useListNavigation({
 items: languageItems,
 onSelect: item => {
 setByoConfig(c => ({ ...c, language: item.id as TargetLanguage }));
 setByoStep('framework');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'language',
 isDisabled: item => item.disabled ?? false,
 });

 const frameworkNav = useListNavigation({
 items: frameworkItems,
 onSelect: item => {
 const newFramework = item.id as SDKFramework;
 // Reset modelProvider if it's not supported by the new framework
 const supportedProviders = getModelProviderOptionsForSdk(newFramework);
 const isCurrentProviderSupported = supportedProviders.some(p => p.id === byoConfig.modelProvider);
 const newModelProvider = isCurrentProviderSupported
 ? byoConfig.modelProvider
 : (supportedProviders[0]?.id ?? 'Bedrock');
 setByoConfig(c => ({ ...c, framework: newFramework, modelProvider: newModelProvider }));
 setByoStep('modelProvider');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'framework',
 });

 const modelProviderNav = useListNavigation({
 items: modelProviderItems,
 onSelect: item => {
Expand DownExpand Up@@ -374,21 +335,13 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 initialEntrypoint={byoConfig.entrypoint}
 onSubmit={(codeLocation, entrypoint) => {
 setByoConfig(c => ({ ...c, codeLocation, entrypoint }));
 setByoStep('language');
 setByoStep('modelProvider');
 return true;
 }}
 onCancel={handleByoBack}
 />
 )}

 {byoStep === 'language' && (
 <WizardSelect title="Select language" items={languageItems} selectedIndex={languageNav.selectedIndex} />
 )}

 {byoStep === 'framework' && (
 <WizardSelect title="Select framework" items={frameworkItems} selectedIndex={frameworkNav.selectedIndex} />
 )}

 {byoStep === 'modelProvider' && (
 <WizardSelect
 title="Select model provider"
Expand DownExpand Up@@ -417,11 +370,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 { label: 'Type', value: 'Bring my own code' },
 { label: 'Code Location', value: byoConfig.codeLocation },
 { label: 'Entrypoint', value: byoConfig.entrypoint },
 { label: 'Language', value: byoConfig.language },
 {
 label: 'Framework',
 value: FRAMEWORK_OPTIONS.find(o => o.id === byoConfig.framework)?.title ?? byoConfig.framework,
 },
 { label: 'Model Provider', value: byoConfig.modelProvider },
 ...(byoConfig.modelProvider !== 'Bedrock'
 ? [
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/tui/screens/agent/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,8 @@ export type AgentType = 'create' | 'byo';
 * - language → framework → modelProvider → [apiKey] → memory → confirm
 *
 * BYO path (agentType = 'byo'):
 * - codeLocation → language → framework → modelProvider → [apiKey] → confirm
 * - codeLocation → modelProvider → [apiKey] → confirm
 * (language/framework not needed for BYO - user's code already has these)
 *
 * Note: apiKey step only appears for non-Bedrock model providers
 */
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix: skip framework/language prompts in BYOC flow by notgitika · Pull Request #179 · aws/agentcore-cli · GitHub
Skip to content
fix: skip framework/language prompts in BYOC flow#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

notgitika
merged 1 commit into

from

Feb 9, 2026
 Merged


fix: skip framework/language prompts in BYOC flow
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


80 changes: 14 additions & 66 deletions
src/cli/tui/screens/agent/AddAgentScreen.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import type { ModelProvider, SDKFramework, TargetLanguage } from '../../../../schema';
import type { ModelProvider } from '../../../../schema';
import { AgentNameSchema } from '../../../../schema';
import {
 ApiKeySecretInput,
Expand All@@ -21,9 +21,7 @@ import {
 AGENT_TYPE_OPTIONS,
 DEFAULT_ENTRYPOINT,
 DEFAULT_PYTHON_VERSION,
 FRAMEWORK_OPTIONS,
 LANGUAGE_OPTIONS,
 getModelProviderOptionsForSdk,
 MODEL_PROVIDER_OPTIONS,
} from './types';
import { Box, Text, useInput } from 'ink';
import React, { useCallback, useMemo, useState } from 'react';
Expand All@@ -50,11 +48,11 @@ interface AddAgentScreenProps {

// Steps for the initial phase (before branching to create or byo)
type InitialStep = 'name' | 'agentType';
// Steps for BYO path only
type ByoStep = 'codeLocation' | 'language' | 'framework' | 'modelProvider' | 'apiKey' | 'confirm';
// Steps for BYO path only (no framework/language - user's code already has these baked in)
type ByoStep = 'codeLocation' | 'modelProvider' | 'apiKey' | 'confirm';

const INITIAL_STEPS: InitialStep[] = ['name', 'agentType'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'language', 'framework', 'modelProvider', 'apiKey', 'confirm'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'modelProvider', 'apiKey', 'confirm'];

export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAgentScreenProps) {
 // Phase 1: name + agentType selection
Expand All@@ -66,12 +64,11 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 const generateWizard = useGenerateWizard({ initialName: name });

 // Phase 2 (byo path): BYO-specific state
 // Note: language/framework not needed for BYO - user's code already has these
 const [byoStep, setByoStep] = useState<ByoStep>('codeLocation');
 const [byoConfig, setByoConfig] = useState({
 codeLocation: '',
 entrypoint: DEFAULT_ENTRYPOINT,
 language: 'Python' as TargetLanguage,
 framework: 'Strands' as SDKFramework,
 modelProvider: 'Bedrock' as ModelProvider,
 apiKey: undefined as string | undefined,
 });
Expand DownExpand Up@@ -165,25 +162,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg

 const byoCurrentIndex = byoSteps.indexOf(byoStep);

 // BYO language options (include "Other" for BYO path)
 const languageItems: SelectableItem[] = useMemo(
 () => LANGUAGE_OPTIONS.map(o => ({ id: o.id, title: o.title, disabled: 'disabled' in o ? o.disabled : undefined })),
 []
 );

 const frameworkItems: SelectableItem[] = useMemo(
 () => FRAMEWORK_OPTIONS.map(o => ({ id: o.id, title: o.title, description: o.description })),
 []
 );

 // BYO model provider options - show ALL providers since we don't know the framework
 const modelProviderItems: SelectableItem[] = useMemo(
 () =>
getModelProviderOptionsForSdk(byoConfig.framework).map(o => ({
MODEL_PROVIDER_OPTIONS.map(o => ({
 id: o.id,
 title: o.title,
 description: o.description,
 })),
 [byoConfig.framework]
 []
 );

 const handleByoBack = useCallback(() => {
Expand All@@ -198,13 +185,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 }, [byoCurrentIndex, byoSteps]);

 const handleByoComplete = useCallback(() => {
 // For BYO, language/framework are not asked - we default to Python/Strands
 // since the actual values don't matter for BYO (code already exists)
 const config: AddAgentConfig = {
 name,
 agentType: 'byo',
 codeLocation: byoConfig.codeLocation,
 entrypoint: byoConfig.entrypoint,
 language: byoConfig.language,
 framework: byoConfig.framework,
 language: 'Python', // Default - not used for BYO agents
 framework: 'Strands', // Default - not used for BYO agents
 modelProvider: byoConfig.modelProvider,
 apiKey: byoConfig.apiKey,
 pythonVersion: DEFAULT_PYTHON_VERSION,
Expand All@@ -213,34 +202,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 onComplete(config);
 }, [name, byoConfig, onComplete]);

 const languageNav = useListNavigation({
 items: languageItems,
 onSelect: item => {
 setByoConfig(c => ({ ...c, language: item.id as TargetLanguage }));
 setByoStep('framework');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'language',
 isDisabled: item => item.disabled ?? false,
 });

 const frameworkNav = useListNavigation({
 items: frameworkItems,
 onSelect: item => {
 const newFramework = item.id as SDKFramework;
 // Reset modelProvider if it's not supported by the new framework
 const supportedProviders = getModelProviderOptionsForSdk(newFramework);
 const isCurrentProviderSupported = supportedProviders.some(p => p.id === byoConfig.modelProvider);
 const newModelProvider = isCurrentProviderSupported
 ? byoConfig.modelProvider
 : (supportedProviders[0]?.id ?? 'Bedrock');
 setByoConfig(c => ({ ...c, framework: newFramework, modelProvider: newModelProvider }));
 setByoStep('modelProvider');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'framework',
 });

 const modelProviderNav = useListNavigation({
 items: modelProviderItems,
 onSelect: item => {
Expand DownExpand Up@@ -374,21 +335,13 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 initialEntrypoint={byoConfig.entrypoint}
 onSubmit={(codeLocation, entrypoint) => {
 setByoConfig(c => ({ ...c, codeLocation, entrypoint }));
 setByoStep('language');
 setByoStep('modelProvider');
 return true;
 }}
 onCancel={handleByoBack}
 />
 )}

 {byoStep === 'language' && (
 <WizardSelect title="Select language" items={languageItems} selectedIndex={languageNav.selectedIndex} />
 )}

 {byoStep === 'framework' && (
 <WizardSelect title="Select framework" items={frameworkItems} selectedIndex={frameworkNav.selectedIndex} />
 )}

 {byoStep === 'modelProvider' && (
 <WizardSelect
 title="Select model provider"
Expand DownExpand Up@@ -417,11 +370,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 { label: 'Type', value: 'Bring my own code' },
 { label: 'Code Location', value: byoConfig.codeLocation },
 { label: 'Entrypoint', value: byoConfig.entrypoint },
 { label: 'Language', value: byoConfig.language },
 {
 label: 'Framework',
 value: FRAMEWORK_OPTIONS.find(o => o.id === byoConfig.framework)?.title ?? byoConfig.framework,
 },
 { label: 'Model Provider', value: byoConfig.modelProvider },
 ...(byoConfig.modelProvider !== 'Bedrock'
 ? [
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/tui/screens/agent/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,8 @@ export type AgentType = 'create' | 'byo';
 * - language → framework → modelProvider → [apiKey] → memory → confirm
 *
 * BYO path (agentType = 'byo'):
 * - codeLocation → language → framework → modelProvider → [apiKey] → confirm
 * - codeLocation → modelProvider → [apiKey] → confirm
 * (language/framework not needed for BYO - user's code already has these)
 *
 * Note: apiKey step only appears for non-Bedrock model providers
 */
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: skip framework/language prompts in BYOC flow by notgitika · Pull Request #179 · aws/agentcore-cli · GitHub
Skip to content
fix: skip framework/language prompts in BYOC flow#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

notgitika
merged 1 commit into

from

Feb 9, 2026
 Merged


fix: skip framework/language prompts in BYOC flow
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


80 changes: 14 additions & 66 deletions
src/cli/tui/screens/agent/AddAgentScreen.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import type { ModelProvider, SDKFramework, TargetLanguage } from '../../../../schema';
import type { ModelProvider } from '../../../../schema';
import { AgentNameSchema } from '../../../../schema';
import {
 ApiKeySecretInput,
Expand All@@ -21,9 +21,7 @@ import {
 AGENT_TYPE_OPTIONS,
 DEFAULT_ENTRYPOINT,
 DEFAULT_PYTHON_VERSION,
 FRAMEWORK_OPTIONS,
 LANGUAGE_OPTIONS,
 getModelProviderOptionsForSdk,
 MODEL_PROVIDER_OPTIONS,
} from './types';
import { Box, Text, useInput } from 'ink';
import React, { useCallback, useMemo, useState } from 'react';
Expand All@@ -50,11 +48,11 @@ interface AddAgentScreenProps {

// Steps for the initial phase (before branching to create or byo)
type InitialStep = 'name' | 'agentType';
// Steps for BYO path only
type ByoStep = 'codeLocation' | 'language' | 'framework' | 'modelProvider' | 'apiKey' | 'confirm';
// Steps for BYO path only (no framework/language - user's code already has these baked in)
type ByoStep = 'codeLocation' | 'modelProvider' | 'apiKey' | 'confirm';

const INITIAL_STEPS: InitialStep[] = ['name', 'agentType'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'language', 'framework', 'modelProvider', 'apiKey', 'confirm'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'modelProvider', 'apiKey', 'confirm'];

export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAgentScreenProps) {
 // Phase 1: name + agentType selection
Expand All@@ -66,12 +64,11 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 const generateWizard = useGenerateWizard({ initialName: name });

 // Phase 2 (byo path): BYO-specific state
 // Note: language/framework not needed for BYO - user's code already has these
 const [byoStep, setByoStep] = useState<ByoStep>('codeLocation');
 const [byoConfig, setByoConfig] = useState({
 codeLocation: '',
 entrypoint: DEFAULT_ENTRYPOINT,
 language: 'Python' as TargetLanguage,
 framework: 'Strands' as SDKFramework,
 modelProvider: 'Bedrock' as ModelProvider,
 apiKey: undefined as string | undefined,
 });
Expand DownExpand Up@@ -165,25 +162,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg

 const byoCurrentIndex = byoSteps.indexOf(byoStep);

 // BYO language options (include "Other" for BYO path)
 const languageItems: SelectableItem[] = useMemo(
 () => LANGUAGE_OPTIONS.map(o => ({ id: o.id, title: o.title, disabled: 'disabled' in o ? o.disabled : undefined })),
 []
 );

 const frameworkItems: SelectableItem[] = useMemo(
 () => FRAMEWORK_OPTIONS.map(o => ({ id: o.id, title: o.title, description: o.description })),
 []
 );

 // BYO model provider options - show ALL providers since we don't know the framework
 const modelProviderItems: SelectableItem[] = useMemo(
 () =>
getModelProviderOptionsForSdk(byoConfig.framework).map(o => ({
MODEL_PROVIDER_OPTIONS.map(o => ({
 id: o.id,
 title: o.title,
 description: o.description,
 })),
 [byoConfig.framework]
 []
 );

 const handleByoBack = useCallback(() => {
Expand All@@ -198,13 +185,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 }, [byoCurrentIndex, byoSteps]);

 const handleByoComplete = useCallback(() => {
 // For BYO, language/framework are not asked - we default to Python/Strands
 // since the actual values don't matter for BYO (code already exists)
 const config: AddAgentConfig = {
 name,
 agentType: 'byo',
 codeLocation: byoConfig.codeLocation,
 entrypoint: byoConfig.entrypoint,
 language: byoConfig.language,
 framework: byoConfig.framework,
 language: 'Python', // Default - not used for BYO agents
 framework: 'Strands', // Default - not used for BYO agents
 modelProvider: byoConfig.modelProvider,
 apiKey: byoConfig.apiKey,
 pythonVersion: DEFAULT_PYTHON_VERSION,
Expand All@@ -213,34 +202,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 onComplete(config);
 }, [name, byoConfig, onComplete]);

 const languageNav = useListNavigation({
 items: languageItems,
 onSelect: item => {
 setByoConfig(c => ({ ...c, language: item.id as TargetLanguage }));
 setByoStep('framework');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'language',
 isDisabled: item => item.disabled ?? false,
 });

 const frameworkNav = useListNavigation({
 items: frameworkItems,
 onSelect: item => {
 const newFramework = item.id as SDKFramework;
 // Reset modelProvider if it's not supported by the new framework
 const supportedProviders = getModelProviderOptionsForSdk(newFramework);
 const isCurrentProviderSupported = supportedProviders.some(p => p.id === byoConfig.modelProvider);
 const newModelProvider = isCurrentProviderSupported
 ? byoConfig.modelProvider
 : (supportedProviders[0]?.id ?? 'Bedrock');
 setByoConfig(c => ({ ...c, framework: newFramework, modelProvider: newModelProvider }));
 setByoStep('modelProvider');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'framework',
 });

 const modelProviderNav = useListNavigation({
 items: modelProviderItems,
 onSelect: item => {
Expand DownExpand Up@@ -374,21 +335,13 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 initialEntrypoint={byoConfig.entrypoint}
 onSubmit={(codeLocation, entrypoint) => {
 setByoConfig(c => ({ ...c, codeLocation, entrypoint }));
 setByoStep('language');
 setByoStep('modelProvider');
 return true;
 }}
 onCancel={handleByoBack}
 />
 )}

 {byoStep === 'language' && (
 <WizardSelect title="Select language" items={languageItems} selectedIndex={languageNav.selectedIndex} />
 )}

 {byoStep === 'framework' && (
 <WizardSelect title="Select framework" items={frameworkItems} selectedIndex={frameworkNav.selectedIndex} />
 )}

 {byoStep === 'modelProvider' && (
 <WizardSelect
 title="Select model provider"
Expand DownExpand Up@@ -417,11 +370,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 { label: 'Type', value: 'Bring my own code' },
 { label: 'Code Location', value: byoConfig.codeLocation },
 { label: 'Entrypoint', value: byoConfig.entrypoint },
 { label: 'Language', value: byoConfig.language },
 {
 label: 'Framework',
 value: FRAMEWORK_OPTIONS.find(o => o.id === byoConfig.framework)?.title ?? byoConfig.framework,
 },
 { label: 'Model Provider', value: byoConfig.modelProvider },
 ...(byoConfig.modelProvider !== 'Bedrock'
 ? [
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/tui/screens/agent/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,8 @@ export type AgentType = 'create' | 'byo';
 * - language → framework → modelProvider → [apiKey] → memory → confirm
 *
 * BYO path (agentType = 'byo'):
 * - codeLocation → language → framework → modelProvider → [apiKey] → confirm
 * - codeLocation → modelProvider → [apiKey] → confirm
 * (language/framework not needed for BYO - user's code already has these)
 *
 * Note: apiKey step only appears for non-Bedrock model providers
 */
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: skip framework/language prompts in BYOC flow by notgitika · Pull Request #179 · aws/agentcore-cli · GitHub
Skip to content
fix: skip framework/language prompts in BYOC flow#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

notgitika
merged 1 commit into

from

Feb 9, 2026
 Merged


fix: skip framework/language prompts in BYOC flow
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


80 changes: 14 additions & 66 deletions
src/cli/tui/screens/agent/AddAgentScreen.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import type { ModelProvider, SDKFramework, TargetLanguage } from '../../../../schema';
import type { ModelProvider } from '../../../../schema';
import { AgentNameSchema } from '../../../../schema';
import {
 ApiKeySecretInput,
Expand All@@ -21,9 +21,7 @@ import {
 AGENT_TYPE_OPTIONS,
 DEFAULT_ENTRYPOINT,
 DEFAULT_PYTHON_VERSION,
 FRAMEWORK_OPTIONS,
 LANGUAGE_OPTIONS,
 getModelProviderOptionsForSdk,
 MODEL_PROVIDER_OPTIONS,
} from './types';
import { Box, Text, useInput } from 'ink';
import React, { useCallback, useMemo, useState } from 'react';
Expand All@@ -50,11 +48,11 @@ interface AddAgentScreenProps {

// Steps for the initial phase (before branching to create or byo)
type InitialStep = 'name' | 'agentType';
// Steps for BYO path only
type ByoStep = 'codeLocation' | 'language' | 'framework' | 'modelProvider' | 'apiKey' | 'confirm';
// Steps for BYO path only (no framework/language - user's code already has these baked in)
type ByoStep = 'codeLocation' | 'modelProvider' | 'apiKey' | 'confirm';

const INITIAL_STEPS: InitialStep[] = ['name', 'agentType'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'language', 'framework', 'modelProvider', 'apiKey', 'confirm'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'modelProvider', 'apiKey', 'confirm'];

export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAgentScreenProps) {
 // Phase 1: name + agentType selection
Expand All@@ -66,12 +64,11 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 const generateWizard = useGenerateWizard({ initialName: name });

 // Phase 2 (byo path): BYO-specific state
 // Note: language/framework not needed for BYO - user's code already has these
 const [byoStep, setByoStep] = useState<ByoStep>('codeLocation');
 const [byoConfig, setByoConfig] = useState({
 codeLocation: '',
 entrypoint: DEFAULT_ENTRYPOINT,
 language: 'Python' as TargetLanguage,
 framework: 'Strands' as SDKFramework,
 modelProvider: 'Bedrock' as ModelProvider,
 apiKey: undefined as string | undefined,
 });
Expand DownExpand Up@@ -165,25 +162,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg

 const byoCurrentIndex = byoSteps.indexOf(byoStep);

 // BYO language options (include "Other" for BYO path)
 const languageItems: SelectableItem[] = useMemo(
 () => LANGUAGE_OPTIONS.map(o => ({ id: o.id, title: o.title, disabled: 'disabled' in o ? o.disabled : undefined })),
 []
 );

 const frameworkItems: SelectableItem[] = useMemo(
 () => FRAMEWORK_OPTIONS.map(o => ({ id: o.id, title: o.title, description: o.description })),
 []
 );

 // BYO model provider options - show ALL providers since we don't know the framework
 const modelProviderItems: SelectableItem[] = useMemo(
 () =>
getModelProviderOptionsForSdk(byoConfig.framework).map(o => ({
MODEL_PROVIDER_OPTIONS.map(o => ({
 id: o.id,
 title: o.title,
 description: o.description,
 })),
 [byoConfig.framework]
 []
 );

 const handleByoBack = useCallback(() => {
Expand All@@ -198,13 +185,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 }, [byoCurrentIndex, byoSteps]);

 const handleByoComplete = useCallback(() => {
 // For BYO, language/framework are not asked - we default to Python/Strands
 // since the actual values don't matter for BYO (code already exists)
 const config: AddAgentConfig = {
 name,
 agentType: 'byo',
 codeLocation: byoConfig.codeLocation,
 entrypoint: byoConfig.entrypoint,
 language: byoConfig.language,
 framework: byoConfig.framework,
 language: 'Python', // Default - not used for BYO agents
 framework: 'Strands', // Default - not used for BYO agents
 modelProvider: byoConfig.modelProvider,
 apiKey: byoConfig.apiKey,
 pythonVersion: DEFAULT_PYTHON_VERSION,
Expand All@@ -213,34 +202,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 onComplete(config);
 }, [name, byoConfig, onComplete]);

 const languageNav = useListNavigation({
 items: languageItems,
 onSelect: item => {
 setByoConfig(c => ({ ...c, language: item.id as TargetLanguage }));
 setByoStep('framework');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'language',
 isDisabled: item => item.disabled ?? false,
 });

 const frameworkNav = useListNavigation({
 items: frameworkItems,
 onSelect: item => {
 const newFramework = item.id as SDKFramework;
 // Reset modelProvider if it's not supported by the new framework
 const supportedProviders = getModelProviderOptionsForSdk(newFramework);
 const isCurrentProviderSupported = supportedProviders.some(p => p.id === byoConfig.modelProvider);
 const newModelProvider = isCurrentProviderSupported
 ? byoConfig.modelProvider
 : (supportedProviders[0]?.id ?? 'Bedrock');
 setByoConfig(c => ({ ...c, framework: newFramework, modelProvider: newModelProvider }));
 setByoStep('modelProvider');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'framework',
 });

 const modelProviderNav = useListNavigation({
 items: modelProviderItems,
 onSelect: item => {
Expand DownExpand Up@@ -374,21 +335,13 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 initialEntrypoint={byoConfig.entrypoint}
 onSubmit={(codeLocation, entrypoint) => {
 setByoConfig(c => ({ ...c, codeLocation, entrypoint }));
 setByoStep('language');
 setByoStep('modelProvider');
 return true;
 }}
 onCancel={handleByoBack}
 />
 )}

 {byoStep === 'language' && (
 <WizardSelect title="Select language" items={languageItems} selectedIndex={languageNav.selectedIndex} />
 )}

 {byoStep === 'framework' && (
 <WizardSelect title="Select framework" items={frameworkItems} selectedIndex={frameworkNav.selectedIndex} />
 )}

 {byoStep === 'modelProvider' && (
 <WizardSelect
 title="Select model provider"
Expand DownExpand Up@@ -417,11 +370,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 { label: 'Type', value: 'Bring my own code' },
 { label: 'Code Location', value: byoConfig.codeLocation },
 { label: 'Entrypoint', value: byoConfig.entrypoint },
 { label: 'Language', value: byoConfig.language },
 {
 label: 'Framework',
 value: FRAMEWORK_OPTIONS.find(o => o.id === byoConfig.framework)?.title ?? byoConfig.framework,
 },
 { label: 'Model Provider', value: byoConfig.modelProvider },
 ...(byoConfig.modelProvider !== 'Bedrock'
 ? [
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/tui/screens/agent/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,8 @@ export type AgentType = 'create' | 'byo';
 * - language → framework → modelProvider → [apiKey] → memory → confirm
 *
 * BYO path (agentType = 'byo'):
 * - codeLocation → language → framework → modelProvider → [apiKey] → confirm
 * - codeLocation → modelProvider → [apiKey] → confirm
 * (language/framework not needed for BYO - user's code already has these)
 *
 * Note: apiKey step only appears for non-Bedrock model providers
 */
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix: skip framework/language prompts in BYOC flow by notgitika · Pull Request #179 · aws/agentcore-cli · GitHub
Skip to content
fix: skip framework/language prompts in BYOC flow#179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

notgitika
merged 1 commit into

from

Feb 9, 2026
 Merged


fix: skip framework/language prompts in BYOC flow
#179
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


80 changes: 14 additions & 66 deletions
src/cli/tui/screens/agent/AddAgentScreen.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import type { ModelProvider, SDKFramework, TargetLanguage } from '../../../../schema';
import type { ModelProvider } from '../../../../schema';
import { AgentNameSchema } from '../../../../schema';
import {
 ApiKeySecretInput,
Expand All@@ -21,9 +21,7 @@ import {
 AGENT_TYPE_OPTIONS,
 DEFAULT_ENTRYPOINT,
 DEFAULT_PYTHON_VERSION,
 FRAMEWORK_OPTIONS,
 LANGUAGE_OPTIONS,
 getModelProviderOptionsForSdk,
 MODEL_PROVIDER_OPTIONS,
} from './types';
import { Box, Text, useInput } from 'ink';
import React, { useCallback, useMemo, useState } from 'react';
Expand All@@ -50,11 +48,11 @@ interface AddAgentScreenProps {

// Steps for the initial phase (before branching to create or byo)
type InitialStep = 'name' | 'agentType';
// Steps for BYO path only
type ByoStep = 'codeLocation' | 'language' | 'framework' | 'modelProvider' | 'apiKey' | 'confirm';
// Steps for BYO path only (no framework/language - user's code already has these baked in)
type ByoStep = 'codeLocation' | 'modelProvider' | 'apiKey' | 'confirm';

const INITIAL_STEPS: InitialStep[] = ['name', 'agentType'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'language', 'framework', 'modelProvider', 'apiKey', 'confirm'];
const BYO_STEPS: ByoStep[] = ['codeLocation', 'modelProvider', 'apiKey', 'confirm'];

export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAgentScreenProps) {
 // Phase 1: name + agentType selection
Expand All@@ -66,12 +64,11 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 const generateWizard = useGenerateWizard({ initialName: name });

 // Phase 2 (byo path): BYO-specific state
 // Note: language/framework not needed for BYO - user's code already has these
 const [byoStep, setByoStep] = useState<ByoStep>('codeLocation');
 const [byoConfig, setByoConfig] = useState({
 codeLocation: '',
 entrypoint: DEFAULT_ENTRYPOINT,
 language: 'Python' as TargetLanguage,
 framework: 'Strands' as SDKFramework,
 modelProvider: 'Bedrock' as ModelProvider,
 apiKey: undefined as string | undefined,
 });
Expand DownExpand Up@@ -165,25 +162,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg

 const byoCurrentIndex = byoSteps.indexOf(byoStep);

 // BYO language options (include "Other" for BYO path)
 const languageItems: SelectableItem[] = useMemo(
 () => LANGUAGE_OPTIONS.map(o => ({ id: o.id, title: o.title, disabled: 'disabled' in o ? o.disabled : undefined })),
 []
 );

 const frameworkItems: SelectableItem[] = useMemo(
 () => FRAMEWORK_OPTIONS.map(o => ({ id: o.id, title: o.title, description: o.description })),
 []
 );

 // BYO model provider options - show ALL providers since we don't know the framework
 const modelProviderItems: SelectableItem[] = useMemo(
 () =>
getModelProviderOptionsForSdk(byoConfig.framework).map(o => ({
MODEL_PROVIDER_OPTIONS.map(o => ({
 id: o.id,
 title: o.title,
 description: o.description,
 })),
 [byoConfig.framework]
 []
 );

 const handleByoBack = useCallback(() => {
Expand All@@ -198,13 +185,15 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 }, [byoCurrentIndex, byoSteps]);

 const handleByoComplete = useCallback(() => {
 // For BYO, language/framework are not asked - we default to Python/Strands
 // since the actual values don't matter for BYO (code already exists)
 const config: AddAgentConfig = {
 name,
 agentType: 'byo',
 codeLocation: byoConfig.codeLocation,
 entrypoint: byoConfig.entrypoint,
 language: byoConfig.language,
 framework: byoConfig.framework,
 language: 'Python', // Default - not used for BYO agents
 framework: 'Strands', // Default - not used for BYO agents
 modelProvider: byoConfig.modelProvider,
 apiKey: byoConfig.apiKey,
 pythonVersion: DEFAULT_PYTHON_VERSION,
Expand All@@ -213,34 +202,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 onComplete(config);
 }, [name, byoConfig, onComplete]);

 const languageNav = useListNavigation({
 items: languageItems,
 onSelect: item => {
 setByoConfig(c => ({ ...c, language: item.id as TargetLanguage }));
 setByoStep('framework');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'language',
 isDisabled: item => item.disabled ?? false,
 });

 const frameworkNav = useListNavigation({
 items: frameworkItems,
 onSelect: item => {
 const newFramework = item.id as SDKFramework;
 // Reset modelProvider if it's not supported by the new framework
 const supportedProviders = getModelProviderOptionsForSdk(newFramework);
 const isCurrentProviderSupported = supportedProviders.some(p => p.id === byoConfig.modelProvider);
 const newModelProvider = isCurrentProviderSupported
 ? byoConfig.modelProvider
 : (supportedProviders[0]?.id ?? 'Bedrock');
 setByoConfig(c => ({ ...c, framework: newFramework, modelProvider: newModelProvider }));
 setByoStep('modelProvider');
 },
 onExit: handleByoBack,
 isActive: isByoPath && byoStep === 'framework',
 });

 const modelProviderNav = useListNavigation({
 items: modelProviderItems,
 onSelect: item => {
Expand DownExpand Up@@ -374,21 +335,13 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 initialEntrypoint={byoConfig.entrypoint}
 onSubmit={(codeLocation, entrypoint) => {
 setByoConfig(c => ({ ...c, codeLocation, entrypoint }));
 setByoStep('language');
 setByoStep('modelProvider');
 return true;
 }}
 onCancel={handleByoBack}
 />
 )}

 {byoStep === 'language' && (
 <WizardSelect title="Select language" items={languageItems} selectedIndex={languageNav.selectedIndex} />
 )}

 {byoStep === 'framework' && (
 <WizardSelect title="Select framework" items={frameworkItems} selectedIndex={frameworkNav.selectedIndex} />
 )}

 {byoStep === 'modelProvider' && (
 <WizardSelect
 title="Select model provider"
Expand DownExpand Up@@ -417,11 +370,6 @@ export function AddAgentScreen({ existingAgentNames, onComplete, onExit }: AddAg
 { label: 'Type', value: 'Bring my own code' },
 { label: 'Code Location', value: byoConfig.codeLocation },
 { label: 'Entrypoint', value: byoConfig.entrypoint },
 { label: 'Language', value: byoConfig.language },
 {
 label: 'Framework',
 value: FRAMEWORK_OPTIONS.find(o => o.id === byoConfig.framework)?.title ?? byoConfig.framework,
 },
 { label: 'Model Provider', value: byoConfig.modelProvider },
 ...(byoConfig.modelProvider !== 'Bedrock'
 ? [
Expand Down

3 changes: 2 additions & 1 deletion
src/cli/tui/screens/agent/types.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,8 @@ export type AgentType = 'create' | 'byo';
 * - language → framework → modelProvider → [apiKey] → memory → confirm
 *
 * BYO path (agentType = 'byo'):
 * - codeLocation → language → framework → modelProvider → [apiKey] → confirm
 * - codeLocation → modelProvider → [apiKey] → confirm
 * (language/framework not needed for BYO - user's code already has these)
 *
 * Note: apiKey step only appears for non-Bedrock model providers
 */
Expand Down
Loading