Uh oh!
There was an error while loading. Please reload this page.
feat: add read-only datasets TUI - #1932
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## refactor #1932 +/- ##
============================================
+ Coverage 96.94% 96.96% +0.01%
============================================
Files 360 364 +4 Lines 20596 20758 +162 ============================================
+ Hits 19966 20127 +161 - Misses 630 631 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cc71c64 to
13bf522Compare13bf522 to
e9e6be7Compare
jariy17
left a comment
There was a problem hiding this comment.
Seperate the update commands in their own PR
| import { coreOptsFromCtx } from "../../../utils"; | ||
| export const createUpdateDatasetHandler = (core: Core, io: AppIO) => | ||
| export const createUpdateDatasetHandler = (core: Core) => |
There was a problem hiding this comment.
Seperate the write only dataset handlers into their own pr.
There was a problem hiding this comment.
This PR was incorrectly pulling in commits from the dataset update CLI command PR. That's why this file was showing up. The PR is now showing the correct commits/diff now that I've fixed conflicts and rebased
e9e6be7 to
9e682f1Compare| <ResourceDetailScreen | ||
| breadcrumb={["agentcore", "eval", "dataset", "get", datasetId ?? ""]} | ||
| isPending={detail.isPending} | ||
| error={detail.isError ? (detail.error as Error) : null} |
There was a problem hiding this comment.
should we use AgentCoreCLIError.from here?
There was a problem hiding this comment.
Hmm yeah looking into it now, this is a good call out. It would probably make the most sense to use AgentCoreCLIError.from inside ResourceDetailScreen and the other shared resources. That way the its standardized across all screens. The call site would then just do:detail.isError ? detail.error : null
9e682f1 to
84034b5CompareUh oh!
There was an error while loading. Please reload this page.
Adds an interactive, read-only TUI for the
eval datasetcommand tree. Follows conventional menu → list → detail → JSON flow. Bare commandseval dataset,eval dataset list,eval dataset getnow open TUI flows instead of missing flag error messaging.Screens
eval datasetRouterScreenmenueval dataset list/eval dataset getDatasetPickerusingPaginatedTablePickereval dataset get/:datasetIdResourceDetailScreeneval dataset get/:datasetId/jsonJsonDetailTesting
dataset.screen.test.tsxcovering navigation, menu filtering, metadata rendering, etc.bun run test(892 pass, 0 fail)Stack created with GitHub Stacks CLI • Give Feedback 💬