') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(evaluator): derived --config, region fallback, base-id regex, llm-context by jariy17 · Pull Request #2027 · aws/agentcore-cli · GitHub
Skip to content

fix(evaluator): derived --config, region fallback, base-id regex, llm-context - #2027

Merged
jariy17 merged 2 commits into
Dervived_evaluatorsfrom
derived_fixes
Aug 18, 2026
Merged

fix(evaluator): derived --config, region fallback, base-id regex, llm-context#2027
jariy17 merged 2 commits into
Dervived_evaluatorsfrom
derived_fixes

Conversation

@jariy17

@jariy17jariy17 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Follow-up fixes from the derived-evaluators bug bash (P2/P3), stacked on Dervived_evaluators.

Fixes

  1. P2 — --config for derived — --type derived --config x.json demanded --base-evaluator-id, and explicit derived flags + a nonexistent --config silently ignored the file. Cause: the derived arm ran before the config loader. Now --config is rejected for --type derived with a clear message (use --base-evaluator-id + --model).
  2. P2 — profile-only region — auto-level lookup failed on a fresh project (empty aws-targets.json) when the region came only from the AWS profile. resolveAWSDeploymentTargets() maps over an empty array and drops the fallback. Now uses ConfigIO.resolveRegionFallback() (made public) which returns the scalar env→profile fallback.
  3. P3 — loose base-id regex — BASE_EVALUATOR_ID_PATTERN accepted malformed ids (ThirdParty.DeepEval, ThirdParty..ToolUse, ThirdParty.DeepEval.) which --level then persisted. Tightened to Builtin.<Metric> / ThirdParty.<Provider>.<Metric>.
  4. P3 — stale .llm-context — llm-compacted schema still described config as llmAsAJudge | codeBased; synced in the derived arm so generated project guidance matches runtime Zod.

Verification

  • Typecheck clean (pre-existing agentcore-control.ts:546 SDK-model error unrelated).
  • Evaluator schema + primitive unit tests pass.
  • Behavioral smokes: --type derived --config → rejected; ThirdParty.DeepEval (+--level) → rejected; valid derived still writes correct config.

jariy17
fix(evaluator): derived --config handling, region fallback, base-id r…
320201e
…egex, llm-context
Follow-up fixes from the derived bug bash:
- Reject --config with --type derived instead of silently ignoring it (the
derived arm ran before the config loader).
- Resolve the base metric's region via ConfigIO.resolveRegionFallback so a
profile-only region works on a fresh project with no saved deploy targets
(the old path mapped over an empty targets array and dropped the fallback).
- Tighten BASE_EVALUATOR_ID_PATTERN to Builtin.<Metric> / ThirdParty.<Provider>.<Metric>;
rejects malformed ids (ThirdParty.DeepEval, ThirdParty..ToolUse, trailing dot)
that --level previously let through.
- Sync llm-compacted schema so generated project guidance includes the derived arm.
@github-actionsgithub-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 18, 2026
jariy17
refactor: drop redundant try/catch in region resolution
075e1a0
resolveRegionFallback already checks env vars first and returns undefined
rather than throwing (it's called bare in resolveAWSDeploymentTargets), so the
catch that re-read the env vars was dead.
@jariy17
jariy17 merged commit 5faa177 into Dervived_evaluatorsAug 18, 2026
2 checks passed
@jariy17
jariy17 deleted the derived_fixes branch August 18, 2026 21:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidandaly24aidandaly24aidandaly24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jariy17@aidandaly24