Skip to content

feat(capacity-provider): add capacity-provider resource (Journey 1) - #2030

Merged
xxuam merged 2 commits into
mainfrom
feat/capacity-provider-journey1
Aug 19, 2026
Merged

feat(capacity-provider): add capacity-provider resource (Journey 1)#2030
xxuam merged 2 commits into
mainfrom
feat/capacity-provider-journey1

Conversation

@xxuam

@xxuamxxuam commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the capacity-provider resource — a customer-managed pool of AWS-managed
EC2 compute that agent runtimes can run on instead of the default managed fleet.

Changes:

  • CapacityProviderPrimitive (create/remove) with CLI flags (--name,
    --operator-role-arn, --subnets, --security-groups, --os,
    --instance-types, --volume/--volume-encrypted/--volume-kms-key,
    --instance-profile-arn, --idle-instance-timeout, --max-lifetime,
    --description).
  • Zod schema for the capacity-provider spec (nested compute/VPC/volume/
    lifecycle config), added to the project spec.
  • Interactive TUI — add wizard and remove picker.
  • Telemetry — add/remove command-run instrumentation + OperatingSystem enum.
  • Deploy/status plumbing — CloudFormation output parsing, deployed-state
    schema, preflight empty-project guard (so a CP-only project isn't misread as a
    teardown), and ResourceGraph rendering.
  • Docs (AGENTS.md, README, docs/commands.md) and integration tests.

This is the CLI half of Capacity Provider Journey 1 (create/remove a standalone
capacity provider). The AgentCoreCapacityProvider L3 construct lands in a
companion PR in aws/agentcore-l3-cdk-constructs.

The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 in this PR until the L3
construct publishes a new alpha; a follow-up commit bumps it.

Related Issue

Closes #

Documentation PR

Type of Change

  • New feature

Testing

How have you tested the change?

Ran the full unit suite (6128 passing) and integration suite (344 passing,
including integ-tests/add-remove-capacity-provider.test.ts which exercises
add → inspect JSON → remove against the real CLI binary). Also live-validated
the full create → deploy → update → remove lifecycle against real AWS.

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

@xxuam@claude
feat(capacity-provider): add capacity-provider resource (Journey 1)
da9ab44
Add the CapacityProviderPrimitive (create/remove) for a customer-managed EC2
compute pool that runtimes can run on. Includes the Zod schema, primitive with
CLI flags, interactive TUI add wizard and remove picker, telemetry (add/remove
command-run + OperatingSystem enum), and deploy/status plumbing: CloudFormation
output parsing, deployed-state schema, preflight empty-project guard, and
ResourceGraph rendering. Docs (AGENTS.md, README, commands) and integ tests
included.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 until the L3 construct
publishes a new alpha; a follow-up bumps it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@xxuam
xxuam requested a review from a teamAugust 18, 2026 21:05
@github-actionsgithub-actionsBot added size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 18, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 18, 2026
@agentcore-devx-automation

agentcore-devx-automationBot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 18, 2026
@github-actionsgithub-actionsBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 18, 2026
tejaskash
tejaskash reviewed Aug 19, 2026
View reviewed changes
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts Outdated
tejaskash
tejaskash reviewed Aug 19, 2026
View reviewed changes

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down together with the L3 PR (#328, wired in as a local tarball) and ran the full lifecycle against a real account in us-west-2: create → add capacity-provider → deploy → status → remove → teardown. Everything worked end to end — the CFN resource came up, the Id/Arn outputs landed in deployed-state, status showed it as deployed, and removing the last capacity provider correctly tore the stack down instead of tripping the empty-project check.

A few findings below, roughly in priority order. One note from the live test that isn't tied to a line: when the capacity provider fails asynchronously (e.g. the operator role is missing events:PutRule), CloudFormation only says NotStabilized — the real reason is only visible via GetCapacityProvider.statusReason. Not this PR's bug, but worth raising with the service team.

Comment threadsrc/cli/operations/deploy/preflight.ts Outdated
Comment threadsrc/cli/primitives/CapacityProviderPrimitive.ts Outdated
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts Outdated
Comment threadsrc/cli/commands/remove/command.tsx
Comment threadsrc/cli/tui/screens/add/AddScreen.tsx Outdated
@xxuam@claude
fix(capacity-provider): address review — TagsSchema, ARN partitions, …
fcd27cb
…deployable-resource preflight, volume parsing, TUI parity, optional operator role
Address PR #2030 review feedback:
- tags: use shared TagsSchema (mirrors the CDK schema) instead of a plain string record
- ARN patterns (operator-role, instance-profile, KMS): partition-agnostic arn:[^:]+: per
AGENTS.md; drop now-unneeded eslint-disable directives
- preflight: replace the hand-maintained hasX teardown chain with a typed
hasDeployableResources(spec) + DEPLOYABLE_RESOURCE_KEYS, fixing latent drift where a
project containing only configBundles or onlineEvalConfigs was misclassified as empty
- --volume parse: require exactly name:sizeGiB (segment count + digit regex), rejecting
data:20:gp3, hex (0x14), and exponent (2e1) that Number() silently accepted
- TUI: remove-all confirmation now enumerates capacity providers; add screen shows
"Capacity Provider [preview]" to match the remove screen
- operator role: --operator-role-arn is now optional (auto-created at deploy when omitted,
matching the CDK construct); supplying an ARN is a bring-your-own override. Docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 19, 2026
@agentcore-devx-automationagentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 19, 2026
@agentcore-devx-automation

agentcore-devx-automationBot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automationagentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 19, 2026
@github-actions

github-actionsBot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

StatusCategoryPercentageCovered / Total
🔵Lines40.65%15382 / 37840
🔵Statements39.92%16403 / 41089
🔵Functions34.8%2640 / 7586
🔵Branches33.95%10239 / 30156
Generated in workflow #4358 for commit fcd27cb by the Vitest Coverage Report Action

tejaskash
tejaskash approved these changes Aug 19, 2026
View reviewed changes

@tejaskashtejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxuam
xxuam merged commit 72cb257 into mainAug 19, 2026
96 of 99 checks passed
@xxuam
xxuam deleted the feat/capacity-provider-journey1 branch August 19, 2026 19:44
@aidandaly24aidandaly24 mentioned this pull request Aug 19, 2026
Merged
16 tasks
@xxuamxxuam mentioned this pull request Aug 22, 2026
Open
15 tasks
@aidandaly24aidandaly24 mentioned this pull request Aug 26, 2026
Merged
15 tasks
@xxuamxxuam mentioned this pull request Aug 27, 2026
Merged
15 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tejaskashtejaskashtejaskash approved these changes

Assignees

No one assigned

Labels

size/xlPR size: XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xxuam@tejaskash
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(capacity-provider): add capacity-provider resource (Journey 1) by xxuam · Pull Request #2030 · aws/agentcore-cli · GitHub
Skip to content
feat(capacity-provider): add capacity-provider resource (Journey 1) - #2030
Merged
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Aug 19, 2026
Merged
feat(capacity-provider): add capacity-provider resource (Journey 1)#2030
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Conversation
@xxuam
@xxuamxxuam
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Description
Adds the capacity-provider resource — a customer-managed pool of AWS-managed

EC2 compute that agent runtimes can run on instead of the default managed fleet.
Changes:
  • CapacityProviderPrimitive (create/remove) with CLI flags (--name,
    --operator-role-arn, --subnets, --security-groups, --os,
    --instance-types, --volume/--volume-encrypted/--volume-kms-key,
    --instance-profile-arn, --idle-instance-timeout, --max-lifetime,
    --description).
  • Zod schema for the capacity-provider spec (nested compute/VPC/volume/
    
lifecycle config), added to the project spec.
  • Interactive TUI — add wizard and remove picker.
  • Telemetry — add/remove command-run instrumentation + OperatingSystem enum.
  • Deploy/status plumbing — CloudFormation output parsing, deployed-state
    
schema, preflight empty-project guard (so a CP-only project isn't misread as a
    
teardown), and ResourceGraph rendering.
  • Docs (AGENTS.md, README, docs/commands.md) and integration tests.
This is the CLI half of Capacity Provider Journey 1 (create/remove a standalone

capacity provider). The AgentCoreCapacityProvider L3 construct lands in a

companion PR in aws/agentcore-l3-cdk-constructs.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 in this PR until the L3

construct publishes a new alpha; a follow-up commit bumps it.
Related Issue
Closes #
Documentation PR
Type of Change
  •  New feature
Testing
How have you tested the change?
Ran the full unit suite (6128 passing) and integration suite (344 passing,

including integ-tests/add-remove-capacity-provider.test.ts which exercises

add → inspect JSON → remove against the real CLI binary). Also live-validated

the full create → deploy → update → remove lifecycle against real AWS.
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
@xxuam@claude
feat(capacity-provider): add capacity-provider resource (Journey 1)
da9ab44
Add the CapacityProviderPrimitive (create/remove) for a customer-managed EC2
compute pool that runtimes can run on. Includes the Zod schema, primitive with
CLI flags, interactive TUI add wizard and remove picker, telemetry (add/remove
command-run + OperatingSystem enum), and deploy/status plumbing: CloudFormation
output parsing, deployed-state schema, preflight empty-project guard, and
ResourceGraph rendering. Docs (AGENTS.md, README, commands) and integ tests
included.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 until the L3 construct
publishes a new alpha; a follow-up bumps it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@xxuam
xxuam
requested a review
from a teamAugust 18, 2026 21:05
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
agentcore-harness-reviewing
AgentCore Harness review in progress
labels
Aug 18, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
agentcore-harness-reviewing
AgentCore Harness review in progress
label
Aug 18, 2026
tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down together with the L3 PR (#328, wired in as a local tarball) and ran the full lifecycle against a real account in us-west-2: create → add capacity-provider → deploy → status → remove → teardown. Everything worked end to end — the CFN resource came up, the Id/Arn outputs landed in deployed-state, status showed it as deployed, and removing the last capacity provider correctly tore the stack down instead of tripping the empty-project check.
A few findings below, roughly in priority order. One note from the live test that isn't tied to a line: when the capacity provider fails asynchronously (e.g. the operator role is missing events:PutRule), CloudFormation only says NotStabilized — the real reason is only visible via GetCapacityProvider.statusReason. Not this PR's bug, but worth raising with the service team.
Comment threadsrc/cli/operations/deploy/preflight.ts
Outdated

Comment threadsrc/cli/primitives/CapacityProviderPrimitive.ts
Outdated

Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

Comment threadsrc/cli/commands/remove/command.tsx
Comment threadsrc/cli/tui/screens/add/AddScreen.tsx
Outdated

@xxuam@claude
fix(capacity-provider): address review — TagsSchema, ARN partitions, …
fcd27cb
…deployable-resource preflight, volume parsing, TUI parity, optional operator role
Address PR #2030 review feedback:
- tags: use shared TagsSchema (mirrors the CDK schema) instead of a plain string record
- ARN patterns (operator-role, instance-profile, KMS): partition-agnostic arn:[^:]+: per
AGENTS.md; drop now-unneeded eslint-disable directives
- preflight: replace the hand-maintained hasX teardown chain with a typed
hasDeployableResources(spec) + DEPLOYABLE_RESOURCE_KEYS, fixing latent drift where a
project containing only configBundles or onlineEvalConfigs was misclassified as empty
- --volume parse: require exactly name:sizeGiB (segment count + digit regex), rejecting
data:20:gp3, hex (0x14), and exponent (2e1) that Number() silently accepted
- TUI: remove-all confirmation now enumerates capacity providers; add screen shows
"Capacity Provider [preview]" to match the remove screen
- operator role: --operator-role-arn is now optional (auto-created at deploy when omitted,
matching the CDK construct); supplying an ARN is a bring-your-own override. Docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
and removed

size/xl
PR size: XL
labels
Aug 19, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@github-actions
github-actionsBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines40.65%15382 / 37840
🔵Statements39.92%16403 / 41089
🔵Functions34.8%2640 / 7586
🔵Branches33.95%10239 / 30156
Generated in workflow #4358 for commit fcd27cb by the Vitest Coverage Report Action
tejaskash
tejaskash
approved these changes
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xxuam
xxuam
merged commit 72cb257
into
mainAug 19, 2026

96 of 99 checks passed

@xxuam
xxuam
deleted the

feat/capacity-provider-journey1

branch
August 19, 2026 19:44
@aidandaly24aidandaly24
mentioned this pull request
Aug 19, 2026
 Merged

16 tasks
@xxuamxxuam
mentioned this pull request
Aug 22, 2026
 Open

15 tasks
@aidandaly24aidandaly24
mentioned this pull request
Aug 26, 2026
 Merged

15 tasks
@xxuamxxuam
mentioned this pull request
Aug 27, 2026
 Merged

15 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tejaskashtejaskashtejaskash approved these changes

Assignees


No one assigned


Labels

size/xlPR size: XL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@xxuam@tejaskash

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(capacity-provider): add capacity-provider resource (Journey 1) by xxuam · Pull Request #2030 · aws/agentcore-cli · GitHub
Skip to content
feat(capacity-provider): add capacity-provider resource (Journey 1) - #2030
Merged
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Aug 19, 2026
Merged
feat(capacity-provider): add capacity-provider resource (Journey 1)#2030
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Conversation
@xxuam
@xxuamxxuam
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Description
Adds the capacity-provider resource — a customer-managed pool of AWS-managed

EC2 compute that agent runtimes can run on instead of the default managed fleet.
Changes:
  • CapacityProviderPrimitive (create/remove) with CLI flags (--name,
    --operator-role-arn, --subnets, --security-groups, --os,
    --instance-types, --volume/--volume-encrypted/--volume-kms-key,
    --instance-profile-arn, --idle-instance-timeout, --max-lifetime,
    --description).
  • Zod schema for the capacity-provider spec (nested compute/VPC/volume/
    
lifecycle config), added to the project spec.
  • Interactive TUI — add wizard and remove picker.
  • Telemetry — add/remove command-run instrumentation + OperatingSystem enum.
  • Deploy/status plumbing — CloudFormation output parsing, deployed-state
    
schema, preflight empty-project guard (so a CP-only project isn't misread as a
    
teardown), and ResourceGraph rendering.
  • Docs (AGENTS.md, README, docs/commands.md) and integration tests.
This is the CLI half of Capacity Provider Journey 1 (create/remove a standalone

capacity provider). The AgentCoreCapacityProvider L3 construct lands in a

companion PR in aws/agentcore-l3-cdk-constructs.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 in this PR until the L3

construct publishes a new alpha; a follow-up commit bumps it.
Related Issue
Closes #
Documentation PR
Type of Change
  •  New feature
Testing
How have you tested the change?
Ran the full unit suite (6128 passing) and integration suite (344 passing,

including integ-tests/add-remove-capacity-provider.test.ts which exercises

add → inspect JSON → remove against the real CLI binary). Also live-validated

the full create → deploy → update → remove lifecycle against real AWS.
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
@xxuam@claude
feat(capacity-provider): add capacity-provider resource (Journey 1)
da9ab44
Add the CapacityProviderPrimitive (create/remove) for a customer-managed EC2
compute pool that runtimes can run on. Includes the Zod schema, primitive with
CLI flags, interactive TUI add wizard and remove picker, telemetry (add/remove
command-run + OperatingSystem enum), and deploy/status plumbing: CloudFormation
output parsing, deployed-state schema, preflight empty-project guard, and
ResourceGraph rendering. Docs (AGENTS.md, README, commands) and integ tests
included.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 until the L3 construct
publishes a new alpha; a follow-up bumps it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@xxuam
xxuam
requested a review
from a teamAugust 18, 2026 21:05
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
agentcore-harness-reviewing
AgentCore Harness review in progress
labels
Aug 18, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
agentcore-harness-reviewing
AgentCore Harness review in progress
label
Aug 18, 2026
tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down together with the L3 PR (#328, wired in as a local tarball) and ran the full lifecycle against a real account in us-west-2: create → add capacity-provider → deploy → status → remove → teardown. Everything worked end to end — the CFN resource came up, the Id/Arn outputs landed in deployed-state, status showed it as deployed, and removing the last capacity provider correctly tore the stack down instead of tripping the empty-project check.
A few findings below, roughly in priority order. One note from the live test that isn't tied to a line: when the capacity provider fails asynchronously (e.g. the operator role is missing events:PutRule), CloudFormation only says NotStabilized — the real reason is only visible via GetCapacityProvider.statusReason. Not this PR's bug, but worth raising with the service team.
Comment threadsrc/cli/operations/deploy/preflight.ts
Outdated

Comment threadsrc/cli/primitives/CapacityProviderPrimitive.ts
Outdated

Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

Comment threadsrc/cli/commands/remove/command.tsx
Comment threadsrc/cli/tui/screens/add/AddScreen.tsx
Outdated

@xxuam@claude
fix(capacity-provider): address review — TagsSchema, ARN partitions, …
fcd27cb
…deployable-resource preflight, volume parsing, TUI parity, optional operator role
Address PR #2030 review feedback:
- tags: use shared TagsSchema (mirrors the CDK schema) instead of a plain string record
- ARN patterns (operator-role, instance-profile, KMS): partition-agnostic arn:[^:]+: per
AGENTS.md; drop now-unneeded eslint-disable directives
- preflight: replace the hand-maintained hasX teardown chain with a typed
hasDeployableResources(spec) + DEPLOYABLE_RESOURCE_KEYS, fixing latent drift where a
project containing only configBundles or onlineEvalConfigs was misclassified as empty
- --volume parse: require exactly name:sizeGiB (segment count + digit regex), rejecting
data:20:gp3, hex (0x14), and exponent (2e1) that Number() silently accepted
- TUI: remove-all confirmation now enumerates capacity providers; add screen shows
"Capacity Provider [preview]" to match the remove screen
- operator role: --operator-role-arn is now optional (auto-created at deploy when omitted,
matching the CDK construct); supplying an ARN is a bring-your-own override. Docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
and removed

size/xl
PR size: XL
labels
Aug 19, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@github-actions
github-actionsBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines40.65%15382 / 37840
🔵Statements39.92%16403 / 41089
🔵Functions34.8%2640 / 7586
🔵Branches33.95%10239 / 30156
Generated in workflow #4358 for commit fcd27cb by the Vitest Coverage Report Action
tejaskash
tejaskash
approved these changes
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xxuam
xxuam
merged commit 72cb257
into
mainAug 19, 2026

96 of 99 checks passed

@xxuam
xxuam
deleted the

feat/capacity-provider-journey1

branch
August 19, 2026 19:44
@aidandaly24aidandaly24
mentioned this pull request
Aug 19, 2026
 Merged

16 tasks
@xxuamxxuam
mentioned this pull request
Aug 22, 2026
 Open

15 tasks
@aidandaly24aidandaly24
mentioned this pull request
Aug 26, 2026
 Merged

15 tasks
@xxuamxxuam
mentioned this pull request
Aug 27, 2026
 Merged

15 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tejaskashtejaskashtejaskash approved these changes

Assignees


No one assigned


Labels

size/xlPR size: XL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@xxuam@tejaskash

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(capacity-provider): add capacity-provider resource (Journey 1) by xxuam · Pull Request #2030 · aws/agentcore-cli · GitHub
Skip to content
feat(capacity-provider): add capacity-provider resource (Journey 1) - #2030
Merged
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Aug 19, 2026
Merged
feat(capacity-provider): add capacity-provider resource (Journey 1)#2030
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Conversation
@xxuam
@xxuamxxuam
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Description
Adds the capacity-provider resource — a customer-managed pool of AWS-managed

EC2 compute that agent runtimes can run on instead of the default managed fleet.
Changes:
  • CapacityProviderPrimitive (create/remove) with CLI flags (--name,
    --operator-role-arn, --subnets, --security-groups, --os,
    --instance-types, --volume/--volume-encrypted/--volume-kms-key,
    --instance-profile-arn, --idle-instance-timeout, --max-lifetime,
    --description).
  • Zod schema for the capacity-provider spec (nested compute/VPC/volume/
    
lifecycle config), added to the project spec.
  • Interactive TUI — add wizard and remove picker.
  • Telemetry — add/remove command-run instrumentation + OperatingSystem enum.
  • Deploy/status plumbing — CloudFormation output parsing, deployed-state
    
schema, preflight empty-project guard (so a CP-only project isn't misread as a
    
teardown), and ResourceGraph rendering.
  • Docs (AGENTS.md, README, docs/commands.md) and integration tests.
This is the CLI half of Capacity Provider Journey 1 (create/remove a standalone

capacity provider). The AgentCoreCapacityProvider L3 construct lands in a

companion PR in aws/agentcore-l3-cdk-constructs.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 in this PR until the L3

construct publishes a new alpha; a follow-up commit bumps it.
Related Issue
Closes #
Documentation PR
Type of Change
  •  New feature
Testing
How have you tested the change?
Ran the full unit suite (6128 passing) and integration suite (344 passing,

including integ-tests/add-remove-capacity-provider.test.ts which exercises

add → inspect JSON → remove against the real CLI binary). Also live-validated

the full create → deploy → update → remove lifecycle against real AWS.
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
@xxuam@claude
feat(capacity-provider): add capacity-provider resource (Journey 1)
da9ab44
Add the CapacityProviderPrimitive (create/remove) for a customer-managed EC2
compute pool that runtimes can run on. Includes the Zod schema, primitive with
CLI flags, interactive TUI add wizard and remove picker, telemetry (add/remove
command-run + OperatingSystem enum), and deploy/status plumbing: CloudFormation
output parsing, deployed-state schema, preflight empty-project guard, and
ResourceGraph rendering. Docs (AGENTS.md, README, commands) and integ tests
included.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 until the L3 construct
publishes a new alpha; a follow-up bumps it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@xxuam
xxuam
requested a review
from a teamAugust 18, 2026 21:05
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
agentcore-harness-reviewing
AgentCore Harness review in progress
labels
Aug 18, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
agentcore-harness-reviewing
AgentCore Harness review in progress
label
Aug 18, 2026
tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down together with the L3 PR (#328, wired in as a local tarball) and ran the full lifecycle against a real account in us-west-2: create → add capacity-provider → deploy → status → remove → teardown. Everything worked end to end — the CFN resource came up, the Id/Arn outputs landed in deployed-state, status showed it as deployed, and removing the last capacity provider correctly tore the stack down instead of tripping the empty-project check.
A few findings below, roughly in priority order. One note from the live test that isn't tied to a line: when the capacity provider fails asynchronously (e.g. the operator role is missing events:PutRule), CloudFormation only says NotStabilized — the real reason is only visible via GetCapacityProvider.statusReason. Not this PR's bug, but worth raising with the service team.
Comment threadsrc/cli/operations/deploy/preflight.ts
Outdated

Comment threadsrc/cli/primitives/CapacityProviderPrimitive.ts
Outdated

Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

Comment threadsrc/cli/commands/remove/command.tsx
Comment threadsrc/cli/tui/screens/add/AddScreen.tsx
Outdated

@xxuam@claude
fix(capacity-provider): address review — TagsSchema, ARN partitions, …
fcd27cb
…deployable-resource preflight, volume parsing, TUI parity, optional operator role
Address PR #2030 review feedback:
- tags: use shared TagsSchema (mirrors the CDK schema) instead of a plain string record
- ARN patterns (operator-role, instance-profile, KMS): partition-agnostic arn:[^:]+: per
AGENTS.md; drop now-unneeded eslint-disable directives
- preflight: replace the hand-maintained hasX teardown chain with a typed
hasDeployableResources(spec) + DEPLOYABLE_RESOURCE_KEYS, fixing latent drift where a
project containing only configBundles or onlineEvalConfigs was misclassified as empty
- --volume parse: require exactly name:sizeGiB (segment count + digit regex), rejecting
data:20:gp3, hex (0x14), and exponent (2e1) that Number() silently accepted
- TUI: remove-all confirmation now enumerates capacity providers; add screen shows
"Capacity Provider [preview]" to match the remove screen
- operator role: --operator-role-arn is now optional (auto-created at deploy when omitted,
matching the CDK construct); supplying an ARN is a bring-your-own override. Docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
and removed

size/xl
PR size: XL
labels
Aug 19, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@github-actions
github-actionsBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines40.65%15382 / 37840
🔵Statements39.92%16403 / 41089
🔵Functions34.8%2640 / 7586
🔵Branches33.95%10239 / 30156
Generated in workflow #4358 for commit fcd27cb by the Vitest Coverage Report Action
tejaskash
tejaskash
approved these changes
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xxuam
xxuam
merged commit 72cb257
into
mainAug 19, 2026

96 of 99 checks passed

@xxuam
xxuam
deleted the

feat/capacity-provider-journey1

branch
August 19, 2026 19:44
@aidandaly24aidandaly24
mentioned this pull request
Aug 19, 2026
 Merged

16 tasks
@xxuamxxuam
mentioned this pull request
Aug 22, 2026
 Open

15 tasks
@aidandaly24aidandaly24
mentioned this pull request
Aug 26, 2026
 Merged

15 tasks
@xxuamxxuam
mentioned this pull request
Aug 27, 2026
 Merged

15 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tejaskashtejaskashtejaskash approved these changes

Assignees


No one assigned


Labels

size/xlPR size: XL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@xxuam@tejaskash

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(capacity-provider): add capacity-provider resource (Journey 1) by xxuam · Pull Request #2030 · aws/agentcore-cli · GitHub
Skip to content
feat(capacity-provider): add capacity-provider resource (Journey 1) - #2030
Merged
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Aug 19, 2026
Merged
feat(capacity-provider): add capacity-provider resource (Journey 1)#2030
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Conversation
@xxuam
@xxuamxxuam
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Description
Adds the capacity-provider resource — a customer-managed pool of AWS-managed

EC2 compute that agent runtimes can run on instead of the default managed fleet.
Changes:
  • CapacityProviderPrimitive (create/remove) with CLI flags (--name,
    --operator-role-arn, --subnets, --security-groups, --os,
    --instance-types, --volume/--volume-encrypted/--volume-kms-key,
    --instance-profile-arn, --idle-instance-timeout, --max-lifetime,
    --description).
  • Zod schema for the capacity-provider spec (nested compute/VPC/volume/
    
lifecycle config), added to the project spec.
  • Interactive TUI — add wizard and remove picker.
  • Telemetry — add/remove command-run instrumentation + OperatingSystem enum.
  • Deploy/status plumbing — CloudFormation output parsing, deployed-state
    
schema, preflight empty-project guard (so a CP-only project isn't misread as a
    
teardown), and ResourceGraph rendering.
  • Docs (AGENTS.md, README, docs/commands.md) and integration tests.
This is the CLI half of Capacity Provider Journey 1 (create/remove a standalone

capacity provider). The AgentCoreCapacityProvider L3 construct lands in a

companion PR in aws/agentcore-l3-cdk-constructs.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 in this PR until the L3

construct publishes a new alpha; a follow-up commit bumps it.
Related Issue
Closes #
Documentation PR
Type of Change
  •  New feature
Testing
How have you tested the change?
Ran the full unit suite (6128 passing) and integration suite (344 passing,

including integ-tests/add-remove-capacity-provider.test.ts which exercises

add → inspect JSON → remove against the real CLI binary). Also live-validated

the full create → deploy → update → remove lifecycle against real AWS.
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
@xxuam@claude
feat(capacity-provider): add capacity-provider resource (Journey 1)
da9ab44
Add the CapacityProviderPrimitive (create/remove) for a customer-managed EC2
compute pool that runtimes can run on. Includes the Zod schema, primitive with
CLI flags, interactive TUI add wizard and remove picker, telemetry (add/remove
command-run + OperatingSystem enum), and deploy/status plumbing: CloudFormation
output parsing, deployed-state schema, preflight empty-project guard, and
ResourceGraph rendering. Docs (AGENTS.md, README, commands) and integ tests
included.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 until the L3 construct
publishes a new alpha; a follow-up bumps it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@xxuam
xxuam
requested a review
from a teamAugust 18, 2026 21:05
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
agentcore-harness-reviewing
AgentCore Harness review in progress
labels
Aug 18, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
agentcore-harness-reviewing
AgentCore Harness review in progress
label
Aug 18, 2026
tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down together with the L3 PR (#328, wired in as a local tarball) and ran the full lifecycle against a real account in us-west-2: create → add capacity-provider → deploy → status → remove → teardown. Everything worked end to end — the CFN resource came up, the Id/Arn outputs landed in deployed-state, status showed it as deployed, and removing the last capacity provider correctly tore the stack down instead of tripping the empty-project check.
A few findings below, roughly in priority order. One note from the live test that isn't tied to a line: when the capacity provider fails asynchronously (e.g. the operator role is missing events:PutRule), CloudFormation only says NotStabilized — the real reason is only visible via GetCapacityProvider.statusReason. Not this PR's bug, but worth raising with the service team.
Comment threadsrc/cli/operations/deploy/preflight.ts
Outdated

Comment threadsrc/cli/primitives/CapacityProviderPrimitive.ts
Outdated

Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

Comment threadsrc/cli/commands/remove/command.tsx
Comment threadsrc/cli/tui/screens/add/AddScreen.tsx
Outdated

@xxuam@claude
fix(capacity-provider): address review — TagsSchema, ARN partitions, …
fcd27cb
…deployable-resource preflight, volume parsing, TUI parity, optional operator role
Address PR #2030 review feedback:
- tags: use shared TagsSchema (mirrors the CDK schema) instead of a plain string record
- ARN patterns (operator-role, instance-profile, KMS): partition-agnostic arn:[^:]+: per
AGENTS.md; drop now-unneeded eslint-disable directives
- preflight: replace the hand-maintained hasX teardown chain with a typed
hasDeployableResources(spec) + DEPLOYABLE_RESOURCE_KEYS, fixing latent drift where a
project containing only configBundles or onlineEvalConfigs was misclassified as empty
- --volume parse: require exactly name:sizeGiB (segment count + digit regex), rejecting
data:20:gp3, hex (0x14), and exponent (2e1) that Number() silently accepted
- TUI: remove-all confirmation now enumerates capacity providers; add screen shows
"Capacity Provider [preview]" to match the remove screen
- operator role: --operator-role-arn is now optional (auto-created at deploy when omitted,
matching the CDK construct); supplying an ARN is a bring-your-own override. Docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
and removed

size/xl
PR size: XL
labels
Aug 19, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@github-actions
github-actionsBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines40.65%15382 / 37840
🔵Statements39.92%16403 / 41089
🔵Functions34.8%2640 / 7586
🔵Branches33.95%10239 / 30156
Generated in workflow #4358 for commit fcd27cb by the Vitest Coverage Report Action
tejaskash
tejaskash
approved these changes
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xxuam
xxuam
merged commit 72cb257
into
mainAug 19, 2026

96 of 99 checks passed

@xxuam
xxuam
deleted the

feat/capacity-provider-journey1

branch
August 19, 2026 19:44
@aidandaly24aidandaly24
mentioned this pull request
Aug 19, 2026
 Merged

16 tasks
@xxuamxxuam
mentioned this pull request
Aug 22, 2026
 Open

15 tasks
@aidandaly24aidandaly24
mentioned this pull request
Aug 26, 2026
 Merged

15 tasks
@xxuamxxuam
mentioned this pull request
Aug 27, 2026
 Merged

15 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tejaskashtejaskashtejaskash approved these changes

Assignees


No one assigned


Labels

size/xlPR size: XL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@xxuam@tejaskash

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(capacity-provider): add capacity-provider resource (Journey 1) by xxuam · Pull Request #2030 · aws/agentcore-cli · GitHub
Skip to content
feat(capacity-provider): add capacity-provider resource (Journey 1) - #2030
Merged
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Aug 19, 2026
Merged
feat(capacity-provider): add capacity-provider resource (Journey 1)#2030
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Conversation
@xxuam
@xxuamxxuam
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Description
Adds the capacity-provider resource — a customer-managed pool of AWS-managed

EC2 compute that agent runtimes can run on instead of the default managed fleet.
Changes:
  • CapacityProviderPrimitive (create/remove) with CLI flags (--name,
    --operator-role-arn, --subnets, --security-groups, --os,
    --instance-types, --volume/--volume-encrypted/--volume-kms-key,
    --instance-profile-arn, --idle-instance-timeout, --max-lifetime,
    --description).
  • Zod schema for the capacity-provider spec (nested compute/VPC/volume/
    
lifecycle config), added to the project spec.
  • Interactive TUI — add wizard and remove picker.
  • Telemetry — add/remove command-run instrumentation + OperatingSystem enum.
  • Deploy/status plumbing — CloudFormation output parsing, deployed-state
    
schema, preflight empty-project guard (so a CP-only project isn't misread as a
    
teardown), and ResourceGraph rendering.
  • Docs (AGENTS.md, README, docs/commands.md) and integration tests.
This is the CLI half of Capacity Provider Journey 1 (create/remove a standalone

capacity provider). The AgentCoreCapacityProvider L3 construct lands in a

companion PR in aws/agentcore-l3-cdk-constructs.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 in this PR until the L3

construct publishes a new alpha; a follow-up commit bumps it.
Related Issue
Closes #
Documentation PR
Type of Change
  •  New feature
Testing
How have you tested the change?
Ran the full unit suite (6128 passing) and integration suite (344 passing,

including integ-tests/add-remove-capacity-provider.test.ts which exercises

add → inspect JSON → remove against the real CLI binary). Also live-validated

the full create → deploy → update → remove lifecycle against real AWS.
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
@xxuam@claude
feat(capacity-provider): add capacity-provider resource (Journey 1)
da9ab44
Add the CapacityProviderPrimitive (create/remove) for a customer-managed EC2
compute pool that runtimes can run on. Includes the Zod schema, primitive with
CLI flags, interactive TUI add wizard and remove picker, telemetry (add/remove
command-run + OperatingSystem enum), and deploy/status plumbing: CloudFormation
output parsing, deployed-state schema, preflight empty-project guard, and
ResourceGraph rendering. Docs (AGENTS.md, README, commands) and integ tests
included.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 until the L3 construct
publishes a new alpha; a follow-up bumps it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@xxuam
xxuam
requested a review
from a teamAugust 18, 2026 21:05
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
agentcore-harness-reviewing
AgentCore Harness review in progress
labels
Aug 18, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
agentcore-harness-reviewing
AgentCore Harness review in progress
label
Aug 18, 2026
tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down together with the L3 PR (#328, wired in as a local tarball) and ran the full lifecycle against a real account in us-west-2: create → add capacity-provider → deploy → status → remove → teardown. Everything worked end to end — the CFN resource came up, the Id/Arn outputs landed in deployed-state, status showed it as deployed, and removing the last capacity provider correctly tore the stack down instead of tripping the empty-project check.
A few findings below, roughly in priority order. One note from the live test that isn't tied to a line: when the capacity provider fails asynchronously (e.g. the operator role is missing events:PutRule), CloudFormation only says NotStabilized — the real reason is only visible via GetCapacityProvider.statusReason. Not this PR's bug, but worth raising with the service team.
Comment threadsrc/cli/operations/deploy/preflight.ts
Outdated

Comment threadsrc/cli/primitives/CapacityProviderPrimitive.ts
Outdated

Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

Comment threadsrc/cli/commands/remove/command.tsx
Comment threadsrc/cli/tui/screens/add/AddScreen.tsx
Outdated

@xxuam@claude
fix(capacity-provider): address review — TagsSchema, ARN partitions, …
fcd27cb
…deployable-resource preflight, volume parsing, TUI parity, optional operator role
Address PR #2030 review feedback:
- tags: use shared TagsSchema (mirrors the CDK schema) instead of a plain string record
- ARN patterns (operator-role, instance-profile, KMS): partition-agnostic arn:[^:]+: per
AGENTS.md; drop now-unneeded eslint-disable directives
- preflight: replace the hand-maintained hasX teardown chain with a typed
hasDeployableResources(spec) + DEPLOYABLE_RESOURCE_KEYS, fixing latent drift where a
project containing only configBundles or onlineEvalConfigs was misclassified as empty
- --volume parse: require exactly name:sizeGiB (segment count + digit regex), rejecting
data:20:gp3, hex (0x14), and exponent (2e1) that Number() silently accepted
- TUI: remove-all confirmation now enumerates capacity providers; add screen shows
"Capacity Provider [preview]" to match the remove screen
- operator role: --operator-role-arn is now optional (auto-created at deploy when omitted,
matching the CDK construct); supplying an ARN is a bring-your-own override. Docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
and removed

size/xl
PR size: XL
labels
Aug 19, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@github-actions
github-actionsBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines40.65%15382 / 37840
🔵Statements39.92%16403 / 41089
🔵Functions34.8%2640 / 7586
🔵Branches33.95%10239 / 30156
Generated in workflow #4358 for commit fcd27cb by the Vitest Coverage Report Action
tejaskash
tejaskash
approved these changes
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xxuam
xxuam
merged commit 72cb257
into
mainAug 19, 2026

96 of 99 checks passed

@xxuam
xxuam
deleted the

feat/capacity-provider-journey1

branch
August 19, 2026 19:44
@aidandaly24aidandaly24
mentioned this pull request
Aug 19, 2026
 Merged

16 tasks
@xxuamxxuam
mentioned this pull request
Aug 22, 2026
 Open

15 tasks
@aidandaly24aidandaly24
mentioned this pull request
Aug 26, 2026
 Merged

15 tasks
@xxuamxxuam
mentioned this pull request
Aug 27, 2026
 Merged

15 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tejaskashtejaskashtejaskash approved these changes

Assignees


No one assigned


Labels

size/xlPR size: XL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@xxuam@tejaskash

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(capacity-provider): add capacity-provider resource (Journey 1) by xxuam · Pull Request #2030 · aws/agentcore-cli · GitHub
Skip to content
feat(capacity-provider): add capacity-provider resource (Journey 1) - #2030
Merged
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Aug 19, 2026
Merged
feat(capacity-provider): add capacity-provider resource (Journey 1)#2030
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Conversation
@xxuam
@xxuamxxuam
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Description
Adds the capacity-provider resource — a customer-managed pool of AWS-managed

EC2 compute that agent runtimes can run on instead of the default managed fleet.
Changes:
  • CapacityProviderPrimitive (create/remove) with CLI flags (--name,
    --operator-role-arn, --subnets, --security-groups, --os,
    --instance-types, --volume/--volume-encrypted/--volume-kms-key,
    --instance-profile-arn, --idle-instance-timeout, --max-lifetime,
    --description).
  • Zod schema for the capacity-provider spec (nested compute/VPC/volume/
    
lifecycle config), added to the project spec.
  • Interactive TUI — add wizard and remove picker.
  • Telemetry — add/remove command-run instrumentation + OperatingSystem enum.
  • Deploy/status plumbing — CloudFormation output parsing, deployed-state
    
schema, preflight empty-project guard (so a CP-only project isn't misread as a
    
teardown), and ResourceGraph rendering.
  • Docs (AGENTS.md, README, docs/commands.md) and integration tests.
This is the CLI half of Capacity Provider Journey 1 (create/remove a standalone

capacity provider). The AgentCoreCapacityProvider L3 construct lands in a

companion PR in aws/agentcore-l3-cdk-constructs.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 in this PR until the L3

construct publishes a new alpha; a follow-up commit bumps it.
Related Issue
Closes #
Documentation PR
Type of Change
  •  New feature
Testing
How have you tested the change?
Ran the full unit suite (6128 passing) and integration suite (344 passing,

including integ-tests/add-remove-capacity-provider.test.ts which exercises

add → inspect JSON → remove against the real CLI binary). Also live-validated

the full create → deploy → update → remove lifecycle against real AWS.
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
@xxuam@claude
feat(capacity-provider): add capacity-provider resource (Journey 1)
da9ab44
Add the CapacityProviderPrimitive (create/remove) for a customer-managed EC2
compute pool that runtimes can run on. Includes the Zod schema, primitive with
CLI flags, interactive TUI add wizard and remove picker, telemetry (add/remove
command-run + OperatingSystem enum), and deploy/status plumbing: CloudFormation
output parsing, deployed-state schema, preflight empty-project guard, and
ResourceGraph rendering. Docs (AGENTS.md, README, commands) and integ tests
included.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 until the L3 construct
publishes a new alpha; a follow-up bumps it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@xxuam
xxuam
requested a review
from a teamAugust 18, 2026 21:05
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
agentcore-harness-reviewing
AgentCore Harness review in progress
labels
Aug 18, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
agentcore-harness-reviewing
AgentCore Harness review in progress
label
Aug 18, 2026
tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down together with the L3 PR (#328, wired in as a local tarball) and ran the full lifecycle against a real account in us-west-2: create → add capacity-provider → deploy → status → remove → teardown. Everything worked end to end — the CFN resource came up, the Id/Arn outputs landed in deployed-state, status showed it as deployed, and removing the last capacity provider correctly tore the stack down instead of tripping the empty-project check.
A few findings below, roughly in priority order. One note from the live test that isn't tied to a line: when the capacity provider fails asynchronously (e.g. the operator role is missing events:PutRule), CloudFormation only says NotStabilized — the real reason is only visible via GetCapacityProvider.statusReason. Not this PR's bug, but worth raising with the service team.
Comment threadsrc/cli/operations/deploy/preflight.ts
Outdated

Comment threadsrc/cli/primitives/CapacityProviderPrimitive.ts
Outdated

Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

Comment threadsrc/cli/commands/remove/command.tsx
Comment threadsrc/cli/tui/screens/add/AddScreen.tsx
Outdated

@xxuam@claude
fix(capacity-provider): address review — TagsSchema, ARN partitions, …
fcd27cb
…deployable-resource preflight, volume parsing, TUI parity, optional operator role
Address PR #2030 review feedback:
- tags: use shared TagsSchema (mirrors the CDK schema) instead of a plain string record
- ARN patterns (operator-role, instance-profile, KMS): partition-agnostic arn:[^:]+: per
AGENTS.md; drop now-unneeded eslint-disable directives
- preflight: replace the hand-maintained hasX teardown chain with a typed
hasDeployableResources(spec) + DEPLOYABLE_RESOURCE_KEYS, fixing latent drift where a
project containing only configBundles or onlineEvalConfigs was misclassified as empty
- --volume parse: require exactly name:sizeGiB (segment count + digit regex), rejecting
data:20:gp3, hex (0x14), and exponent (2e1) that Number() silently accepted
- TUI: remove-all confirmation now enumerates capacity providers; add screen shows
"Capacity Provider [preview]" to match the remove screen
- operator role: --operator-role-arn is now optional (auto-created at deploy when omitted,
matching the CDK construct); supplying an ARN is a bring-your-own override. Docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
and removed

size/xl
PR size: XL
labels
Aug 19, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@github-actions
github-actionsBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines40.65%15382 / 37840
🔵Statements39.92%16403 / 41089
🔵Functions34.8%2640 / 7586
🔵Branches33.95%10239 / 30156
Generated in workflow #4358 for commit fcd27cb by the Vitest Coverage Report Action
tejaskash
tejaskash
approved these changes
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xxuam
xxuam
merged commit 72cb257
into
mainAug 19, 2026

96 of 99 checks passed

@xxuam
xxuam
deleted the

feat/capacity-provider-journey1

branch
August 19, 2026 19:44
@aidandaly24aidandaly24
mentioned this pull request
Aug 19, 2026
 Merged

16 tasks
@xxuamxxuam
mentioned this pull request
Aug 22, 2026
 Open

15 tasks
@aidandaly24aidandaly24
mentioned this pull request
Aug 26, 2026
 Merged

15 tasks
@xxuamxxuam
mentioned this pull request
Aug 27, 2026
 Merged

15 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tejaskashtejaskashtejaskash approved these changes

Assignees


No one assigned


Labels

size/xlPR size: XL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@xxuam@tejaskash

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(capacity-provider): add capacity-provider resource (Journey 1) by xxuam · Pull Request #2030 · aws/agentcore-cli · GitHub
Skip to content
feat(capacity-provider): add capacity-provider resource (Journey 1) - #2030
Merged
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Aug 19, 2026
Merged
feat(capacity-provider): add capacity-provider resource (Journey 1)#2030
xxuam merged 2 commits into
mainfrom 
feat/capacity-provider-journey1
Conversation
@xxuam
@xxuamxxuam
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Description
Adds the capacity-provider resource — a customer-managed pool of AWS-managed

EC2 compute that agent runtimes can run on instead of the default managed fleet.
Changes:
  • CapacityProviderPrimitive (create/remove) with CLI flags (--name,
    --operator-role-arn, --subnets, --security-groups, --os,
    --instance-types, --volume/--volume-encrypted/--volume-kms-key,
    --instance-profile-arn, --idle-instance-timeout, --max-lifetime,
    --description).
  • Zod schema for the capacity-provider spec (nested compute/VPC/volume/
    
lifecycle config), added to the project spec.
  • Interactive TUI — add wizard and remove picker.
  • Telemetry — add/remove command-run instrumentation + OperatingSystem enum.
  • Deploy/status plumbing — CloudFormation output parsing, deployed-state
    
schema, preflight empty-project guard (so a CP-only project isn't misread as a
    
teardown), and ResourceGraph rendering.
  • Docs (AGENTS.md, README, docs/commands.md) and integration tests.
This is the CLI half of Capacity Provider Journey 1 (create/remove a standalone

capacity provider). The AgentCoreCapacityProvider L3 construct lands in a

companion PR in aws/agentcore-l3-cdk-constructs.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 in this PR until the L3

construct publishes a new alpha; a follow-up commit bumps it.
Related Issue
Closes #
Documentation PR
Type of Change
  •  New feature
Testing
How have you tested the change?
Ran the full unit suite (6128 passing) and integration suite (344 passing,

including integ-tests/add-remove-capacity-provider.test.ts which exercises

add → inspect JSON → remove against the real CLI binary). Also live-validated

the full create → deploy → update → remove lifecycle against real AWS.
  •  I ran npm run test:unit and npm run test:integ
  •  I ran npm run typecheck
  •  I ran npm run lint
  •  If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots
Checklist
  •  I have read the CONTRIBUTING document
  •  I have added any necessary tests that prove my fix is effective or my feature works
  •  I have updated the documentation accordingly
  •  I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  •  My changes generate no new warnings
  •  Any dependent changes have been merged and published
@xxuam@claude
feat(capacity-provider): add capacity-provider resource (Journey 1)
da9ab44
Add the CapacityProviderPrimitive (create/remove) for a customer-managed EC2
compute pool that runtimes can run on. Includes the Zod schema, primitive with
CLI flags, interactive TUI add wizard and remove picker, telemetry (add/remove
command-run + OperatingSystem enum), and deploy/status plumbing: CloudFormation
output parsing, deployed-state schema, preflight empty-project guard, and
ResourceGraph rendering. Docs (AGENTS.md, README, commands) and integ tests
included.
The @aws/agentcore-cdk pin stays at 0.1.0-alpha.45 until the L3 construct
publishes a new alpha; a follow-up bumps it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@xxuam
xxuam
requested a review
from a teamAugust 18, 2026 21:05
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
agentcore-harness-reviewing
AgentCore Harness review in progress
labels
Aug 18, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 18, 2026
@github-actionsgithub-actionsBot
removed
the 
agentcore-harness-reviewing
AgentCore Harness review in progress
label
Aug 18, 2026
tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

tejaskash
tejaskash
reviewed
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled this down together with the L3 PR (#328, wired in as a local tarball) and ran the full lifecycle against a real account in us-west-2: create → add capacity-provider → deploy → status → remove → teardown. Everything worked end to end — the CFN resource came up, the Id/Arn outputs landed in deployed-state, status showed it as deployed, and removing the last capacity provider correctly tore the stack down instead of tripping the empty-project check.
A few findings below, roughly in priority order. One note from the live test that isn't tied to a line: when the capacity provider fails asynchronously (e.g. the operator role is missing events:PutRule), CloudFormation only says NotStabilized — the real reason is only visible via GetCapacityProvider.statusReason. Not this PR's bug, but worth raising with the service team.
Comment threadsrc/cli/operations/deploy/preflight.ts
Outdated

Comment threadsrc/cli/primitives/CapacityProviderPrimitive.ts
Outdated

Comment threadsrc/schema/schemas/primitives/capacity-provider.ts
Outdated

Comment threadsrc/cli/commands/remove/command.tsx
Comment threadsrc/cli/tui/screens/add/AddScreen.tsx
Outdated

@xxuam@claude
fix(capacity-provider): address review — TagsSchema, ARN partitions, …
fcd27cb
…deployable-resource preflight, volume parsing, TUI parity, optional operator role
Address PR #2030 review feedback:
- tags: use shared TagsSchema (mirrors the CDK schema) instead of a plain string record
- ARN patterns (operator-role, instance-profile, KMS): partition-agnostic arn:[^:]+: per
AGENTS.md; drop now-unneeded eslint-disable directives
- preflight: replace the hand-maintained hasX teardown chain with a typed
hasDeployableResources(spec) + DEPLOYABLE_RESOURCE_KEYS, fixing latent drift where a
project containing only configBundles or onlineEvalConfigs was misclassified as empty
- --volume parse: require exactly name:sizeGiB (segment count + digit regex), rejecting
data:20:gp3, hex (0x14), and exponent (2e1) that Number() silently accepted
- TUI: remove-all confirmation now enumerates capacity providers; add screen shows
"Capacity Provider [preview]" to match the remove screen
- operator role: --operator-role-arn is now optional (auto-created at deploy when omitted,
matching the CDK construct); supplying an ARN is a bring-your-own override. Docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actionsgithub-actionsBot
added

size/xl
PR size: XL
and removed

size/xl
PR size: XL
labels
Aug 19, 2026
@agentcore-devx-automationagentcore-devx-automationBot
added
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@agentcore-devx-automation
agentcore-devx-automationBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Claude Security Review: no high-confidence findings. (run)
@agentcore-devx-automationagentcore-devx-automationBot
removed
the 
claude-security-reviewing
Claude Code /security-review in progress
label
Aug 19, 2026
@github-actions
github-actionsBot
commented
Aug 19, 2026

Copy link


Copy Markdown

Contributor
Coverage Report
StatusCategoryPercentageCovered / Total
🔵Lines40.65%15382 / 37840
🔵Statements39.92%16403 / 41089
🔵Functions34.8%2640 / 7586
🔵Branches33.95%10239 / 30156
Generated in workflow #4358 for commit fcd27cb by the Vitest Coverage Report Action
tejaskash
tejaskash
approved these changes
Aug 19, 2026
View reviewed changes
@tejaskashtejaskash
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xxuam
xxuam
merged commit 72cb257
into
mainAug 19, 2026

96 of 99 checks passed

@xxuam
xxuam
deleted the

feat/capacity-provider-journey1

branch
August 19, 2026 19:44
@aidandaly24aidandaly24
mentioned this pull request
Aug 19, 2026
 Merged

16 tasks
@xxuamxxuam
mentioned this pull request
Aug 22, 2026
 Open

15 tasks
@aidandaly24aidandaly24
mentioned this pull request
Aug 26, 2026
 Merged

15 tasks
@xxuamxxuam
mentioned this pull request
Aug 27, 2026
 Merged

15 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tejaskashtejaskashtejaskash approved these changes

Assignees


No one assigned


Labels

size/xlPR size: XL

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@xxuam@tejaskash