fix: reject inline secrets across runtime and identity credential commands by tejaskash · Pull Request #2080 · aws/agentcore-cli

tejaskash · 2026-08-24T14:35:52Z

What

Route every secret-value flag through SourceResolver.resolveSecret (stdin - or file:// only, single-line enforced, trailing newline stripped) instead of the generic resolveText. Inline secrets on argv leak into shell history, ps output, and CI logs.

Handlers changed:

project add runtime--api-key (addresses jariy17's comment on feat(project): scaffold add runtime handler #2035, r3833097791: shift secret handling into SourceResolver and reuse it in runtime on rebase; resolveSecret was added in feat(project): add 'project add credentials' (AgentCore Identity api-key + oauth) #2046).
identity api-key-credential-provider create|update--api-key.
identity oauth2-credential-provider create|update--client-secret.

Also dropped "inline" from those flags' help text so it matches the enforced contract, aligning with the project add credentials handlers.

Not changed: bearer-token invoke paths (ephemeral, never persisted) and structured-config flags (JSON/tags/free text) that legitimately use resolveText.

Testing

tsc --noEmit clean.
Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for runtime --api-key, and identity api-key + oauth2 create.
Full suite: 1742 pass, 0 fail.

…eSecret The runtime add handler resolved its --api-key with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Switch to resolveSecret (stdin/file only, single-line enforced), matching the api-key and oauth credential handlers and the flag's documented contract.

The standalone identity api-key/oauth2 credential-provider create and update handlers resolved their --api-key / --client-secret with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Inline secrets on argv leak into shell history, ps output, and CI logs. Switch all four to resolveSecret (stdin '-' or file:// only, single-line enforced) and drop "inline" from the flag help, matching the project add credentials and runtime handlers. Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for api-key and oauth2 create.

codecov-commenter · 2026-08-24T15:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (38c30ae) to head (eaf11b5).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2080 +/- ##
=========================================
Coverage 97.24% 97.24% =========================================
Files 396 396 Lines 24019 24021 +2 =========================================
+ Hits 23357 23359 +2 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tejaskash · 2026-08-24T14:35:52Z

What

Route every secret-value flag through SourceResolver.resolveSecret (stdin - or file:// only, single-line enforced, trailing newline stripped) instead of the generic resolveText. Inline secrets on argv leak into shell history, ps output, and CI logs.

Handlers changed:

project add runtime--api-key (addresses jariy17's comment on feat(project): scaffold add runtime handler #2035, r3833097791: shift secret handling into SourceResolver and reuse it in runtime on rebase; resolveSecret was added in feat(project): add 'project add credentials' (AgentCore Identity api-key + oauth) #2046).
identity api-key-credential-provider create|update--api-key.
identity oauth2-credential-provider create|update--client-secret.

Also dropped "inline" from those flags' help text so it matches the enforced contract, aligning with the project add credentials handlers.

Not changed: bearer-token invoke paths (ephemeral, never persisted) and structured-config flags (JSON/tags/free text) that legitimately use resolveText.

Testing

tsc --noEmit clean.
Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for runtime --api-key, and identity api-key + oauth2 create.
Full suite: 1742 pass, 0 fail.

…eSecret The runtime add handler resolved its --api-key with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Switch to resolveSecret (stdin/file only, single-line enforced), matching the api-key and oauth credential handlers and the flag's documented contract.

The standalone identity api-key/oauth2 credential-provider create and update handlers resolved their --api-key / --client-secret with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Inline secrets on argv leak into shell history, ps output, and CI logs. Switch all four to resolveSecret (stdin '-' or file:// only, single-line enforced) and drop "inline" from the flag help, matching the project add credentials and runtime handlers. Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for api-key and oauth2 create.

codecov-commenter · 2026-08-24T15:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (38c30ae) to head (eaf11b5).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2080 +/- ##
=========================================
Coverage 97.24% 97.24% =========================================
Files 396 396 Lines 24019 24021 +2 =========================================
+ Hits 23357 23359 +2 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tejaskash · 2026-08-24T14:35:52Z

What

Route every secret-value flag through SourceResolver.resolveSecret (stdin - or file:// only, single-line enforced, trailing newline stripped) instead of the generic resolveText. Inline secrets on argv leak into shell history, ps output, and CI logs.

Handlers changed:

project add runtime--api-key (addresses jariy17's comment on feat(project): scaffold add runtime handler #2035, r3833097791: shift secret handling into SourceResolver and reuse it in runtime on rebase; resolveSecret was added in feat(project): add 'project add credentials' (AgentCore Identity api-key + oauth) #2046).
identity api-key-credential-provider create|update--api-key.
identity oauth2-credential-provider create|update--client-secret.

Also dropped "inline" from those flags' help text so it matches the enforced contract, aligning with the project add credentials handlers.

Not changed: bearer-token invoke paths (ephemeral, never persisted) and structured-config flags (JSON/tags/free text) that legitimately use resolveText.

Testing

tsc --noEmit clean.
Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for runtime --api-key, and identity api-key + oauth2 create.
Full suite: 1742 pass, 0 fail.

…eSecret The runtime add handler resolved its --api-key with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Switch to resolveSecret (stdin/file only, single-line enforced), matching the api-key and oauth credential handlers and the flag's documented contract.

The standalone identity api-key/oauth2 credential-provider create and update handlers resolved their --api-key / --client-secret with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Inline secrets on argv leak into shell history, ps output, and CI logs. Switch all four to resolveSecret (stdin '-' or file:// only, single-line enforced) and drop "inline" from the flag help, matching the project add credentials and runtime handlers. Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for api-key and oauth2 create.

codecov-commenter · 2026-08-24T15:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (38c30ae) to head (eaf11b5).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2080 +/- ##
=========================================
Coverage 97.24% 97.24% =========================================
Files 396 396 Lines 24019 24021 +2 =========================================
+ Hits 23357 23359 +2 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tejaskash · 2026-08-24T14:35:52Z

What

Route every secret-value flag through SourceResolver.resolveSecret (stdin - or file:// only, single-line enforced, trailing newline stripped) instead of the generic resolveText. Inline secrets on argv leak into shell history, ps output, and CI logs.

Handlers changed:

project add runtime--api-key (addresses jariy17's comment on feat(project): scaffold add runtime handler #2035, r3833097791: shift secret handling into SourceResolver and reuse it in runtime on rebase; resolveSecret was added in feat(project): add 'project add credentials' (AgentCore Identity api-key + oauth) #2046).
identity api-key-credential-provider create|update--api-key.
identity oauth2-credential-provider create|update--client-secret.

Also dropped "inline" from those flags' help text so it matches the enforced contract, aligning with the project add credentials handlers.

Not changed: bearer-token invoke paths (ephemeral, never persisted) and structured-config flags (JSON/tags/free text) that legitimately use resolveText.

Testing

tsc --noEmit clean.
Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for runtime --api-key, and identity api-key + oauth2 create.
Full suite: 1742 pass, 0 fail.

…eSecret The runtime add handler resolved its --api-key with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Switch to resolveSecret (stdin/file only, single-line enforced), matching the api-key and oauth credential handlers and the flag's documented contract.

The standalone identity api-key/oauth2 credential-provider create and update handlers resolved their --api-key / --client-secret with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Inline secrets on argv leak into shell history, ps output, and CI logs. Switch all four to resolveSecret (stdin '-' or file:// only, single-line enforced) and drop "inline" from the flag help, matching the project add credentials and runtime handlers. Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for api-key and oauth2 create.

codecov-commenter · 2026-08-24T15:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (38c30ae) to head (eaf11b5).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2080 +/- ##
=========================================
Coverage 97.24% 97.24% =========================================
Files 396 396 Lines 24019 24021 +2 =========================================
+ Hits 23357 23359 +2 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tejaskash · 2026-08-24T14:35:52Z

What

Route every secret-value flag through SourceResolver.resolveSecret (stdin - or file:// only, single-line enforced, trailing newline stripped) instead of the generic resolveText. Inline secrets on argv leak into shell history, ps output, and CI logs.

Handlers changed:

project add runtime--api-key (addresses jariy17's comment on feat(project): scaffold add runtime handler #2035, r3833097791: shift secret handling into SourceResolver and reuse it in runtime on rebase; resolveSecret was added in feat(project): add 'project add credentials' (AgentCore Identity api-key + oauth) #2046).
identity api-key-credential-provider create|update--api-key.
identity oauth2-credential-provider create|update--client-secret.

Also dropped "inline" from those flags' help text so it matches the enforced contract, aligning with the project add credentials handlers.

Not changed: bearer-token invoke paths (ephemeral, never persisted) and structured-config flags (JSON/tags/free text) that legitimately use resolveText.

Testing

tsc --noEmit clean.
Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for runtime --api-key, and identity api-key + oauth2 create.
Full suite: 1742 pass, 0 fail.

…eSecret The runtime add handler resolved its --api-key with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Switch to resolveSecret (stdin/file only, single-line enforced), matching the api-key and oauth credential handlers and the flag's documented contract.

The standalone identity api-key/oauth2 credential-provider create and update handlers resolved their --api-key / --client-secret with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Inline secrets on argv leak into shell history, ps output, and CI logs. Switch all four to resolveSecret (stdin '-' or file:// only, single-line enforced) and drop "inline" from the flag help, matching the project add credentials and runtime handlers. Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for api-key and oauth2 create.

codecov-commenter · 2026-08-24T15:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (38c30ae) to head (eaf11b5).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2080 +/- ##
=========================================
Coverage 97.24% 97.24% =========================================
Files 396 396 Lines 24019 24021 +2 =========================================
+ Hits 23357 23359 +2 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tejaskash · 2026-08-24T14:35:52Z

What

Route every secret-value flag through SourceResolver.resolveSecret (stdin - or file:// only, single-line enforced, trailing newline stripped) instead of the generic resolveText. Inline secrets on argv leak into shell history, ps output, and CI logs.

Handlers changed:

project add runtime--api-key (addresses jariy17's comment on feat(project): scaffold add runtime handler #2035, r3833097791: shift secret handling into SourceResolver and reuse it in runtime on rebase; resolveSecret was added in feat(project): add 'project add credentials' (AgentCore Identity api-key + oauth) #2046).
identity api-key-credential-provider create|update--api-key.
identity oauth2-credential-provider create|update--client-secret.

Also dropped "inline" from those flags' help text so it matches the enforced contract, aligning with the project add credentials handlers.

Not changed: bearer-token invoke paths (ephemeral, never persisted) and structured-config flags (JSON/tags/free text) that legitimately use resolveText.

Testing

tsc --noEmit clean.
Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for runtime --api-key, and identity api-key + oauth2 create.
Full suite: 1742 pass, 0 fail.

…eSecret The runtime add handler resolved its --api-key with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Switch to resolveSecret (stdin/file only, single-line enforced), matching the api-key and oauth credential handlers and the flag's documented contract.

The standalone identity api-key/oauth2 credential-provider create and update handlers resolved their --api-key / --client-secret with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Inline secrets on argv leak into shell history, ps output, and CI logs. Switch all four to resolveSecret (stdin '-' or file:// only, single-line enforced) and drop "inline" from the flag help, matching the project add credentials and runtime handlers. Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for api-key and oauth2 create.

codecov-commenter · 2026-08-24T15:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (38c30ae) to head (eaf11b5).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2080 +/- ##
=========================================
Coverage 97.24% 97.24% =========================================
Files 396 396 Lines 24019 24021 +2 =========================================
+ Hits 23357 23359 +2 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tejaskash · 2026-08-24T14:35:52Z

What

Route every secret-value flag through SourceResolver.resolveSecret (stdin - or file:// only, single-line enforced, trailing newline stripped) instead of the generic resolveText. Inline secrets on argv leak into shell history, ps output, and CI logs.

Handlers changed:

project add runtime--api-key (addresses jariy17's comment on feat(project): scaffold add runtime handler #2035, r3833097791: shift secret handling into SourceResolver and reuse it in runtime on rebase; resolveSecret was added in feat(project): add 'project add credentials' (AgentCore Identity api-key + oauth) #2046).
identity api-key-credential-provider create|update--api-key.
identity oauth2-credential-provider create|update--client-secret.

Also dropped "inline" from those flags' help text so it matches the enforced contract, aligning with the project add credentials handlers.

Not changed: bearer-token invoke paths (ephemeral, never persisted) and structured-config flags (JSON/tags/free text) that legitimately use resolveText.

Testing

tsc --noEmit clean.
Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for runtime --api-key, and identity api-key + oauth2 create.
Full suite: 1742 pass, 0 fail.

…eSecret The runtime add handler resolved its --api-key with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Switch to resolveSecret (stdin/file only, single-line enforced), matching the api-key and oauth credential handlers and the flag's documented contract.

The standalone identity api-key/oauth2 credential-provider create and update handlers resolved their --api-key / --client-secret with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Inline secrets on argv leak into shell history, ps output, and CI logs. Switch all four to resolveSecret (stdin '-' or file:// only, single-line enforced) and drop "inline" from the flag help, matching the project add credentials and runtime handlers. Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for api-key and oauth2 create.

codecov-commenter · 2026-08-24T15:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (38c30ae) to head (eaf11b5).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2080 +/- ##
=========================================
Coverage 97.24% 97.24% =========================================
Files 396 396 Lines 24019 24021 +2 =========================================
+ Hits 23357 23359 +2 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tejaskash · 2026-08-24T14:35:52Z

What

Route every secret-value flag through SourceResolver.resolveSecret (stdin - or file:// only, single-line enforced, trailing newline stripped) instead of the generic resolveText. Inline secrets on argv leak into shell history, ps output, and CI logs.

Handlers changed:

project add runtime--api-key (addresses jariy17's comment on feat(project): scaffold add runtime handler #2035, r3833097791: shift secret handling into SourceResolver and reuse it in runtime on rebase; resolveSecret was added in feat(project): add 'project add credentials' (AgentCore Identity api-key + oauth) #2046).
identity api-key-credential-provider create|update--api-key.
identity oauth2-credential-provider create|update--client-secret.

Also dropped "inline" from those flags' help text so it matches the enforced contract, aligning with the project add credentials handlers.

Not changed: bearer-token invoke paths (ephemeral, never persisted) and structured-config flags (JSON/tags/free text) that legitimately use resolveText.

Testing

tsc --noEmit clean.
Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for runtime --api-key, and identity api-key + oauth2 create.
Full suite: 1742 pass, 0 fail.

…eSecret The runtime add handler resolved its --api-key with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Switch to resolveSecret (stdin/file only, single-line enforced), matching the api-key and oauth credential handlers and the flag's documented contract.

The standalone identity api-key/oauth2 credential-provider create and update handlers resolved their --api-key / --client-secret with the generic resolveText, so an inline secret value was accepted and a trailing newline was not stripped. Inline secrets on argv leak into shell history, ps output, and CI logs. Switch all four to resolveSecret (stdin '-' or file:// only, single-line enforced) and drop "inline" from the flag help, matching the project add credentials and runtime handlers. Tests feeding a secret now pipe it via stdin; added inline-rejection coverage for api-key and oauth2 create.

codecov-commenter · 2026-08-24T15:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.24%. Comparing base (38c30ae) to head (eaf11b5).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2080 +/- ##
=========================================
Coverage 97.24% 97.24% =========================================
Files 396 396 Lines 24019 24021 +2 =========================================
+ Hits 23357 23359 +2 
Misses 662 662

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actionsBot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 24, 2026

tejaskash changed the title ~~fix(project): resolve runtime --api-key through SourceResolver.resolveSecret~~fix: reject inline secrets across runtime and identity credential commandsAug 24, 2026

jariy17 approved these changes Aug 24, 2026
View reviewed changes

jariy17 merged commit b75e1c6 into refactorAug 24, 2026
10 checks passed

jariy17 deleted the feat/runtime-api-key-resolve-secret branch August 24, 2026 16:07