fix(deps): pin @aws-cdk/toolkit-lib yaml to v1 to fix 'yaml/types' resolution by notgitika · Pull Request #2122 · aws/agentcore-cli

notgitika · 2026-08-26T23:43:41Z

What

Add a nested overrides entry forcing @aws-cdk/toolkit-lib's yaml dependency to ^1.

Why

@aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types")at import time — a subpath that only exists in yaml v1. yaml@2 (pulled transitively, e.g. via the lint-staged devDep) has an exports map that does not expose ./types, so any install topology that resolves toolkit-lib's yaml to the hoisted v2 fails to load the module with:

Cannot find module 'yaml/types' (ERR_PACKAGE_PATH_NOT_EXPORTED)

This is especially dangerous for bun compile, which inlines toolkit-lib (only bundle() marks it external) and embeds whatever yaml/types the build machine resolves.

Fix

"overrides": {
"@aws-cdk/toolkit-lib": { "yaml": "^1" }
}

Guarantees toolkit-lib always resolves the nested yaml@1 copy (which ships types.js).

Testing

Verified require.resolve('yaml/types') from toolkit-lib resolves to the v1 nested copy under both node and bun.
Reproduced the v2 failure (ERR_PACKAGE_PATH_NOT_EXPORTED) and confirmed the override prevents it.
project deploy (CDK synth + CloudFormation) exercised end-to-end after the change.

agentcore-devx-automation · 2026-08-26T23:45:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-08-26T23:46:46Z

looking into failing CI

agentcore-devx-automation

AgentCore Harness Review

Verdict: Changes requested

The override itself is correct and well-motivated — @aws-cdk/toolkit-lib@1.38.2 declares yaml: ^1, its yaml-cfn.js does require("yaml/types") which only resolves in yaml@1.x (v2 has no ./types in its exports map), and pinning the nested yaml to ^1 matches upstream's declared range. Bun supports npm's nested overrides syntax, so this works for both npm and bun install paths.

Issue: `bun.lock` is not updated

package.json is the only file changed in this PR, but every CI workflow in this repo runs bun install --frozen-lockfile (.github/workflows/build.yml, unit-test.yml, check.yml). Bun's --frozen-lockfile errors out when package.json and bun.lock disagree, which is what an added override does — the resolved yaml version under @aws-cdk/toolkit-lib in the lockfile will not reflect the new constraint until the lockfile is regenerated.

This matches what's happening on the PR: all build, unit-test, and check jobs across Linux/macOS/Windows are currently failing.

Fix: run bun install locally (without --frozen-lockfile) and commit the updated bun.lock alongside the package.json change. That will both make CI pass and ensure downstream bun compile builds embed the v1 copy of yaml/types deterministically (which is the whole point of the fix).

Once the lockfile is regenerated, it's worth spot-checking the bun.lock diff to confirm the toolkit-lib yaml entry is pinned to a 1.x version — that verifies the override actually took effect rather than silently being ignored.

notgitika · 2026-08-26T23:49:25Z

forgot to commit bun.lock earlier just added it

agentcore-devx-automation · 2026-08-26T23:49:45Z

Claude Security Review: no high-confidence findings. (run)

codecov-commenter · 2026-08-26T23:52:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (9ab30d3) to head (367f995).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2122 +/- ##
=========================================
Coverage 97.41% 97.41% =========================================
Files 453 453 Lines 27637 27637 =========================================
Hits 26922 26922 Misses 715 715

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

notgitika · 2026-08-26T23:58:13Z

CI windows failure seems like it's from the branch but let me confirm

…solution @aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types") at import time, a subpath that only exists in yaml v1. When an install topology resolves toolkit-lib's yaml to the hoisted yaml v2 (whose exports map blocks ./types), the module fails to load with ERR_PACKAGE_PATH_NOT_EXPORTED ("Cannot find module 'yaml/types'"). This bites bun compile, which inlines toolkit-lib and embeds whatever the build machine resolves. Add a nested override forcing toolkit-lib's yaml to ^1 so it always resolves the v1 nested copy that ships yaml/types.

agentcore-devx-automation · 2026-08-27T00:08:42Z

Claude Security Review: no high-confidence findings. (run)

Hweinstock

makes sense. I'm not still not fully clear on why its resolving in the wrong version if its pinned here https://github.com/aws/aws-cdk-cli/blob/02523f01b0a45a04582628ef3cd53160a3287032/packages/%40aws-cdk/toolkit-lib/package.json#L132, but I guess its because its not bundled in, so it tries to pull it in at runtime via require which doesn't check the version.

notgitika · 2026-08-27T06:00:37Z

Yeah, require just grabs the first yaml on disk, doesn't check the version. Override pins v1 so it always lands there

bun 1.4.0 — which CI installs via the unpinned setup-bun@v2 — records nested package.json overrides in the lockfile and refuses frozen installs when they are missing, so every CI job fails with "lockfile had changes, but lockfile is frozen" (the base refactor branch's own CI run on 2026-08-31 fails the same way; runs from 2026-08-28 under the previous bun were green). The bun that last saved this lockfile predated nested-override recording and silently dropped the @aws-cdk/toolkit-lib yaml pin from #2122. Regenerated with bun 1.4.0. The only changes are lockfileVersion 1 -> 3 and the recorded override block — zero resolution changes ("Checked 766 installs across 703 packages (no changes)"). The full CI gate passes under bun 1.4.0: frozen install, 2513 tests, tsc, oxlint, prettier. Note: lockfileVersion 3 requires bun >= 1.4.0 for lockfile-honoring installs; older bun prints "Ignoring lockfile" (it cannot represent the nested override either way, so there is no lockfile both versions accept). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfADH54TZn2SSGUUixft8P

notgitika · 2026-08-26T23:43:41Z

What

Add a nested overrides entry forcing @aws-cdk/toolkit-lib's yaml dependency to ^1.

Why

@aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types")at import time — a subpath that only exists in yaml v1. yaml@2 (pulled transitively, e.g. via the lint-staged devDep) has an exports map that does not expose ./types, so any install topology that resolves toolkit-lib's yaml to the hoisted v2 fails to load the module with:

Cannot find module 'yaml/types' (ERR_PACKAGE_PATH_NOT_EXPORTED)

This is especially dangerous for bun compile, which inlines toolkit-lib (only bundle() marks it external) and embeds whatever yaml/types the build machine resolves.

Fix

"overrides": {
"@aws-cdk/toolkit-lib": { "yaml": "^1" }
}

Guarantees toolkit-lib always resolves the nested yaml@1 copy (which ships types.js).

Testing

Verified require.resolve('yaml/types') from toolkit-lib resolves to the v1 nested copy under both node and bun.
Reproduced the v2 failure (ERR_PACKAGE_PATH_NOT_EXPORTED) and confirmed the override prevents it.
project deploy (CDK synth + CloudFormation) exercised end-to-end after the change.

agentcore-devx-automation · 2026-08-26T23:45:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-08-26T23:46:46Z

looking into failing CI

agentcore-devx-automation

AgentCore Harness Review

Verdict: Changes requested

The override itself is correct and well-motivated — @aws-cdk/toolkit-lib@1.38.2 declares yaml: ^1, its yaml-cfn.js does require("yaml/types") which only resolves in yaml@1.x (v2 has no ./types in its exports map), and pinning the nested yaml to ^1 matches upstream's declared range. Bun supports npm's nested overrides syntax, so this works for both npm and bun install paths.

Issue: `bun.lock` is not updated

package.json is the only file changed in this PR, but every CI workflow in this repo runs bun install --frozen-lockfile (.github/workflows/build.yml, unit-test.yml, check.yml). Bun's --frozen-lockfile errors out when package.json and bun.lock disagree, which is what an added override does — the resolved yaml version under @aws-cdk/toolkit-lib in the lockfile will not reflect the new constraint until the lockfile is regenerated.

This matches what's happening on the PR: all build, unit-test, and check jobs across Linux/macOS/Windows are currently failing.

Fix: run bun install locally (without --frozen-lockfile) and commit the updated bun.lock alongside the package.json change. That will both make CI pass and ensure downstream bun compile builds embed the v1 copy of yaml/types deterministically (which is the whole point of the fix).

Once the lockfile is regenerated, it's worth spot-checking the bun.lock diff to confirm the toolkit-lib yaml entry is pinned to a 1.x version — that verifies the override actually took effect rather than silently being ignored.

notgitika · 2026-08-26T23:49:25Z

forgot to commit bun.lock earlier just added it

agentcore-devx-automation · 2026-08-26T23:49:45Z

Claude Security Review: no high-confidence findings. (run)

codecov-commenter · 2026-08-26T23:52:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (9ab30d3) to head (367f995).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2122 +/- ##
=========================================
Coverage 97.41% 97.41% =========================================
Files 453 453 Lines 27637 27637 =========================================
Hits 26922 26922 Misses 715 715

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

notgitika · 2026-08-26T23:58:13Z

CI windows failure seems like it's from the branch but let me confirm

…solution @aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types") at import time, a subpath that only exists in yaml v1. When an install topology resolves toolkit-lib's yaml to the hoisted yaml v2 (whose exports map blocks ./types), the module fails to load with ERR_PACKAGE_PATH_NOT_EXPORTED ("Cannot find module 'yaml/types'"). This bites bun compile, which inlines toolkit-lib and embeds whatever the build machine resolves. Add a nested override forcing toolkit-lib's yaml to ^1 so it always resolves the v1 nested copy that ships yaml/types.

agentcore-devx-automation · 2026-08-27T00:08:42Z

Claude Security Review: no high-confidence findings. (run)

Hweinstock

makes sense. I'm not still not fully clear on why its resolving in the wrong version if its pinned here https://github.com/aws/aws-cdk-cli/blob/02523f01b0a45a04582628ef3cd53160a3287032/packages/%40aws-cdk/toolkit-lib/package.json#L132, but I guess its because its not bundled in, so it tries to pull it in at runtime via require which doesn't check the version.

notgitika · 2026-08-27T06:00:37Z

Yeah, require just grabs the first yaml on disk, doesn't check the version. Override pins v1 so it always lands there

bun 1.4.0 — which CI installs via the unpinned setup-bun@v2 — records nested package.json overrides in the lockfile and refuses frozen installs when they are missing, so every CI job fails with "lockfile had changes, but lockfile is frozen" (the base refactor branch's own CI run on 2026-08-31 fails the same way; runs from 2026-08-28 under the previous bun were green). The bun that last saved this lockfile predated nested-override recording and silently dropped the @aws-cdk/toolkit-lib yaml pin from #2122. Regenerated with bun 1.4.0. The only changes are lockfileVersion 1 -> 3 and the recorded override block — zero resolution changes ("Checked 766 installs across 703 packages (no changes)"). The full CI gate passes under bun 1.4.0: frozen install, 2513 tests, tsc, oxlint, prettier. Note: lockfileVersion 3 requires bun >= 1.4.0 for lockfile-honoring installs; older bun prints "Ignoring lockfile" (it cannot represent the nested override either way, so there is no lockfile both versions accept). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfADH54TZn2SSGUUixft8P

notgitika · 2026-08-26T23:43:41Z

What

Add a nested overrides entry forcing @aws-cdk/toolkit-lib's yaml dependency to ^1.

Why

@aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types")at import time — a subpath that only exists in yaml v1. yaml@2 (pulled transitively, e.g. via the lint-staged devDep) has an exports map that does not expose ./types, so any install topology that resolves toolkit-lib's yaml to the hoisted v2 fails to load the module with:

Cannot find module 'yaml/types' (ERR_PACKAGE_PATH_NOT_EXPORTED)

This is especially dangerous for bun compile, which inlines toolkit-lib (only bundle() marks it external) and embeds whatever yaml/types the build machine resolves.

Fix

"overrides": {
"@aws-cdk/toolkit-lib": { "yaml": "^1" }
}

Guarantees toolkit-lib always resolves the nested yaml@1 copy (which ships types.js).

Testing

Verified require.resolve('yaml/types') from toolkit-lib resolves to the v1 nested copy under both node and bun.
Reproduced the v2 failure (ERR_PACKAGE_PATH_NOT_EXPORTED) and confirmed the override prevents it.
project deploy (CDK synth + CloudFormation) exercised end-to-end after the change.

agentcore-devx-automation · 2026-08-26T23:45:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-08-26T23:46:46Z

looking into failing CI

agentcore-devx-automation

AgentCore Harness Review

Verdict: Changes requested

The override itself is correct and well-motivated — @aws-cdk/toolkit-lib@1.38.2 declares yaml: ^1, its yaml-cfn.js does require("yaml/types") which only resolves in yaml@1.x (v2 has no ./types in its exports map), and pinning the nested yaml to ^1 matches upstream's declared range. Bun supports npm's nested overrides syntax, so this works for both npm and bun install paths.

Issue: `bun.lock` is not updated

package.json is the only file changed in this PR, but every CI workflow in this repo runs bun install --frozen-lockfile (.github/workflows/build.yml, unit-test.yml, check.yml). Bun's --frozen-lockfile errors out when package.json and bun.lock disagree, which is what an added override does — the resolved yaml version under @aws-cdk/toolkit-lib in the lockfile will not reflect the new constraint until the lockfile is regenerated.

This matches what's happening on the PR: all build, unit-test, and check jobs across Linux/macOS/Windows are currently failing.

Fix: run bun install locally (without --frozen-lockfile) and commit the updated bun.lock alongside the package.json change. That will both make CI pass and ensure downstream bun compile builds embed the v1 copy of yaml/types deterministically (which is the whole point of the fix).

Once the lockfile is regenerated, it's worth spot-checking the bun.lock diff to confirm the toolkit-lib yaml entry is pinned to a 1.x version — that verifies the override actually took effect rather than silently being ignored.

notgitika · 2026-08-26T23:49:25Z

forgot to commit bun.lock earlier just added it

agentcore-devx-automation · 2026-08-26T23:49:45Z

Claude Security Review: no high-confidence findings. (run)

codecov-commenter · 2026-08-26T23:52:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (9ab30d3) to head (367f995).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2122 +/- ##
=========================================
Coverage 97.41% 97.41% =========================================
Files 453 453 Lines 27637 27637 =========================================
Hits 26922 26922 Misses 715 715

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

notgitika · 2026-08-26T23:58:13Z

CI windows failure seems like it's from the branch but let me confirm

…solution @aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types") at import time, a subpath that only exists in yaml v1. When an install topology resolves toolkit-lib's yaml to the hoisted yaml v2 (whose exports map blocks ./types), the module fails to load with ERR_PACKAGE_PATH_NOT_EXPORTED ("Cannot find module 'yaml/types'"). This bites bun compile, which inlines toolkit-lib and embeds whatever the build machine resolves. Add a nested override forcing toolkit-lib's yaml to ^1 so it always resolves the v1 nested copy that ships yaml/types.

agentcore-devx-automation · 2026-08-27T00:08:42Z

Claude Security Review: no high-confidence findings. (run)

Hweinstock

makes sense. I'm not still not fully clear on why its resolving in the wrong version if its pinned here https://github.com/aws/aws-cdk-cli/blob/02523f01b0a45a04582628ef3cd53160a3287032/packages/%40aws-cdk/toolkit-lib/package.json#L132, but I guess its because its not bundled in, so it tries to pull it in at runtime via require which doesn't check the version.

notgitika · 2026-08-27T06:00:37Z

Yeah, require just grabs the first yaml on disk, doesn't check the version. Override pins v1 so it always lands there

bun 1.4.0 — which CI installs via the unpinned setup-bun@v2 — records nested package.json overrides in the lockfile and refuses frozen installs when they are missing, so every CI job fails with "lockfile had changes, but lockfile is frozen" (the base refactor branch's own CI run on 2026-08-31 fails the same way; runs from 2026-08-28 under the previous bun were green). The bun that last saved this lockfile predated nested-override recording and silently dropped the @aws-cdk/toolkit-lib yaml pin from #2122. Regenerated with bun 1.4.0. The only changes are lockfileVersion 1 -> 3 and the recorded override block — zero resolution changes ("Checked 766 installs across 703 packages (no changes)"). The full CI gate passes under bun 1.4.0: frozen install, 2513 tests, tsc, oxlint, prettier. Note: lockfileVersion 3 requires bun >= 1.4.0 for lockfile-honoring installs; older bun prints "Ignoring lockfile" (it cannot represent the nested override either way, so there is no lockfile both versions accept). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfADH54TZn2SSGUUixft8P

notgitika · 2026-08-26T23:43:41Z

What

Add a nested overrides entry forcing @aws-cdk/toolkit-lib's yaml dependency to ^1.

Why

@aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types")at import time — a subpath that only exists in yaml v1. yaml@2 (pulled transitively, e.g. via the lint-staged devDep) has an exports map that does not expose ./types, so any install topology that resolves toolkit-lib's yaml to the hoisted v2 fails to load the module with:

Cannot find module 'yaml/types' (ERR_PACKAGE_PATH_NOT_EXPORTED)

This is especially dangerous for bun compile, which inlines toolkit-lib (only bundle() marks it external) and embeds whatever yaml/types the build machine resolves.

Fix

"overrides": {
"@aws-cdk/toolkit-lib": { "yaml": "^1" }
}

Guarantees toolkit-lib always resolves the nested yaml@1 copy (which ships types.js).

Testing

Verified require.resolve('yaml/types') from toolkit-lib resolves to the v1 nested copy under both node and bun.
Reproduced the v2 failure (ERR_PACKAGE_PATH_NOT_EXPORTED) and confirmed the override prevents it.
project deploy (CDK synth + CloudFormation) exercised end-to-end after the change.

agentcore-devx-automation · 2026-08-26T23:45:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-08-26T23:46:46Z

looking into failing CI

agentcore-devx-automation

AgentCore Harness Review

Verdict: Changes requested

The override itself is correct and well-motivated — @aws-cdk/toolkit-lib@1.38.2 declares yaml: ^1, its yaml-cfn.js does require("yaml/types") which only resolves in yaml@1.x (v2 has no ./types in its exports map), and pinning the nested yaml to ^1 matches upstream's declared range. Bun supports npm's nested overrides syntax, so this works for both npm and bun install paths.

Issue: `bun.lock` is not updated

package.json is the only file changed in this PR, but every CI workflow in this repo runs bun install --frozen-lockfile (.github/workflows/build.yml, unit-test.yml, check.yml). Bun's --frozen-lockfile errors out when package.json and bun.lock disagree, which is what an added override does — the resolved yaml version under @aws-cdk/toolkit-lib in the lockfile will not reflect the new constraint until the lockfile is regenerated.

This matches what's happening on the PR: all build, unit-test, and check jobs across Linux/macOS/Windows are currently failing.

Fix: run bun install locally (without --frozen-lockfile) and commit the updated bun.lock alongside the package.json change. That will both make CI pass and ensure downstream bun compile builds embed the v1 copy of yaml/types deterministically (which is the whole point of the fix).

Once the lockfile is regenerated, it's worth spot-checking the bun.lock diff to confirm the toolkit-lib yaml entry is pinned to a 1.x version — that verifies the override actually took effect rather than silently being ignored.

notgitika · 2026-08-26T23:49:25Z

forgot to commit bun.lock earlier just added it

agentcore-devx-automation · 2026-08-26T23:49:45Z

Claude Security Review: no high-confidence findings. (run)

codecov-commenter · 2026-08-26T23:52:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (9ab30d3) to head (367f995).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2122 +/- ##
=========================================
Coverage 97.41% 97.41% =========================================
Files 453 453 Lines 27637 27637 =========================================
Hits 26922 26922 Misses 715 715

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

notgitika · 2026-08-26T23:58:13Z

CI windows failure seems like it's from the branch but let me confirm

…solution @aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types") at import time, a subpath that only exists in yaml v1. When an install topology resolves toolkit-lib's yaml to the hoisted yaml v2 (whose exports map blocks ./types), the module fails to load with ERR_PACKAGE_PATH_NOT_EXPORTED ("Cannot find module 'yaml/types'"). This bites bun compile, which inlines toolkit-lib and embeds whatever the build machine resolves. Add a nested override forcing toolkit-lib's yaml to ^1 so it always resolves the v1 nested copy that ships yaml/types.

agentcore-devx-automation · 2026-08-27T00:08:42Z

Claude Security Review: no high-confidence findings. (run)

Hweinstock

makes sense. I'm not still not fully clear on why its resolving in the wrong version if its pinned here https://github.com/aws/aws-cdk-cli/blob/02523f01b0a45a04582628ef3cd53160a3287032/packages/%40aws-cdk/toolkit-lib/package.json#L132, but I guess its because its not bundled in, so it tries to pull it in at runtime via require which doesn't check the version.

notgitika · 2026-08-27T06:00:37Z

Yeah, require just grabs the first yaml on disk, doesn't check the version. Override pins v1 so it always lands there

bun 1.4.0 — which CI installs via the unpinned setup-bun@v2 — records nested package.json overrides in the lockfile and refuses frozen installs when they are missing, so every CI job fails with "lockfile had changes, but lockfile is frozen" (the base refactor branch's own CI run on 2026-08-31 fails the same way; runs from 2026-08-28 under the previous bun were green). The bun that last saved this lockfile predated nested-override recording and silently dropped the @aws-cdk/toolkit-lib yaml pin from #2122. Regenerated with bun 1.4.0. The only changes are lockfileVersion 1 -> 3 and the recorded override block — zero resolution changes ("Checked 766 installs across 703 packages (no changes)"). The full CI gate passes under bun 1.4.0: frozen install, 2513 tests, tsc, oxlint, prettier. Note: lockfileVersion 3 requires bun >= 1.4.0 for lockfile-honoring installs; older bun prints "Ignoring lockfile" (it cannot represent the nested override either way, so there is no lockfile both versions accept). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfADH54TZn2SSGUUixft8P

notgitika · 2026-08-26T23:43:41Z

What

Add a nested overrides entry forcing @aws-cdk/toolkit-lib's yaml dependency to ^1.

Why

@aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types")at import time — a subpath that only exists in yaml v1. yaml@2 (pulled transitively, e.g. via the lint-staged devDep) has an exports map that does not expose ./types, so any install topology that resolves toolkit-lib's yaml to the hoisted v2 fails to load the module with:

Cannot find module 'yaml/types' (ERR_PACKAGE_PATH_NOT_EXPORTED)

This is especially dangerous for bun compile, which inlines toolkit-lib (only bundle() marks it external) and embeds whatever yaml/types the build machine resolves.

Fix

"overrides": {
"@aws-cdk/toolkit-lib": { "yaml": "^1" }
}

Guarantees toolkit-lib always resolves the nested yaml@1 copy (which ships types.js).

Testing

Verified require.resolve('yaml/types') from toolkit-lib resolves to the v1 nested copy under both node and bun.
Reproduced the v2 failure (ERR_PACKAGE_PATH_NOT_EXPORTED) and confirmed the override prevents it.
project deploy (CDK synth + CloudFormation) exercised end-to-end after the change.

agentcore-devx-automation · 2026-08-26T23:45:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-08-26T23:46:46Z

looking into failing CI

agentcore-devx-automation

AgentCore Harness Review

Verdict: Changes requested

The override itself is correct and well-motivated — @aws-cdk/toolkit-lib@1.38.2 declares yaml: ^1, its yaml-cfn.js does require("yaml/types") which only resolves in yaml@1.x (v2 has no ./types in its exports map), and pinning the nested yaml to ^1 matches upstream's declared range. Bun supports npm's nested overrides syntax, so this works for both npm and bun install paths.

Issue: `bun.lock` is not updated

package.json is the only file changed in this PR, but every CI workflow in this repo runs bun install --frozen-lockfile (.github/workflows/build.yml, unit-test.yml, check.yml). Bun's --frozen-lockfile errors out when package.json and bun.lock disagree, which is what an added override does — the resolved yaml version under @aws-cdk/toolkit-lib in the lockfile will not reflect the new constraint until the lockfile is regenerated.

This matches what's happening on the PR: all build, unit-test, and check jobs across Linux/macOS/Windows are currently failing.

Fix: run bun install locally (without --frozen-lockfile) and commit the updated bun.lock alongside the package.json change. That will both make CI pass and ensure downstream bun compile builds embed the v1 copy of yaml/types deterministically (which is the whole point of the fix).

Once the lockfile is regenerated, it's worth spot-checking the bun.lock diff to confirm the toolkit-lib yaml entry is pinned to a 1.x version — that verifies the override actually took effect rather than silently being ignored.

notgitika · 2026-08-26T23:49:25Z

forgot to commit bun.lock earlier just added it

agentcore-devx-automation · 2026-08-26T23:49:45Z

Claude Security Review: no high-confidence findings. (run)

codecov-commenter · 2026-08-26T23:52:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (9ab30d3) to head (367f995).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2122 +/- ##
=========================================
Coverage 97.41% 97.41% =========================================
Files 453 453 Lines 27637 27637 =========================================
Hits 26922 26922 Misses 715 715

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

notgitika · 2026-08-26T23:58:13Z

CI windows failure seems like it's from the branch but let me confirm

…solution @aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types") at import time, a subpath that only exists in yaml v1. When an install topology resolves toolkit-lib's yaml to the hoisted yaml v2 (whose exports map blocks ./types), the module fails to load with ERR_PACKAGE_PATH_NOT_EXPORTED ("Cannot find module 'yaml/types'"). This bites bun compile, which inlines toolkit-lib and embeds whatever the build machine resolves. Add a nested override forcing toolkit-lib's yaml to ^1 so it always resolves the v1 nested copy that ships yaml/types.

agentcore-devx-automation · 2026-08-27T00:08:42Z

Claude Security Review: no high-confidence findings. (run)

Hweinstock

makes sense. I'm not still not fully clear on why its resolving in the wrong version if its pinned here https://github.com/aws/aws-cdk-cli/blob/02523f01b0a45a04582628ef3cd53160a3287032/packages/%40aws-cdk/toolkit-lib/package.json#L132, but I guess its because its not bundled in, so it tries to pull it in at runtime via require which doesn't check the version.

notgitika · 2026-08-27T06:00:37Z

Yeah, require just grabs the first yaml on disk, doesn't check the version. Override pins v1 so it always lands there

bun 1.4.0 — which CI installs via the unpinned setup-bun@v2 — records nested package.json overrides in the lockfile and refuses frozen installs when they are missing, so every CI job fails with "lockfile had changes, but lockfile is frozen" (the base refactor branch's own CI run on 2026-08-31 fails the same way; runs from 2026-08-28 under the previous bun were green). The bun that last saved this lockfile predated nested-override recording and silently dropped the @aws-cdk/toolkit-lib yaml pin from #2122. Regenerated with bun 1.4.0. The only changes are lockfileVersion 1 -> 3 and the recorded override block — zero resolution changes ("Checked 766 installs across 703 packages (no changes)"). The full CI gate passes under bun 1.4.0: frozen install, 2513 tests, tsc, oxlint, prettier. Note: lockfileVersion 3 requires bun >= 1.4.0 for lockfile-honoring installs; older bun prints "Ignoring lockfile" (it cannot represent the nested override either way, so there is no lockfile both versions accept). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfADH54TZn2SSGUUixft8P

notgitika · 2026-08-26T23:43:41Z

What

Add a nested overrides entry forcing @aws-cdk/toolkit-lib's yaml dependency to ^1.

Why

@aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types")at import time — a subpath that only exists in yaml v1. yaml@2 (pulled transitively, e.g. via the lint-staged devDep) has an exports map that does not expose ./types, so any install topology that resolves toolkit-lib's yaml to the hoisted v2 fails to load the module with:

Cannot find module 'yaml/types' (ERR_PACKAGE_PATH_NOT_EXPORTED)

This is especially dangerous for bun compile, which inlines toolkit-lib (only bundle() marks it external) and embeds whatever yaml/types the build machine resolves.

Fix

"overrides": {
"@aws-cdk/toolkit-lib": { "yaml": "^1" }
}

Guarantees toolkit-lib always resolves the nested yaml@1 copy (which ships types.js).

Testing

Verified require.resolve('yaml/types') from toolkit-lib resolves to the v1 nested copy under both node and bun.
Reproduced the v2 failure (ERR_PACKAGE_PATH_NOT_EXPORTED) and confirmed the override prevents it.
project deploy (CDK synth + CloudFormation) exercised end-to-end after the change.

agentcore-devx-automation · 2026-08-26T23:45:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-08-26T23:46:46Z

looking into failing CI

agentcore-devx-automation

AgentCore Harness Review

Verdict: Changes requested

The override itself is correct and well-motivated — @aws-cdk/toolkit-lib@1.38.2 declares yaml: ^1, its yaml-cfn.js does require("yaml/types") which only resolves in yaml@1.x (v2 has no ./types in its exports map), and pinning the nested yaml to ^1 matches upstream's declared range. Bun supports npm's nested overrides syntax, so this works for both npm and bun install paths.

Issue: `bun.lock` is not updated

package.json is the only file changed in this PR, but every CI workflow in this repo runs bun install --frozen-lockfile (.github/workflows/build.yml, unit-test.yml, check.yml). Bun's --frozen-lockfile errors out when package.json and bun.lock disagree, which is what an added override does — the resolved yaml version under @aws-cdk/toolkit-lib in the lockfile will not reflect the new constraint until the lockfile is regenerated.

This matches what's happening on the PR: all build, unit-test, and check jobs across Linux/macOS/Windows are currently failing.

Fix: run bun install locally (without --frozen-lockfile) and commit the updated bun.lock alongside the package.json change. That will both make CI pass and ensure downstream bun compile builds embed the v1 copy of yaml/types deterministically (which is the whole point of the fix).

Once the lockfile is regenerated, it's worth spot-checking the bun.lock diff to confirm the toolkit-lib yaml entry is pinned to a 1.x version — that verifies the override actually took effect rather than silently being ignored.

notgitika · 2026-08-26T23:49:25Z

forgot to commit bun.lock earlier just added it

agentcore-devx-automation · 2026-08-26T23:49:45Z

Claude Security Review: no high-confidence findings. (run)

codecov-commenter · 2026-08-26T23:52:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (9ab30d3) to head (367f995).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2122 +/- ##
=========================================
Coverage 97.41% 97.41% =========================================
Files 453 453 Lines 27637 27637 =========================================
Hits 26922 26922 Misses 715 715

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

notgitika · 2026-08-26T23:58:13Z

CI windows failure seems like it's from the branch but let me confirm

…solution @aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types") at import time, a subpath that only exists in yaml v1. When an install topology resolves toolkit-lib's yaml to the hoisted yaml v2 (whose exports map blocks ./types), the module fails to load with ERR_PACKAGE_PATH_NOT_EXPORTED ("Cannot find module 'yaml/types'"). This bites bun compile, which inlines toolkit-lib and embeds whatever the build machine resolves. Add a nested override forcing toolkit-lib's yaml to ^1 so it always resolves the v1 nested copy that ships yaml/types.

agentcore-devx-automation · 2026-08-27T00:08:42Z

Claude Security Review: no high-confidence findings. (run)

Hweinstock

makes sense. I'm not still not fully clear on why its resolving in the wrong version if its pinned here https://github.com/aws/aws-cdk-cli/blob/02523f01b0a45a04582628ef3cd53160a3287032/packages/%40aws-cdk/toolkit-lib/package.json#L132, but I guess its because its not bundled in, so it tries to pull it in at runtime via require which doesn't check the version.

notgitika · 2026-08-27T06:00:37Z

Yeah, require just grabs the first yaml on disk, doesn't check the version. Override pins v1 so it always lands there

bun 1.4.0 — which CI installs via the unpinned setup-bun@v2 — records nested package.json overrides in the lockfile and refuses frozen installs when they are missing, so every CI job fails with "lockfile had changes, but lockfile is frozen" (the base refactor branch's own CI run on 2026-08-31 fails the same way; runs from 2026-08-28 under the previous bun were green). The bun that last saved this lockfile predated nested-override recording and silently dropped the @aws-cdk/toolkit-lib yaml pin from #2122. Regenerated with bun 1.4.0. The only changes are lockfileVersion 1 -> 3 and the recorded override block — zero resolution changes ("Checked 766 installs across 703 packages (no changes)"). The full CI gate passes under bun 1.4.0: frozen install, 2513 tests, tsc, oxlint, prettier. Note: lockfileVersion 3 requires bun >= 1.4.0 for lockfile-honoring installs; older bun prints "Ignoring lockfile" (it cannot represent the nested override either way, so there is no lockfile both versions accept). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfADH54TZn2SSGUUixft8P

notgitika · 2026-08-26T23:43:41Z

What

Add a nested overrides entry forcing @aws-cdk/toolkit-lib's yaml dependency to ^1.

Why

@aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types")at import time — a subpath that only exists in yaml v1. yaml@2 (pulled transitively, e.g. via the lint-staged devDep) has an exports map that does not expose ./types, so any install topology that resolves toolkit-lib's yaml to the hoisted v2 fails to load the module with:

Cannot find module 'yaml/types' (ERR_PACKAGE_PATH_NOT_EXPORTED)

This is especially dangerous for bun compile, which inlines toolkit-lib (only bundle() marks it external) and embeds whatever yaml/types the build machine resolves.

Fix

"overrides": {
"@aws-cdk/toolkit-lib": { "yaml": "^1" }
}

Guarantees toolkit-lib always resolves the nested yaml@1 copy (which ships types.js).

Testing

Verified require.resolve('yaml/types') from toolkit-lib resolves to the v1 nested copy under both node and bun.
Reproduced the v2 failure (ERR_PACKAGE_PATH_NOT_EXPORTED) and confirmed the override prevents it.
project deploy (CDK synth + CloudFormation) exercised end-to-end after the change.

agentcore-devx-automation · 2026-08-26T23:45:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-08-26T23:46:46Z

looking into failing CI

agentcore-devx-automation

AgentCore Harness Review

Verdict: Changes requested

The override itself is correct and well-motivated — @aws-cdk/toolkit-lib@1.38.2 declares yaml: ^1, its yaml-cfn.js does require("yaml/types") which only resolves in yaml@1.x (v2 has no ./types in its exports map), and pinning the nested yaml to ^1 matches upstream's declared range. Bun supports npm's nested overrides syntax, so this works for both npm and bun install paths.

Issue: `bun.lock` is not updated

package.json is the only file changed in this PR, but every CI workflow in this repo runs bun install --frozen-lockfile (.github/workflows/build.yml, unit-test.yml, check.yml). Bun's --frozen-lockfile errors out when package.json and bun.lock disagree, which is what an added override does — the resolved yaml version under @aws-cdk/toolkit-lib in the lockfile will not reflect the new constraint until the lockfile is regenerated.

This matches what's happening on the PR: all build, unit-test, and check jobs across Linux/macOS/Windows are currently failing.

Fix: run bun install locally (without --frozen-lockfile) and commit the updated bun.lock alongside the package.json change. That will both make CI pass and ensure downstream bun compile builds embed the v1 copy of yaml/types deterministically (which is the whole point of the fix).

Once the lockfile is regenerated, it's worth spot-checking the bun.lock diff to confirm the toolkit-lib yaml entry is pinned to a 1.x version — that verifies the override actually took effect rather than silently being ignored.

notgitika · 2026-08-26T23:49:25Z

forgot to commit bun.lock earlier just added it

agentcore-devx-automation · 2026-08-26T23:49:45Z

Claude Security Review: no high-confidence findings. (run)

codecov-commenter · 2026-08-26T23:52:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (9ab30d3) to head (367f995).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2122 +/- ##
=========================================
Coverage 97.41% 97.41% =========================================
Files 453 453 Lines 27637 27637 =========================================
Hits 26922 26922 Misses 715 715

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

notgitika · 2026-08-26T23:58:13Z

CI windows failure seems like it's from the branch but let me confirm

…solution @aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types") at import time, a subpath that only exists in yaml v1. When an install topology resolves toolkit-lib's yaml to the hoisted yaml v2 (whose exports map blocks ./types), the module fails to load with ERR_PACKAGE_PATH_NOT_EXPORTED ("Cannot find module 'yaml/types'"). This bites bun compile, which inlines toolkit-lib and embeds whatever the build machine resolves. Add a nested override forcing toolkit-lib's yaml to ^1 so it always resolves the v1 nested copy that ships yaml/types.

agentcore-devx-automation · 2026-08-27T00:08:42Z

Claude Security Review: no high-confidence findings. (run)

Hweinstock

makes sense. I'm not still not fully clear on why its resolving in the wrong version if its pinned here https://github.com/aws/aws-cdk-cli/blob/02523f01b0a45a04582628ef3cd53160a3287032/packages/%40aws-cdk/toolkit-lib/package.json#L132, but I guess its because its not bundled in, so it tries to pull it in at runtime via require which doesn't check the version.

notgitika · 2026-08-27T06:00:37Z

Yeah, require just grabs the first yaml on disk, doesn't check the version. Override pins v1 so it always lands there

bun 1.4.0 — which CI installs via the unpinned setup-bun@v2 — records nested package.json overrides in the lockfile and refuses frozen installs when they are missing, so every CI job fails with "lockfile had changes, but lockfile is frozen" (the base refactor branch's own CI run on 2026-08-31 fails the same way; runs from 2026-08-28 under the previous bun were green). The bun that last saved this lockfile predated nested-override recording and silently dropped the @aws-cdk/toolkit-lib yaml pin from #2122. Regenerated with bun 1.4.0. The only changes are lockfileVersion 1 -> 3 and the recorded override block — zero resolution changes ("Checked 766 installs across 703 packages (no changes)"). The full CI gate passes under bun 1.4.0: frozen install, 2513 tests, tsc, oxlint, prettier. Note: lockfileVersion 3 requires bun >= 1.4.0 for lockfile-honoring installs; older bun prints "Ignoring lockfile" (it cannot represent the nested override either way, so there is no lockfile both versions accept). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfADH54TZn2SSGUUixft8P

notgitika · 2026-08-26T23:43:41Z

What

Add a nested overrides entry forcing @aws-cdk/toolkit-lib's yaml dependency to ^1.

Why

@aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types")at import time — a subpath that only exists in yaml v1. yaml@2 (pulled transitively, e.g. via the lint-staged devDep) has an exports map that does not expose ./types, so any install topology that resolves toolkit-lib's yaml to the hoisted v2 fails to load the module with:

Cannot find module 'yaml/types' (ERR_PACKAGE_PATH_NOT_EXPORTED)

This is especially dangerous for bun compile, which inlines toolkit-lib (only bundle() marks it external) and embeds whatever yaml/types the build machine resolves.

Fix

"overrides": {
"@aws-cdk/toolkit-lib": { "yaml": "^1" }
}

Guarantees toolkit-lib always resolves the nested yaml@1 copy (which ships types.js).

Testing

Verified require.resolve('yaml/types') from toolkit-lib resolves to the v1 nested copy under both node and bun.
Reproduced the v2 failure (ERR_PACKAGE_PATH_NOT_EXPORTED) and confirmed the override prevents it.
project deploy (CDK synth + CloudFormation) exercised end-to-end after the change.

agentcore-devx-automation · 2026-08-26T23:45:46Z

Claude Security Review: no high-confidence findings. (run)

notgitika · 2026-08-26T23:46:46Z

looking into failing CI

agentcore-devx-automation

AgentCore Harness Review

Verdict: Changes requested

The override itself is correct and well-motivated — @aws-cdk/toolkit-lib@1.38.2 declares yaml: ^1, its yaml-cfn.js does require("yaml/types") which only resolves in yaml@1.x (v2 has no ./types in its exports map), and pinning the nested yaml to ^1 matches upstream's declared range. Bun supports npm's nested overrides syntax, so this works for both npm and bun install paths.

Issue: `bun.lock` is not updated

package.json is the only file changed in this PR, but every CI workflow in this repo runs bun install --frozen-lockfile (.github/workflows/build.yml, unit-test.yml, check.yml). Bun's --frozen-lockfile errors out when package.json and bun.lock disagree, which is what an added override does — the resolved yaml version under @aws-cdk/toolkit-lib in the lockfile will not reflect the new constraint until the lockfile is regenerated.

This matches what's happening on the PR: all build, unit-test, and check jobs across Linux/macOS/Windows are currently failing.

Fix: run bun install locally (without --frozen-lockfile) and commit the updated bun.lock alongside the package.json change. That will both make CI pass and ensure downstream bun compile builds embed the v1 copy of yaml/types deterministically (which is the whole point of the fix).

Once the lockfile is regenerated, it's worth spot-checking the bun.lock diff to confirm the toolkit-lib yaml entry is pinned to a 1.x version — that verifies the override actually took effect rather than silently being ignored.

notgitika · 2026-08-26T23:49:25Z

forgot to commit bun.lock earlier just added it

agentcore-devx-automation · 2026-08-26T23:49:45Z

Claude Security Review: no high-confidence findings. (run)

codecov-commenter · 2026-08-26T23:52:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (9ab30d3) to head (367f995).

Additional details and impacted files

@@ Coverage Diff @@## refactor #2122 +/- ##
=========================================
Coverage 97.41% 97.41% =========================================
Files 453 453 Lines 27637 27637 =========================================
Hits 26922 26922 Misses 715 715

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

notgitika · 2026-08-26T23:58:13Z

CI windows failure seems like it's from the branch but let me confirm

…solution @aws-cdk/toolkit-lib's yaml-cfn.js does require("yaml/types") at import time, a subpath that only exists in yaml v1. When an install topology resolves toolkit-lib's yaml to the hoisted yaml v2 (whose exports map blocks ./types), the module fails to load with ERR_PACKAGE_PATH_NOT_EXPORTED ("Cannot find module 'yaml/types'"). This bites bun compile, which inlines toolkit-lib and embeds whatever the build machine resolves. Add a nested override forcing toolkit-lib's yaml to ^1 so it always resolves the v1 nested copy that ships yaml/types.

agentcore-devx-automation · 2026-08-27T00:08:42Z

Claude Security Review: no high-confidence findings. (run)

Hweinstock

makes sense. I'm not still not fully clear on why its resolving in the wrong version if its pinned here https://github.com/aws/aws-cdk-cli/blob/02523f01b0a45a04582628ef3cd53160a3287032/packages/%40aws-cdk/toolkit-lib/package.json#L132, but I guess its because its not bundled in, so it tries to pull it in at runtime via require which doesn't check the version.

notgitika · 2026-08-27T06:00:37Z

Yeah, require just grabs the first yaml on disk, doesn't check the version. Override pins v1 so it always lands there

bun 1.4.0 — which CI installs via the unpinned setup-bun@v2 — records nested package.json overrides in the lockfile and refuses frozen installs when they are missing, so every CI job fails with "lockfile had changes, but lockfile is frozen" (the base refactor branch's own CI run on 2026-08-31 fails the same way; runs from 2026-08-28 under the previous bun were green). The bun that last saved this lockfile predated nested-override recording and silently dropped the @aws-cdk/toolkit-lib yaml pin from #2122. Regenerated with bun 1.4.0. The only changes are lockfileVersion 1 -> 3 and the recorded override block — zero resolution changes ("Checked 766 installs across 703 packages (no changes)"). The full CI gate passes under bun 1.4.0: frozen install, 2513 tests, tsc, oxlint, prettier. Note: lockfileVersion 3 requires bun >= 1.4.0 for lockfile-honoring installs; older bun prints "Ignoring lockfile" (it cannot represent the nested override either way, so there is no lockfile both versions accept). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfADH54TZn2SSGUUixft8P

github-actionsBot added the size/xs PR size: XS label Aug 26, 2026

agentcore-devx-automationBot added claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 26, 2026

agentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

agentcore-devx-automationBot reviewed Aug 26, 2026
View reviewed changes

agentcore-devx-automationBot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 26, 2026

notgitika force-pushed the fix-toolkit-lib-yaml branch from be50d65 to d93c63bCompare August 26, 2026 23:48

github-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 26, 2026

agentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

agentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 26, 2026

notgitika force-pushed the fix-toolkit-lib-yaml branch from d93c63b to 367f995Compare August 27, 2026 00:06

github-actionsBot added size/xs PR size: XS and removed size/xs PR size: XS labels Aug 27, 2026

agentcore-devx-automationBot added the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026

agentcore-devx-automationBot removed the claude-security-reviewing Claude Code /security-review in progress label Aug 27, 2026

Hweinstock approved these changes Aug 27, 2026
View reviewed changes

notgitika merged commit a1f2f32 into aws:refactorAug 27, 2026
19 of 21 checks passed

notgitika deleted the fix-toolkit-lib-yaml branch August 27, 2026 06:00

AlexanderRichey mentioned this pull request Aug 31, 2026
feat: close the eight essential CLI feature gaps #2146
Merged