Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/core.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,7 @@ test("exposes feature sub-clients", () => {
expect(core.harness).toBeDefined();
expect(core.memory).toBeDefined();
expect(core.gateway).toBeDefined();
expect(core.observability).toBeDefined();
});

test("getEvent sends a GetEventCommand on the data client", async () => {
Expand Down
12 changes: 11 additions & 1 deletion src/core/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,11 @@ import { GatewayClient } from "./gateway";
import { HarnessClient } from "./harness";
import { IdentityClient } from "./identity";
import { MemoryClient } from "./memory";
import {
CloudWatchSourceReader,
ObservabilityClient,
RuntimeSourceResolver,
} from "./observability";
import { RuntimeClient } from "./runtime";
import type {
AwsClients,
Expand DownExpand Up@@ -67,6 +72,7 @@ export class CoreClient implements AwsClients {
readonly runtime: RuntimeClient;
readonly gateway: GatewayClient;
readonly eval: EvalClient;
readonly observability: ObservabilityClient;

readonly projectManager: ProjectManager;

Expand All@@ -88,6 +94,10 @@ export class CoreClient implements AwsClients {
this.logger.child({ module: "eval" }),
config.newSessionId,
);
this.observability = new ObservabilityClient(
{ runtime: new RuntimeSourceResolver() },
new CloudWatchSourceReader(this),
);

this.projectManager = new FsProjectManager({
logger: this.logger.child({ module: "projectManager" }),
Expand DownExpand Up@@ -132,7 +142,7 @@ export class CoreClient implements AwsClients {
}

// logs returns the CloudWatch Logs client for `config`, creating and caching it
// on first use (used to read batch-evaluation result log streams).
// on first use for customer-facing observability and evaluation result streams.
logs(config: ClientConfig): CloudWatchLogsClient {
const key = cacheKey(config);
let client = this.logsClients.get(key);
Expand Down
144 changes: 144 additions & 0 deletions src/core/observability/client.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
import { describe, expect, test } from "bun:test";
import type { CoreOptions } from "../types";
import { ObservabilityClient, type LogRecord } from "./client";
import type { LogSource, ObservabilitySourceResolverRegistry } from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

const SOURCE: LogSource = {
provider: "cloudwatch",
logGroupName: "/aws/runtime-1",
};
const OPTIONS = { region: "us-east-1" };

async function collect(records: AsyncIterable<LogRecord>) {
const result: LogRecord[] = [];
for await (const record of records) result.push(record);
return result;
}

function createClient(rawRecords: RawLogRecord[]) {
const calls: { method: string; args: unknown[] }[] = [];
const resolvers: ObservabilitySourceResolverRegistry = {
runtime: {
resolve: async (...args) => {
calls.push({ method: "resolve", args });
return {
resource: {
kind: "runtime",
id: args[0].id,
qualifier: args[0].qualifier ?? "DEFAULT",
},
logs: [SOURCE],
};
},
},
};
const reader: SourceReader = {
async *searchLogs(
source: LogSource,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
) {
calls.push({
method: "searchLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
async *tailLogs(
source: LogSource,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
) {
calls.push({
method: "tailLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
};
return { client: new ObservabilityClient(resolvers, reader), calls };
}

describe("ObservabilityClient", () => {
test("resolves, reads, and normalizes common log metadata", async () => {
const raw = {
timestamp: 1_709_391_000_000,
ingestionTime: 1_709_391_000_100,
logStreamName: "runtime-stream",
message: JSON.stringify({
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
severityText: "INFO",
attributes: { "session.id": "session-1" },
}),
raw: { eventId: "event-1" },
};
const { client, calls } = createClient([raw]);
const signal = new AbortController().signal;
const query = { startTimeMs: 1, endTimeMs: 2 };

const records = await collect(
client.searchLogs(
{ kind: "runtime", id: "runtime-1", qualifier: "blue" },
query,
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "searchLogs"]);
expect(records).toEqual([
{
timestamp: new Date(1_709_391_000_000),
ingestionTime: new Date(1_709_391_000_100),
message: raw.message,
correlation: {
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
sessionId: "session-1",
},
severity: "INFO",
source: {
provider: "cloudwatch",
resource: {
kind: "runtime",
id: "runtime-1",
qualifier: "blue",
},
logGroupName: SOURCE.logGroupName,
logStreamName: "runtime-stream",
},
raw: { eventId: "event-1" },
},
]);
});

test("uses the same orchestration path for Live Tail records", async () => {
const { client, calls } = createClient([
{
timestamp: 1,
message: "plain text",
raw: { message: "plain text" },
},
]);
const signal = new AbortController().signal;

const records = await collect(
client.tailLogs(
{ kind: "runtime", id: "runtime-1" },
{ filterPattern: "ERROR" },
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "tailLogs"]);
expect(records[0]).not.toHaveProperty("correlation");
expect(records[0]).not.toHaveProperty("severity");
});
});
148 changes: 148 additions & 0 deletions src/core/observability/client.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,148 @@
import type { CoreOptions } from "../types";
import type {
LogSource,
ObservableResourceRef,
ObservabilitySourceResolver,
ObservabilitySourceResolverRegistry,
ResolvedObservabilityTarget,
ResolvedResourceIdentity,
} from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

export interface LogRecord {
timestamp: Date;
message: string;
correlation?: {
traceId?: string;
spanId?: string;
parentSpanId?: string;
sessionId?: string;
};
severity?: string;
ingestionTime?: Date;
source: {
provider: "cloudwatch";
resource: ResolvedResourceIdentity;
logGroupName: string;
logStreamName?: string;
};
raw?: unknown;
}

export interface CoreObservabilityClient {
searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncIterable<LogRecord>;

tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncIterable<LogRecord>;
}

/**
* Shared entry point for logs. It orchestrates resolution and provider reads,
* then normalizes provider events into the stable record contract.
*/
export class ObservabilityClient implements CoreObservabilityClient {
constructor(
private readonly resolvers: ObservabilitySourceResolverRegistry,
private readonly sourceReader: SourceReader,
) {}

async *searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.searchLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

async *tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.tailLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

private resolve(
resource: ObservableResourceRef,
options: CoreOptions,
signal?: AbortSignal,
): Promise<ResolvedObservabilityTarget> {
const resolver = this.resolvers[resource.kind] as ObservabilitySourceResolver<typeof resource>;
return resolver.resolve(resource, options, signal);
}
}

function toLogRecord(
resource: ResolvedResourceIdentity,
source: LogSource,
record: RawLogRecord,
): LogRecord {
const metadata = extractCommonMetadata(record.message);
return {
timestamp: new Date(record.timestamp),
message: record.message,
...metadata,
...(record.ingestionTime !== undefined
? { ingestionTime: new Date(record.ingestionTime) }
: {}),
source: {
provider: source.provider,
resource,
logGroupName: source.logGroupName,
...(record.logStreamName ? { logStreamName: record.logStreamName } : {}),
},
raw: record.raw,
};
}

function extractCommonMetadata(message: string): Pick<LogRecord, "correlation" | "severity"> {
let parsed: Record<string, unknown>;
try {
parsed = JSON.parse(message) as Record<string, unknown>;
} catch {
return {};
}
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};

const attributes =
parsed.attributes && typeof parsed.attributes === "object" && !Array.isArray(parsed.attributes)
? (parsed.attributes as Record<string, unknown>)
: {};
const stringValue = (value: unknown): string | undefined =>
typeof value === "string" ? value : undefined;
const correlation = {
traceId: stringValue(parsed.traceId),
spanId: stringValue(parsed.spanId),
parentSpanId: stringValue(parsed.parentSpanId),
sessionId: stringValue(parsed.sessionId) ?? stringValue(attributes["session.id"]),
};
const hasCorrelation = Object.values(correlation).some((value) => value !== undefined);
const severity =
stringValue(parsed.severityText) ?? stringValue(parsed.severity) ?? stringValue(parsed.level);

return {
...(hasCorrelation ? { correlation } : {}),
...(severity ? { severity } : {}),
};
}
19 changes: 19 additions & 0 deletions src/core/observability/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
export { ObservabilityClient, type CoreObservabilityClient, type LogRecord } from "./client";
export {
DEFAULT_RUNTIME_QUALIFIER,
RuntimeSourceResolver,
runtimeLogGroup,
type LogSource,
type ObservableResourceRef,
type ObservabilitySourceResolver,
type ObservabilitySourceResolverRegistry,
type ResolvedObservabilityTarget,
type ResolvedResourceIdentity,
} from "./resolver";
export {
CloudWatchSourceReader,
type LogSearchQuery,
type LogTailQuery,
type RawLogRecord,
type SourceReader,
} from "./sourceReader";
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat: add observability abstractions and wire to runtime by nborges-aws · Pull Request #2147 · aws/agentcore-cli · GitHub
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/core.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,7 @@ test("exposes feature sub-clients", () => {
expect(core.harness).toBeDefined();
expect(core.memory).toBeDefined();
expect(core.gateway).toBeDefined();
expect(core.observability).toBeDefined();
});

test("getEvent sends a GetEventCommand on the data client", async () => {
Expand Down
12 changes: 11 additions & 1 deletion src/core/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,11 @@ import { GatewayClient } from "./gateway";
import { HarnessClient } from "./harness";
import { IdentityClient } from "./identity";
import { MemoryClient } from "./memory";
import {
CloudWatchSourceReader,
ObservabilityClient,
RuntimeSourceResolver,
} from "./observability";
import { RuntimeClient } from "./runtime";
import type {
AwsClients,
Expand DownExpand Up@@ -67,6 +72,7 @@ export class CoreClient implements AwsClients {
readonly runtime: RuntimeClient;
readonly gateway: GatewayClient;
readonly eval: EvalClient;
readonly observability: ObservabilityClient;

readonly projectManager: ProjectManager;

Expand All@@ -88,6 +94,10 @@ export class CoreClient implements AwsClients {
this.logger.child({ module: "eval" }),
config.newSessionId,
);
this.observability = new ObservabilityClient(
{ runtime: new RuntimeSourceResolver() },
new CloudWatchSourceReader(this),
);

this.projectManager = new FsProjectManager({
logger: this.logger.child({ module: "projectManager" }),
Expand DownExpand Up@@ -132,7 +142,7 @@ export class CoreClient implements AwsClients {
}

// logs returns the CloudWatch Logs client for `config`, creating and caching it
// on first use (used to read batch-evaluation result log streams).
// on first use for customer-facing observability and evaluation result streams.
logs(config: ClientConfig): CloudWatchLogsClient {
const key = cacheKey(config);
let client = this.logsClients.get(key);
Expand Down
144 changes: 144 additions & 0 deletions src/core/observability/client.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
import { describe, expect, test } from "bun:test";
import type { CoreOptions } from "../types";
import { ObservabilityClient, type LogRecord } from "./client";
import type { LogSource, ObservabilitySourceResolverRegistry } from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

const SOURCE: LogSource = {
provider: "cloudwatch",
logGroupName: "/aws/runtime-1",
};
const OPTIONS = { region: "us-east-1" };

async function collect(records: AsyncIterable<LogRecord>) {
const result: LogRecord[] = [];
for await (const record of records) result.push(record);
return result;
}

function createClient(rawRecords: RawLogRecord[]) {
const calls: { method: string; args: unknown[] }[] = [];
const resolvers: ObservabilitySourceResolverRegistry = {
runtime: {
resolve: async (...args) => {
calls.push({ method: "resolve", args });
return {
resource: {
kind: "runtime",
id: args[0].id,
qualifier: args[0].qualifier ?? "DEFAULT",
},
logs: [SOURCE],
};
},
},
};
const reader: SourceReader = {
async *searchLogs(
source: LogSource,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
) {
calls.push({
method: "searchLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
async *tailLogs(
source: LogSource,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
) {
calls.push({
method: "tailLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
};
return { client: new ObservabilityClient(resolvers, reader), calls };
}

describe("ObservabilityClient", () => {
test("resolves, reads, and normalizes common log metadata", async () => {
const raw = {
timestamp: 1_709_391_000_000,
ingestionTime: 1_709_391_000_100,
logStreamName: "runtime-stream",
message: JSON.stringify({
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
severityText: "INFO",
attributes: { "session.id": "session-1" },
}),
raw: { eventId: "event-1" },
};
const { client, calls } = createClient([raw]);
const signal = new AbortController().signal;
const query = { startTimeMs: 1, endTimeMs: 2 };

const records = await collect(
client.searchLogs(
{ kind: "runtime", id: "runtime-1", qualifier: "blue" },
query,
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "searchLogs"]);
expect(records).toEqual([
{
timestamp: new Date(1_709_391_000_000),
ingestionTime: new Date(1_709_391_000_100),
message: raw.message,
correlation: {
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
sessionId: "session-1",
},
severity: "INFO",
source: {
provider: "cloudwatch",
resource: {
kind: "runtime",
id: "runtime-1",
qualifier: "blue",
},
logGroupName: SOURCE.logGroupName,
logStreamName: "runtime-stream",
},
raw: { eventId: "event-1" },
},
]);
});

test("uses the same orchestration path for Live Tail records", async () => {
const { client, calls } = createClient([
{
timestamp: 1,
message: "plain text",
raw: { message: "plain text" },
},
]);
const signal = new AbortController().signal;

const records = await collect(
client.tailLogs(
{ kind: "runtime", id: "runtime-1" },
{ filterPattern: "ERROR" },
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "tailLogs"]);
expect(records[0]).not.toHaveProperty("correlation");
expect(records[0]).not.toHaveProperty("severity");
});
});
148 changes: 148 additions & 0 deletions src/core/observability/client.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,148 @@
import type { CoreOptions } from "../types";
import type {
LogSource,
ObservableResourceRef,
ObservabilitySourceResolver,
ObservabilitySourceResolverRegistry,
ResolvedObservabilityTarget,
ResolvedResourceIdentity,
} from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

export interface LogRecord {
timestamp: Date;
message: string;
correlation?: {
traceId?: string;
spanId?: string;
parentSpanId?: string;
sessionId?: string;
};
severity?: string;
ingestionTime?: Date;
source: {
provider: "cloudwatch";
resource: ResolvedResourceIdentity;
logGroupName: string;
logStreamName?: string;
};
raw?: unknown;
}

export interface CoreObservabilityClient {
searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncIterable<LogRecord>;

tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncIterable<LogRecord>;
}

/**
* Shared entry point for logs. It orchestrates resolution and provider reads,
* then normalizes provider events into the stable record contract.
*/
export class ObservabilityClient implements CoreObservabilityClient {
constructor(
private readonly resolvers: ObservabilitySourceResolverRegistry,
private readonly sourceReader: SourceReader,
) {}

async *searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.searchLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

async *tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.tailLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

private resolve(
resource: ObservableResourceRef,
options: CoreOptions,
signal?: AbortSignal,
): Promise<ResolvedObservabilityTarget> {
const resolver = this.resolvers[resource.kind] as ObservabilitySourceResolver<typeof resource>;
return resolver.resolve(resource, options, signal);
}
}

function toLogRecord(
resource: ResolvedResourceIdentity,
source: LogSource,
record: RawLogRecord,
): LogRecord {
const metadata = extractCommonMetadata(record.message);
return {
timestamp: new Date(record.timestamp),
message: record.message,
...metadata,
...(record.ingestionTime !== undefined
? { ingestionTime: new Date(record.ingestionTime) }
: {}),
source: {
provider: source.provider,
resource,
logGroupName: source.logGroupName,
...(record.logStreamName ? { logStreamName: record.logStreamName } : {}),
},
raw: record.raw,
};
}

function extractCommonMetadata(message: string): Pick<LogRecord, "correlation" | "severity"> {
let parsed: Record<string, unknown>;
try {
parsed = JSON.parse(message) as Record<string, unknown>;
} catch {
return {};
}
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};

const attributes =
parsed.attributes && typeof parsed.attributes === "object" && !Array.isArray(parsed.attributes)
? (parsed.attributes as Record<string, unknown>)
: {};
const stringValue = (value: unknown): string | undefined =>
typeof value === "string" ? value : undefined;
const correlation = {
traceId: stringValue(parsed.traceId),
spanId: stringValue(parsed.spanId),
parentSpanId: stringValue(parsed.parentSpanId),
sessionId: stringValue(parsed.sessionId) ?? stringValue(attributes["session.id"]),
};
const hasCorrelation = Object.values(correlation).some((value) => value !== undefined);
const severity =
stringValue(parsed.severityText) ?? stringValue(parsed.severity) ?? stringValue(parsed.level);

return {
...(hasCorrelation ? { correlation } : {}),
...(severity ? { severity } : {}),
};
}
19 changes: 19 additions & 0 deletions src/core/observability/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
export { ObservabilityClient, type CoreObservabilityClient, type LogRecord } from "./client";
export {
DEFAULT_RUNTIME_QUALIFIER,
RuntimeSourceResolver,
runtimeLogGroup,
type LogSource,
type ObservableResourceRef,
type ObservabilitySourceResolver,
type ObservabilitySourceResolverRegistry,
type ResolvedObservabilityTarget,
type ResolvedResourceIdentity,
} from "./resolver";
export {
CloudWatchSourceReader,
type LogSearchQuery,
type LogTailQuery,
type RawLogRecord,
type SourceReader,
} from "./sourceReader";
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat: add observability abstractions and wire to runtime by nborges-aws · Pull Request #2147 · aws/agentcore-cli · GitHub
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/core.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,7 @@ test("exposes feature sub-clients", () => {
expect(core.harness).toBeDefined();
expect(core.memory).toBeDefined();
expect(core.gateway).toBeDefined();
expect(core.observability).toBeDefined();
});

test("getEvent sends a GetEventCommand on the data client", async () => {
Expand Down
12 changes: 11 additions & 1 deletion src/core/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,11 @@ import { GatewayClient } from "./gateway";
import { HarnessClient } from "./harness";
import { IdentityClient } from "./identity";
import { MemoryClient } from "./memory";
import {
CloudWatchSourceReader,
ObservabilityClient,
RuntimeSourceResolver,
} from "./observability";
import { RuntimeClient } from "./runtime";
import type {
AwsClients,
Expand DownExpand Up@@ -67,6 +72,7 @@ export class CoreClient implements AwsClients {
readonly runtime: RuntimeClient;
readonly gateway: GatewayClient;
readonly eval: EvalClient;
readonly observability: ObservabilityClient;

readonly projectManager: ProjectManager;

Expand All@@ -88,6 +94,10 @@ export class CoreClient implements AwsClients {
this.logger.child({ module: "eval" }),
config.newSessionId,
);
this.observability = new ObservabilityClient(
{ runtime: new RuntimeSourceResolver() },
new CloudWatchSourceReader(this),
);

this.projectManager = new FsProjectManager({
logger: this.logger.child({ module: "projectManager" }),
Expand DownExpand Up@@ -132,7 +142,7 @@ export class CoreClient implements AwsClients {
}

// logs returns the CloudWatch Logs client for `config`, creating and caching it
// on first use (used to read batch-evaluation result log streams).
// on first use for customer-facing observability and evaluation result streams.
logs(config: ClientConfig): CloudWatchLogsClient {
const key = cacheKey(config);
let client = this.logsClients.get(key);
Expand Down
144 changes: 144 additions & 0 deletions src/core/observability/client.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
import { describe, expect, test } from "bun:test";
import type { CoreOptions } from "../types";
import { ObservabilityClient, type LogRecord } from "./client";
import type { LogSource, ObservabilitySourceResolverRegistry } from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

const SOURCE: LogSource = {
provider: "cloudwatch",
logGroupName: "/aws/runtime-1",
};
const OPTIONS = { region: "us-east-1" };

async function collect(records: AsyncIterable<LogRecord>) {
const result: LogRecord[] = [];
for await (const record of records) result.push(record);
return result;
}

function createClient(rawRecords: RawLogRecord[]) {
const calls: { method: string; args: unknown[] }[] = [];
const resolvers: ObservabilitySourceResolverRegistry = {
runtime: {
resolve: async (...args) => {
calls.push({ method: "resolve", args });
return {
resource: {
kind: "runtime",
id: args[0].id,
qualifier: args[0].qualifier ?? "DEFAULT",
},
logs: [SOURCE],
};
},
},
};
const reader: SourceReader = {
async *searchLogs(
source: LogSource,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
) {
calls.push({
method: "searchLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
async *tailLogs(
source: LogSource,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
) {
calls.push({
method: "tailLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
};
return { client: new ObservabilityClient(resolvers, reader), calls };
}

describe("ObservabilityClient", () => {
test("resolves, reads, and normalizes common log metadata", async () => {
const raw = {
timestamp: 1_709_391_000_000,
ingestionTime: 1_709_391_000_100,
logStreamName: "runtime-stream",
message: JSON.stringify({
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
severityText: "INFO",
attributes: { "session.id": "session-1" },
}),
raw: { eventId: "event-1" },
};
const { client, calls } = createClient([raw]);
const signal = new AbortController().signal;
const query = { startTimeMs: 1, endTimeMs: 2 };

const records = await collect(
client.searchLogs(
{ kind: "runtime", id: "runtime-1", qualifier: "blue" },
query,
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "searchLogs"]);
expect(records).toEqual([
{
timestamp: new Date(1_709_391_000_000),
ingestionTime: new Date(1_709_391_000_100),
message: raw.message,
correlation: {
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
sessionId: "session-1",
},
severity: "INFO",
source: {
provider: "cloudwatch",
resource: {
kind: "runtime",
id: "runtime-1",
qualifier: "blue",
},
logGroupName: SOURCE.logGroupName,
logStreamName: "runtime-stream",
},
raw: { eventId: "event-1" },
},
]);
});

test("uses the same orchestration path for Live Tail records", async () => {
const { client, calls } = createClient([
{
timestamp: 1,
message: "plain text",
raw: { message: "plain text" },
},
]);
const signal = new AbortController().signal;

const records = await collect(
client.tailLogs(
{ kind: "runtime", id: "runtime-1" },
{ filterPattern: "ERROR" },
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "tailLogs"]);
expect(records[0]).not.toHaveProperty("correlation");
expect(records[0]).not.toHaveProperty("severity");
});
});
148 changes: 148 additions & 0 deletions src/core/observability/client.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,148 @@
import type { CoreOptions } from "../types";
import type {
LogSource,
ObservableResourceRef,
ObservabilitySourceResolver,
ObservabilitySourceResolverRegistry,
ResolvedObservabilityTarget,
ResolvedResourceIdentity,
} from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

export interface LogRecord {
timestamp: Date;
message: string;
correlation?: {
traceId?: string;
spanId?: string;
parentSpanId?: string;
sessionId?: string;
};
severity?: string;
ingestionTime?: Date;
source: {
provider: "cloudwatch";
resource: ResolvedResourceIdentity;
logGroupName: string;
logStreamName?: string;
};
raw?: unknown;
}

export interface CoreObservabilityClient {
searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncIterable<LogRecord>;

tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncIterable<LogRecord>;
}

/**
* Shared entry point for logs. It orchestrates resolution and provider reads,
* then normalizes provider events into the stable record contract.
*/
export class ObservabilityClient implements CoreObservabilityClient {
constructor(
private readonly resolvers: ObservabilitySourceResolverRegistry,
private readonly sourceReader: SourceReader,
) {}

async *searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.searchLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

async *tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.tailLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

private resolve(
resource: ObservableResourceRef,
options: CoreOptions,
signal?: AbortSignal,
): Promise<ResolvedObservabilityTarget> {
const resolver = this.resolvers[resource.kind] as ObservabilitySourceResolver<typeof resource>;
return resolver.resolve(resource, options, signal);
}
}

function toLogRecord(
resource: ResolvedResourceIdentity,
source: LogSource,
record: RawLogRecord,
): LogRecord {
const metadata = extractCommonMetadata(record.message);
return {
timestamp: new Date(record.timestamp),
message: record.message,
...metadata,
...(record.ingestionTime !== undefined
? { ingestionTime: new Date(record.ingestionTime) }
: {}),
source: {
provider: source.provider,
resource,
logGroupName: source.logGroupName,
...(record.logStreamName ? { logStreamName: record.logStreamName } : {}),
},
raw: record.raw,
};
}

function extractCommonMetadata(message: string): Pick<LogRecord, "correlation" | "severity"> {
let parsed: Record<string, unknown>;
try {
parsed = JSON.parse(message) as Record<string, unknown>;
} catch {
return {};
}
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};

const attributes =
parsed.attributes && typeof parsed.attributes === "object" && !Array.isArray(parsed.attributes)
? (parsed.attributes as Record<string, unknown>)
: {};
const stringValue = (value: unknown): string | undefined =>
typeof value === "string" ? value : undefined;
const correlation = {
traceId: stringValue(parsed.traceId),
spanId: stringValue(parsed.spanId),
parentSpanId: stringValue(parsed.parentSpanId),
sessionId: stringValue(parsed.sessionId) ?? stringValue(attributes["session.id"]),
};
const hasCorrelation = Object.values(correlation).some((value) => value !== undefined);
const severity =
stringValue(parsed.severityText) ?? stringValue(parsed.severity) ?? stringValue(parsed.level);

return {
...(hasCorrelation ? { correlation } : {}),
...(severity ? { severity } : {}),
};
}
19 changes: 19 additions & 0 deletions src/core/observability/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
export { ObservabilityClient, type CoreObservabilityClient, type LogRecord } from "./client";
export {
DEFAULT_RUNTIME_QUALIFIER,
RuntimeSourceResolver,
runtimeLogGroup,
type LogSource,
type ObservableResourceRef,
type ObservabilitySourceResolver,
type ObservabilitySourceResolverRegistry,
type ResolvedObservabilityTarget,
type ResolvedResourceIdentity,
} from "./resolver";
export {
CloudWatchSourceReader,
type LogSearchQuery,
type LogTailQuery,
type RawLogRecord,
type SourceReader,
} from "./sourceReader";
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat: add observability abstractions and wire to runtime by nborges-aws · Pull Request #2147 · aws/agentcore-cli · GitHub
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/core.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,7 @@ test("exposes feature sub-clients", () => {
expect(core.harness).toBeDefined();
expect(core.memory).toBeDefined();
expect(core.gateway).toBeDefined();
expect(core.observability).toBeDefined();
});

test("getEvent sends a GetEventCommand on the data client", async () => {
Expand Down
12 changes: 11 additions & 1 deletion src/core/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,11 @@ import { GatewayClient } from "./gateway";
import { HarnessClient } from "./harness";
import { IdentityClient } from "./identity";
import { MemoryClient } from "./memory";
import {
CloudWatchSourceReader,
ObservabilityClient,
RuntimeSourceResolver,
} from "./observability";
import { RuntimeClient } from "./runtime";
import type {
AwsClients,
Expand DownExpand Up@@ -67,6 +72,7 @@ export class CoreClient implements AwsClients {
readonly runtime: RuntimeClient;
readonly gateway: GatewayClient;
readonly eval: EvalClient;
readonly observability: ObservabilityClient;

readonly projectManager: ProjectManager;

Expand All@@ -88,6 +94,10 @@ export class CoreClient implements AwsClients {
this.logger.child({ module: "eval" }),
config.newSessionId,
);
this.observability = new ObservabilityClient(
{ runtime: new RuntimeSourceResolver() },
new CloudWatchSourceReader(this),
);

this.projectManager = new FsProjectManager({
logger: this.logger.child({ module: "projectManager" }),
Expand DownExpand Up@@ -132,7 +142,7 @@ export class CoreClient implements AwsClients {
}

// logs returns the CloudWatch Logs client for `config`, creating and caching it
// on first use (used to read batch-evaluation result log streams).
// on first use for customer-facing observability and evaluation result streams.
logs(config: ClientConfig): CloudWatchLogsClient {
const key = cacheKey(config);
let client = this.logsClients.get(key);
Expand Down
144 changes: 144 additions & 0 deletions src/core/observability/client.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
import { describe, expect, test } from "bun:test";
import type { CoreOptions } from "../types";
import { ObservabilityClient, type LogRecord } from "./client";
import type { LogSource, ObservabilitySourceResolverRegistry } from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

const SOURCE: LogSource = {
provider: "cloudwatch",
logGroupName: "/aws/runtime-1",
};
const OPTIONS = { region: "us-east-1" };

async function collect(records: AsyncIterable<LogRecord>) {
const result: LogRecord[] = [];
for await (const record of records) result.push(record);
return result;
}

function createClient(rawRecords: RawLogRecord[]) {
const calls: { method: string; args: unknown[] }[] = [];
const resolvers: ObservabilitySourceResolverRegistry = {
runtime: {
resolve: async (...args) => {
calls.push({ method: "resolve", args });
return {
resource: {
kind: "runtime",
id: args[0].id,
qualifier: args[0].qualifier ?? "DEFAULT",
},
logs: [SOURCE],
};
},
},
};
const reader: SourceReader = {
async *searchLogs(
source: LogSource,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
) {
calls.push({
method: "searchLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
async *tailLogs(
source: LogSource,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
) {
calls.push({
method: "tailLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
};
return { client: new ObservabilityClient(resolvers, reader), calls };
}

describe("ObservabilityClient", () => {
test("resolves, reads, and normalizes common log metadata", async () => {
const raw = {
timestamp: 1_709_391_000_000,
ingestionTime: 1_709_391_000_100,
logStreamName: "runtime-stream",
message: JSON.stringify({
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
severityText: "INFO",
attributes: { "session.id": "session-1" },
}),
raw: { eventId: "event-1" },
};
const { client, calls } = createClient([raw]);
const signal = new AbortController().signal;
const query = { startTimeMs: 1, endTimeMs: 2 };

const records = await collect(
client.searchLogs(
{ kind: "runtime", id: "runtime-1", qualifier: "blue" },
query,
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "searchLogs"]);
expect(records).toEqual([
{
timestamp: new Date(1_709_391_000_000),
ingestionTime: new Date(1_709_391_000_100),
message: raw.message,
correlation: {
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
sessionId: "session-1",
},
severity: "INFO",
source: {
provider: "cloudwatch",
resource: {
kind: "runtime",
id: "runtime-1",
qualifier: "blue",
},
logGroupName: SOURCE.logGroupName,
logStreamName: "runtime-stream",
},
raw: { eventId: "event-1" },
},
]);
});

test("uses the same orchestration path for Live Tail records", async () => {
const { client, calls } = createClient([
{
timestamp: 1,
message: "plain text",
raw: { message: "plain text" },
},
]);
const signal = new AbortController().signal;

const records = await collect(
client.tailLogs(
{ kind: "runtime", id: "runtime-1" },
{ filterPattern: "ERROR" },
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "tailLogs"]);
expect(records[0]).not.toHaveProperty("correlation");
expect(records[0]).not.toHaveProperty("severity");
});
});
148 changes: 148 additions & 0 deletions src/core/observability/client.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,148 @@
import type { CoreOptions } from "../types";
import type {
LogSource,
ObservableResourceRef,
ObservabilitySourceResolver,
ObservabilitySourceResolverRegistry,
ResolvedObservabilityTarget,
ResolvedResourceIdentity,
} from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

export interface LogRecord {
timestamp: Date;
message: string;
correlation?: {
traceId?: string;
spanId?: string;
parentSpanId?: string;
sessionId?: string;
};
severity?: string;
ingestionTime?: Date;
source: {
provider: "cloudwatch";
resource: ResolvedResourceIdentity;
logGroupName: string;
logStreamName?: string;
};
raw?: unknown;
}

export interface CoreObservabilityClient {
searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncIterable<LogRecord>;

tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncIterable<LogRecord>;
}

/**
* Shared entry point for logs. It orchestrates resolution and provider reads,
* then normalizes provider events into the stable record contract.
*/
export class ObservabilityClient implements CoreObservabilityClient {
constructor(
private readonly resolvers: ObservabilitySourceResolverRegistry,
private readonly sourceReader: SourceReader,
) {}

async *searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.searchLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

async *tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.tailLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

private resolve(
resource: ObservableResourceRef,
options: CoreOptions,
signal?: AbortSignal,
): Promise<ResolvedObservabilityTarget> {
const resolver = this.resolvers[resource.kind] as ObservabilitySourceResolver<typeof resource>;
return resolver.resolve(resource, options, signal);
}
}

function toLogRecord(
resource: ResolvedResourceIdentity,
source: LogSource,
record: RawLogRecord,
): LogRecord {
const metadata = extractCommonMetadata(record.message);
return {
timestamp: new Date(record.timestamp),
message: record.message,
...metadata,
...(record.ingestionTime !== undefined
? { ingestionTime: new Date(record.ingestionTime) }
: {}),
source: {
provider: source.provider,
resource,
logGroupName: source.logGroupName,
...(record.logStreamName ? { logStreamName: record.logStreamName } : {}),
},
raw: record.raw,
};
}

function extractCommonMetadata(message: string): Pick<LogRecord, "correlation" | "severity"> {
let parsed: Record<string, unknown>;
try {
parsed = JSON.parse(message) as Record<string, unknown>;
} catch {
return {};
}
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};

const attributes =
parsed.attributes && typeof parsed.attributes === "object" && !Array.isArray(parsed.attributes)
? (parsed.attributes as Record<string, unknown>)
: {};
const stringValue = (value: unknown): string | undefined =>
typeof value === "string" ? value : undefined;
const correlation = {
traceId: stringValue(parsed.traceId),
spanId: stringValue(parsed.spanId),
parentSpanId: stringValue(parsed.parentSpanId),
sessionId: stringValue(parsed.sessionId) ?? stringValue(attributes["session.id"]),
};
const hasCorrelation = Object.values(correlation).some((value) => value !== undefined);
const severity =
stringValue(parsed.severityText) ?? stringValue(parsed.severity) ?? stringValue(parsed.level);

return {
...(hasCorrelation ? { correlation } : {}),
...(severity ? { severity } : {}),
};
}
19 changes: 19 additions & 0 deletions src/core/observability/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
export { ObservabilityClient, type CoreObservabilityClient, type LogRecord } from "./client";
export {
DEFAULT_RUNTIME_QUALIFIER,
RuntimeSourceResolver,
runtimeLogGroup,
type LogSource,
type ObservableResourceRef,
type ObservabilitySourceResolver,
type ObservabilitySourceResolverRegistry,
type ResolvedObservabilityTarget,
type ResolvedResourceIdentity,
} from "./resolver";
export {
CloudWatchSourceReader,
type LogSearchQuery,
type LogTailQuery,
type RawLogRecord,
type SourceReader,
} from "./sourceReader";
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat: add observability abstractions and wire to runtime by nborges-aws · Pull Request #2147 · aws/agentcore-cli · GitHub
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/core.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,7 @@ test("exposes feature sub-clients", () => {
expect(core.harness).toBeDefined();
expect(core.memory).toBeDefined();
expect(core.gateway).toBeDefined();
expect(core.observability).toBeDefined();
});

test("getEvent sends a GetEventCommand on the data client", async () => {
Expand Down
12 changes: 11 additions & 1 deletion src/core/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,11 @@ import { GatewayClient } from "./gateway";
import { HarnessClient } from "./harness";
import { IdentityClient } from "./identity";
import { MemoryClient } from "./memory";
import {
CloudWatchSourceReader,
ObservabilityClient,
RuntimeSourceResolver,
} from "./observability";
import { RuntimeClient } from "./runtime";
import type {
AwsClients,
Expand DownExpand Up@@ -67,6 +72,7 @@ export class CoreClient implements AwsClients {
readonly runtime: RuntimeClient;
readonly gateway: GatewayClient;
readonly eval: EvalClient;
readonly observability: ObservabilityClient;

readonly projectManager: ProjectManager;

Expand All@@ -88,6 +94,10 @@ export class CoreClient implements AwsClients {
this.logger.child({ module: "eval" }),
config.newSessionId,
);
this.observability = new ObservabilityClient(
{ runtime: new RuntimeSourceResolver() },
new CloudWatchSourceReader(this),
);

this.projectManager = new FsProjectManager({
logger: this.logger.child({ module: "projectManager" }),
Expand DownExpand Up@@ -132,7 +142,7 @@ export class CoreClient implements AwsClients {
}

// logs returns the CloudWatch Logs client for `config`, creating and caching it
// on first use (used to read batch-evaluation result log streams).
// on first use for customer-facing observability and evaluation result streams.
logs(config: ClientConfig): CloudWatchLogsClient {
const key = cacheKey(config);
let client = this.logsClients.get(key);
Expand Down
144 changes: 144 additions & 0 deletions src/core/observability/client.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
import { describe, expect, test } from "bun:test";
import type { CoreOptions } from "../types";
import { ObservabilityClient, type LogRecord } from "./client";
import type { LogSource, ObservabilitySourceResolverRegistry } from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

const SOURCE: LogSource = {
provider: "cloudwatch",
logGroupName: "/aws/runtime-1",
};
const OPTIONS = { region: "us-east-1" };

async function collect(records: AsyncIterable<LogRecord>) {
const result: LogRecord[] = [];
for await (const record of records) result.push(record);
return result;
}

function createClient(rawRecords: RawLogRecord[]) {
const calls: { method: string; args: unknown[] }[] = [];
const resolvers: ObservabilitySourceResolverRegistry = {
runtime: {
resolve: async (...args) => {
calls.push({ method: "resolve", args });
return {
resource: {
kind: "runtime",
id: args[0].id,
qualifier: args[0].qualifier ?? "DEFAULT",
},
logs: [SOURCE],
};
},
},
};
const reader: SourceReader = {
async *searchLogs(
source: LogSource,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
) {
calls.push({
method: "searchLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
async *tailLogs(
source: LogSource,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
) {
calls.push({
method: "tailLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
};
return { client: new ObservabilityClient(resolvers, reader), calls };
}

describe("ObservabilityClient", () => {
test("resolves, reads, and normalizes common log metadata", async () => {
const raw = {
timestamp: 1_709_391_000_000,
ingestionTime: 1_709_391_000_100,
logStreamName: "runtime-stream",
message: JSON.stringify({
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
severityText: "INFO",
attributes: { "session.id": "session-1" },
}),
raw: { eventId: "event-1" },
};
const { client, calls } = createClient([raw]);
const signal = new AbortController().signal;
const query = { startTimeMs: 1, endTimeMs: 2 };

const records = await collect(
client.searchLogs(
{ kind: "runtime", id: "runtime-1", qualifier: "blue" },
query,
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "searchLogs"]);
expect(records).toEqual([
{
timestamp: new Date(1_709_391_000_000),
ingestionTime: new Date(1_709_391_000_100),
message: raw.message,
correlation: {
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
sessionId: "session-1",
},
severity: "INFO",
source: {
provider: "cloudwatch",
resource: {
kind: "runtime",
id: "runtime-1",
qualifier: "blue",
},
logGroupName: SOURCE.logGroupName,
logStreamName: "runtime-stream",
},
raw: { eventId: "event-1" },
},
]);
});

test("uses the same orchestration path for Live Tail records", async () => {
const { client, calls } = createClient([
{
timestamp: 1,
message: "plain text",
raw: { message: "plain text" },
},
]);
const signal = new AbortController().signal;

const records = await collect(
client.tailLogs(
{ kind: "runtime", id: "runtime-1" },
{ filterPattern: "ERROR" },
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "tailLogs"]);
expect(records[0]).not.toHaveProperty("correlation");
expect(records[0]).not.toHaveProperty("severity");
});
});
148 changes: 148 additions & 0 deletions src/core/observability/client.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,148 @@
import type { CoreOptions } from "../types";
import type {
LogSource,
ObservableResourceRef,
ObservabilitySourceResolver,
ObservabilitySourceResolverRegistry,
ResolvedObservabilityTarget,
ResolvedResourceIdentity,
} from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

export interface LogRecord {
timestamp: Date;
message: string;
correlation?: {
traceId?: string;
spanId?: string;
parentSpanId?: string;
sessionId?: string;
};
severity?: string;
ingestionTime?: Date;
source: {
provider: "cloudwatch";
resource: ResolvedResourceIdentity;
logGroupName: string;
logStreamName?: string;
};
raw?: unknown;
}

export interface CoreObservabilityClient {
searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncIterable<LogRecord>;

tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncIterable<LogRecord>;
}

/**
* Shared entry point for logs. It orchestrates resolution and provider reads,
* then normalizes provider events into the stable record contract.
*/
export class ObservabilityClient implements CoreObservabilityClient {
constructor(
private readonly resolvers: ObservabilitySourceResolverRegistry,
private readonly sourceReader: SourceReader,
) {}

async *searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.searchLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

async *tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.tailLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

private resolve(
resource: ObservableResourceRef,
options: CoreOptions,
signal?: AbortSignal,
): Promise<ResolvedObservabilityTarget> {
const resolver = this.resolvers[resource.kind] as ObservabilitySourceResolver<typeof resource>;
return resolver.resolve(resource, options, signal);
}
}

function toLogRecord(
resource: ResolvedResourceIdentity,
source: LogSource,
record: RawLogRecord,
): LogRecord {
const metadata = extractCommonMetadata(record.message);
return {
timestamp: new Date(record.timestamp),
message: record.message,
...metadata,
...(record.ingestionTime !== undefined
? { ingestionTime: new Date(record.ingestionTime) }
: {}),
source: {
provider: source.provider,
resource,
logGroupName: source.logGroupName,
...(record.logStreamName ? { logStreamName: record.logStreamName } : {}),
},
raw: record.raw,
};
}

function extractCommonMetadata(message: string): Pick<LogRecord, "correlation" | "severity"> {
let parsed: Record<string, unknown>;
try {
parsed = JSON.parse(message) as Record<string, unknown>;
} catch {
return {};
}
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};

const attributes =
parsed.attributes && typeof parsed.attributes === "object" && !Array.isArray(parsed.attributes)
? (parsed.attributes as Record<string, unknown>)
: {};
const stringValue = (value: unknown): string | undefined =>
typeof value === "string" ? value : undefined;
const correlation = {
traceId: stringValue(parsed.traceId),
spanId: stringValue(parsed.spanId),
parentSpanId: stringValue(parsed.parentSpanId),
sessionId: stringValue(parsed.sessionId) ?? stringValue(attributes["session.id"]),
};
const hasCorrelation = Object.values(correlation).some((value) => value !== undefined);
const severity =
stringValue(parsed.severityText) ?? stringValue(parsed.severity) ?? stringValue(parsed.level);

return {
...(hasCorrelation ? { correlation } : {}),
...(severity ? { severity } : {}),
};
}
19 changes: 19 additions & 0 deletions src/core/observability/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
export { ObservabilityClient, type CoreObservabilityClient, type LogRecord } from "./client";
export {
DEFAULT_RUNTIME_QUALIFIER,
RuntimeSourceResolver,
runtimeLogGroup,
type LogSource,
type ObservableResourceRef,
type ObservabilitySourceResolver,
type ObservabilitySourceResolverRegistry,
type ResolvedObservabilityTarget,
type ResolvedResourceIdentity,
} from "./resolver";
export {
CloudWatchSourceReader,
type LogSearchQuery,
type LogTailQuery,
type RawLogRecord,
type SourceReader,
} from "./sourceReader";
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat: add observability abstractions and wire to runtime by nborges-aws · Pull Request #2147 · aws/agentcore-cli · GitHub
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/core.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,7 @@ test("exposes feature sub-clients", () => {
expect(core.harness).toBeDefined();
expect(core.memory).toBeDefined();
expect(core.gateway).toBeDefined();
expect(core.observability).toBeDefined();
});

test("getEvent sends a GetEventCommand on the data client", async () => {
Expand Down
12 changes: 11 additions & 1 deletion src/core/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,11 @@ import { GatewayClient } from "./gateway";
import { HarnessClient } from "./harness";
import { IdentityClient } from "./identity";
import { MemoryClient } from "./memory";
import {
CloudWatchSourceReader,
ObservabilityClient,
RuntimeSourceResolver,
} from "./observability";
import { RuntimeClient } from "./runtime";
import type {
AwsClients,
Expand DownExpand Up@@ -67,6 +72,7 @@ export class CoreClient implements AwsClients {
readonly runtime: RuntimeClient;
readonly gateway: GatewayClient;
readonly eval: EvalClient;
readonly observability: ObservabilityClient;

readonly projectManager: ProjectManager;

Expand All@@ -88,6 +94,10 @@ export class CoreClient implements AwsClients {
this.logger.child({ module: "eval" }),
config.newSessionId,
);
this.observability = new ObservabilityClient(
{ runtime: new RuntimeSourceResolver() },
new CloudWatchSourceReader(this),
);

this.projectManager = new FsProjectManager({
logger: this.logger.child({ module: "projectManager" }),
Expand DownExpand Up@@ -132,7 +142,7 @@ export class CoreClient implements AwsClients {
}

// logs returns the CloudWatch Logs client for `config`, creating and caching it
// on first use (used to read batch-evaluation result log streams).
// on first use for customer-facing observability and evaluation result streams.
logs(config: ClientConfig): CloudWatchLogsClient {
const key = cacheKey(config);
let client = this.logsClients.get(key);
Expand Down
144 changes: 144 additions & 0 deletions src/core/observability/client.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
import { describe, expect, test } from "bun:test";
import type { CoreOptions } from "../types";
import { ObservabilityClient, type LogRecord } from "./client";
import type { LogSource, ObservabilitySourceResolverRegistry } from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

const SOURCE: LogSource = {
provider: "cloudwatch",
logGroupName: "/aws/runtime-1",
};
const OPTIONS = { region: "us-east-1" };

async function collect(records: AsyncIterable<LogRecord>) {
const result: LogRecord[] = [];
for await (const record of records) result.push(record);
return result;
}

function createClient(rawRecords: RawLogRecord[]) {
const calls: { method: string; args: unknown[] }[] = [];
const resolvers: ObservabilitySourceResolverRegistry = {
runtime: {
resolve: async (...args) => {
calls.push({ method: "resolve", args });
return {
resource: {
kind: "runtime",
id: args[0].id,
qualifier: args[0].qualifier ?? "DEFAULT",
},
logs: [SOURCE],
};
},
},
};
const reader: SourceReader = {
async *searchLogs(
source: LogSource,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
) {
calls.push({
method: "searchLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
async *tailLogs(
source: LogSource,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
) {
calls.push({
method: "tailLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
};
return { client: new ObservabilityClient(resolvers, reader), calls };
}

describe("ObservabilityClient", () => {
test("resolves, reads, and normalizes common log metadata", async () => {
const raw = {
timestamp: 1_709_391_000_000,
ingestionTime: 1_709_391_000_100,
logStreamName: "runtime-stream",
message: JSON.stringify({
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
severityText: "INFO",
attributes: { "session.id": "session-1" },
}),
raw: { eventId: "event-1" },
};
const { client, calls } = createClient([raw]);
const signal = new AbortController().signal;
const query = { startTimeMs: 1, endTimeMs: 2 };

const records = await collect(
client.searchLogs(
{ kind: "runtime", id: "runtime-1", qualifier: "blue" },
query,
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "searchLogs"]);
expect(records).toEqual([
{
timestamp: new Date(1_709_391_000_000),
ingestionTime: new Date(1_709_391_000_100),
message: raw.message,
correlation: {
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
sessionId: "session-1",
},
severity: "INFO",
source: {
provider: "cloudwatch",
resource: {
kind: "runtime",
id: "runtime-1",
qualifier: "blue",
},
logGroupName: SOURCE.logGroupName,
logStreamName: "runtime-stream",
},
raw: { eventId: "event-1" },
},
]);
});

test("uses the same orchestration path for Live Tail records", async () => {
const { client, calls } = createClient([
{
timestamp: 1,
message: "plain text",
raw: { message: "plain text" },
},
]);
const signal = new AbortController().signal;

const records = await collect(
client.tailLogs(
{ kind: "runtime", id: "runtime-1" },
{ filterPattern: "ERROR" },
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "tailLogs"]);
expect(records[0]).not.toHaveProperty("correlation");
expect(records[0]).not.toHaveProperty("severity");
});
});
148 changes: 148 additions & 0 deletions src/core/observability/client.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,148 @@
import type { CoreOptions } from "../types";
import type {
LogSource,
ObservableResourceRef,
ObservabilitySourceResolver,
ObservabilitySourceResolverRegistry,
ResolvedObservabilityTarget,
ResolvedResourceIdentity,
} from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

export interface LogRecord {
timestamp: Date;
message: string;
correlation?: {
traceId?: string;
spanId?: string;
parentSpanId?: string;
sessionId?: string;
};
severity?: string;
ingestionTime?: Date;
source: {
provider: "cloudwatch";
resource: ResolvedResourceIdentity;
logGroupName: string;
logStreamName?: string;
};
raw?: unknown;
}

export interface CoreObservabilityClient {
searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncIterable<LogRecord>;

tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncIterable<LogRecord>;
}

/**
* Shared entry point for logs. It orchestrates resolution and provider reads,
* then normalizes provider events into the stable record contract.
*/
export class ObservabilityClient implements CoreObservabilityClient {
constructor(
private readonly resolvers: ObservabilitySourceResolverRegistry,
private readonly sourceReader: SourceReader,
) {}

async *searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.searchLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

async *tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.tailLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

private resolve(
resource: ObservableResourceRef,
options: CoreOptions,
signal?: AbortSignal,
): Promise<ResolvedObservabilityTarget> {
const resolver = this.resolvers[resource.kind] as ObservabilitySourceResolver<typeof resource>;
return resolver.resolve(resource, options, signal);
}
}

function toLogRecord(
resource: ResolvedResourceIdentity,
source: LogSource,
record: RawLogRecord,
): LogRecord {
const metadata = extractCommonMetadata(record.message);
return {
timestamp: new Date(record.timestamp),
message: record.message,
...metadata,
...(record.ingestionTime !== undefined
? { ingestionTime: new Date(record.ingestionTime) }
: {}),
source: {
provider: source.provider,
resource,
logGroupName: source.logGroupName,
...(record.logStreamName ? { logStreamName: record.logStreamName } : {}),
},
raw: record.raw,
};
}

function extractCommonMetadata(message: string): Pick<LogRecord, "correlation" | "severity"> {
let parsed: Record<string, unknown>;
try {
parsed = JSON.parse(message) as Record<string, unknown>;
} catch {
return {};
}
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};

const attributes =
parsed.attributes && typeof parsed.attributes === "object" && !Array.isArray(parsed.attributes)
? (parsed.attributes as Record<string, unknown>)
: {};
const stringValue = (value: unknown): string | undefined =>
typeof value === "string" ? value : undefined;
const correlation = {
traceId: stringValue(parsed.traceId),
spanId: stringValue(parsed.spanId),
parentSpanId: stringValue(parsed.parentSpanId),
sessionId: stringValue(parsed.sessionId) ?? stringValue(attributes["session.id"]),
};
const hasCorrelation = Object.values(correlation).some((value) => value !== undefined);
const severity =
stringValue(parsed.severityText) ?? stringValue(parsed.severity) ?? stringValue(parsed.level);

return {
...(hasCorrelation ? { correlation } : {}),
...(severity ? { severity } : {}),
};
}
19 changes: 19 additions & 0 deletions src/core/observability/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
export { ObservabilityClient, type CoreObservabilityClient, type LogRecord } from "./client";
export {
DEFAULT_RUNTIME_QUALIFIER,
RuntimeSourceResolver,
runtimeLogGroup,
type LogSource,
type ObservableResourceRef,
type ObservabilitySourceResolver,
type ObservabilitySourceResolverRegistry,
type ResolvedObservabilityTarget,
type ResolvedResourceIdentity,
} from "./resolver";
export {
CloudWatchSourceReader,
type LogSearchQuery,
type LogTailQuery,
type RawLogRecord,
type SourceReader,
} from "./sourceReader";
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat: add observability abstractions and wire to runtime by nborges-aws · Pull Request #2147 · aws/agentcore-cli · GitHub
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/core.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,7 @@ test("exposes feature sub-clients", () => {
expect(core.harness).toBeDefined();
expect(core.memory).toBeDefined();
expect(core.gateway).toBeDefined();
expect(core.observability).toBeDefined();
});

test("getEvent sends a GetEventCommand on the data client", async () => {
Expand Down
12 changes: 11 additions & 1 deletion src/core/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,11 @@ import { GatewayClient } from "./gateway";
import { HarnessClient } from "./harness";
import { IdentityClient } from "./identity";
import { MemoryClient } from "./memory";
import {
CloudWatchSourceReader,
ObservabilityClient,
RuntimeSourceResolver,
} from "./observability";
import { RuntimeClient } from "./runtime";
import type {
AwsClients,
Expand DownExpand Up@@ -67,6 +72,7 @@ export class CoreClient implements AwsClients {
readonly runtime: RuntimeClient;
readonly gateway: GatewayClient;
readonly eval: EvalClient;
readonly observability: ObservabilityClient;

readonly projectManager: ProjectManager;

Expand All@@ -88,6 +94,10 @@ export class CoreClient implements AwsClients {
this.logger.child({ module: "eval" }),
config.newSessionId,
);
this.observability = new ObservabilityClient(
{ runtime: new RuntimeSourceResolver() },
new CloudWatchSourceReader(this),
);

this.projectManager = new FsProjectManager({
logger: this.logger.child({ module: "projectManager" }),
Expand DownExpand Up@@ -132,7 +142,7 @@ export class CoreClient implements AwsClients {
}

// logs returns the CloudWatch Logs client for `config`, creating and caching it
// on first use (used to read batch-evaluation result log streams).
// on first use for customer-facing observability and evaluation result streams.
logs(config: ClientConfig): CloudWatchLogsClient {
const key = cacheKey(config);
let client = this.logsClients.get(key);
Expand Down
144 changes: 144 additions & 0 deletions src/core/observability/client.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
import { describe, expect, test } from "bun:test";
import type { CoreOptions } from "../types";
import { ObservabilityClient, type LogRecord } from "./client";
import type { LogSource, ObservabilitySourceResolverRegistry } from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

const SOURCE: LogSource = {
provider: "cloudwatch",
logGroupName: "/aws/runtime-1",
};
const OPTIONS = { region: "us-east-1" };

async function collect(records: AsyncIterable<LogRecord>) {
const result: LogRecord[] = [];
for await (const record of records) result.push(record);
return result;
}

function createClient(rawRecords: RawLogRecord[]) {
const calls: { method: string; args: unknown[] }[] = [];
const resolvers: ObservabilitySourceResolverRegistry = {
runtime: {
resolve: async (...args) => {
calls.push({ method: "resolve", args });
return {
resource: {
kind: "runtime",
id: args[0].id,
qualifier: args[0].qualifier ?? "DEFAULT",
},
logs: [SOURCE],
};
},
},
};
const reader: SourceReader = {
async *searchLogs(
source: LogSource,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
) {
calls.push({
method: "searchLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
async *tailLogs(
source: LogSource,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
) {
calls.push({
method: "tailLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
};
return { client: new ObservabilityClient(resolvers, reader), calls };
}

describe("ObservabilityClient", () => {
test("resolves, reads, and normalizes common log metadata", async () => {
const raw = {
timestamp: 1_709_391_000_000,
ingestionTime: 1_709_391_000_100,
logStreamName: "runtime-stream",
message: JSON.stringify({
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
severityText: "INFO",
attributes: { "session.id": "session-1" },
}),
raw: { eventId: "event-1" },
};
const { client, calls } = createClient([raw]);
const signal = new AbortController().signal;
const query = { startTimeMs: 1, endTimeMs: 2 };

const records = await collect(
client.searchLogs(
{ kind: "runtime", id: "runtime-1", qualifier: "blue" },
query,
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "searchLogs"]);
expect(records).toEqual([
{
timestamp: new Date(1_709_391_000_000),
ingestionTime: new Date(1_709_391_000_100),
message: raw.message,
correlation: {
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
sessionId: "session-1",
},
severity: "INFO",
source: {
provider: "cloudwatch",
resource: {
kind: "runtime",
id: "runtime-1",
qualifier: "blue",
},
logGroupName: SOURCE.logGroupName,
logStreamName: "runtime-stream",
},
raw: { eventId: "event-1" },
},
]);
});

test("uses the same orchestration path for Live Tail records", async () => {
const { client, calls } = createClient([
{
timestamp: 1,
message: "plain text",
raw: { message: "plain text" },
},
]);
const signal = new AbortController().signal;

const records = await collect(
client.tailLogs(
{ kind: "runtime", id: "runtime-1" },
{ filterPattern: "ERROR" },
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "tailLogs"]);
expect(records[0]).not.toHaveProperty("correlation");
expect(records[0]).not.toHaveProperty("severity");
});
});
148 changes: 148 additions & 0 deletions src/core/observability/client.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,148 @@
import type { CoreOptions } from "../types";
import type {
LogSource,
ObservableResourceRef,
ObservabilitySourceResolver,
ObservabilitySourceResolverRegistry,
ResolvedObservabilityTarget,
ResolvedResourceIdentity,
} from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

export interface LogRecord {
timestamp: Date;
message: string;
correlation?: {
traceId?: string;
spanId?: string;
parentSpanId?: string;
sessionId?: string;
};
severity?: string;
ingestionTime?: Date;
source: {
provider: "cloudwatch";
resource: ResolvedResourceIdentity;
logGroupName: string;
logStreamName?: string;
};
raw?: unknown;
}

export interface CoreObservabilityClient {
searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncIterable<LogRecord>;

tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncIterable<LogRecord>;
}

/**
* Shared entry point for logs. It orchestrates resolution and provider reads,
* then normalizes provider events into the stable record contract.
*/
export class ObservabilityClient implements CoreObservabilityClient {
constructor(
private readonly resolvers: ObservabilitySourceResolverRegistry,
private readonly sourceReader: SourceReader,
) {}

async *searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.searchLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

async *tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.tailLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

private resolve(
resource: ObservableResourceRef,
options: CoreOptions,
signal?: AbortSignal,
): Promise<ResolvedObservabilityTarget> {
const resolver = this.resolvers[resource.kind] as ObservabilitySourceResolver<typeof resource>;
return resolver.resolve(resource, options, signal);
}
}

function toLogRecord(
resource: ResolvedResourceIdentity,
source: LogSource,
record: RawLogRecord,
): LogRecord {
const metadata = extractCommonMetadata(record.message);
return {
timestamp: new Date(record.timestamp),
message: record.message,
...metadata,
...(record.ingestionTime !== undefined
? { ingestionTime: new Date(record.ingestionTime) }
: {}),
source: {
provider: source.provider,
resource,
logGroupName: source.logGroupName,
...(record.logStreamName ? { logStreamName: record.logStreamName } : {}),
},
raw: record.raw,
};
}

function extractCommonMetadata(message: string): Pick<LogRecord, "correlation" | "severity"> {
let parsed: Record<string, unknown>;
try {
parsed = JSON.parse(message) as Record<string, unknown>;
} catch {
return {};
}
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};

const attributes =
parsed.attributes && typeof parsed.attributes === "object" && !Array.isArray(parsed.attributes)
? (parsed.attributes as Record<string, unknown>)
: {};
const stringValue = (value: unknown): string | undefined =>
typeof value === "string" ? value : undefined;
const correlation = {
traceId: stringValue(parsed.traceId),
spanId: stringValue(parsed.spanId),
parentSpanId: stringValue(parsed.parentSpanId),
sessionId: stringValue(parsed.sessionId) ?? stringValue(attributes["session.id"]),
};
const hasCorrelation = Object.values(correlation).some((value) => value !== undefined);
const severity =
stringValue(parsed.severityText) ?? stringValue(parsed.severity) ?? stringValue(parsed.level);

return {
...(hasCorrelation ? { correlation } : {}),
...(severity ? { severity } : {}),
};
}
19 changes: 19 additions & 0 deletions src/core/observability/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
export { ObservabilityClient, type CoreObservabilityClient, type LogRecord } from "./client";
export {
DEFAULT_RUNTIME_QUALIFIER,
RuntimeSourceResolver,
runtimeLogGroup,
type LogSource,
type ObservableResourceRef,
type ObservabilitySourceResolver,
type ObservabilitySourceResolverRegistry,
type ResolvedObservabilityTarget,
type ResolvedResourceIdentity,
} from "./resolver";
export {
CloudWatchSourceReader,
type LogSearchQuery,
type LogTailQuery,
type RawLogRecord,
type SourceReader,
} from "./sourceReader";
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat: add observability abstractions and wire to runtime by nborges-aws · Pull Request #2147 · aws/agentcore-cli · GitHub
Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/core.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,7 @@ test("exposes feature sub-clients", () => {
expect(core.harness).toBeDefined();
expect(core.memory).toBeDefined();
expect(core.gateway).toBeDefined();
expect(core.observability).toBeDefined();
});

test("getEvent sends a GetEventCommand on the data client", async () => {
Expand Down
12 changes: 11 additions & 1 deletion src/core/index.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,11 @@ import { GatewayClient } from "./gateway";
import { HarnessClient } from "./harness";
import { IdentityClient } from "./identity";
import { MemoryClient } from "./memory";
import {
CloudWatchSourceReader,
ObservabilityClient,
RuntimeSourceResolver,
} from "./observability";
import { RuntimeClient } from "./runtime";
import type {
AwsClients,
Expand DownExpand Up@@ -67,6 +72,7 @@ export class CoreClient implements AwsClients {
readonly runtime: RuntimeClient;
readonly gateway: GatewayClient;
readonly eval: EvalClient;
readonly observability: ObservabilityClient;

readonly projectManager: ProjectManager;

Expand All@@ -88,6 +94,10 @@ export class CoreClient implements AwsClients {
this.logger.child({ module: "eval" }),
config.newSessionId,
);
this.observability = new ObservabilityClient(
{ runtime: new RuntimeSourceResolver() },
new CloudWatchSourceReader(this),
);

this.projectManager = new FsProjectManager({
logger: this.logger.child({ module: "projectManager" }),
Expand DownExpand Up@@ -132,7 +142,7 @@ export class CoreClient implements AwsClients {
}

// logs returns the CloudWatch Logs client for `config`, creating and caching it
// on first use (used to read batch-evaluation result log streams).
// on first use for customer-facing observability and evaluation result streams.
logs(config: ClientConfig): CloudWatchLogsClient {
const key = cacheKey(config);
let client = this.logsClients.get(key);
Expand Down
144 changes: 144 additions & 0 deletions src/core/observability/client.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
import { describe, expect, test } from "bun:test";
import type { CoreOptions } from "../types";
import { ObservabilityClient, type LogRecord } from "./client";
import type { LogSource, ObservabilitySourceResolverRegistry } from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

const SOURCE: LogSource = {
provider: "cloudwatch",
logGroupName: "/aws/runtime-1",
};
const OPTIONS = { region: "us-east-1" };

async function collect(records: AsyncIterable<LogRecord>) {
const result: LogRecord[] = [];
for await (const record of records) result.push(record);
return result;
}

function createClient(rawRecords: RawLogRecord[]) {
const calls: { method: string; args: unknown[] }[] = [];
const resolvers: ObservabilitySourceResolverRegistry = {
runtime: {
resolve: async (...args) => {
calls.push({ method: "resolve", args });
return {
resource: {
kind: "runtime",
id: args[0].id,
qualifier: args[0].qualifier ?? "DEFAULT",
},
logs: [SOURCE],
};
},
},
};
const reader: SourceReader = {
async *searchLogs(
source: LogSource,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
) {
calls.push({
method: "searchLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
async *tailLogs(
source: LogSource,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
) {
calls.push({
method: "tailLogs",
args: [source, query, options, signal],
});
yield* rawRecords;
},
};
return { client: new ObservabilityClient(resolvers, reader), calls };
}

describe("ObservabilityClient", () => {
test("resolves, reads, and normalizes common log metadata", async () => {
const raw = {
timestamp: 1_709_391_000_000,
ingestionTime: 1_709_391_000_100,
logStreamName: "runtime-stream",
message: JSON.stringify({
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
severityText: "INFO",
attributes: { "session.id": "session-1" },
}),
raw: { eventId: "event-1" },
};
const { client, calls } = createClient([raw]);
const signal = new AbortController().signal;
const query = { startTimeMs: 1, endTimeMs: 2 };

const records = await collect(
client.searchLogs(
{ kind: "runtime", id: "runtime-1", qualifier: "blue" },
query,
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "searchLogs"]);
expect(records).toEqual([
{
timestamp: new Date(1_709_391_000_000),
ingestionTime: new Date(1_709_391_000_100),
message: raw.message,
correlation: {
traceId: "trace-1",
spanId: "span-1",
parentSpanId: "parent-1",
sessionId: "session-1",
},
severity: "INFO",
source: {
provider: "cloudwatch",
resource: {
kind: "runtime",
id: "runtime-1",
qualifier: "blue",
},
logGroupName: SOURCE.logGroupName,
logStreamName: "runtime-stream",
},
raw: { eventId: "event-1" },
},
]);
});

test("uses the same orchestration path for Live Tail records", async () => {
const { client, calls } = createClient([
{
timestamp: 1,
message: "plain text",
raw: { message: "plain text" },
},
]);
const signal = new AbortController().signal;

const records = await collect(
client.tailLogs(
{ kind: "runtime", id: "runtime-1" },
{ filterPattern: "ERROR" },
OPTIONS,
signal,
),
);

expect(calls.map((call) => call.method)).toEqual(["resolve", "tailLogs"]);
expect(records[0]).not.toHaveProperty("correlation");
expect(records[0]).not.toHaveProperty("severity");
});
});
148 changes: 148 additions & 0 deletions src/core/observability/client.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,148 @@
import type { CoreOptions } from "../types";
import type {
LogSource,
ObservableResourceRef,
ObservabilitySourceResolver,
ObservabilitySourceResolverRegistry,
ResolvedObservabilityTarget,
ResolvedResourceIdentity,
} from "./resolver";
import type { LogSearchQuery, LogTailQuery, RawLogRecord, SourceReader } from "./sourceReader";

export interface LogRecord {
timestamp: Date;
message: string;
correlation?: {
traceId?: string;
spanId?: string;
parentSpanId?: string;
sessionId?: string;
};
severity?: string;
ingestionTime?: Date;
source: {
provider: "cloudwatch";
resource: ResolvedResourceIdentity;
logGroupName: string;
logStreamName?: string;
};
raw?: unknown;
}

export interface CoreObservabilityClient {
searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncIterable<LogRecord>;

tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncIterable<LogRecord>;
}

/**
* Shared entry point for logs. It orchestrates resolution and provider reads,
* then normalizes provider events into the stable record contract.
*/
export class ObservabilityClient implements CoreObservabilityClient {
constructor(
private readonly resolvers: ObservabilitySourceResolverRegistry,
private readonly sourceReader: SourceReader,
) {}

async *searchLogs(
resource: ObservableResourceRef,
query: LogSearchQuery,
options: CoreOptions,
signal?: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.searchLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

async *tailLogs(
resource: ObservableResourceRef,
query: LogTailQuery,
options: CoreOptions,
signal: AbortSignal,
): AsyncGenerator<LogRecord, void> {
const target = await this.resolve(resource, options, signal);
for (const source of target.logs) {
for await (const raw of this.sourceReader.tailLogs(source, query, options, signal)) {
yield toLogRecord(target.resource, source, raw);
}
}
}

private resolve(
resource: ObservableResourceRef,
options: CoreOptions,
signal?: AbortSignal,
): Promise<ResolvedObservabilityTarget> {
const resolver = this.resolvers[resource.kind] as ObservabilitySourceResolver<typeof resource>;
return resolver.resolve(resource, options, signal);
}
}

function toLogRecord(
resource: ResolvedResourceIdentity,
source: LogSource,
record: RawLogRecord,
): LogRecord {
const metadata = extractCommonMetadata(record.message);
return {
timestamp: new Date(record.timestamp),
message: record.message,
...metadata,
...(record.ingestionTime !== undefined
? { ingestionTime: new Date(record.ingestionTime) }
: {}),
source: {
provider: source.provider,
resource,
logGroupName: source.logGroupName,
...(record.logStreamName ? { logStreamName: record.logStreamName } : {}),
},
raw: record.raw,
};
}

function extractCommonMetadata(message: string): Pick<LogRecord, "correlation" | "severity"> {
let parsed: Record<string, unknown>;
try {
parsed = JSON.parse(message) as Record<string, unknown>;
} catch {
return {};
}
if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return {};

const attributes =
parsed.attributes && typeof parsed.attributes === "object" && !Array.isArray(parsed.attributes)
? (parsed.attributes as Record<string, unknown>)
: {};
const stringValue = (value: unknown): string | undefined =>
typeof value === "string" ? value : undefined;
const correlation = {
traceId: stringValue(parsed.traceId),
spanId: stringValue(parsed.spanId),
parentSpanId: stringValue(parsed.parentSpanId),
sessionId: stringValue(parsed.sessionId) ?? stringValue(attributes["session.id"]),
};
const hasCorrelation = Object.values(correlation).some((value) => value !== undefined);
const severity =
stringValue(parsed.severityText) ?? stringValue(parsed.severity) ?? stringValue(parsed.level);

return {
...(hasCorrelation ? { correlation } : {}),
...(severity ? { severity } : {}),
};
}
19 changes: 19 additions & 0 deletions src/core/observability/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
export { ObservabilityClient, type CoreObservabilityClient, type LogRecord } from "./client";
export {
DEFAULT_RUNTIME_QUALIFIER,
RuntimeSourceResolver,
runtimeLogGroup,
type LogSource,
type ObservableResourceRef,
type ObservabilitySourceResolver,
type ObservabilitySourceResolverRegistry,
type ResolvedObservabilityTarget,
type ResolvedResourceIdentity,
} from "./resolver";
export {
CloudWatchSourceReader,
type LogSearchQuery,
type LogTailQuery,
type RawLogRecord,
type SourceReader,
} from "./sourceReader";
Loading
Loading