Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,6 @@ agentcore invoke --stream
| `validate` | Validate configuration files |
| `deploy` | Deploy infrastructure to AWS |
| `status` | Check deployment status |
| `destroy` | Tear down deployed resources |

### Resource Management

Expand Down
15 changes: 0 additions & 15 deletions docs/commands.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,21 +65,6 @@ agentcore deploy -v --json # Verbose JSON output
| `-v, --verbose` | Resource-level events |
| `--json` | JSON output |

### destroy

Tear down deployed resources.

```bash
agentcore destroy
agentcore destroy --target dev -y # Auto-confirm
```

| Flag | Description |
| ----------------- | ----------------- |
| `--target <name>` | Target to destroy |
| `-y, --yes` | Skip confirmation |
| `--json` | JSON output |

### status

Check deployment status.
Expand Down
12 changes: 6 additions & 6 deletions integ-tests/deploy.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,17 +83,17 @@ describe('integration: deploy', () => {
}, 120000);

afterAll(async () => {
// Destroy resources and verify it succeeds
// Tear down deployed resources: remove all agents, then deploy --yes to destroy the stack
if (projectPath && hasAws) {
const result = await runCLI(['destroy', '--target', targetName, '--yes', '--json'], projectPath, false);
await runCLI(['remove', 'all', '--json'], projectPath, false);
const result = await runCLI(['deploy', '--target', targetName, '--yes', '--json'], projectPath, false);

// Assert destroy succeeded
expect(result.exitCode, `Destroy failed: ${result.stderr}`).toBe(0);
expect(result.exitCode, `Teardown failed: ${result.stderr}`).toBe(0);
const json = JSON.parse(result.stdout);
expect(json.success, 'Destroy should report success').toBe(true);
expect(json.success, 'Teardown should report success').toBe(true);
}
await rm(testDir, { recursive: true, force: true });
}, 120000);
}, 300000);

it.skipIf(!hasNpm || !hasGit || !hasUv || !hasAws)(
'deploys to AWS successfully',
Expand Down
1 change: 0 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const COMMANDS = [
'deploy',
'dev',
'invoke',
'destroy',
'status',
'validate',
'add',
Expand Down
2 changes: 0 additions & 2 deletions src/cli/cli.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import { registerAdd } from './commands/add';
import { registerCreate } from './commands/create';
import { registerDeploy } from './commands/deploy';
import { registerDestroy } from './commands/destroy';
import { registerDev } from './commands/dev';
import { registerHelp } from './commands/help';
import { registerInvoke } from './commands/invoke';
Expand DownExpand Up@@ -120,7 +119,6 @@ export function registerCommands(program: Command) {
registerAdd(program);
registerDev(program);
registerDeploy(program);
registerDestroy(program);
registerCreate(program);
registerHelp(program);
registerInvoke(program);
Expand Down
107 changes: 107 additions & 0 deletions src/cli/commands/deploy/__tests__/deploy-teardown.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { runCLI } from '../../../../test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

describe('destroy command removed', () => {
it('destroy does not appear as a command in help output', async () => {
const result = await runCLI(['--help'], process.cwd());
expect(result.exitCode).toBe(0);
// Verify 'destroy' is not listed as a command
// Extract the commands section and check no line starts with destroy
const lines = result.stdout.split('\n').map(l => l.trim());
const commandLines = lines.filter(l => /^\w/.test(l));
expect(commandLines.some(l => l.startsWith('destroy'))).toBe(false);
});
});

describe('deploy with empty agents and deployed state (teardown)', () => {
let testDir: string;
let projectDir: string;

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-deploy-teardown-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

// Create project without agents
const projectName = 'TeardownTestProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);

// Add a target
const targetResult = await runCLI(
['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
projectDir
);
if (targetResult.exitCode !== 0) {
throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
}
});

afterAll(async () => {
await rm(testDir, { recursive: true, force: true });
});

it('rejects deploy when no agents and no deployed state', async () => {
// With no agents and empty deployed-state, deploy should fail with "no agents" error
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
expect(result.exitCode).toBe(1);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('no agents');
});

it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
// Simulate that a previous deploy happened by writing to deployed-state.json
// deployed-state.json lives in agentcore/.cli/
const cliDir = join(projectDir, 'agentcore', '.cli');
await mkdir(cliDir, { recursive: true });
const deployedStatePath = join(cliDir, 'deployed-state.json');
await writeFile(
deployedStatePath,
JSON.stringify({
targets: {
'test-target': {
resources: {
stackName: 'TeardownTestProj-test-target',
agents: {
OldAgent: {
runtimeId: 'rt-123',
runtimeArn: 'arn:aws:agentcore:us-east-1:123456789012:runtime/rt-123',
roleArn: 'arn:aws:iam::123456789012:role/test-role',
},
},
},
},
},
})
);

// Without --yes, deploy should fail asking for confirmation
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('teardown');
expect(json.error).toContain('--yes');
}, 90000);

it('allows teardown deploy with --yes flag when deployed state exists', async () => {
// With --yes, deploy should proceed past the teardown confirmation
// It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
const json = JSON.parse(result.stdout);
expect(
!json.error?.toLowerCase().includes('no agents'),
`Should not fail with "no agents" when deployed state exists. Got: ${json.error}`
).toBe(true);
expect(
!json.error?.toLowerCase().includes('teardown'),
`Should not fail with teardown confirmation when --yes is passed. Got: ${json.error}`
).toBe(true);
}, 90000);
});
45 changes: 45 additions & 0 deletions src/cli/commands/deploy/actions.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { ConfigIO, SecureCredentials } from '../../../lib';
import { validateAwsCredentials } from '../../aws/account';
import { createSwitchableIoHost } from '../../cdk/toolkit-lib';
import { buildDeployedState, getStackOutputs, parseAgentOutputs } from '../../cloudformation';
import { getErrorMessage } from '../../errors';
Expand All@@ -10,6 +11,7 @@ import {
checkStackDeployability,
getAllCredentials,
hasOwnedIdentityApiProviders,
performStackTeardown,
setupApiKeyProviders,
synthesizeCdk,
validateProject,
Expand DownExpand Up@@ -67,6 +69,24 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
const context = await validateProject();
endStep('success');

// Teardown confirmation: if this is a teardown deploy, require --yes
if (context.isTeardownDeploy && !options.autoConfirm) {
logger.finalize(false);
return {
success: false,
error:
'This will delete all deployed resources and the CloudFormation stack. Run with --yes to confirm teardown.',
logPath: logger.getRelativeLogPath(),
};
}

// Validate AWS credentials (deferred for teardown deploys until after confirmation)
if (context.isTeardownDeploy) {
startStep('Validate AWS credentials');
await validateAwsCredentials();
endStep('success');
}

// Ensure L3 constructs are linked (for local development)
startStep('Link L3 constructs');
await context.cdkProject.ensureL3Link();
Expand DownExpand Up@@ -195,6 +215,31 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

endStep('success');

if (context.isTeardownDeploy) {
// After deploying the empty spec, destroy the stack entirely
startStep('Tear down stack');
const teardown = await performStackTeardown(target.name);
if (!teardown.success) {
endStep('error', teardown.error);
logger.finalize(false);
return {
success: false,
error: `Stack teardown failed: ${teardown.error}`,
logPath: logger.getRelativeLogPath(),
};
}
endStep('success');

logger.finalize(true);

return {
success: true,
targetName: target.name,
stackName,
logPath: logger.getRelativeLogPath(),
};
}

// Get stack outputs and persist state
startStep('Persist deployment state');
const outputs = await getStackOutputs(target.region, stackName);
Expand Down
119 changes: 0 additions & 119 deletions src/cli/commands/destroy/__tests__/destroy.test.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,6 @@ agentcore invoke --stream
| `validate` | Validate configuration files |
| `deploy` | Deploy infrastructure to AWS |
| `status` | Check deployment status |
| `destroy` | Tear down deployed resources |

### Resource Management

Expand Down
15 changes: 0 additions & 15 deletions docs/commands.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,21 +65,6 @@ agentcore deploy -v --json # Verbose JSON output
| `-v, --verbose` | Resource-level events |
| `--json` | JSON output |

### destroy

Tear down deployed resources.

```bash
agentcore destroy
agentcore destroy --target dev -y # Auto-confirm
```

| Flag | Description |
| ----------------- | ----------------- |
| `--target <name>` | Target to destroy |
| `-y, --yes` | Skip confirmation |
| `--json` | JSON output |

### status

Check deployment status.
Expand Down
12 changes: 6 additions & 6 deletions integ-tests/deploy.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,17 +83,17 @@ describe('integration: deploy', () => {
}, 120000);

afterAll(async () => {
// Destroy resources and verify it succeeds
// Tear down deployed resources: remove all agents, then deploy --yes to destroy the stack
if (projectPath && hasAws) {
const result = await runCLI(['destroy', '--target', targetName, '--yes', '--json'], projectPath, false);
await runCLI(['remove', 'all', '--json'], projectPath, false);
const result = await runCLI(['deploy', '--target', targetName, '--yes', '--json'], projectPath, false);

// Assert destroy succeeded
expect(result.exitCode, `Destroy failed: ${result.stderr}`).toBe(0);
expect(result.exitCode, `Teardown failed: ${result.stderr}`).toBe(0);
const json = JSON.parse(result.stdout);
expect(json.success, 'Destroy should report success').toBe(true);
expect(json.success, 'Teardown should report success').toBe(true);
}
await rm(testDir, { recursive: true, force: true });
}, 120000);
}, 300000);

it.skipIf(!hasNpm || !hasGit || !hasUv || !hasAws)(
'deploys to AWS successfully',
Expand Down
1 change: 0 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const COMMANDS = [
'deploy',
'dev',
'invoke',
'destroy',
'status',
'validate',
'add',
Expand Down
2 changes: 0 additions & 2 deletions src/cli/cli.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import { registerAdd } from './commands/add';
import { registerCreate } from './commands/create';
import { registerDeploy } from './commands/deploy';
import { registerDestroy } from './commands/destroy';
import { registerDev } from './commands/dev';
import { registerHelp } from './commands/help';
import { registerInvoke } from './commands/invoke';
Expand DownExpand Up@@ -120,7 +119,6 @@ export function registerCommands(program: Command) {
registerAdd(program);
registerDev(program);
registerDeploy(program);
registerDestroy(program);
registerCreate(program);
registerHelp(program);
registerInvoke(program);
Expand Down
107 changes: 107 additions & 0 deletions src/cli/commands/deploy/__tests__/deploy-teardown.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { runCLI } from '../../../../test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

describe('destroy command removed', () => {
it('destroy does not appear as a command in help output', async () => {
const result = await runCLI(['--help'], process.cwd());
expect(result.exitCode).toBe(0);
// Verify 'destroy' is not listed as a command
// Extract the commands section and check no line starts with destroy
const lines = result.stdout.split('\n').map(l => l.trim());
const commandLines = lines.filter(l => /^\w/.test(l));
expect(commandLines.some(l => l.startsWith('destroy'))).toBe(false);
});
});

describe('deploy with empty agents and deployed state (teardown)', () => {
let testDir: string;
let projectDir: string;

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-deploy-teardown-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

// Create project without agents
const projectName = 'TeardownTestProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);

// Add a target
const targetResult = await runCLI(
['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
projectDir
);
if (targetResult.exitCode !== 0) {
throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
}
});

afterAll(async () => {
await rm(testDir, { recursive: true, force: true });
});

it('rejects deploy when no agents and no deployed state', async () => {
// With no agents and empty deployed-state, deploy should fail with "no agents" error
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
expect(result.exitCode).toBe(1);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('no agents');
});

it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
// Simulate that a previous deploy happened by writing to deployed-state.json
// deployed-state.json lives in agentcore/.cli/
const cliDir = join(projectDir, 'agentcore', '.cli');
await mkdir(cliDir, { recursive: true });
const deployedStatePath = join(cliDir, 'deployed-state.json');
await writeFile(
deployedStatePath,
JSON.stringify({
targets: {
'test-target': {
resources: {
stackName: 'TeardownTestProj-test-target',
agents: {
OldAgent: {
runtimeId: 'rt-123',
runtimeArn: 'arn:aws:agentcore:us-east-1:123456789012:runtime/rt-123',
roleArn: 'arn:aws:iam::123456789012:role/test-role',
},
},
},
},
},
})
);

// Without --yes, deploy should fail asking for confirmation
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('teardown');
expect(json.error).toContain('--yes');
}, 90000);

it('allows teardown deploy with --yes flag when deployed state exists', async () => {
// With --yes, deploy should proceed past the teardown confirmation
// It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
const json = JSON.parse(result.stdout);
expect(
!json.error?.toLowerCase().includes('no agents'),
`Should not fail with "no agents" when deployed state exists. Got: ${json.error}`
).toBe(true);
expect(
!json.error?.toLowerCase().includes('teardown'),
`Should not fail with teardown confirmation when --yes is passed. Got: ${json.error}`
).toBe(true);
}, 90000);
});
45 changes: 45 additions & 0 deletions src/cli/commands/deploy/actions.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { ConfigIO, SecureCredentials } from '../../../lib';
import { validateAwsCredentials } from '../../aws/account';
import { createSwitchableIoHost } from '../../cdk/toolkit-lib';
import { buildDeployedState, getStackOutputs, parseAgentOutputs } from '../../cloudformation';
import { getErrorMessage } from '../../errors';
Expand All@@ -10,6 +11,7 @@ import {
checkStackDeployability,
getAllCredentials,
hasOwnedIdentityApiProviders,
performStackTeardown,
setupApiKeyProviders,
synthesizeCdk,
validateProject,
Expand DownExpand Up@@ -67,6 +69,24 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
const context = await validateProject();
endStep('success');

// Teardown confirmation: if this is a teardown deploy, require --yes
if (context.isTeardownDeploy && !options.autoConfirm) {
logger.finalize(false);
return {
success: false,
error:
'This will delete all deployed resources and the CloudFormation stack. Run with --yes to confirm teardown.',
logPath: logger.getRelativeLogPath(),
};
}

// Validate AWS credentials (deferred for teardown deploys until after confirmation)
if (context.isTeardownDeploy) {
startStep('Validate AWS credentials');
await validateAwsCredentials();
endStep('success');
}

// Ensure L3 constructs are linked (for local development)
startStep('Link L3 constructs');
await context.cdkProject.ensureL3Link();
Expand DownExpand Up@@ -195,6 +215,31 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

endStep('success');

if (context.isTeardownDeploy) {
// After deploying the empty spec, destroy the stack entirely
startStep('Tear down stack');
const teardown = await performStackTeardown(target.name);
if (!teardown.success) {
endStep('error', teardown.error);
logger.finalize(false);
return {
success: false,
error: `Stack teardown failed: ${teardown.error}`,
logPath: logger.getRelativeLogPath(),
};
}
endStep('success');

logger.finalize(true);

return {
success: true,
targetName: target.name,
stackName,
logPath: logger.getRelativeLogPath(),
};
}

// Get stack outputs and persist state
startStep('Persist deployment state');
const outputs = await getStackOutputs(target.region, stackName);
Expand Down
119 changes: 0 additions & 119 deletions src/cli/commands/destroy/__tests__/destroy.test.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,6 @@ agentcore invoke --stream
| `validate` | Validate configuration files |
| `deploy` | Deploy infrastructure to AWS |
| `status` | Check deployment status |
| `destroy` | Tear down deployed resources |

### Resource Management

Expand Down
15 changes: 0 additions & 15 deletions docs/commands.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,21 +65,6 @@ agentcore deploy -v --json # Verbose JSON output
| `-v, --verbose` | Resource-level events |
| `--json` | JSON output |

### destroy

Tear down deployed resources.

```bash
agentcore destroy
agentcore destroy --target dev -y # Auto-confirm
```

| Flag | Description |
| ----------------- | ----------------- |
| `--target <name>` | Target to destroy |
| `-y, --yes` | Skip confirmation |
| `--json` | JSON output |

### status

Check deployment status.
Expand Down
12 changes: 6 additions & 6 deletions integ-tests/deploy.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,17 +83,17 @@ describe('integration: deploy', () => {
}, 120000);

afterAll(async () => {
// Destroy resources and verify it succeeds
// Tear down deployed resources: remove all agents, then deploy --yes to destroy the stack
if (projectPath && hasAws) {
const result = await runCLI(['destroy', '--target', targetName, '--yes', '--json'], projectPath, false);
await runCLI(['remove', 'all', '--json'], projectPath, false);
const result = await runCLI(['deploy', '--target', targetName, '--yes', '--json'], projectPath, false);

// Assert destroy succeeded
expect(result.exitCode, `Destroy failed: ${result.stderr}`).toBe(0);
expect(result.exitCode, `Teardown failed: ${result.stderr}`).toBe(0);
const json = JSON.parse(result.stdout);
expect(json.success, 'Destroy should report success').toBe(true);
expect(json.success, 'Teardown should report success').toBe(true);
}
await rm(testDir, { recursive: true, force: true });
}, 120000);
}, 300000);

it.skipIf(!hasNpm || !hasGit || !hasUv || !hasAws)(
'deploys to AWS successfully',
Expand Down
1 change: 0 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const COMMANDS = [
'deploy',
'dev',
'invoke',
'destroy',
'status',
'validate',
'add',
Expand Down
2 changes: 0 additions & 2 deletions src/cli/cli.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import { registerAdd } from './commands/add';
import { registerCreate } from './commands/create';
import { registerDeploy } from './commands/deploy';
import { registerDestroy } from './commands/destroy';
import { registerDev } from './commands/dev';
import { registerHelp } from './commands/help';
import { registerInvoke } from './commands/invoke';
Expand DownExpand Up@@ -120,7 +119,6 @@ export function registerCommands(program: Command) {
registerAdd(program);
registerDev(program);
registerDeploy(program);
registerDestroy(program);
registerCreate(program);
registerHelp(program);
registerInvoke(program);
Expand Down
107 changes: 107 additions & 0 deletions src/cli/commands/deploy/__tests__/deploy-teardown.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { runCLI } from '../../../../test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

describe('destroy command removed', () => {
it('destroy does not appear as a command in help output', async () => {
const result = await runCLI(['--help'], process.cwd());
expect(result.exitCode).toBe(0);
// Verify 'destroy' is not listed as a command
// Extract the commands section and check no line starts with destroy
const lines = result.stdout.split('\n').map(l => l.trim());
const commandLines = lines.filter(l => /^\w/.test(l));
expect(commandLines.some(l => l.startsWith('destroy'))).toBe(false);
});
});

describe('deploy with empty agents and deployed state (teardown)', () => {
let testDir: string;
let projectDir: string;

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-deploy-teardown-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

// Create project without agents
const projectName = 'TeardownTestProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);

// Add a target
const targetResult = await runCLI(
['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
projectDir
);
if (targetResult.exitCode !== 0) {
throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
}
});

afterAll(async () => {
await rm(testDir, { recursive: true, force: true });
});

it('rejects deploy when no agents and no deployed state', async () => {
// With no agents and empty deployed-state, deploy should fail with "no agents" error
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
expect(result.exitCode).toBe(1);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('no agents');
});

it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
// Simulate that a previous deploy happened by writing to deployed-state.json
// deployed-state.json lives in agentcore/.cli/
const cliDir = join(projectDir, 'agentcore', '.cli');
await mkdir(cliDir, { recursive: true });
const deployedStatePath = join(cliDir, 'deployed-state.json');
await writeFile(
deployedStatePath,
JSON.stringify({
targets: {
'test-target': {
resources: {
stackName: 'TeardownTestProj-test-target',
agents: {
OldAgent: {
runtimeId: 'rt-123',
runtimeArn: 'arn:aws:agentcore:us-east-1:123456789012:runtime/rt-123',
roleArn: 'arn:aws:iam::123456789012:role/test-role',
},
},
},
},
},
})
);

// Without --yes, deploy should fail asking for confirmation
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('teardown');
expect(json.error).toContain('--yes');
}, 90000);

it('allows teardown deploy with --yes flag when deployed state exists', async () => {
// With --yes, deploy should proceed past the teardown confirmation
// It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
const json = JSON.parse(result.stdout);
expect(
!json.error?.toLowerCase().includes('no agents'),
`Should not fail with "no agents" when deployed state exists. Got: ${json.error}`
).toBe(true);
expect(
!json.error?.toLowerCase().includes('teardown'),
`Should not fail with teardown confirmation when --yes is passed. Got: ${json.error}`
).toBe(true);
}, 90000);
});
45 changes: 45 additions & 0 deletions src/cli/commands/deploy/actions.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { ConfigIO, SecureCredentials } from '../../../lib';
import { validateAwsCredentials } from '../../aws/account';
import { createSwitchableIoHost } from '../../cdk/toolkit-lib';
import { buildDeployedState, getStackOutputs, parseAgentOutputs } from '../../cloudformation';
import { getErrorMessage } from '../../errors';
Expand All@@ -10,6 +11,7 @@ import {
checkStackDeployability,
getAllCredentials,
hasOwnedIdentityApiProviders,
performStackTeardown,
setupApiKeyProviders,
synthesizeCdk,
validateProject,
Expand DownExpand Up@@ -67,6 +69,24 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
const context = await validateProject();
endStep('success');

// Teardown confirmation: if this is a teardown deploy, require --yes
if (context.isTeardownDeploy && !options.autoConfirm) {
logger.finalize(false);
return {
success: false,
error:
'This will delete all deployed resources and the CloudFormation stack. Run with --yes to confirm teardown.',
logPath: logger.getRelativeLogPath(),
};
}

// Validate AWS credentials (deferred for teardown deploys until after confirmation)
if (context.isTeardownDeploy) {
startStep('Validate AWS credentials');
await validateAwsCredentials();
endStep('success');
}

// Ensure L3 constructs are linked (for local development)
startStep('Link L3 constructs');
await context.cdkProject.ensureL3Link();
Expand DownExpand Up@@ -195,6 +215,31 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

endStep('success');

if (context.isTeardownDeploy) {
// After deploying the empty spec, destroy the stack entirely
startStep('Tear down stack');
const teardown = await performStackTeardown(target.name);
if (!teardown.success) {
endStep('error', teardown.error);
logger.finalize(false);
return {
success: false,
error: `Stack teardown failed: ${teardown.error}`,
logPath: logger.getRelativeLogPath(),
};
}
endStep('success');

logger.finalize(true);

return {
success: true,
targetName: target.name,
stackName,
logPath: logger.getRelativeLogPath(),
};
}

// Get stack outputs and persist state
startStep('Persist deployment state');
const outputs = await getStackOutputs(target.region, stackName);
Expand Down
119 changes: 0 additions & 119 deletions src/cli/commands/destroy/__tests__/destroy.test.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,6 @@ agentcore invoke --stream
| `validate` | Validate configuration files |
| `deploy` | Deploy infrastructure to AWS |
| `status` | Check deployment status |
| `destroy` | Tear down deployed resources |

### Resource Management

Expand Down
15 changes: 0 additions & 15 deletions docs/commands.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,21 +65,6 @@ agentcore deploy -v --json # Verbose JSON output
| `-v, --verbose` | Resource-level events |
| `--json` | JSON output |

### destroy

Tear down deployed resources.

```bash
agentcore destroy
agentcore destroy --target dev -y # Auto-confirm
```

| Flag | Description |
| ----------------- | ----------------- |
| `--target <name>` | Target to destroy |
| `-y, --yes` | Skip confirmation |
| `--json` | JSON output |

### status

Check deployment status.
Expand Down
12 changes: 6 additions & 6 deletions integ-tests/deploy.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,17 +83,17 @@ describe('integration: deploy', () => {
}, 120000);

afterAll(async () => {
// Destroy resources and verify it succeeds
// Tear down deployed resources: remove all agents, then deploy --yes to destroy the stack
if (projectPath && hasAws) {
const result = await runCLI(['destroy', '--target', targetName, '--yes', '--json'], projectPath, false);
await runCLI(['remove', 'all', '--json'], projectPath, false);
const result = await runCLI(['deploy', '--target', targetName, '--yes', '--json'], projectPath, false);

// Assert destroy succeeded
expect(result.exitCode, `Destroy failed: ${result.stderr}`).toBe(0);
expect(result.exitCode, `Teardown failed: ${result.stderr}`).toBe(0);
const json = JSON.parse(result.stdout);
expect(json.success, 'Destroy should report success').toBe(true);
expect(json.success, 'Teardown should report success').toBe(true);
}
await rm(testDir, { recursive: true, force: true });
}, 120000);
}, 300000);

it.skipIf(!hasNpm || !hasGit || !hasUv || !hasAws)(
'deploys to AWS successfully',
Expand Down
1 change: 0 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const COMMANDS = [
'deploy',
'dev',
'invoke',
'destroy',
'status',
'validate',
'add',
Expand Down
2 changes: 0 additions & 2 deletions src/cli/cli.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import { registerAdd } from './commands/add';
import { registerCreate } from './commands/create';
import { registerDeploy } from './commands/deploy';
import { registerDestroy } from './commands/destroy';
import { registerDev } from './commands/dev';
import { registerHelp } from './commands/help';
import { registerInvoke } from './commands/invoke';
Expand DownExpand Up@@ -120,7 +119,6 @@ export function registerCommands(program: Command) {
registerAdd(program);
registerDev(program);
registerDeploy(program);
registerDestroy(program);
registerCreate(program);
registerHelp(program);
registerInvoke(program);
Expand Down
107 changes: 107 additions & 0 deletions src/cli/commands/deploy/__tests__/deploy-teardown.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { runCLI } from '../../../../test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

describe('destroy command removed', () => {
it('destroy does not appear as a command in help output', async () => {
const result = await runCLI(['--help'], process.cwd());
expect(result.exitCode).toBe(0);
// Verify 'destroy' is not listed as a command
// Extract the commands section and check no line starts with destroy
const lines = result.stdout.split('\n').map(l => l.trim());
const commandLines = lines.filter(l => /^\w/.test(l));
expect(commandLines.some(l => l.startsWith('destroy'))).toBe(false);
});
});

describe('deploy with empty agents and deployed state (teardown)', () => {
let testDir: string;
let projectDir: string;

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-deploy-teardown-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

// Create project without agents
const projectName = 'TeardownTestProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);

// Add a target
const targetResult = await runCLI(
['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
projectDir
);
if (targetResult.exitCode !== 0) {
throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
}
});

afterAll(async () => {
await rm(testDir, { recursive: true, force: true });
});

it('rejects deploy when no agents and no deployed state', async () => {
// With no agents and empty deployed-state, deploy should fail with "no agents" error
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
expect(result.exitCode).toBe(1);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('no agents');
});

it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
// Simulate that a previous deploy happened by writing to deployed-state.json
// deployed-state.json lives in agentcore/.cli/
const cliDir = join(projectDir, 'agentcore', '.cli');
await mkdir(cliDir, { recursive: true });
const deployedStatePath = join(cliDir, 'deployed-state.json');
await writeFile(
deployedStatePath,
JSON.stringify({
targets: {
'test-target': {
resources: {
stackName: 'TeardownTestProj-test-target',
agents: {
OldAgent: {
runtimeId: 'rt-123',
runtimeArn: 'arn:aws:agentcore:us-east-1:123456789012:runtime/rt-123',
roleArn: 'arn:aws:iam::123456789012:role/test-role',
},
},
},
},
},
})
);

// Without --yes, deploy should fail asking for confirmation
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('teardown');
expect(json.error).toContain('--yes');
}, 90000);

it('allows teardown deploy with --yes flag when deployed state exists', async () => {
// With --yes, deploy should proceed past the teardown confirmation
// It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
const json = JSON.parse(result.stdout);
expect(
!json.error?.toLowerCase().includes('no agents'),
`Should not fail with "no agents" when deployed state exists. Got: ${json.error}`
).toBe(true);
expect(
!json.error?.toLowerCase().includes('teardown'),
`Should not fail with teardown confirmation when --yes is passed. Got: ${json.error}`
).toBe(true);
}, 90000);
});
45 changes: 45 additions & 0 deletions src/cli/commands/deploy/actions.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { ConfigIO, SecureCredentials } from '../../../lib';
import { validateAwsCredentials } from '../../aws/account';
import { createSwitchableIoHost } from '../../cdk/toolkit-lib';
import { buildDeployedState, getStackOutputs, parseAgentOutputs } from '../../cloudformation';
import { getErrorMessage } from '../../errors';
Expand All@@ -10,6 +11,7 @@ import {
checkStackDeployability,
getAllCredentials,
hasOwnedIdentityApiProviders,
performStackTeardown,
setupApiKeyProviders,
synthesizeCdk,
validateProject,
Expand DownExpand Up@@ -67,6 +69,24 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
const context = await validateProject();
endStep('success');

// Teardown confirmation: if this is a teardown deploy, require --yes
if (context.isTeardownDeploy && !options.autoConfirm) {
logger.finalize(false);
return {
success: false,
error:
'This will delete all deployed resources and the CloudFormation stack. Run with --yes to confirm teardown.',
logPath: logger.getRelativeLogPath(),
};
}

// Validate AWS credentials (deferred for teardown deploys until after confirmation)
if (context.isTeardownDeploy) {
startStep('Validate AWS credentials');
await validateAwsCredentials();
endStep('success');
}

// Ensure L3 constructs are linked (for local development)
startStep('Link L3 constructs');
await context.cdkProject.ensureL3Link();
Expand DownExpand Up@@ -195,6 +215,31 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

endStep('success');

if (context.isTeardownDeploy) {
// After deploying the empty spec, destroy the stack entirely
startStep('Tear down stack');
const teardown = await performStackTeardown(target.name);
if (!teardown.success) {
endStep('error', teardown.error);
logger.finalize(false);
return {
success: false,
error: `Stack teardown failed: ${teardown.error}`,
logPath: logger.getRelativeLogPath(),
};
}
endStep('success');

logger.finalize(true);

return {
success: true,
targetName: target.name,
stackName,
logPath: logger.getRelativeLogPath(),
};
}

// Get stack outputs and persist state
startStep('Persist deployment state');
const outputs = await getStackOutputs(target.region, stackName);
Expand Down
119 changes: 0 additions & 119 deletions src/cli/commands/destroy/__tests__/destroy.test.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,6 @@ agentcore invoke --stream
| `validate` | Validate configuration files |
| `deploy` | Deploy infrastructure to AWS |
| `status` | Check deployment status |
| `destroy` | Tear down deployed resources |

### Resource Management

Expand Down
15 changes: 0 additions & 15 deletions docs/commands.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,21 +65,6 @@ agentcore deploy -v --json # Verbose JSON output
| `-v, --verbose` | Resource-level events |
| `--json` | JSON output |

### destroy

Tear down deployed resources.

```bash
agentcore destroy
agentcore destroy --target dev -y # Auto-confirm
```

| Flag | Description |
| ----------------- | ----------------- |
| `--target <name>` | Target to destroy |
| `-y, --yes` | Skip confirmation |
| `--json` | JSON output |

### status

Check deployment status.
Expand Down
12 changes: 6 additions & 6 deletions integ-tests/deploy.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,17 +83,17 @@ describe('integration: deploy', () => {
}, 120000);

afterAll(async () => {
// Destroy resources and verify it succeeds
// Tear down deployed resources: remove all agents, then deploy --yes to destroy the stack
if (projectPath && hasAws) {
const result = await runCLI(['destroy', '--target', targetName, '--yes', '--json'], projectPath, false);
await runCLI(['remove', 'all', '--json'], projectPath, false);
const result = await runCLI(['deploy', '--target', targetName, '--yes', '--json'], projectPath, false);

// Assert destroy succeeded
expect(result.exitCode, `Destroy failed: ${result.stderr}`).toBe(0);
expect(result.exitCode, `Teardown failed: ${result.stderr}`).toBe(0);
const json = JSON.parse(result.stdout);
expect(json.success, 'Destroy should report success').toBe(true);
expect(json.success, 'Teardown should report success').toBe(true);
}
await rm(testDir, { recursive: true, force: true });
}, 120000);
}, 300000);

it.skipIf(!hasNpm || !hasGit || !hasUv || !hasAws)(
'deploys to AWS successfully',
Expand Down
1 change: 0 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const COMMANDS = [
'deploy',
'dev',
'invoke',
'destroy',
'status',
'validate',
'add',
Expand Down
2 changes: 0 additions & 2 deletions src/cli/cli.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import { registerAdd } from './commands/add';
import { registerCreate } from './commands/create';
import { registerDeploy } from './commands/deploy';
import { registerDestroy } from './commands/destroy';
import { registerDev } from './commands/dev';
import { registerHelp } from './commands/help';
import { registerInvoke } from './commands/invoke';
Expand DownExpand Up@@ -120,7 +119,6 @@ export function registerCommands(program: Command) {
registerAdd(program);
registerDev(program);
registerDeploy(program);
registerDestroy(program);
registerCreate(program);
registerHelp(program);
registerInvoke(program);
Expand Down
107 changes: 107 additions & 0 deletions src/cli/commands/deploy/__tests__/deploy-teardown.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { runCLI } from '../../../../test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

describe('destroy command removed', () => {
it('destroy does not appear as a command in help output', async () => {
const result = await runCLI(['--help'], process.cwd());
expect(result.exitCode).toBe(0);
// Verify 'destroy' is not listed as a command
// Extract the commands section and check no line starts with destroy
const lines = result.stdout.split('\n').map(l => l.trim());
const commandLines = lines.filter(l => /^\w/.test(l));
expect(commandLines.some(l => l.startsWith('destroy'))).toBe(false);
});
});

describe('deploy with empty agents and deployed state (teardown)', () => {
let testDir: string;
let projectDir: string;

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-deploy-teardown-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

// Create project without agents
const projectName = 'TeardownTestProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);

// Add a target
const targetResult = await runCLI(
['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
projectDir
);
if (targetResult.exitCode !== 0) {
throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
}
});

afterAll(async () => {
await rm(testDir, { recursive: true, force: true });
});

it('rejects deploy when no agents and no deployed state', async () => {
// With no agents and empty deployed-state, deploy should fail with "no agents" error
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
expect(result.exitCode).toBe(1);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('no agents');
});

it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
// Simulate that a previous deploy happened by writing to deployed-state.json
// deployed-state.json lives in agentcore/.cli/
const cliDir = join(projectDir, 'agentcore', '.cli');
await mkdir(cliDir, { recursive: true });
const deployedStatePath = join(cliDir, 'deployed-state.json');
await writeFile(
deployedStatePath,
JSON.stringify({
targets: {
'test-target': {
resources: {
stackName: 'TeardownTestProj-test-target',
agents: {
OldAgent: {
runtimeId: 'rt-123',
runtimeArn: 'arn:aws:agentcore:us-east-1:123456789012:runtime/rt-123',
roleArn: 'arn:aws:iam::123456789012:role/test-role',
},
},
},
},
},
})
);

// Without --yes, deploy should fail asking for confirmation
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('teardown');
expect(json.error).toContain('--yes');
}, 90000);

it('allows teardown deploy with --yes flag when deployed state exists', async () => {
// With --yes, deploy should proceed past the teardown confirmation
// It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
const json = JSON.parse(result.stdout);
expect(
!json.error?.toLowerCase().includes('no agents'),
`Should not fail with "no agents" when deployed state exists. Got: ${json.error}`
).toBe(true);
expect(
!json.error?.toLowerCase().includes('teardown'),
`Should not fail with teardown confirmation when --yes is passed. Got: ${json.error}`
).toBe(true);
}, 90000);
});
45 changes: 45 additions & 0 deletions src/cli/commands/deploy/actions.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { ConfigIO, SecureCredentials } from '../../../lib';
import { validateAwsCredentials } from '../../aws/account';
import { createSwitchableIoHost } from '../../cdk/toolkit-lib';
import { buildDeployedState, getStackOutputs, parseAgentOutputs } from '../../cloudformation';
import { getErrorMessage } from '../../errors';
Expand All@@ -10,6 +11,7 @@ import {
checkStackDeployability,
getAllCredentials,
hasOwnedIdentityApiProviders,
performStackTeardown,
setupApiKeyProviders,
synthesizeCdk,
validateProject,
Expand DownExpand Up@@ -67,6 +69,24 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
const context = await validateProject();
endStep('success');

// Teardown confirmation: if this is a teardown deploy, require --yes
if (context.isTeardownDeploy && !options.autoConfirm) {
logger.finalize(false);
return {
success: false,
error:
'This will delete all deployed resources and the CloudFormation stack. Run with --yes to confirm teardown.',
logPath: logger.getRelativeLogPath(),
};
}

// Validate AWS credentials (deferred for teardown deploys until after confirmation)
if (context.isTeardownDeploy) {
startStep('Validate AWS credentials');
await validateAwsCredentials();
endStep('success');
}

// Ensure L3 constructs are linked (for local development)
startStep('Link L3 constructs');
await context.cdkProject.ensureL3Link();
Expand DownExpand Up@@ -195,6 +215,31 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

endStep('success');

if (context.isTeardownDeploy) {
// After deploying the empty spec, destroy the stack entirely
startStep('Tear down stack');
const teardown = await performStackTeardown(target.name);
if (!teardown.success) {
endStep('error', teardown.error);
logger.finalize(false);
return {
success: false,
error: `Stack teardown failed: ${teardown.error}`,
logPath: logger.getRelativeLogPath(),
};
}
endStep('success');

logger.finalize(true);

return {
success: true,
targetName: target.name,
stackName,
logPath: logger.getRelativeLogPath(),
};
}

// Get stack outputs and persist state
startStep('Persist deployment state');
const outputs = await getStackOutputs(target.region, stackName);
Expand Down
119 changes: 0 additions & 119 deletions src/cli/commands/destroy/__tests__/destroy.test.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,6 @@ agentcore invoke --stream
| `validate` | Validate configuration files |
| `deploy` | Deploy infrastructure to AWS |
| `status` | Check deployment status |
| `destroy` | Tear down deployed resources |

### Resource Management

Expand Down
15 changes: 0 additions & 15 deletions docs/commands.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,21 +65,6 @@ agentcore deploy -v --json # Verbose JSON output
| `-v, --verbose` | Resource-level events |
| `--json` | JSON output |

### destroy

Tear down deployed resources.

```bash
agentcore destroy
agentcore destroy --target dev -y # Auto-confirm
```

| Flag | Description |
| ----------------- | ----------------- |
| `--target <name>` | Target to destroy |
| `-y, --yes` | Skip confirmation |
| `--json` | JSON output |

### status

Check deployment status.
Expand Down
12 changes: 6 additions & 6 deletions integ-tests/deploy.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,17 +83,17 @@ describe('integration: deploy', () => {
}, 120000);

afterAll(async () => {
// Destroy resources and verify it succeeds
// Tear down deployed resources: remove all agents, then deploy --yes to destroy the stack
if (projectPath && hasAws) {
const result = await runCLI(['destroy', '--target', targetName, '--yes', '--json'], projectPath, false);
await runCLI(['remove', 'all', '--json'], projectPath, false);
const result = await runCLI(['deploy', '--target', targetName, '--yes', '--json'], projectPath, false);

// Assert destroy succeeded
expect(result.exitCode, `Destroy failed: ${result.stderr}`).toBe(0);
expect(result.exitCode, `Teardown failed: ${result.stderr}`).toBe(0);
const json = JSON.parse(result.stdout);
expect(json.success, 'Destroy should report success').toBe(true);
expect(json.success, 'Teardown should report success').toBe(true);
}
await rm(testDir, { recursive: true, force: true });
}, 120000);
}, 300000);

it.skipIf(!hasNpm || !hasGit || !hasUv || !hasAws)(
'deploys to AWS successfully',
Expand Down
1 change: 0 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const COMMANDS = [
'deploy',
'dev',
'invoke',
'destroy',
'status',
'validate',
'add',
Expand Down
2 changes: 0 additions & 2 deletions src/cli/cli.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import { registerAdd } from './commands/add';
import { registerCreate } from './commands/create';
import { registerDeploy } from './commands/deploy';
import { registerDestroy } from './commands/destroy';
import { registerDev } from './commands/dev';
import { registerHelp } from './commands/help';
import { registerInvoke } from './commands/invoke';
Expand DownExpand Up@@ -120,7 +119,6 @@ export function registerCommands(program: Command) {
registerAdd(program);
registerDev(program);
registerDeploy(program);
registerDestroy(program);
registerCreate(program);
registerHelp(program);
registerInvoke(program);
Expand Down
107 changes: 107 additions & 0 deletions src/cli/commands/deploy/__tests__/deploy-teardown.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { runCLI } from '../../../../test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

describe('destroy command removed', () => {
it('destroy does not appear as a command in help output', async () => {
const result = await runCLI(['--help'], process.cwd());
expect(result.exitCode).toBe(0);
// Verify 'destroy' is not listed as a command
// Extract the commands section and check no line starts with destroy
const lines = result.stdout.split('\n').map(l => l.trim());
const commandLines = lines.filter(l => /^\w/.test(l));
expect(commandLines.some(l => l.startsWith('destroy'))).toBe(false);
});
});

describe('deploy with empty agents and deployed state (teardown)', () => {
let testDir: string;
let projectDir: string;

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-deploy-teardown-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

// Create project without agents
const projectName = 'TeardownTestProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);

// Add a target
const targetResult = await runCLI(
['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
projectDir
);
if (targetResult.exitCode !== 0) {
throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
}
});

afterAll(async () => {
await rm(testDir, { recursive: true, force: true });
});

it('rejects deploy when no agents and no deployed state', async () => {
// With no agents and empty deployed-state, deploy should fail with "no agents" error
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
expect(result.exitCode).toBe(1);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('no agents');
});

it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
// Simulate that a previous deploy happened by writing to deployed-state.json
// deployed-state.json lives in agentcore/.cli/
const cliDir = join(projectDir, 'agentcore', '.cli');
await mkdir(cliDir, { recursive: true });
const deployedStatePath = join(cliDir, 'deployed-state.json');
await writeFile(
deployedStatePath,
JSON.stringify({
targets: {
'test-target': {
resources: {
stackName: 'TeardownTestProj-test-target',
agents: {
OldAgent: {
runtimeId: 'rt-123',
runtimeArn: 'arn:aws:agentcore:us-east-1:123456789012:runtime/rt-123',
roleArn: 'arn:aws:iam::123456789012:role/test-role',
},
},
},
},
},
})
);

// Without --yes, deploy should fail asking for confirmation
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('teardown');
expect(json.error).toContain('--yes');
}, 90000);

it('allows teardown deploy with --yes flag when deployed state exists', async () => {
// With --yes, deploy should proceed past the teardown confirmation
// It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
const json = JSON.parse(result.stdout);
expect(
!json.error?.toLowerCase().includes('no agents'),
`Should not fail with "no agents" when deployed state exists. Got: ${json.error}`
).toBe(true);
expect(
!json.error?.toLowerCase().includes('teardown'),
`Should not fail with teardown confirmation when --yes is passed. Got: ${json.error}`
).toBe(true);
}, 90000);
});
45 changes: 45 additions & 0 deletions src/cli/commands/deploy/actions.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { ConfigIO, SecureCredentials } from '../../../lib';
import { validateAwsCredentials } from '../../aws/account';
import { createSwitchableIoHost } from '../../cdk/toolkit-lib';
import { buildDeployedState, getStackOutputs, parseAgentOutputs } from '../../cloudformation';
import { getErrorMessage } from '../../errors';
Expand All@@ -10,6 +11,7 @@ import {
checkStackDeployability,
getAllCredentials,
hasOwnedIdentityApiProviders,
performStackTeardown,
setupApiKeyProviders,
synthesizeCdk,
validateProject,
Expand DownExpand Up@@ -67,6 +69,24 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
const context = await validateProject();
endStep('success');

// Teardown confirmation: if this is a teardown deploy, require --yes
if (context.isTeardownDeploy && !options.autoConfirm) {
logger.finalize(false);
return {
success: false,
error:
'This will delete all deployed resources and the CloudFormation stack. Run with --yes to confirm teardown.',
logPath: logger.getRelativeLogPath(),
};
}

// Validate AWS credentials (deferred for teardown deploys until after confirmation)
if (context.isTeardownDeploy) {
startStep('Validate AWS credentials');
await validateAwsCredentials();
endStep('success');
}

// Ensure L3 constructs are linked (for local development)
startStep('Link L3 constructs');
await context.cdkProject.ensureL3Link();
Expand DownExpand Up@@ -195,6 +215,31 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

endStep('success');

if (context.isTeardownDeploy) {
// After deploying the empty spec, destroy the stack entirely
startStep('Tear down stack');
const teardown = await performStackTeardown(target.name);
if (!teardown.success) {
endStep('error', teardown.error);
logger.finalize(false);
return {
success: false,
error: `Stack teardown failed: ${teardown.error}`,
logPath: logger.getRelativeLogPath(),
};
}
endStep('success');

logger.finalize(true);

return {
success: true,
targetName: target.name,
stackName,
logPath: logger.getRelativeLogPath(),
};
}

// Get stack outputs and persist state
startStep('Persist deployment state');
const outputs = await getStackOutputs(target.region, stackName);
Expand Down
119 changes: 0 additions & 119 deletions src/cli/commands/destroy/__tests__/destroy.test.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,6 @@ agentcore invoke --stream
| `validate` | Validate configuration files |
| `deploy` | Deploy infrastructure to AWS |
| `status` | Check deployment status |
| `destroy` | Tear down deployed resources |

### Resource Management

Expand Down
15 changes: 0 additions & 15 deletions docs/commands.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,21 +65,6 @@ agentcore deploy -v --json # Verbose JSON output
| `-v, --verbose` | Resource-level events |
| `--json` | JSON output |

### destroy

Tear down deployed resources.

```bash
agentcore destroy
agentcore destroy --target dev -y # Auto-confirm
```

| Flag | Description |
| ----------------- | ----------------- |
| `--target <name>` | Target to destroy |
| `-y, --yes` | Skip confirmation |
| `--json` | JSON output |

### status

Check deployment status.
Expand Down
12 changes: 6 additions & 6 deletions integ-tests/deploy.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,17 +83,17 @@ describe('integration: deploy', () => {
}, 120000);

afterAll(async () => {
// Destroy resources and verify it succeeds
// Tear down deployed resources: remove all agents, then deploy --yes to destroy the stack
if (projectPath && hasAws) {
const result = await runCLI(['destroy', '--target', targetName, '--yes', '--json'], projectPath, false);
await runCLI(['remove', 'all', '--json'], projectPath, false);
const result = await runCLI(['deploy', '--target', targetName, '--yes', '--json'], projectPath, false);

// Assert destroy succeeded
expect(result.exitCode, `Destroy failed: ${result.stderr}`).toBe(0);
expect(result.exitCode, `Teardown failed: ${result.stderr}`).toBe(0);
const json = JSON.parse(result.stdout);
expect(json.success, 'Destroy should report success').toBe(true);
expect(json.success, 'Teardown should report success').toBe(true);
}
await rm(testDir, { recursive: true, force: true });
}, 120000);
}, 300000);

it.skipIf(!hasNpm || !hasGit || !hasUv || !hasAws)(
'deploys to AWS successfully',
Expand Down
1 change: 0 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const COMMANDS = [
'deploy',
'dev',
'invoke',
'destroy',
'status',
'validate',
'add',
Expand Down
2 changes: 0 additions & 2 deletions src/cli/cli.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import { registerAdd } from './commands/add';
import { registerCreate } from './commands/create';
import { registerDeploy } from './commands/deploy';
import { registerDestroy } from './commands/destroy';
import { registerDev } from './commands/dev';
import { registerHelp } from './commands/help';
import { registerInvoke } from './commands/invoke';
Expand DownExpand Up@@ -120,7 +119,6 @@ export function registerCommands(program: Command) {
registerAdd(program);
registerDev(program);
registerDeploy(program);
registerDestroy(program);
registerCreate(program);
registerHelp(program);
registerInvoke(program);
Expand Down
107 changes: 107 additions & 0 deletions src/cli/commands/deploy/__tests__/deploy-teardown.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { runCLI } from '../../../../test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

describe('destroy command removed', () => {
it('destroy does not appear as a command in help output', async () => {
const result = await runCLI(['--help'], process.cwd());
expect(result.exitCode).toBe(0);
// Verify 'destroy' is not listed as a command
// Extract the commands section and check no line starts with destroy
const lines = result.stdout.split('\n').map(l => l.trim());
const commandLines = lines.filter(l => /^\w/.test(l));
expect(commandLines.some(l => l.startsWith('destroy'))).toBe(false);
});
});

describe('deploy with empty agents and deployed state (teardown)', () => {
let testDir: string;
let projectDir: string;

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-deploy-teardown-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

// Create project without agents
const projectName = 'TeardownTestProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);

// Add a target
const targetResult = await runCLI(
['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
projectDir
);
if (targetResult.exitCode !== 0) {
throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
}
});

afterAll(async () => {
await rm(testDir, { recursive: true, force: true });
});

it('rejects deploy when no agents and no deployed state', async () => {
// With no agents and empty deployed-state, deploy should fail with "no agents" error
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
expect(result.exitCode).toBe(1);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('no agents');
});

it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
// Simulate that a previous deploy happened by writing to deployed-state.json
// deployed-state.json lives in agentcore/.cli/
const cliDir = join(projectDir, 'agentcore', '.cli');
await mkdir(cliDir, { recursive: true });
const deployedStatePath = join(cliDir, 'deployed-state.json');
await writeFile(
deployedStatePath,
JSON.stringify({
targets: {
'test-target': {
resources: {
stackName: 'TeardownTestProj-test-target',
agents: {
OldAgent: {
runtimeId: 'rt-123',
runtimeArn: 'arn:aws:agentcore:us-east-1:123456789012:runtime/rt-123',
roleArn: 'arn:aws:iam::123456789012:role/test-role',
},
},
},
},
},
})
);

// Without --yes, deploy should fail asking for confirmation
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('teardown');
expect(json.error).toContain('--yes');
}, 90000);

it('allows teardown deploy with --yes flag when deployed state exists', async () => {
// With --yes, deploy should proceed past the teardown confirmation
// It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
const json = JSON.parse(result.stdout);
expect(
!json.error?.toLowerCase().includes('no agents'),
`Should not fail with "no agents" when deployed state exists. Got: ${json.error}`
).toBe(true);
expect(
!json.error?.toLowerCase().includes('teardown'),
`Should not fail with teardown confirmation when --yes is passed. Got: ${json.error}`
).toBe(true);
}, 90000);
});
45 changes: 45 additions & 0 deletions src/cli/commands/deploy/actions.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { ConfigIO, SecureCredentials } from '../../../lib';
import { validateAwsCredentials } from '../../aws/account';
import { createSwitchableIoHost } from '../../cdk/toolkit-lib';
import { buildDeployedState, getStackOutputs, parseAgentOutputs } from '../../cloudformation';
import { getErrorMessage } from '../../errors';
Expand All@@ -10,6 +11,7 @@ import {
checkStackDeployability,
getAllCredentials,
hasOwnedIdentityApiProviders,
performStackTeardown,
setupApiKeyProviders,
synthesizeCdk,
validateProject,
Expand DownExpand Up@@ -67,6 +69,24 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
const context = await validateProject();
endStep('success');

// Teardown confirmation: if this is a teardown deploy, require --yes
if (context.isTeardownDeploy && !options.autoConfirm) {
logger.finalize(false);
return {
success: false,
error:
'This will delete all deployed resources and the CloudFormation stack. Run with --yes to confirm teardown.',
logPath: logger.getRelativeLogPath(),
};
}

// Validate AWS credentials (deferred for teardown deploys until after confirmation)
if (context.isTeardownDeploy) {
startStep('Validate AWS credentials');
await validateAwsCredentials();
endStep('success');
}

// Ensure L3 constructs are linked (for local development)
startStep('Link L3 constructs');
await context.cdkProject.ensureL3Link();
Expand DownExpand Up@@ -195,6 +215,31 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

endStep('success');

if (context.isTeardownDeploy) {
// After deploying the empty spec, destroy the stack entirely
startStep('Tear down stack');
const teardown = await performStackTeardown(target.name);
if (!teardown.success) {
endStep('error', teardown.error);
logger.finalize(false);
return {
success: false,
error: `Stack teardown failed: ${teardown.error}`,
logPath: logger.getRelativeLogPath(),
};
}
endStep('success');

logger.finalize(true);

return {
success: true,
targetName: target.name,
stackName,
logPath: logger.getRelativeLogPath(),
};
}

// Get stack outputs and persist state
startStep('Persist deployment state');
const outputs = await getStackOutputs(target.region, stackName);
Expand Down
119 changes: 0 additions & 119 deletions src/cli/commands/destroy/__tests__/destroy.test.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,6 @@ agentcore invoke --stream
| `validate` | Validate configuration files |
| `deploy` | Deploy infrastructure to AWS |
| `status` | Check deployment status |
| `destroy` | Tear down deployed resources |

### Resource Management

Expand Down
15 changes: 0 additions & 15 deletions docs/commands.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -65,21 +65,6 @@ agentcore deploy -v --json # Verbose JSON output
| `-v, --verbose` | Resource-level events |
| `--json` | JSON output |

### destroy

Tear down deployed resources.

```bash
agentcore destroy
agentcore destroy --target dev -y # Auto-confirm
```

| Flag | Description |
| ----------------- | ----------------- |
| `--target <name>` | Target to destroy |
| `-y, --yes` | Skip confirmation |
| `--json` | JSON output |

### status

Check deployment status.
Expand Down
12 changes: 6 additions & 6 deletions integ-tests/deploy.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,17 +83,17 @@ describe('integration: deploy', () => {
}, 120000);

afterAll(async () => {
// Destroy resources and verify it succeeds
// Tear down deployed resources: remove all agents, then deploy --yes to destroy the stack
if (projectPath && hasAws) {
const result = await runCLI(['destroy', '--target', targetName, '--yes', '--json'], projectPath, false);
await runCLI(['remove', 'all', '--json'], projectPath, false);
const result = await runCLI(['deploy', '--target', targetName, '--yes', '--json'], projectPath, false);

// Assert destroy succeeded
expect(result.exitCode, `Destroy failed: ${result.stderr}`).toBe(0);
expect(result.exitCode, `Teardown failed: ${result.stderr}`).toBe(0);
const json = JSON.parse(result.stdout);
expect(json.success, 'Destroy should report success').toBe(true);
expect(json.success, 'Teardown should report success').toBe(true);
}
await rm(testDir, { recursive: true, force: true });
}, 120000);
}, 300000);

it.skipIf(!hasNpm || !hasGit || !hasUv || !hasAws)(
'deploys to AWS successfully',
Expand Down
1 change: 0 additions & 1 deletion integ-tests/help.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@ const COMMANDS = [
'deploy',
'dev',
'invoke',
'destroy',
'status',
'validate',
'add',
Expand Down
2 changes: 0 additions & 2 deletions src/cli/cli.ts
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import { registerAdd } from './commands/add';
import { registerCreate } from './commands/create';
import { registerDeploy } from './commands/deploy';
import { registerDestroy } from './commands/destroy';
import { registerDev } from './commands/dev';
import { registerHelp } from './commands/help';
import { registerInvoke } from './commands/invoke';
Expand DownExpand Up@@ -120,7 +119,6 @@ export function registerCommands(program: Command) {
registerAdd(program);
registerDev(program);
registerDeploy(program);
registerDestroy(program);
registerCreate(program);
registerHelp(program);
registerInvoke(program);
Expand Down
107 changes: 107 additions & 0 deletions src/cli/commands/deploy/__tests__/deploy-teardown.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
import { runCLI } from '../../../../test-utils/index.js';
import { randomUUID } from 'node:crypto';
import { mkdir, rm, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterAll, beforeAll, describe, expect, it } from 'vitest';

describe('destroy command removed', () => {
it('destroy does not appear as a command in help output', async () => {
const result = await runCLI(['--help'], process.cwd());
expect(result.exitCode).toBe(0);
// Verify 'destroy' is not listed as a command
// Extract the commands section and check no line starts with destroy
const lines = result.stdout.split('\n').map(l => l.trim());
const commandLines = lines.filter(l => /^\w/.test(l));
expect(commandLines.some(l => l.startsWith('destroy'))).toBe(false);
});
});

describe('deploy with empty agents and deployed state (teardown)', () => {
let testDir: string;
let projectDir: string;

beforeAll(async () => {
testDir = join(tmpdir(), `agentcore-deploy-teardown-${randomUUID()}`);
await mkdir(testDir, { recursive: true });

// Create project without agents
const projectName = 'TeardownTestProj';
const result = await runCLI(['create', '--name', projectName, '--no-agent'], testDir);
if (result.exitCode !== 0) {
throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
}
projectDir = join(testDir, projectName);

// Add a target
const targetResult = await runCLI(
['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
projectDir
);
if (targetResult.exitCode !== 0) {
throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
}
});

afterAll(async () => {
await rm(testDir, { recursive: true, force: true });
});

it('rejects deploy when no agents and no deployed state', async () => {
// With no agents and empty deployed-state, deploy should fail with "no agents" error
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
expect(result.exitCode).toBe(1);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('no agents');
});

it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
// Simulate that a previous deploy happened by writing to deployed-state.json
// deployed-state.json lives in agentcore/.cli/
const cliDir = join(projectDir, 'agentcore', '.cli');
await mkdir(cliDir, { recursive: true });
const deployedStatePath = join(cliDir, 'deployed-state.json');
await writeFile(
deployedStatePath,
JSON.stringify({
targets: {
'test-target': {
resources: {
stackName: 'TeardownTestProj-test-target',
agents: {
OldAgent: {
runtimeId: 'rt-123',
runtimeArn: 'arn:aws:agentcore:us-east-1:123456789012:runtime/rt-123',
roleArn: 'arn:aws:iam::123456789012:role/test-role',
},
},
},
},
},
})
);

// Without --yes, deploy should fail asking for confirmation
const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
const json = JSON.parse(result.stdout);
expect(json.success).toBe(false);
expect(json.error.toLowerCase()).toContain('teardown');
expect(json.error).toContain('--yes');
}, 90000);

it('allows teardown deploy with --yes flag when deployed state exists', async () => {
// With --yes, deploy should proceed past the teardown confirmation
// It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
const json = JSON.parse(result.stdout);
expect(
!json.error?.toLowerCase().includes('no agents'),
`Should not fail with "no agents" when deployed state exists. Got: ${json.error}`
).toBe(true);
expect(
!json.error?.toLowerCase().includes('teardown'),
`Should not fail with teardown confirmation when --yes is passed. Got: ${json.error}`
).toBe(true);
}, 90000);
});
45 changes: 45 additions & 0 deletions src/cli/commands/deploy/actions.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { ConfigIO, SecureCredentials } from '../../../lib';
import { validateAwsCredentials } from '../../aws/account';
import { createSwitchableIoHost } from '../../cdk/toolkit-lib';
import { buildDeployedState, getStackOutputs, parseAgentOutputs } from '../../cloudformation';
import { getErrorMessage } from '../../errors';
Expand All@@ -10,6 +11,7 @@ import {
checkStackDeployability,
getAllCredentials,
hasOwnedIdentityApiProviders,
performStackTeardown,
setupApiKeyProviders,
synthesizeCdk,
validateProject,
Expand DownExpand Up@@ -67,6 +69,24 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
const context = await validateProject();
endStep('success');

// Teardown confirmation: if this is a teardown deploy, require --yes
if (context.isTeardownDeploy && !options.autoConfirm) {
logger.finalize(false);
return {
success: false,
error:
'This will delete all deployed resources and the CloudFormation stack. Run with --yes to confirm teardown.',
logPath: logger.getRelativeLogPath(),
};
}

// Validate AWS credentials (deferred for teardown deploys until after confirmation)
if (context.isTeardownDeploy) {
startStep('Validate AWS credentials');
await validateAwsCredentials();
endStep('success');
}

// Ensure L3 constructs are linked (for local development)
startStep('Link L3 constructs');
await context.cdkProject.ensureL3Link();
Expand DownExpand Up@@ -195,6 +215,31 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep

endStep('success');

if (context.isTeardownDeploy) {
// After deploying the empty spec, destroy the stack entirely
startStep('Tear down stack');
const teardown = await performStackTeardown(target.name);
if (!teardown.success) {
endStep('error', teardown.error);
logger.finalize(false);
return {
success: false,
error: `Stack teardown failed: ${teardown.error}`,
logPath: logger.getRelativeLogPath(),
};
}
endStep('success');

logger.finalize(true);

return {
success: true,
targetName: target.name,
stackName,
logPath: logger.getRelativeLogPath(),
};
}

// Get stack outputs and persist state
startStep('Persist deployment state');
const outputs = await getStackOutputs(target.region, stackName);
Expand Down
119 changes: 0 additions & 119 deletions src/cli/commands/destroy/__tests__/destroy.test.ts

This file was deleted.

Loading
Loading