feat: add resource tagging support by tejaskash · Pull Request #564 · aws/agentcore-cli

tejaskash · 2026-03-18T22:43:39Z

Summary

Add agentcore tag command with subcommands: list, add, remove, set-defaults, remove-defaults
Add TagsSchema to project, agent, memory, and gateway schemas (optional, backward compatible)
Auto-tag new projects with agentcore:created-by: agentcore-cli and agentcore:project-name: <name>
Project-level default tags propagate to all resources; per-resource tags override on conflict
Taggable resources: agents, memories, gateways. Credentials are not taggable (deployed via Identity API, not CFN)
No changes to vended CDK code; tag propagation handled by L3 constructs

Companion PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/87

Test plan

Schema unit tests: TagKeySchema, TagValueSchema, TagsSchema validation (11 tests)
Action unit tests: listTags, addTag, removeTag, setDefaultTag, removeDefaultTag (12 tests)
Integration tests: tag command round-trip (create project, add/list/remove tags)
All 2243 existing unit tests pass, snapshots up to date
End-to-end: created project, added tags, deployed, verified tags on AWS resources via CloudFormation template

github-actions · 2026-03-20T17:22:10Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.6%	5169 / 12131
🔵	Statements	42.28%	5485 / 12971
🔵	Functions	42.04%	960 / 2283
🔵	Branches	43.49%	3311 / 7613

Generated in workflow #1152 for commit 4fb09f3 by the Vitest Coverage Report Action

Add `agentcore tag` command for managing AWS resource tags on agents, memories, and gateways. Supports project-level default tags (inherited by all resources) and per-resource tag overrides. - Add TagsSchema to project, agent, memory, and gateway schemas - Add `tag list|add|remove|set-defaults|remove-defaults` subcommands - Auto-tag new projects with `agentcore:created-by` and `agentcore:project-name` - Add unit tests for schema validation and tag actions - Add integration tests for tag command round-trip

aidandaly24

Some comments

- Remove unused constants.ts (TAGGABLE_RESOURCE_TYPES was duplicated from types.ts and never imported) - Replace silent guard returns in integ tests with explicit assertions - Validate tag key/value against TagKeySchema and TagValueSchema before writing in addTag and setDefaultTag - Add unit tests for key/value validation (empty key, key > 128 chars, value > 256 chars)

- Add Unicode character validation to TagKeySchema and TagValueSchema per AWS tag restrictions (letters, digits, whitespace, _ . : / = + - @) - Improve removeTag error when key is inherited from project defaults: now hints to use "tag remove-defaults" instead - Add tests for character restrictions and updated error messages

notgitika

LGTM

This reverts commit dd9716c.

tejaskash · 2026-03-18T22:43:39Z

Summary

Add agentcore tag command with subcommands: list, add, remove, set-defaults, remove-defaults
Add TagsSchema to project, agent, memory, and gateway schemas (optional, backward compatible)
Auto-tag new projects with agentcore:created-by: agentcore-cli and agentcore:project-name: <name>
Project-level default tags propagate to all resources; per-resource tags override on conflict
Taggable resources: agents, memories, gateways. Credentials are not taggable (deployed via Identity API, not CFN)
No changes to vended CDK code; tag propagation handled by L3 constructs

Companion PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/87

Test plan

Schema unit tests: TagKeySchema, TagValueSchema, TagsSchema validation (11 tests)
Action unit tests: listTags, addTag, removeTag, setDefaultTag, removeDefaultTag (12 tests)
Integration tests: tag command round-trip (create project, add/list/remove tags)
All 2243 existing unit tests pass, snapshots up to date
End-to-end: created project, added tags, deployed, verified tags on AWS resources via CloudFormation template

github-actions · 2026-03-20T17:22:10Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.6%	5169 / 12131
🔵	Statements	42.28%	5485 / 12971
🔵	Functions	42.04%	960 / 2283
🔵	Branches	43.49%	3311 / 7613

Generated in workflow #1152 for commit 4fb09f3 by the Vitest Coverage Report Action

Add `agentcore tag` command for managing AWS resource tags on agents, memories, and gateways. Supports project-level default tags (inherited by all resources) and per-resource tag overrides. - Add TagsSchema to project, agent, memory, and gateway schemas - Add `tag list|add|remove|set-defaults|remove-defaults` subcommands - Auto-tag new projects with `agentcore:created-by` and `agentcore:project-name` - Add unit tests for schema validation and tag actions - Add integration tests for tag command round-trip

aidandaly24

Some comments

- Remove unused constants.ts (TAGGABLE_RESOURCE_TYPES was duplicated from types.ts and never imported) - Replace silent guard returns in integ tests with explicit assertions - Validate tag key/value against TagKeySchema and TagValueSchema before writing in addTag and setDefaultTag - Add unit tests for key/value validation (empty key, key > 128 chars, value > 256 chars)

- Add Unicode character validation to TagKeySchema and TagValueSchema per AWS tag restrictions (letters, digits, whitespace, _ . : / = + - @) - Improve removeTag error when key is inherited from project defaults: now hints to use "tag remove-defaults" instead - Add tests for character restrictions and updated error messages

notgitika

LGTM

This reverts commit dd9716c.

tejaskash · 2026-03-18T22:43:39Z

Summary

Add agentcore tag command with subcommands: list, add, remove, set-defaults, remove-defaults
Add TagsSchema to project, agent, memory, and gateway schemas (optional, backward compatible)
Auto-tag new projects with agentcore:created-by: agentcore-cli and agentcore:project-name: <name>
Project-level default tags propagate to all resources; per-resource tags override on conflict
Taggable resources: agents, memories, gateways. Credentials are not taggable (deployed via Identity API, not CFN)
No changes to vended CDK code; tag propagation handled by L3 constructs

Companion PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/87

Test plan

Schema unit tests: TagKeySchema, TagValueSchema, TagsSchema validation (11 tests)
Action unit tests: listTags, addTag, removeTag, setDefaultTag, removeDefaultTag (12 tests)
Integration tests: tag command round-trip (create project, add/list/remove tags)
All 2243 existing unit tests pass, snapshots up to date
End-to-end: created project, added tags, deployed, verified tags on AWS resources via CloudFormation template

github-actions · 2026-03-20T17:22:10Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.6%	5169 / 12131
🔵	Statements	42.28%	5485 / 12971
🔵	Functions	42.04%	960 / 2283
🔵	Branches	43.49%	3311 / 7613

Generated in workflow #1152 for commit 4fb09f3 by the Vitest Coverage Report Action

Add `agentcore tag` command for managing AWS resource tags on agents, memories, and gateways. Supports project-level default tags (inherited by all resources) and per-resource tag overrides. - Add TagsSchema to project, agent, memory, and gateway schemas - Add `tag list|add|remove|set-defaults|remove-defaults` subcommands - Auto-tag new projects with `agentcore:created-by` and `agentcore:project-name` - Add unit tests for schema validation and tag actions - Add integration tests for tag command round-trip

aidandaly24

Some comments

- Remove unused constants.ts (TAGGABLE_RESOURCE_TYPES was duplicated from types.ts and never imported) - Replace silent guard returns in integ tests with explicit assertions - Validate tag key/value against TagKeySchema and TagValueSchema before writing in addTag and setDefaultTag - Add unit tests for key/value validation (empty key, key > 128 chars, value > 256 chars)

- Add Unicode character validation to TagKeySchema and TagValueSchema per AWS tag restrictions (letters, digits, whitespace, _ . : / = + - @) - Improve removeTag error when key is inherited from project defaults: now hints to use "tag remove-defaults" instead - Add tests for character restrictions and updated error messages

notgitika

LGTM

This reverts commit dd9716c.

tejaskash · 2026-03-18T22:43:39Z

Summary

Add agentcore tag command with subcommands: list, add, remove, set-defaults, remove-defaults
Add TagsSchema to project, agent, memory, and gateway schemas (optional, backward compatible)
Auto-tag new projects with agentcore:created-by: agentcore-cli and agentcore:project-name: <name>
Project-level default tags propagate to all resources; per-resource tags override on conflict
Taggable resources: agents, memories, gateways. Credentials are not taggable (deployed via Identity API, not CFN)
No changes to vended CDK code; tag propagation handled by L3 constructs

Companion PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/87

Test plan

Schema unit tests: TagKeySchema, TagValueSchema, TagsSchema validation (11 tests)
Action unit tests: listTags, addTag, removeTag, setDefaultTag, removeDefaultTag (12 tests)
Integration tests: tag command round-trip (create project, add/list/remove tags)
All 2243 existing unit tests pass, snapshots up to date
End-to-end: created project, added tags, deployed, verified tags on AWS resources via CloudFormation template

github-actions · 2026-03-20T17:22:10Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.6%	5169 / 12131
🔵	Statements	42.28%	5485 / 12971
🔵	Functions	42.04%	960 / 2283
🔵	Branches	43.49%	3311 / 7613

Generated in workflow #1152 for commit 4fb09f3 by the Vitest Coverage Report Action

Add `agentcore tag` command for managing AWS resource tags on agents, memories, and gateways. Supports project-level default tags (inherited by all resources) and per-resource tag overrides. - Add TagsSchema to project, agent, memory, and gateway schemas - Add `tag list|add|remove|set-defaults|remove-defaults` subcommands - Auto-tag new projects with `agentcore:created-by` and `agentcore:project-name` - Add unit tests for schema validation and tag actions - Add integration tests for tag command round-trip

aidandaly24

Some comments

- Remove unused constants.ts (TAGGABLE_RESOURCE_TYPES was duplicated from types.ts and never imported) - Replace silent guard returns in integ tests with explicit assertions - Validate tag key/value against TagKeySchema and TagValueSchema before writing in addTag and setDefaultTag - Add unit tests for key/value validation (empty key, key > 128 chars, value > 256 chars)

- Add Unicode character validation to TagKeySchema and TagValueSchema per AWS tag restrictions (letters, digits, whitespace, _ . : / = + - @) - Improve removeTag error when key is inherited from project defaults: now hints to use "tag remove-defaults" instead - Add tests for character restrictions and updated error messages

notgitika

LGTM

This reverts commit dd9716c.

tejaskash · 2026-03-18T22:43:39Z

Summary

Add agentcore tag command with subcommands: list, add, remove, set-defaults, remove-defaults
Add TagsSchema to project, agent, memory, and gateway schemas (optional, backward compatible)
Auto-tag new projects with agentcore:created-by: agentcore-cli and agentcore:project-name: <name>
Project-level default tags propagate to all resources; per-resource tags override on conflict
Taggable resources: agents, memories, gateways. Credentials are not taggable (deployed via Identity API, not CFN)
No changes to vended CDK code; tag propagation handled by L3 constructs

Companion PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/87

Test plan

Schema unit tests: TagKeySchema, TagValueSchema, TagsSchema validation (11 tests)
Action unit tests: listTags, addTag, removeTag, setDefaultTag, removeDefaultTag (12 tests)
Integration tests: tag command round-trip (create project, add/list/remove tags)
All 2243 existing unit tests pass, snapshots up to date
End-to-end: created project, added tags, deployed, verified tags on AWS resources via CloudFormation template

github-actions · 2026-03-20T17:22:10Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.6%	5169 / 12131
🔵	Statements	42.28%	5485 / 12971
🔵	Functions	42.04%	960 / 2283
🔵	Branches	43.49%	3311 / 7613

Generated in workflow #1152 for commit 4fb09f3 by the Vitest Coverage Report Action

Add `agentcore tag` command for managing AWS resource tags on agents, memories, and gateways. Supports project-level default tags (inherited by all resources) and per-resource tag overrides. - Add TagsSchema to project, agent, memory, and gateway schemas - Add `tag list|add|remove|set-defaults|remove-defaults` subcommands - Auto-tag new projects with `agentcore:created-by` and `agentcore:project-name` - Add unit tests for schema validation and tag actions - Add integration tests for tag command round-trip

aidandaly24

Some comments

- Remove unused constants.ts (TAGGABLE_RESOURCE_TYPES was duplicated from types.ts and never imported) - Replace silent guard returns in integ tests with explicit assertions - Validate tag key/value against TagKeySchema and TagValueSchema before writing in addTag and setDefaultTag - Add unit tests for key/value validation (empty key, key > 128 chars, value > 256 chars)

- Add Unicode character validation to TagKeySchema and TagValueSchema per AWS tag restrictions (letters, digits, whitespace, _ . : / = + - @) - Improve removeTag error when key is inherited from project defaults: now hints to use "tag remove-defaults" instead - Add tests for character restrictions and updated error messages

notgitika

LGTM

This reverts commit dd9716c.

tejaskash · 2026-03-18T22:43:39Z

Summary

Add agentcore tag command with subcommands: list, add, remove, set-defaults, remove-defaults
Add TagsSchema to project, agent, memory, and gateway schemas (optional, backward compatible)
Auto-tag new projects with agentcore:created-by: agentcore-cli and agentcore:project-name: <name>
Project-level default tags propagate to all resources; per-resource tags override on conflict
Taggable resources: agents, memories, gateways. Credentials are not taggable (deployed via Identity API, not CFN)
No changes to vended CDK code; tag propagation handled by L3 constructs

Companion PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/87

Test plan

Schema unit tests: TagKeySchema, TagValueSchema, TagsSchema validation (11 tests)
Action unit tests: listTags, addTag, removeTag, setDefaultTag, removeDefaultTag (12 tests)
Integration tests: tag command round-trip (create project, add/list/remove tags)
All 2243 existing unit tests pass, snapshots up to date
End-to-end: created project, added tags, deployed, verified tags on AWS resources via CloudFormation template

github-actions · 2026-03-20T17:22:10Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.6%	5169 / 12131
🔵	Statements	42.28%	5485 / 12971
🔵	Functions	42.04%	960 / 2283
🔵	Branches	43.49%	3311 / 7613

Generated in workflow #1152 for commit 4fb09f3 by the Vitest Coverage Report Action

Add `agentcore tag` command for managing AWS resource tags on agents, memories, and gateways. Supports project-level default tags (inherited by all resources) and per-resource tag overrides. - Add TagsSchema to project, agent, memory, and gateway schemas - Add `tag list|add|remove|set-defaults|remove-defaults` subcommands - Auto-tag new projects with `agentcore:created-by` and `agentcore:project-name` - Add unit tests for schema validation and tag actions - Add integration tests for tag command round-trip

aidandaly24

Some comments

- Remove unused constants.ts (TAGGABLE_RESOURCE_TYPES was duplicated from types.ts and never imported) - Replace silent guard returns in integ tests with explicit assertions - Validate tag key/value against TagKeySchema and TagValueSchema before writing in addTag and setDefaultTag - Add unit tests for key/value validation (empty key, key > 128 chars, value > 256 chars)

- Add Unicode character validation to TagKeySchema and TagValueSchema per AWS tag restrictions (letters, digits, whitespace, _ . : / = + - @) - Improve removeTag error when key is inherited from project defaults: now hints to use "tag remove-defaults" instead - Add tests for character restrictions and updated error messages

notgitika

LGTM

This reverts commit dd9716c.

tejaskash · 2026-03-18T22:43:39Z

Summary

Add agentcore tag command with subcommands: list, add, remove, set-defaults, remove-defaults
Add TagsSchema to project, agent, memory, and gateway schemas (optional, backward compatible)
Auto-tag new projects with agentcore:created-by: agentcore-cli and agentcore:project-name: <name>
Project-level default tags propagate to all resources; per-resource tags override on conflict
Taggable resources: agents, memories, gateways. Credentials are not taggable (deployed via Identity API, not CFN)
No changes to vended CDK code; tag propagation handled by L3 constructs

Companion PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/87

Test plan

Schema unit tests: TagKeySchema, TagValueSchema, TagsSchema validation (11 tests)
Action unit tests: listTags, addTag, removeTag, setDefaultTag, removeDefaultTag (12 tests)
Integration tests: tag command round-trip (create project, add/list/remove tags)
All 2243 existing unit tests pass, snapshots up to date
End-to-end: created project, added tags, deployed, verified tags on AWS resources via CloudFormation template

github-actions · 2026-03-20T17:22:10Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.6%	5169 / 12131
🔵	Statements	42.28%	5485 / 12971
🔵	Functions	42.04%	960 / 2283
🔵	Branches	43.49%	3311 / 7613

Generated in workflow #1152 for commit 4fb09f3 by the Vitest Coverage Report Action

Add `agentcore tag` command for managing AWS resource tags on agents, memories, and gateways. Supports project-level default tags (inherited by all resources) and per-resource tag overrides. - Add TagsSchema to project, agent, memory, and gateway schemas - Add `tag list|add|remove|set-defaults|remove-defaults` subcommands - Auto-tag new projects with `agentcore:created-by` and `agentcore:project-name` - Add unit tests for schema validation and tag actions - Add integration tests for tag command round-trip

aidandaly24

Some comments

- Remove unused constants.ts (TAGGABLE_RESOURCE_TYPES was duplicated from types.ts and never imported) - Replace silent guard returns in integ tests with explicit assertions - Validate tag key/value against TagKeySchema and TagValueSchema before writing in addTag and setDefaultTag - Add unit tests for key/value validation (empty key, key > 128 chars, value > 256 chars)

- Add Unicode character validation to TagKeySchema and TagValueSchema per AWS tag restrictions (letters, digits, whitespace, _ . : / = + - @) - Improve removeTag error when key is inherited from project defaults: now hints to use "tag remove-defaults" instead - Add tests for character restrictions and updated error messages

notgitika

LGTM

This reverts commit dd9716c.

tejaskash requested a review from a teamMarch 18, 2026 22:43

github-actionsBot added the size/l PR size: L label Mar 18, 2026

tejaskash temporarily deployed to e2e-testing March 18, 2026 22:43 — with GitHub Actions Inactive

tejaskash force-pushed the feat/resource-tagging branch from 10a7dcb to 716db40Compare March 20, 2026 17:17

github-actionsBot added size/l PR size: L and removed size/l PR size: L labels Mar 20, 2026

tejaskash had a problem deploying to e2e-testing March 20, 2026 17:17 — with GitHub Actions Failure

tejaskash had a problem deploying to e2e-testing March 20, 2026 17:36 — with GitHub Actions Failure

tejaskash force-pushed the feat/resource-tagging branch from 716db40 to 25d2d4eCompare March 20, 2026 17:40

github-actionsBot added size/l PR size: L and removed size/l PR size: L labels Mar 20, 2026

tejaskash had a problem deploying to e2e-testing March 20, 2026 17:43 — with GitHub Actions Failure

tejaskash force-pushed the feat/resource-tagging branch from 25d2d4e to 0f3095dCompare March 23, 2026 15:11

github-actionsBot added size/l PR size: L and removed size/l PR size: L labels Mar 23, 2026

tejaskash temporarily deployed to e2e-testing March 23, 2026 15:11 — with GitHub Actions Inactive

tejaskash force-pushed the feat/resource-tagging branch from 0f3095d to e8eddc8Compare March 23, 2026 17:30

github-actionsBot removed the size/l PR size: L label Mar 23, 2026

tejaskash had a problem deploying to e2e-testing March 23, 2026 17:30 — with GitHub Actions Failure

github-actionsBot added the size/l PR size: L label Mar 23, 2026

style: fix prettier formatting in primitives/index.ts
d71b345

tejaskash had a problem deploying to e2e-testing March 23, 2026 17:37 — with GitHub Actions Failure

github-actionsBot added size/l PR size: L and removed size/l PR size: L labels Mar 23, 2026

notgitika requested changes Mar 23, 2026
View reviewed changes

Comment threadsrc/cli/commands/tag/constants.ts Outdated
Comment threadinteg-tests/tag.test.ts Outdated
Comment threadsrc/cli/commands/tag/action.ts

aidandaly24 requested changes Mar 23, 2026
View reviewed changes

tejaskash had a problem deploying to e2e-testing March 23, 2026 17:50 — with GitHub Actions Failure

github-actionsBot added size/l PR size: L and removed size/l PR size: L labels Mar 23, 2026

tejaskash had a problem deploying to e2e-testing March 23, 2026 18:00 — with GitHub Actions Failure

github-actionsBot added size/l PR size: L and removed size/l PR size: L labels Mar 23, 2026

style: fix prettier formatting in tag files
4fb09f3

tejaskash had a problem deploying to e2e-testing March 23, 2026 18:16 — with GitHub Actions Failure

github-actionsBot added size/l PR size: L and removed size/l PR size: L labels Mar 23, 2026

aidandaly24 approved these changes Mar 23, 2026
View reviewed changes

notgitika self-requested a review March 23, 2026 20:24

notgitika approved these changes Mar 23, 2026
View reviewed changes

tejaskash merged commit dd9716c into mainMar 23, 2026
19 of 20 checks passed

tejaskash deleted the feat/resource-tagging branch March 23, 2026 20:26

jesseturner21 added a commit that referenced this pull request Mar 23, 2026
Revert "feat: add resource tagging support (#564)"
a25080d
This reverts commit dd9716c.

jesseturner21 mentioned this pull request Mar 23, 2026
Revert resource tagging support #612
Merged
2 tasks

aidandaly24 pushed a commit that referenced this pull request Mar 23, 2026
Revert "feat: add resource tagging support (#564)" (#612)
b62ca3a
This reverts commit dd9716c.