Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49be7fe
feat(import): add evaluator import subcommand with TUI wizard
jesseturner21 Apr 3, 2026
6f676d9
fix(import): use correct importType for evaluator in TUI flow
jesseturner21 Apr 3, 2026
6ca4030
feat(import): add online eval config import subcommand
jesseturner21 Apr 3, 2026
e21718f
feat(import): add online eval config to TUI import wizard
jesseturner21 Apr 3, 2026
cb4c675
docs: add TUI import wizard screenshots for online eval
jesseturner21 Apr 3, 2026
915b6c2
Revert "docs: add TUI import wizard screenshots for online eval"
jesseturner21 Apr 3, 2026
385f416
refactor(import): extract generic import orchestrator with descriptor…
jesseturner21 Apr 6, 2026
1f1b62c
refactor(aws): extract paginateAll and fetchTags helpers in agentcore…
jesseturner21 Apr 6, 2026
b2b3630
fix(import): resolve evaluator references via deployed state for impo…
jesseturner21 Apr 6, 2026
5839391
fix(import): auto-disable online eval configs to unlock evaluators du…
jesseturner21 Apr 6, 2026
1cadfc7
Revert "fix(import): auto-disable online eval configs to unlock evalu…
jesseturner21 Apr 6, 2026
5bed8ed
fix(import): block evaluator import when referenced by online eval, u…
jesseturner21 Apr 6, 2026
7bf2aee
fix(import): resolve OEC agent reference via deployed state when runt…
jesseturner21 Apr 6, 2026
1506e14
fix(import): strip CDK project prefix from OEC service name when reso…
jesseturner21 Apr 6, 2026
f5cbb56
fix(import): show friendly error for non-existent evaluator ID
jesseturner21 Apr 6, 2026
5f2a213
fix(import): validate ARN resource type for online-eval import
jesseturner21 Apr 6, 2026
612c7ac
refactor(import): address PR review feedback
jesseturner21 Apr 7, 2026
426d782
test(import): remove unreachable empty-level evaluator test
jesseturner21 Apr 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 234 additions & 51 deletions src/cli/aws/agentcore-control.ts

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts

Large diffs are not rendered by default.

368 changes: 368 additions & 0 deletions src/cli/commands/import/__tests__/import-online-eval.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,368 @@
/**
* Import Online Eval Config Unit Tests
*
* Covers:
* - extractAgentName: service name parsing
* - toOnlineEvalConfigSpec conversion: happy path, missing sampling, enableOnCreate
* - Template logical ID lookup for online eval configs
* - Phase 2 import resource list construction for online eval configs
*/
import type { GetOnlineEvalConfigResult } from '../../../aws/agentcore-control';
import { extractAgentName, toOnlineEvalConfigSpec } from '../import-online-eval';
import { buildImportTemplate, findLogicalIdByProperty, findLogicalIdsByType } from '../template-utils';
import type { CfnTemplate } from '../template-utils';
import type { ResourceToImport } from '../types';
import { describe, expect, it } from 'vitest';

// ============================================================================
// extractAgentName Tests
// ============================================================================

describe('extractAgentName', () => {
it('extracts agent name from service name with .DEFAULT suffix', () => {
expect(extractAgentName(['my_agent.DEFAULT'])).toBe('my_agent');
});

it('extracts agent name with project prefix pattern', () => {
expect(extractAgentName(['testproject_my_agent.DEFAULT'])).toBe('testproject_my_agent');
});

it('returns full string when no dot suffix', () => {
expect(extractAgentName(['my_agent'])).toBe('my_agent');
});

it('returns undefined for empty array', () => {
expect(extractAgentName([])).toBeUndefined();
});

it('uses first service name when multiple provided', () => {
expect(extractAgentName(['agent_one.DEFAULT', 'agent_two.DEFAULT'])).toBe('agent_one');
});

it('handles service name with multiple dots', () => {
expect(extractAgentName(['my.agent.DEFAULT'])).toBe('my.agent');
});
});

// ============================================================================
// toOnlineEvalConfigSpec Conversion Tests
// ============================================================================

describe('toOnlineEvalConfigSpec', () => {
it('maps online eval config with all fields', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-123',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-123',
configName: 'QualityMonitor',
status: 'ACTIVE',
executionStatus: 'ENABLED',
description: 'Monitor agent quality',
samplingPercentage: 50,
serviceNames: ['my_agent.DEFAULT'],
evaluatorIds: ['eval-456'],
};

const result = toOnlineEvalConfigSpec(detail, 'QualityMonitor', 'my_agent', ['my_evaluator']);

expect(result.name).toBe('QualityMonitor');
expect(result.agent).toBe('my_agent');
expect(result.evaluators).toEqual(['my_evaluator']);
expect(result.samplingRate).toBe(50);
expect(result.description).toBe('Monitor agent quality');
expect(result.enableOnCreate).toBe(true);
});

it('omits enableOnCreate when execution status is DISABLED', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-456',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-456',
configName: 'DisabledConfig',
status: 'ACTIVE',
executionStatus: 'DISABLED',
samplingPercentage: 10,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'DisabledConfig', 'agent', ['eval_one']);

expect(result.enableOnCreate).toBeUndefined();
});

it('omits description when not present', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-789',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-789',
configName: 'NoDesc',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 25,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'NoDesc', 'agent', ['eval_one']);

expect(result.description).toBeUndefined();
});

it('throws when sampling percentage is missing', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-no-sampling',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-no-sampling',
configName: 'NoSampling',
status: 'ACTIVE',
executionStatus: 'ENABLED',
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

expect(() => toOnlineEvalConfigSpec(detail, 'NoSampling', 'agent', ['eval_one'])).toThrow(
'has no sampling configuration'
);
});

it('supports multiple evaluator references', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-multi',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-multi',
configName: 'MultiEval',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 75,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1', 'eval-2'],
};

const result = toOnlineEvalConfigSpec(detail, 'MultiEval', 'agent', [
'local_eval',
'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-2',
]);

expect(result.evaluators).toHaveLength(2);
expect(result.evaluators[0]).toBe('local_eval');
expect(result.evaluators[1]).toMatch(/^arn:/);
});
});

// ============================================================================
// Template Logical ID Lookup Tests for Online Eval Configs
// ============================================================================

describe('Template Logical ID Lookup for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
MyOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
PrefixedOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'TestProject_PrefixedConfig',
},
},
MyAgentRuntime: {
Type: 'AWS::BedrockAgentCore::Runtime',
Properties: {
AgentRuntimeName: 'TestProject_my_agent',
},
},
MyIAMRole: {
Type: 'AWS::IAM::Role',
Properties: {
RoleName: 'MyRole',
},
},
},
};

it('finds online eval config logical ID by OnlineEvaluationConfigName property', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);
expect(logicalId).toBe('MyOnlineEvalConfig');
});

it('finds prefixed online eval config by full name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'TestProject_PrefixedConfig'
);
expect(logicalId).toBe('PrefixedOnlineEvalConfig');
});

it('finds all online eval config logical IDs by type', () => {
const logicalIds = findLogicalIdsByType(synthTemplate, 'AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(logicalIds).toHaveLength(2);
expect(logicalIds).toContain('MyOnlineEvalConfig');
expect(logicalIds).toContain('PrefixedOnlineEvalConfig');
});

it('returns undefined for non-existent config name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'nonexistent_config'
);
expect(logicalId).toBeUndefined();
});

it('falls back to single online eval config logical ID when name does not match', () => {
const singleConfigTemplate: CfnTemplate = {
Resources: {
OnlyConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'some_config',
},
},
},
};

let logicalId = findLogicalIdByProperty(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'different_name'
);

// Primary lookup fails
expect(logicalId).toBeUndefined();

// Fallback: if there's only one config resource, use it
if (!logicalId) {
const configLogicalIds = findLogicalIdsByType(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig'
);
if (configLogicalIds.length === 1) {
logicalId = configLogicalIds[0];
}
}
expect(logicalId).toBe('OnlyConfig');
});
});

// ============================================================================
// Phase 2 Resource Import List Construction for Online Eval Configs
// ============================================================================

describe('Phase 2: ResourceToImport List Construction for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

it('builds ResourceToImport list for online eval config', () => {
const configName = 'QualityMonitor';
const configId = 'oec-123';

const resourcesToImport: ResourceToImport[] = [];

const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
configName
);

if (logicalId) {
resourcesToImport.push({
resourceType: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
logicalResourceId: logicalId,
resourceIdentifier: { OnlineEvaluationConfigId: configId },
});
}

expect(resourcesToImport).toHaveLength(1);
expect(resourcesToImport[0]!.resourceType).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(resourcesToImport[0]!.logicalResourceId).toBe('OnlineEvalLogicalId');
expect(resourcesToImport[0]!.resourceIdentifier).toEqual({ OnlineEvaluationConfigId: 'oec-123' });
});

it('returns empty list when online eval config not found in template', () => {
const emptyTemplate: CfnTemplate = {
Resources: {
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

const logicalId = findLogicalIdByProperty(
emptyTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);

expect(logicalId).toBeUndefined();
});
});

// ============================================================================
// buildImportTemplate Tests for Online Eval Config Resources
// ============================================================================

describe('buildImportTemplate with Online Eval Config', () => {
it('adds online eval config resource to deployed template with Retain deletion policy', () => {
const deployedTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
},
};

const synthTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
DependsOn: 'ExistingIAMRole',
},
},
};

const importTemplate = buildImportTemplate(deployedTemplate, synthTemplate, ['OnlineEvalLogicalId']);

// Verify online eval config resource was added
expect(importTemplate.Resources.OnlineEvalLogicalId).toBeDefined();
expect(importTemplate.Resources.OnlineEvalLogicalId!.Type).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(importTemplate.Resources.OnlineEvalLogicalId!.DeletionPolicy).toBe('Retain');
expect(importTemplate.Resources.OnlineEvalLogicalId!.UpdateReplacePolicy).toBe('Retain');

// DependsOn should be removed for import
expect(importTemplate.Resources.OnlineEvalLogicalId!.DependsOn).toBeUndefined();

// Original resource should still be there
expect(importTemplate.Resources.ExistingIAMRole).toBeDefined();
});
});
11 changes: 6 additions & 5 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
import { registerImportMemory } from './import-memory';
import { registerImportOnlineEval } from './import-online-eval';
import { registerImportRuntime } from './import-runtime';
import type { Command } from '@commander-js/extra-typings';
import * as fs from 'node:fs';

const green = '\x1b[32m';
const yellow = '\x1b[33m';
const cyan = '\x1b[36m';
const dim = '\x1b[2m';
const reset = '\x1b[0m';
const { green, yellow, cyan, dim, reset } = ANSI;

export const registerImport = (program: Command) => {
const importCmd = program
Expand DownExpand Up@@ -151,4 +150,6 @@ export const registerImport = (program: Command) => {
// Register subcommands for importing individual resource types from AWS
registerImportRuntime(importCmd);
registerImportMemory(importCmd);
registerImportEvaluator(importCmd);
registerImportOnlineEval(importCmd);
};
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49be7fe
feat(import): add evaluator import subcommand with TUI wizard
jesseturner21 Apr 3, 2026
6f676d9
fix(import): use correct importType for evaluator in TUI flow
jesseturner21 Apr 3, 2026
6ca4030
feat(import): add online eval config import subcommand
jesseturner21 Apr 3, 2026
e21718f
feat(import): add online eval config to TUI import wizard
jesseturner21 Apr 3, 2026
cb4c675
docs: add TUI import wizard screenshots for online eval
jesseturner21 Apr 3, 2026
915b6c2
Revert "docs: add TUI import wizard screenshots for online eval"
jesseturner21 Apr 3, 2026
385f416
refactor(import): extract generic import orchestrator with descriptor…
jesseturner21 Apr 6, 2026
1f1b62c
refactor(aws): extract paginateAll and fetchTags helpers in agentcore…
jesseturner21 Apr 6, 2026
b2b3630
fix(import): resolve evaluator references via deployed state for impo…
jesseturner21 Apr 6, 2026
5839391
fix(import): auto-disable online eval configs to unlock evaluators du…
jesseturner21 Apr 6, 2026
1cadfc7
Revert "fix(import): auto-disable online eval configs to unlock evalu…
jesseturner21 Apr 6, 2026
5bed8ed
fix(import): block evaluator import when referenced by online eval, u…
jesseturner21 Apr 6, 2026
7bf2aee
fix(import): resolve OEC agent reference via deployed state when runt…
jesseturner21 Apr 6, 2026
1506e14
fix(import): strip CDK project prefix from OEC service name when reso…
jesseturner21 Apr 6, 2026
f5cbb56
fix(import): show friendly error for non-existent evaluator ID
jesseturner21 Apr 6, 2026
5f2a213
fix(import): validate ARN resource type for online-eval import
jesseturner21 Apr 6, 2026
612c7ac
refactor(import): address PR review feedback
jesseturner21 Apr 7, 2026
426d782
test(import): remove unreachable empty-level evaluator test
jesseturner21 Apr 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 234 additions & 51 deletions src/cli/aws/agentcore-control.ts

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts

Large diffs are not rendered by default.

368 changes: 368 additions & 0 deletions src/cli/commands/import/__tests__/import-online-eval.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,368 @@
/**
* Import Online Eval Config Unit Tests
*
* Covers:
* - extractAgentName: service name parsing
* - toOnlineEvalConfigSpec conversion: happy path, missing sampling, enableOnCreate
* - Template logical ID lookup for online eval configs
* - Phase 2 import resource list construction for online eval configs
*/
import type { GetOnlineEvalConfigResult } from '../../../aws/agentcore-control';
import { extractAgentName, toOnlineEvalConfigSpec } from '../import-online-eval';
import { buildImportTemplate, findLogicalIdByProperty, findLogicalIdsByType } from '../template-utils';
import type { CfnTemplate } from '../template-utils';
import type { ResourceToImport } from '../types';
import { describe, expect, it } from 'vitest';

// ============================================================================
// extractAgentName Tests
// ============================================================================

describe('extractAgentName', () => {
it('extracts agent name from service name with .DEFAULT suffix', () => {
expect(extractAgentName(['my_agent.DEFAULT'])).toBe('my_agent');
});

it('extracts agent name with project prefix pattern', () => {
expect(extractAgentName(['testproject_my_agent.DEFAULT'])).toBe('testproject_my_agent');
});

it('returns full string when no dot suffix', () => {
expect(extractAgentName(['my_agent'])).toBe('my_agent');
});

it('returns undefined for empty array', () => {
expect(extractAgentName([])).toBeUndefined();
});

it('uses first service name when multiple provided', () => {
expect(extractAgentName(['agent_one.DEFAULT', 'agent_two.DEFAULT'])).toBe('agent_one');
});

it('handles service name with multiple dots', () => {
expect(extractAgentName(['my.agent.DEFAULT'])).toBe('my.agent');
});
});

// ============================================================================
// toOnlineEvalConfigSpec Conversion Tests
// ============================================================================

describe('toOnlineEvalConfigSpec', () => {
it('maps online eval config with all fields', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-123',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-123',
configName: 'QualityMonitor',
status: 'ACTIVE',
executionStatus: 'ENABLED',
description: 'Monitor agent quality',
samplingPercentage: 50,
serviceNames: ['my_agent.DEFAULT'],
evaluatorIds: ['eval-456'],
};

const result = toOnlineEvalConfigSpec(detail, 'QualityMonitor', 'my_agent', ['my_evaluator']);

expect(result.name).toBe('QualityMonitor');
expect(result.agent).toBe('my_agent');
expect(result.evaluators).toEqual(['my_evaluator']);
expect(result.samplingRate).toBe(50);
expect(result.description).toBe('Monitor agent quality');
expect(result.enableOnCreate).toBe(true);
});

it('omits enableOnCreate when execution status is DISABLED', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-456',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-456',
configName: 'DisabledConfig',
status: 'ACTIVE',
executionStatus: 'DISABLED',
samplingPercentage: 10,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'DisabledConfig', 'agent', ['eval_one']);

expect(result.enableOnCreate).toBeUndefined();
});

it('omits description when not present', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-789',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-789',
configName: 'NoDesc',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 25,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'NoDesc', 'agent', ['eval_one']);

expect(result.description).toBeUndefined();
});

it('throws when sampling percentage is missing', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-no-sampling',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-no-sampling',
configName: 'NoSampling',
status: 'ACTIVE',
executionStatus: 'ENABLED',
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

expect(() => toOnlineEvalConfigSpec(detail, 'NoSampling', 'agent', ['eval_one'])).toThrow(
'has no sampling configuration'
);
});

it('supports multiple evaluator references', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-multi',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-multi',
configName: 'MultiEval',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 75,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1', 'eval-2'],
};

const result = toOnlineEvalConfigSpec(detail, 'MultiEval', 'agent', [
'local_eval',
'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-2',
]);

expect(result.evaluators).toHaveLength(2);
expect(result.evaluators[0]).toBe('local_eval');
expect(result.evaluators[1]).toMatch(/^arn:/);
});
});

// ============================================================================
// Template Logical ID Lookup Tests for Online Eval Configs
// ============================================================================

describe('Template Logical ID Lookup for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
MyOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
PrefixedOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'TestProject_PrefixedConfig',
},
},
MyAgentRuntime: {
Type: 'AWS::BedrockAgentCore::Runtime',
Properties: {
AgentRuntimeName: 'TestProject_my_agent',
},
},
MyIAMRole: {
Type: 'AWS::IAM::Role',
Properties: {
RoleName: 'MyRole',
},
},
},
};

it('finds online eval config logical ID by OnlineEvaluationConfigName property', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);
expect(logicalId).toBe('MyOnlineEvalConfig');
});

it('finds prefixed online eval config by full name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'TestProject_PrefixedConfig'
);
expect(logicalId).toBe('PrefixedOnlineEvalConfig');
});

it('finds all online eval config logical IDs by type', () => {
const logicalIds = findLogicalIdsByType(synthTemplate, 'AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(logicalIds).toHaveLength(2);
expect(logicalIds).toContain('MyOnlineEvalConfig');
expect(logicalIds).toContain('PrefixedOnlineEvalConfig');
});

it('returns undefined for non-existent config name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'nonexistent_config'
);
expect(logicalId).toBeUndefined();
});

it('falls back to single online eval config logical ID when name does not match', () => {
const singleConfigTemplate: CfnTemplate = {
Resources: {
OnlyConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'some_config',
},
},
},
};

let logicalId = findLogicalIdByProperty(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'different_name'
);

// Primary lookup fails
expect(logicalId).toBeUndefined();

// Fallback: if there's only one config resource, use it
if (!logicalId) {
const configLogicalIds = findLogicalIdsByType(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig'
);
if (configLogicalIds.length === 1) {
logicalId = configLogicalIds[0];
}
}
expect(logicalId).toBe('OnlyConfig');
});
});

// ============================================================================
// Phase 2 Resource Import List Construction for Online Eval Configs
// ============================================================================

describe('Phase 2: ResourceToImport List Construction for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

it('builds ResourceToImport list for online eval config', () => {
const configName = 'QualityMonitor';
const configId = 'oec-123';

const resourcesToImport: ResourceToImport[] = [];

const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
configName
);

if (logicalId) {
resourcesToImport.push({
resourceType: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
logicalResourceId: logicalId,
resourceIdentifier: { OnlineEvaluationConfigId: configId },
});
}

expect(resourcesToImport).toHaveLength(1);
expect(resourcesToImport[0]!.resourceType).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(resourcesToImport[0]!.logicalResourceId).toBe('OnlineEvalLogicalId');
expect(resourcesToImport[0]!.resourceIdentifier).toEqual({ OnlineEvaluationConfigId: 'oec-123' });
});

it('returns empty list when online eval config not found in template', () => {
const emptyTemplate: CfnTemplate = {
Resources: {
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

const logicalId = findLogicalIdByProperty(
emptyTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);

expect(logicalId).toBeUndefined();
});
});

// ============================================================================
// buildImportTemplate Tests for Online Eval Config Resources
// ============================================================================

describe('buildImportTemplate with Online Eval Config', () => {
it('adds online eval config resource to deployed template with Retain deletion policy', () => {
const deployedTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
},
};

const synthTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
DependsOn: 'ExistingIAMRole',
},
},
};

const importTemplate = buildImportTemplate(deployedTemplate, synthTemplate, ['OnlineEvalLogicalId']);

// Verify online eval config resource was added
expect(importTemplate.Resources.OnlineEvalLogicalId).toBeDefined();
expect(importTemplate.Resources.OnlineEvalLogicalId!.Type).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(importTemplate.Resources.OnlineEvalLogicalId!.DeletionPolicy).toBe('Retain');
expect(importTemplate.Resources.OnlineEvalLogicalId!.UpdateReplacePolicy).toBe('Retain');

// DependsOn should be removed for import
expect(importTemplate.Resources.OnlineEvalLogicalId!.DependsOn).toBeUndefined();

// Original resource should still be there
expect(importTemplate.Resources.ExistingIAMRole).toBeDefined();
});
});
11 changes: 6 additions & 5 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
import { registerImportMemory } from './import-memory';
import { registerImportOnlineEval } from './import-online-eval';
import { registerImportRuntime } from './import-runtime';
import type { Command } from '@commander-js/extra-typings';
import * as fs from 'node:fs';

const green = '\x1b[32m';
const yellow = '\x1b[33m';
const cyan = '\x1b[36m';
const dim = '\x1b[2m';
const reset = '\x1b[0m';
const { green, yellow, cyan, dim, reset } = ANSI;

export const registerImport = (program: Command) => {
const importCmd = program
Expand DownExpand Up@@ -151,4 +150,6 @@ export const registerImport = (program: Command) => {
// Register subcommands for importing individual resource types from AWS
registerImportRuntime(importCmd);
registerImportMemory(importCmd);
registerImportEvaluator(importCmd);
registerImportOnlineEval(importCmd);
};
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49be7fe
feat(import): add evaluator import subcommand with TUI wizard
jesseturner21 Apr 3, 2026
6f676d9
fix(import): use correct importType for evaluator in TUI flow
jesseturner21 Apr 3, 2026
6ca4030
feat(import): add online eval config import subcommand
jesseturner21 Apr 3, 2026
e21718f
feat(import): add online eval config to TUI import wizard
jesseturner21 Apr 3, 2026
cb4c675
docs: add TUI import wizard screenshots for online eval
jesseturner21 Apr 3, 2026
915b6c2
Revert "docs: add TUI import wizard screenshots for online eval"
jesseturner21 Apr 3, 2026
385f416
refactor(import): extract generic import orchestrator with descriptor…
jesseturner21 Apr 6, 2026
1f1b62c
refactor(aws): extract paginateAll and fetchTags helpers in agentcore…
jesseturner21 Apr 6, 2026
b2b3630
fix(import): resolve evaluator references via deployed state for impo…
jesseturner21 Apr 6, 2026
5839391
fix(import): auto-disable online eval configs to unlock evaluators du…
jesseturner21 Apr 6, 2026
1cadfc7
Revert "fix(import): auto-disable online eval configs to unlock evalu…
jesseturner21 Apr 6, 2026
5bed8ed
fix(import): block evaluator import when referenced by online eval, u…
jesseturner21 Apr 6, 2026
7bf2aee
fix(import): resolve OEC agent reference via deployed state when runt…
jesseturner21 Apr 6, 2026
1506e14
fix(import): strip CDK project prefix from OEC service name when reso…
jesseturner21 Apr 6, 2026
f5cbb56
fix(import): show friendly error for non-existent evaluator ID
jesseturner21 Apr 6, 2026
5f2a213
fix(import): validate ARN resource type for online-eval import
jesseturner21 Apr 6, 2026
612c7ac
refactor(import): address PR review feedback
jesseturner21 Apr 7, 2026
426d782
test(import): remove unreachable empty-level evaluator test
jesseturner21 Apr 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 234 additions & 51 deletions src/cli/aws/agentcore-control.ts

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts

Large diffs are not rendered by default.

368 changes: 368 additions & 0 deletions src/cli/commands/import/__tests__/import-online-eval.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,368 @@
/**
* Import Online Eval Config Unit Tests
*
* Covers:
* - extractAgentName: service name parsing
* - toOnlineEvalConfigSpec conversion: happy path, missing sampling, enableOnCreate
* - Template logical ID lookup for online eval configs
* - Phase 2 import resource list construction for online eval configs
*/
import type { GetOnlineEvalConfigResult } from '../../../aws/agentcore-control';
import { extractAgentName, toOnlineEvalConfigSpec } from '../import-online-eval';
import { buildImportTemplate, findLogicalIdByProperty, findLogicalIdsByType } from '../template-utils';
import type { CfnTemplate } from '../template-utils';
import type { ResourceToImport } from '../types';
import { describe, expect, it } from 'vitest';

// ============================================================================
// extractAgentName Tests
// ============================================================================

describe('extractAgentName', () => {
it('extracts agent name from service name with .DEFAULT suffix', () => {
expect(extractAgentName(['my_agent.DEFAULT'])).toBe('my_agent');
});

it('extracts agent name with project prefix pattern', () => {
expect(extractAgentName(['testproject_my_agent.DEFAULT'])).toBe('testproject_my_agent');
});

it('returns full string when no dot suffix', () => {
expect(extractAgentName(['my_agent'])).toBe('my_agent');
});

it('returns undefined for empty array', () => {
expect(extractAgentName([])).toBeUndefined();
});

it('uses first service name when multiple provided', () => {
expect(extractAgentName(['agent_one.DEFAULT', 'agent_two.DEFAULT'])).toBe('agent_one');
});

it('handles service name with multiple dots', () => {
expect(extractAgentName(['my.agent.DEFAULT'])).toBe('my.agent');
});
});

// ============================================================================
// toOnlineEvalConfigSpec Conversion Tests
// ============================================================================

describe('toOnlineEvalConfigSpec', () => {
it('maps online eval config with all fields', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-123',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-123',
configName: 'QualityMonitor',
status: 'ACTIVE',
executionStatus: 'ENABLED',
description: 'Monitor agent quality',
samplingPercentage: 50,
serviceNames: ['my_agent.DEFAULT'],
evaluatorIds: ['eval-456'],
};

const result = toOnlineEvalConfigSpec(detail, 'QualityMonitor', 'my_agent', ['my_evaluator']);

expect(result.name).toBe('QualityMonitor');
expect(result.agent).toBe('my_agent');
expect(result.evaluators).toEqual(['my_evaluator']);
expect(result.samplingRate).toBe(50);
expect(result.description).toBe('Monitor agent quality');
expect(result.enableOnCreate).toBe(true);
});

it('omits enableOnCreate when execution status is DISABLED', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-456',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-456',
configName: 'DisabledConfig',
status: 'ACTIVE',
executionStatus: 'DISABLED',
samplingPercentage: 10,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'DisabledConfig', 'agent', ['eval_one']);

expect(result.enableOnCreate).toBeUndefined();
});

it('omits description when not present', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-789',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-789',
configName: 'NoDesc',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 25,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'NoDesc', 'agent', ['eval_one']);

expect(result.description).toBeUndefined();
});

it('throws when sampling percentage is missing', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-no-sampling',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-no-sampling',
configName: 'NoSampling',
status: 'ACTIVE',
executionStatus: 'ENABLED',
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

expect(() => toOnlineEvalConfigSpec(detail, 'NoSampling', 'agent', ['eval_one'])).toThrow(
'has no sampling configuration'
);
});

it('supports multiple evaluator references', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-multi',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-multi',
configName: 'MultiEval',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 75,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1', 'eval-2'],
};

const result = toOnlineEvalConfigSpec(detail, 'MultiEval', 'agent', [
'local_eval',
'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-2',
]);

expect(result.evaluators).toHaveLength(2);
expect(result.evaluators[0]).toBe('local_eval');
expect(result.evaluators[1]).toMatch(/^arn:/);
});
});

// ============================================================================
// Template Logical ID Lookup Tests for Online Eval Configs
// ============================================================================

describe('Template Logical ID Lookup for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
MyOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
PrefixedOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'TestProject_PrefixedConfig',
},
},
MyAgentRuntime: {
Type: 'AWS::BedrockAgentCore::Runtime',
Properties: {
AgentRuntimeName: 'TestProject_my_agent',
},
},
MyIAMRole: {
Type: 'AWS::IAM::Role',
Properties: {
RoleName: 'MyRole',
},
},
},
};

it('finds online eval config logical ID by OnlineEvaluationConfigName property', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);
expect(logicalId).toBe('MyOnlineEvalConfig');
});

it('finds prefixed online eval config by full name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'TestProject_PrefixedConfig'
);
expect(logicalId).toBe('PrefixedOnlineEvalConfig');
});

it('finds all online eval config logical IDs by type', () => {
const logicalIds = findLogicalIdsByType(synthTemplate, 'AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(logicalIds).toHaveLength(2);
expect(logicalIds).toContain('MyOnlineEvalConfig');
expect(logicalIds).toContain('PrefixedOnlineEvalConfig');
});

it('returns undefined for non-existent config name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'nonexistent_config'
);
expect(logicalId).toBeUndefined();
});

it('falls back to single online eval config logical ID when name does not match', () => {
const singleConfigTemplate: CfnTemplate = {
Resources: {
OnlyConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'some_config',
},
},
},
};

let logicalId = findLogicalIdByProperty(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'different_name'
);

// Primary lookup fails
expect(logicalId).toBeUndefined();

// Fallback: if there's only one config resource, use it
if (!logicalId) {
const configLogicalIds = findLogicalIdsByType(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig'
);
if (configLogicalIds.length === 1) {
logicalId = configLogicalIds[0];
}
}
expect(logicalId).toBe('OnlyConfig');
});
});

// ============================================================================
// Phase 2 Resource Import List Construction for Online Eval Configs
// ============================================================================

describe('Phase 2: ResourceToImport List Construction for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

it('builds ResourceToImport list for online eval config', () => {
const configName = 'QualityMonitor';
const configId = 'oec-123';

const resourcesToImport: ResourceToImport[] = [];

const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
configName
);

if (logicalId) {
resourcesToImport.push({
resourceType: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
logicalResourceId: logicalId,
resourceIdentifier: { OnlineEvaluationConfigId: configId },
});
}

expect(resourcesToImport).toHaveLength(1);
expect(resourcesToImport[0]!.resourceType).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(resourcesToImport[0]!.logicalResourceId).toBe('OnlineEvalLogicalId');
expect(resourcesToImport[0]!.resourceIdentifier).toEqual({ OnlineEvaluationConfigId: 'oec-123' });
});

it('returns empty list when online eval config not found in template', () => {
const emptyTemplate: CfnTemplate = {
Resources: {
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

const logicalId = findLogicalIdByProperty(
emptyTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);

expect(logicalId).toBeUndefined();
});
});

// ============================================================================
// buildImportTemplate Tests for Online Eval Config Resources
// ============================================================================

describe('buildImportTemplate with Online Eval Config', () => {
it('adds online eval config resource to deployed template with Retain deletion policy', () => {
const deployedTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
},
};

const synthTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
DependsOn: 'ExistingIAMRole',
},
},
};

const importTemplate = buildImportTemplate(deployedTemplate, synthTemplate, ['OnlineEvalLogicalId']);

// Verify online eval config resource was added
expect(importTemplate.Resources.OnlineEvalLogicalId).toBeDefined();
expect(importTemplate.Resources.OnlineEvalLogicalId!.Type).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(importTemplate.Resources.OnlineEvalLogicalId!.DeletionPolicy).toBe('Retain');
expect(importTemplate.Resources.OnlineEvalLogicalId!.UpdateReplacePolicy).toBe('Retain');

// DependsOn should be removed for import
expect(importTemplate.Resources.OnlineEvalLogicalId!.DependsOn).toBeUndefined();

// Original resource should still be there
expect(importTemplate.Resources.ExistingIAMRole).toBeDefined();
});
});
11 changes: 6 additions & 5 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
import { registerImportMemory } from './import-memory';
import { registerImportOnlineEval } from './import-online-eval';
import { registerImportRuntime } from './import-runtime';
import type { Command } from '@commander-js/extra-typings';
import * as fs from 'node:fs';

const green = '\x1b[32m';
const yellow = '\x1b[33m';
const cyan = '\x1b[36m';
const dim = '\x1b[2m';
const reset = '\x1b[0m';
const { green, yellow, cyan, dim, reset } = ANSI;

export const registerImport = (program: Command) => {
const importCmd = program
Expand DownExpand Up@@ -151,4 +150,6 @@ export const registerImport = (program: Command) => {
// Register subcommands for importing individual resource types from AWS
registerImportRuntime(importCmd);
registerImportMemory(importCmd);
registerImportEvaluator(importCmd);
registerImportOnlineEval(importCmd);
};
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49be7fe
feat(import): add evaluator import subcommand with TUI wizard
jesseturner21 Apr 3, 2026
6f676d9
fix(import): use correct importType for evaluator in TUI flow
jesseturner21 Apr 3, 2026
6ca4030
feat(import): add online eval config import subcommand
jesseturner21 Apr 3, 2026
e21718f
feat(import): add online eval config to TUI import wizard
jesseturner21 Apr 3, 2026
cb4c675
docs: add TUI import wizard screenshots for online eval
jesseturner21 Apr 3, 2026
915b6c2
Revert "docs: add TUI import wizard screenshots for online eval"
jesseturner21 Apr 3, 2026
385f416
refactor(import): extract generic import orchestrator with descriptor…
jesseturner21 Apr 6, 2026
1f1b62c
refactor(aws): extract paginateAll and fetchTags helpers in agentcore…
jesseturner21 Apr 6, 2026
b2b3630
fix(import): resolve evaluator references via deployed state for impo…
jesseturner21 Apr 6, 2026
5839391
fix(import): auto-disable online eval configs to unlock evaluators du…
jesseturner21 Apr 6, 2026
1cadfc7
Revert "fix(import): auto-disable online eval configs to unlock evalu…
jesseturner21 Apr 6, 2026
5bed8ed
fix(import): block evaluator import when referenced by online eval, u…
jesseturner21 Apr 6, 2026
7bf2aee
fix(import): resolve OEC agent reference via deployed state when runt…
jesseturner21 Apr 6, 2026
1506e14
fix(import): strip CDK project prefix from OEC service name when reso…
jesseturner21 Apr 6, 2026
f5cbb56
fix(import): show friendly error for non-existent evaluator ID
jesseturner21 Apr 6, 2026
5f2a213
fix(import): validate ARN resource type for online-eval import
jesseturner21 Apr 6, 2026
612c7ac
refactor(import): address PR review feedback
jesseturner21 Apr 7, 2026
426d782
test(import): remove unreachable empty-level evaluator test
jesseturner21 Apr 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 234 additions & 51 deletions src/cli/aws/agentcore-control.ts

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts

Large diffs are not rendered by default.

368 changes: 368 additions & 0 deletions src/cli/commands/import/__tests__/import-online-eval.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,368 @@
/**
* Import Online Eval Config Unit Tests
*
* Covers:
* - extractAgentName: service name parsing
* - toOnlineEvalConfigSpec conversion: happy path, missing sampling, enableOnCreate
* - Template logical ID lookup for online eval configs
* - Phase 2 import resource list construction for online eval configs
*/
import type { GetOnlineEvalConfigResult } from '../../../aws/agentcore-control';
import { extractAgentName, toOnlineEvalConfigSpec } from '../import-online-eval';
import { buildImportTemplate, findLogicalIdByProperty, findLogicalIdsByType } from '../template-utils';
import type { CfnTemplate } from '../template-utils';
import type { ResourceToImport } from '../types';
import { describe, expect, it } from 'vitest';

// ============================================================================
// extractAgentName Tests
// ============================================================================

describe('extractAgentName', () => {
it('extracts agent name from service name with .DEFAULT suffix', () => {
expect(extractAgentName(['my_agent.DEFAULT'])).toBe('my_agent');
});

it('extracts agent name with project prefix pattern', () => {
expect(extractAgentName(['testproject_my_agent.DEFAULT'])).toBe('testproject_my_agent');
});

it('returns full string when no dot suffix', () => {
expect(extractAgentName(['my_agent'])).toBe('my_agent');
});

it('returns undefined for empty array', () => {
expect(extractAgentName([])).toBeUndefined();
});

it('uses first service name when multiple provided', () => {
expect(extractAgentName(['agent_one.DEFAULT', 'agent_two.DEFAULT'])).toBe('agent_one');
});

it('handles service name with multiple dots', () => {
expect(extractAgentName(['my.agent.DEFAULT'])).toBe('my.agent');
});
});

// ============================================================================
// toOnlineEvalConfigSpec Conversion Tests
// ============================================================================

describe('toOnlineEvalConfigSpec', () => {
it('maps online eval config with all fields', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-123',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-123',
configName: 'QualityMonitor',
status: 'ACTIVE',
executionStatus: 'ENABLED',
description: 'Monitor agent quality',
samplingPercentage: 50,
serviceNames: ['my_agent.DEFAULT'],
evaluatorIds: ['eval-456'],
};

const result = toOnlineEvalConfigSpec(detail, 'QualityMonitor', 'my_agent', ['my_evaluator']);

expect(result.name).toBe('QualityMonitor');
expect(result.agent).toBe('my_agent');
expect(result.evaluators).toEqual(['my_evaluator']);
expect(result.samplingRate).toBe(50);
expect(result.description).toBe('Monitor agent quality');
expect(result.enableOnCreate).toBe(true);
});

it('omits enableOnCreate when execution status is DISABLED', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-456',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-456',
configName: 'DisabledConfig',
status: 'ACTIVE',
executionStatus: 'DISABLED',
samplingPercentage: 10,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'DisabledConfig', 'agent', ['eval_one']);

expect(result.enableOnCreate).toBeUndefined();
});

it('omits description when not present', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-789',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-789',
configName: 'NoDesc',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 25,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'NoDesc', 'agent', ['eval_one']);

expect(result.description).toBeUndefined();
});

it('throws when sampling percentage is missing', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-no-sampling',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-no-sampling',
configName: 'NoSampling',
status: 'ACTIVE',
executionStatus: 'ENABLED',
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

expect(() => toOnlineEvalConfigSpec(detail, 'NoSampling', 'agent', ['eval_one'])).toThrow(
'has no sampling configuration'
);
});

it('supports multiple evaluator references', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-multi',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-multi',
configName: 'MultiEval',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 75,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1', 'eval-2'],
};

const result = toOnlineEvalConfigSpec(detail, 'MultiEval', 'agent', [
'local_eval',
'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-2',
]);

expect(result.evaluators).toHaveLength(2);
expect(result.evaluators[0]).toBe('local_eval');
expect(result.evaluators[1]).toMatch(/^arn:/);
});
});

// ============================================================================
// Template Logical ID Lookup Tests for Online Eval Configs
// ============================================================================

describe('Template Logical ID Lookup for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
MyOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
PrefixedOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'TestProject_PrefixedConfig',
},
},
MyAgentRuntime: {
Type: 'AWS::BedrockAgentCore::Runtime',
Properties: {
AgentRuntimeName: 'TestProject_my_agent',
},
},
MyIAMRole: {
Type: 'AWS::IAM::Role',
Properties: {
RoleName: 'MyRole',
},
},
},
};

it('finds online eval config logical ID by OnlineEvaluationConfigName property', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);
expect(logicalId).toBe('MyOnlineEvalConfig');
});

it('finds prefixed online eval config by full name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'TestProject_PrefixedConfig'
);
expect(logicalId).toBe('PrefixedOnlineEvalConfig');
});

it('finds all online eval config logical IDs by type', () => {
const logicalIds = findLogicalIdsByType(synthTemplate, 'AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(logicalIds).toHaveLength(2);
expect(logicalIds).toContain('MyOnlineEvalConfig');
expect(logicalIds).toContain('PrefixedOnlineEvalConfig');
});

it('returns undefined for non-existent config name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'nonexistent_config'
);
expect(logicalId).toBeUndefined();
});

it('falls back to single online eval config logical ID when name does not match', () => {
const singleConfigTemplate: CfnTemplate = {
Resources: {
OnlyConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'some_config',
},
},
},
};

let logicalId = findLogicalIdByProperty(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'different_name'
);

// Primary lookup fails
expect(logicalId).toBeUndefined();

// Fallback: if there's only one config resource, use it
if (!logicalId) {
const configLogicalIds = findLogicalIdsByType(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig'
);
if (configLogicalIds.length === 1) {
logicalId = configLogicalIds[0];
}
}
expect(logicalId).toBe('OnlyConfig');
});
});

// ============================================================================
// Phase 2 Resource Import List Construction for Online Eval Configs
// ============================================================================

describe('Phase 2: ResourceToImport List Construction for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

it('builds ResourceToImport list for online eval config', () => {
const configName = 'QualityMonitor';
const configId = 'oec-123';

const resourcesToImport: ResourceToImport[] = [];

const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
configName
);

if (logicalId) {
resourcesToImport.push({
resourceType: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
logicalResourceId: logicalId,
resourceIdentifier: { OnlineEvaluationConfigId: configId },
});
}

expect(resourcesToImport).toHaveLength(1);
expect(resourcesToImport[0]!.resourceType).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(resourcesToImport[0]!.logicalResourceId).toBe('OnlineEvalLogicalId');
expect(resourcesToImport[0]!.resourceIdentifier).toEqual({ OnlineEvaluationConfigId: 'oec-123' });
});

it('returns empty list when online eval config not found in template', () => {
const emptyTemplate: CfnTemplate = {
Resources: {
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

const logicalId = findLogicalIdByProperty(
emptyTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);

expect(logicalId).toBeUndefined();
});
});

// ============================================================================
// buildImportTemplate Tests for Online Eval Config Resources
// ============================================================================

describe('buildImportTemplate with Online Eval Config', () => {
it('adds online eval config resource to deployed template with Retain deletion policy', () => {
const deployedTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
},
};

const synthTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
DependsOn: 'ExistingIAMRole',
},
},
};

const importTemplate = buildImportTemplate(deployedTemplate, synthTemplate, ['OnlineEvalLogicalId']);

// Verify online eval config resource was added
expect(importTemplate.Resources.OnlineEvalLogicalId).toBeDefined();
expect(importTemplate.Resources.OnlineEvalLogicalId!.Type).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(importTemplate.Resources.OnlineEvalLogicalId!.DeletionPolicy).toBe('Retain');
expect(importTemplate.Resources.OnlineEvalLogicalId!.UpdateReplacePolicy).toBe('Retain');

// DependsOn should be removed for import
expect(importTemplate.Resources.OnlineEvalLogicalId!.DependsOn).toBeUndefined();

// Original resource should still be there
expect(importTemplate.Resources.ExistingIAMRole).toBeDefined();
});
});
11 changes: 6 additions & 5 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
import { registerImportMemory } from './import-memory';
import { registerImportOnlineEval } from './import-online-eval';
import { registerImportRuntime } from './import-runtime';
import type { Command } from '@commander-js/extra-typings';
import * as fs from 'node:fs';

const green = '\x1b[32m';
const yellow = '\x1b[33m';
const cyan = '\x1b[36m';
const dim = '\x1b[2m';
const reset = '\x1b[0m';
const { green, yellow, cyan, dim, reset } = ANSI;

export const registerImport = (program: Command) => {
const importCmd = program
Expand DownExpand Up@@ -151,4 +150,6 @@ export const registerImport = (program: Command) => {
// Register subcommands for importing individual resource types from AWS
registerImportRuntime(importCmd);
registerImportMemory(importCmd);
registerImportEvaluator(importCmd);
registerImportOnlineEval(importCmd);
};
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49be7fe
feat(import): add evaluator import subcommand with TUI wizard
jesseturner21 Apr 3, 2026
6f676d9
fix(import): use correct importType for evaluator in TUI flow
jesseturner21 Apr 3, 2026
6ca4030
feat(import): add online eval config import subcommand
jesseturner21 Apr 3, 2026
e21718f
feat(import): add online eval config to TUI import wizard
jesseturner21 Apr 3, 2026
cb4c675
docs: add TUI import wizard screenshots for online eval
jesseturner21 Apr 3, 2026
915b6c2
Revert "docs: add TUI import wizard screenshots for online eval"
jesseturner21 Apr 3, 2026
385f416
refactor(import): extract generic import orchestrator with descriptor…
jesseturner21 Apr 6, 2026
1f1b62c
refactor(aws): extract paginateAll and fetchTags helpers in agentcore…
jesseturner21 Apr 6, 2026
b2b3630
fix(import): resolve evaluator references via deployed state for impo…
jesseturner21 Apr 6, 2026
5839391
fix(import): auto-disable online eval configs to unlock evaluators du…
jesseturner21 Apr 6, 2026
1cadfc7
Revert "fix(import): auto-disable online eval configs to unlock evalu…
jesseturner21 Apr 6, 2026
5bed8ed
fix(import): block evaluator import when referenced by online eval, u…
jesseturner21 Apr 6, 2026
7bf2aee
fix(import): resolve OEC agent reference via deployed state when runt…
jesseturner21 Apr 6, 2026
1506e14
fix(import): strip CDK project prefix from OEC service name when reso…
jesseturner21 Apr 6, 2026
f5cbb56
fix(import): show friendly error for non-existent evaluator ID
jesseturner21 Apr 6, 2026
5f2a213
fix(import): validate ARN resource type for online-eval import
jesseturner21 Apr 6, 2026
612c7ac
refactor(import): address PR review feedback
jesseturner21 Apr 7, 2026
426d782
test(import): remove unreachable empty-level evaluator test
jesseturner21 Apr 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 234 additions & 51 deletions src/cli/aws/agentcore-control.ts

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts

Large diffs are not rendered by default.

368 changes: 368 additions & 0 deletions src/cli/commands/import/__tests__/import-online-eval.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,368 @@
/**
* Import Online Eval Config Unit Tests
*
* Covers:
* - extractAgentName: service name parsing
* - toOnlineEvalConfigSpec conversion: happy path, missing sampling, enableOnCreate
* - Template logical ID lookup for online eval configs
* - Phase 2 import resource list construction for online eval configs
*/
import type { GetOnlineEvalConfigResult } from '../../../aws/agentcore-control';
import { extractAgentName, toOnlineEvalConfigSpec } from '../import-online-eval';
import { buildImportTemplate, findLogicalIdByProperty, findLogicalIdsByType } from '../template-utils';
import type { CfnTemplate } from '../template-utils';
import type { ResourceToImport } from '../types';
import { describe, expect, it } from 'vitest';

// ============================================================================
// extractAgentName Tests
// ============================================================================

describe('extractAgentName', () => {
it('extracts agent name from service name with .DEFAULT suffix', () => {
expect(extractAgentName(['my_agent.DEFAULT'])).toBe('my_agent');
});

it('extracts agent name with project prefix pattern', () => {
expect(extractAgentName(['testproject_my_agent.DEFAULT'])).toBe('testproject_my_agent');
});

it('returns full string when no dot suffix', () => {
expect(extractAgentName(['my_agent'])).toBe('my_agent');
});

it('returns undefined for empty array', () => {
expect(extractAgentName([])).toBeUndefined();
});

it('uses first service name when multiple provided', () => {
expect(extractAgentName(['agent_one.DEFAULT', 'agent_two.DEFAULT'])).toBe('agent_one');
});

it('handles service name with multiple dots', () => {
expect(extractAgentName(['my.agent.DEFAULT'])).toBe('my.agent');
});
});

// ============================================================================
// toOnlineEvalConfigSpec Conversion Tests
// ============================================================================

describe('toOnlineEvalConfigSpec', () => {
it('maps online eval config with all fields', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-123',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-123',
configName: 'QualityMonitor',
status: 'ACTIVE',
executionStatus: 'ENABLED',
description: 'Monitor agent quality',
samplingPercentage: 50,
serviceNames: ['my_agent.DEFAULT'],
evaluatorIds: ['eval-456'],
};

const result = toOnlineEvalConfigSpec(detail, 'QualityMonitor', 'my_agent', ['my_evaluator']);

expect(result.name).toBe('QualityMonitor');
expect(result.agent).toBe('my_agent');
expect(result.evaluators).toEqual(['my_evaluator']);
expect(result.samplingRate).toBe(50);
expect(result.description).toBe('Monitor agent quality');
expect(result.enableOnCreate).toBe(true);
});

it('omits enableOnCreate when execution status is DISABLED', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-456',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-456',
configName: 'DisabledConfig',
status: 'ACTIVE',
executionStatus: 'DISABLED',
samplingPercentage: 10,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'DisabledConfig', 'agent', ['eval_one']);

expect(result.enableOnCreate).toBeUndefined();
});

it('omits description when not present', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-789',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-789',
configName: 'NoDesc',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 25,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'NoDesc', 'agent', ['eval_one']);

expect(result.description).toBeUndefined();
});

it('throws when sampling percentage is missing', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-no-sampling',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-no-sampling',
configName: 'NoSampling',
status: 'ACTIVE',
executionStatus: 'ENABLED',
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

expect(() => toOnlineEvalConfigSpec(detail, 'NoSampling', 'agent', ['eval_one'])).toThrow(
'has no sampling configuration'
);
});

it('supports multiple evaluator references', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-multi',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-multi',
configName: 'MultiEval',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 75,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1', 'eval-2'],
};

const result = toOnlineEvalConfigSpec(detail, 'MultiEval', 'agent', [
'local_eval',
'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-2',
]);

expect(result.evaluators).toHaveLength(2);
expect(result.evaluators[0]).toBe('local_eval');
expect(result.evaluators[1]).toMatch(/^arn:/);
});
});

// ============================================================================
// Template Logical ID Lookup Tests for Online Eval Configs
// ============================================================================

describe('Template Logical ID Lookup for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
MyOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
PrefixedOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'TestProject_PrefixedConfig',
},
},
MyAgentRuntime: {
Type: 'AWS::BedrockAgentCore::Runtime',
Properties: {
AgentRuntimeName: 'TestProject_my_agent',
},
},
MyIAMRole: {
Type: 'AWS::IAM::Role',
Properties: {
RoleName: 'MyRole',
},
},
},
};

it('finds online eval config logical ID by OnlineEvaluationConfigName property', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);
expect(logicalId).toBe('MyOnlineEvalConfig');
});

it('finds prefixed online eval config by full name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'TestProject_PrefixedConfig'
);
expect(logicalId).toBe('PrefixedOnlineEvalConfig');
});

it('finds all online eval config logical IDs by type', () => {
const logicalIds = findLogicalIdsByType(synthTemplate, 'AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(logicalIds).toHaveLength(2);
expect(logicalIds).toContain('MyOnlineEvalConfig');
expect(logicalIds).toContain('PrefixedOnlineEvalConfig');
});

it('returns undefined for non-existent config name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'nonexistent_config'
);
expect(logicalId).toBeUndefined();
});

it('falls back to single online eval config logical ID when name does not match', () => {
const singleConfigTemplate: CfnTemplate = {
Resources: {
OnlyConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'some_config',
},
},
},
};

let logicalId = findLogicalIdByProperty(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'different_name'
);

// Primary lookup fails
expect(logicalId).toBeUndefined();

// Fallback: if there's only one config resource, use it
if (!logicalId) {
const configLogicalIds = findLogicalIdsByType(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig'
);
if (configLogicalIds.length === 1) {
logicalId = configLogicalIds[0];
}
}
expect(logicalId).toBe('OnlyConfig');
});
});

// ============================================================================
// Phase 2 Resource Import List Construction for Online Eval Configs
// ============================================================================

describe('Phase 2: ResourceToImport List Construction for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

it('builds ResourceToImport list for online eval config', () => {
const configName = 'QualityMonitor';
const configId = 'oec-123';

const resourcesToImport: ResourceToImport[] = [];

const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
configName
);

if (logicalId) {
resourcesToImport.push({
resourceType: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
logicalResourceId: logicalId,
resourceIdentifier: { OnlineEvaluationConfigId: configId },
});
}

expect(resourcesToImport).toHaveLength(1);
expect(resourcesToImport[0]!.resourceType).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(resourcesToImport[0]!.logicalResourceId).toBe('OnlineEvalLogicalId');
expect(resourcesToImport[0]!.resourceIdentifier).toEqual({ OnlineEvaluationConfigId: 'oec-123' });
});

it('returns empty list when online eval config not found in template', () => {
const emptyTemplate: CfnTemplate = {
Resources: {
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

const logicalId = findLogicalIdByProperty(
emptyTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);

expect(logicalId).toBeUndefined();
});
});

// ============================================================================
// buildImportTemplate Tests for Online Eval Config Resources
// ============================================================================

describe('buildImportTemplate with Online Eval Config', () => {
it('adds online eval config resource to deployed template with Retain deletion policy', () => {
const deployedTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
},
};

const synthTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
DependsOn: 'ExistingIAMRole',
},
},
};

const importTemplate = buildImportTemplate(deployedTemplate, synthTemplate, ['OnlineEvalLogicalId']);

// Verify online eval config resource was added
expect(importTemplate.Resources.OnlineEvalLogicalId).toBeDefined();
expect(importTemplate.Resources.OnlineEvalLogicalId!.Type).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(importTemplate.Resources.OnlineEvalLogicalId!.DeletionPolicy).toBe('Retain');
expect(importTemplate.Resources.OnlineEvalLogicalId!.UpdateReplacePolicy).toBe('Retain');

// DependsOn should be removed for import
expect(importTemplate.Resources.OnlineEvalLogicalId!.DependsOn).toBeUndefined();

// Original resource should still be there
expect(importTemplate.Resources.ExistingIAMRole).toBeDefined();
});
});
11 changes: 6 additions & 5 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
import { registerImportMemory } from './import-memory';
import { registerImportOnlineEval } from './import-online-eval';
import { registerImportRuntime } from './import-runtime';
import type { Command } from '@commander-js/extra-typings';
import * as fs from 'node:fs';

const green = '\x1b[32m';
const yellow = '\x1b[33m';
const cyan = '\x1b[36m';
const dim = '\x1b[2m';
const reset = '\x1b[0m';
const { green, yellow, cyan, dim, reset } = ANSI;

export const registerImport = (program: Command) => {
const importCmd = program
Expand DownExpand Up@@ -151,4 +150,6 @@ export const registerImport = (program: Command) => {
// Register subcommands for importing individual resource types from AWS
registerImportRuntime(importCmd);
registerImportMemory(importCmd);
registerImportEvaluator(importCmd);
registerImportOnlineEval(importCmd);
};
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49be7fe
feat(import): add evaluator import subcommand with TUI wizard
jesseturner21 Apr 3, 2026
6f676d9
fix(import): use correct importType for evaluator in TUI flow
jesseturner21 Apr 3, 2026
6ca4030
feat(import): add online eval config import subcommand
jesseturner21 Apr 3, 2026
e21718f
feat(import): add online eval config to TUI import wizard
jesseturner21 Apr 3, 2026
cb4c675
docs: add TUI import wizard screenshots for online eval
jesseturner21 Apr 3, 2026
915b6c2
Revert "docs: add TUI import wizard screenshots for online eval"
jesseturner21 Apr 3, 2026
385f416
refactor(import): extract generic import orchestrator with descriptor…
jesseturner21 Apr 6, 2026
1f1b62c
refactor(aws): extract paginateAll and fetchTags helpers in agentcore…
jesseturner21 Apr 6, 2026
b2b3630
fix(import): resolve evaluator references via deployed state for impo…
jesseturner21 Apr 6, 2026
5839391
fix(import): auto-disable online eval configs to unlock evaluators du…
jesseturner21 Apr 6, 2026
1cadfc7
Revert "fix(import): auto-disable online eval configs to unlock evalu…
jesseturner21 Apr 6, 2026
5bed8ed
fix(import): block evaluator import when referenced by online eval, u…
jesseturner21 Apr 6, 2026
7bf2aee
fix(import): resolve OEC agent reference via deployed state when runt…
jesseturner21 Apr 6, 2026
1506e14
fix(import): strip CDK project prefix from OEC service name when reso…
jesseturner21 Apr 6, 2026
f5cbb56
fix(import): show friendly error for non-existent evaluator ID
jesseturner21 Apr 6, 2026
5f2a213
fix(import): validate ARN resource type for online-eval import
jesseturner21 Apr 6, 2026
612c7ac
refactor(import): address PR review feedback
jesseturner21 Apr 7, 2026
426d782
test(import): remove unreachable empty-level evaluator test
jesseturner21 Apr 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 234 additions & 51 deletions src/cli/aws/agentcore-control.ts

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts

Large diffs are not rendered by default.

368 changes: 368 additions & 0 deletions src/cli/commands/import/__tests__/import-online-eval.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,368 @@
/**
* Import Online Eval Config Unit Tests
*
* Covers:
* - extractAgentName: service name parsing
* - toOnlineEvalConfigSpec conversion: happy path, missing sampling, enableOnCreate
* - Template logical ID lookup for online eval configs
* - Phase 2 import resource list construction for online eval configs
*/
import type { GetOnlineEvalConfigResult } from '../../../aws/agentcore-control';
import { extractAgentName, toOnlineEvalConfigSpec } from '../import-online-eval';
import { buildImportTemplate, findLogicalIdByProperty, findLogicalIdsByType } from '../template-utils';
import type { CfnTemplate } from '../template-utils';
import type { ResourceToImport } from '../types';
import { describe, expect, it } from 'vitest';

// ============================================================================
// extractAgentName Tests
// ============================================================================

describe('extractAgentName', () => {
it('extracts agent name from service name with .DEFAULT suffix', () => {
expect(extractAgentName(['my_agent.DEFAULT'])).toBe('my_agent');
});

it('extracts agent name with project prefix pattern', () => {
expect(extractAgentName(['testproject_my_agent.DEFAULT'])).toBe('testproject_my_agent');
});

it('returns full string when no dot suffix', () => {
expect(extractAgentName(['my_agent'])).toBe('my_agent');
});

it('returns undefined for empty array', () => {
expect(extractAgentName([])).toBeUndefined();
});

it('uses first service name when multiple provided', () => {
expect(extractAgentName(['agent_one.DEFAULT', 'agent_two.DEFAULT'])).toBe('agent_one');
});

it('handles service name with multiple dots', () => {
expect(extractAgentName(['my.agent.DEFAULT'])).toBe('my.agent');
});
});

// ============================================================================
// toOnlineEvalConfigSpec Conversion Tests
// ============================================================================

describe('toOnlineEvalConfigSpec', () => {
it('maps online eval config with all fields', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-123',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-123',
configName: 'QualityMonitor',
status: 'ACTIVE',
executionStatus: 'ENABLED',
description: 'Monitor agent quality',
samplingPercentage: 50,
serviceNames: ['my_agent.DEFAULT'],
evaluatorIds: ['eval-456'],
};

const result = toOnlineEvalConfigSpec(detail, 'QualityMonitor', 'my_agent', ['my_evaluator']);

expect(result.name).toBe('QualityMonitor');
expect(result.agent).toBe('my_agent');
expect(result.evaluators).toEqual(['my_evaluator']);
expect(result.samplingRate).toBe(50);
expect(result.description).toBe('Monitor agent quality');
expect(result.enableOnCreate).toBe(true);
});

it('omits enableOnCreate when execution status is DISABLED', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-456',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-456',
configName: 'DisabledConfig',
status: 'ACTIVE',
executionStatus: 'DISABLED',
samplingPercentage: 10,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'DisabledConfig', 'agent', ['eval_one']);

expect(result.enableOnCreate).toBeUndefined();
});

it('omits description when not present', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-789',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-789',
configName: 'NoDesc',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 25,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'NoDesc', 'agent', ['eval_one']);

expect(result.description).toBeUndefined();
});

it('throws when sampling percentage is missing', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-no-sampling',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-no-sampling',
configName: 'NoSampling',
status: 'ACTIVE',
executionStatus: 'ENABLED',
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

expect(() => toOnlineEvalConfigSpec(detail, 'NoSampling', 'agent', ['eval_one'])).toThrow(
'has no sampling configuration'
);
});

it('supports multiple evaluator references', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-multi',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-multi',
configName: 'MultiEval',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 75,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1', 'eval-2'],
};

const result = toOnlineEvalConfigSpec(detail, 'MultiEval', 'agent', [
'local_eval',
'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-2',
]);

expect(result.evaluators).toHaveLength(2);
expect(result.evaluators[0]).toBe('local_eval');
expect(result.evaluators[1]).toMatch(/^arn:/);
});
});

// ============================================================================
// Template Logical ID Lookup Tests for Online Eval Configs
// ============================================================================

describe('Template Logical ID Lookup for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
MyOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
PrefixedOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'TestProject_PrefixedConfig',
},
},
MyAgentRuntime: {
Type: 'AWS::BedrockAgentCore::Runtime',
Properties: {
AgentRuntimeName: 'TestProject_my_agent',
},
},
MyIAMRole: {
Type: 'AWS::IAM::Role',
Properties: {
RoleName: 'MyRole',
},
},
},
};

it('finds online eval config logical ID by OnlineEvaluationConfigName property', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);
expect(logicalId).toBe('MyOnlineEvalConfig');
});

it('finds prefixed online eval config by full name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'TestProject_PrefixedConfig'
);
expect(logicalId).toBe('PrefixedOnlineEvalConfig');
});

it('finds all online eval config logical IDs by type', () => {
const logicalIds = findLogicalIdsByType(synthTemplate, 'AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(logicalIds).toHaveLength(2);
expect(logicalIds).toContain('MyOnlineEvalConfig');
expect(logicalIds).toContain('PrefixedOnlineEvalConfig');
});

it('returns undefined for non-existent config name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'nonexistent_config'
);
expect(logicalId).toBeUndefined();
});

it('falls back to single online eval config logical ID when name does not match', () => {
const singleConfigTemplate: CfnTemplate = {
Resources: {
OnlyConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'some_config',
},
},
},
};

let logicalId = findLogicalIdByProperty(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'different_name'
);

// Primary lookup fails
expect(logicalId).toBeUndefined();

// Fallback: if there's only one config resource, use it
if (!logicalId) {
const configLogicalIds = findLogicalIdsByType(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig'
);
if (configLogicalIds.length === 1) {
logicalId = configLogicalIds[0];
}
}
expect(logicalId).toBe('OnlyConfig');
});
});

// ============================================================================
// Phase 2 Resource Import List Construction for Online Eval Configs
// ============================================================================

describe('Phase 2: ResourceToImport List Construction for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

it('builds ResourceToImport list for online eval config', () => {
const configName = 'QualityMonitor';
const configId = 'oec-123';

const resourcesToImport: ResourceToImport[] = [];

const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
configName
);

if (logicalId) {
resourcesToImport.push({
resourceType: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
logicalResourceId: logicalId,
resourceIdentifier: { OnlineEvaluationConfigId: configId },
});
}

expect(resourcesToImport).toHaveLength(1);
expect(resourcesToImport[0]!.resourceType).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(resourcesToImport[0]!.logicalResourceId).toBe('OnlineEvalLogicalId');
expect(resourcesToImport[0]!.resourceIdentifier).toEqual({ OnlineEvaluationConfigId: 'oec-123' });
});

it('returns empty list when online eval config not found in template', () => {
const emptyTemplate: CfnTemplate = {
Resources: {
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

const logicalId = findLogicalIdByProperty(
emptyTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);

expect(logicalId).toBeUndefined();
});
});

// ============================================================================
// buildImportTemplate Tests for Online Eval Config Resources
// ============================================================================

describe('buildImportTemplate with Online Eval Config', () => {
it('adds online eval config resource to deployed template with Retain deletion policy', () => {
const deployedTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
},
};

const synthTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
DependsOn: 'ExistingIAMRole',
},
},
};

const importTemplate = buildImportTemplate(deployedTemplate, synthTemplate, ['OnlineEvalLogicalId']);

// Verify online eval config resource was added
expect(importTemplate.Resources.OnlineEvalLogicalId).toBeDefined();
expect(importTemplate.Resources.OnlineEvalLogicalId!.Type).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(importTemplate.Resources.OnlineEvalLogicalId!.DeletionPolicy).toBe('Retain');
expect(importTemplate.Resources.OnlineEvalLogicalId!.UpdateReplacePolicy).toBe('Retain');

// DependsOn should be removed for import
expect(importTemplate.Resources.OnlineEvalLogicalId!.DependsOn).toBeUndefined();

// Original resource should still be there
expect(importTemplate.Resources.ExistingIAMRole).toBeDefined();
});
});
11 changes: 6 additions & 5 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
import { registerImportMemory } from './import-memory';
import { registerImportOnlineEval } from './import-online-eval';
import { registerImportRuntime } from './import-runtime';
import type { Command } from '@commander-js/extra-typings';
import * as fs from 'node:fs';

const green = '\x1b[32m';
const yellow = '\x1b[33m';
const cyan = '\x1b[36m';
const dim = '\x1b[2m';
const reset = '\x1b[0m';
const { green, yellow, cyan, dim, reset } = ANSI;

export const registerImport = (program: Command) => {
const importCmd = program
Expand DownExpand Up@@ -151,4 +150,6 @@ export const registerImport = (program: Command) => {
// Register subcommands for importing individual resource types from AWS
registerImportRuntime(importCmd);
registerImportMemory(importCmd);
registerImportEvaluator(importCmd);
registerImportOnlineEval(importCmd);
};
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49be7fe
feat(import): add evaluator import subcommand with TUI wizard
jesseturner21 Apr 3, 2026
6f676d9
fix(import): use correct importType for evaluator in TUI flow
jesseturner21 Apr 3, 2026
6ca4030
feat(import): add online eval config import subcommand
jesseturner21 Apr 3, 2026
e21718f
feat(import): add online eval config to TUI import wizard
jesseturner21 Apr 3, 2026
cb4c675
docs: add TUI import wizard screenshots for online eval
jesseturner21 Apr 3, 2026
915b6c2
Revert "docs: add TUI import wizard screenshots for online eval"
jesseturner21 Apr 3, 2026
385f416
refactor(import): extract generic import orchestrator with descriptor…
jesseturner21 Apr 6, 2026
1f1b62c
refactor(aws): extract paginateAll and fetchTags helpers in agentcore…
jesseturner21 Apr 6, 2026
b2b3630
fix(import): resolve evaluator references via deployed state for impo…
jesseturner21 Apr 6, 2026
5839391
fix(import): auto-disable online eval configs to unlock evaluators du…
jesseturner21 Apr 6, 2026
1cadfc7
Revert "fix(import): auto-disable online eval configs to unlock evalu…
jesseturner21 Apr 6, 2026
5bed8ed
fix(import): block evaluator import when referenced by online eval, u…
jesseturner21 Apr 6, 2026
7bf2aee
fix(import): resolve OEC agent reference via deployed state when runt…
jesseturner21 Apr 6, 2026
1506e14
fix(import): strip CDK project prefix from OEC service name when reso…
jesseturner21 Apr 6, 2026
f5cbb56
fix(import): show friendly error for non-existent evaluator ID
jesseturner21 Apr 6, 2026
5f2a213
fix(import): validate ARN resource type for online-eval import
jesseturner21 Apr 6, 2026
612c7ac
refactor(import): address PR review feedback
jesseturner21 Apr 7, 2026
426d782
test(import): remove unreachable empty-level evaluator test
jesseturner21 Apr 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 234 additions & 51 deletions src/cli/aws/agentcore-control.ts

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts

Large diffs are not rendered by default.

368 changes: 368 additions & 0 deletions src/cli/commands/import/__tests__/import-online-eval.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,368 @@
/**
* Import Online Eval Config Unit Tests
*
* Covers:
* - extractAgentName: service name parsing
* - toOnlineEvalConfigSpec conversion: happy path, missing sampling, enableOnCreate
* - Template logical ID lookup for online eval configs
* - Phase 2 import resource list construction for online eval configs
*/
import type { GetOnlineEvalConfigResult } from '../../../aws/agentcore-control';
import { extractAgentName, toOnlineEvalConfigSpec } from '../import-online-eval';
import { buildImportTemplate, findLogicalIdByProperty, findLogicalIdsByType } from '../template-utils';
import type { CfnTemplate } from '../template-utils';
import type { ResourceToImport } from '../types';
import { describe, expect, it } from 'vitest';

// ============================================================================
// extractAgentName Tests
// ============================================================================

describe('extractAgentName', () => {
it('extracts agent name from service name with .DEFAULT suffix', () => {
expect(extractAgentName(['my_agent.DEFAULT'])).toBe('my_agent');
});

it('extracts agent name with project prefix pattern', () => {
expect(extractAgentName(['testproject_my_agent.DEFAULT'])).toBe('testproject_my_agent');
});

it('returns full string when no dot suffix', () => {
expect(extractAgentName(['my_agent'])).toBe('my_agent');
});

it('returns undefined for empty array', () => {
expect(extractAgentName([])).toBeUndefined();
});

it('uses first service name when multiple provided', () => {
expect(extractAgentName(['agent_one.DEFAULT', 'agent_two.DEFAULT'])).toBe('agent_one');
});

it('handles service name with multiple dots', () => {
expect(extractAgentName(['my.agent.DEFAULT'])).toBe('my.agent');
});
});

// ============================================================================
// toOnlineEvalConfigSpec Conversion Tests
// ============================================================================

describe('toOnlineEvalConfigSpec', () => {
it('maps online eval config with all fields', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-123',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-123',
configName: 'QualityMonitor',
status: 'ACTIVE',
executionStatus: 'ENABLED',
description: 'Monitor agent quality',
samplingPercentage: 50,
serviceNames: ['my_agent.DEFAULT'],
evaluatorIds: ['eval-456'],
};

const result = toOnlineEvalConfigSpec(detail, 'QualityMonitor', 'my_agent', ['my_evaluator']);

expect(result.name).toBe('QualityMonitor');
expect(result.agent).toBe('my_agent');
expect(result.evaluators).toEqual(['my_evaluator']);
expect(result.samplingRate).toBe(50);
expect(result.description).toBe('Monitor agent quality');
expect(result.enableOnCreate).toBe(true);
});

it('omits enableOnCreate when execution status is DISABLED', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-456',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-456',
configName: 'DisabledConfig',
status: 'ACTIVE',
executionStatus: 'DISABLED',
samplingPercentage: 10,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'DisabledConfig', 'agent', ['eval_one']);

expect(result.enableOnCreate).toBeUndefined();
});

it('omits description when not present', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-789',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-789',
configName: 'NoDesc',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 25,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'NoDesc', 'agent', ['eval_one']);

expect(result.description).toBeUndefined();
});

it('throws when sampling percentage is missing', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-no-sampling',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-no-sampling',
configName: 'NoSampling',
status: 'ACTIVE',
executionStatus: 'ENABLED',
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

expect(() => toOnlineEvalConfigSpec(detail, 'NoSampling', 'agent', ['eval_one'])).toThrow(
'has no sampling configuration'
);
});

it('supports multiple evaluator references', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-multi',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-multi',
configName: 'MultiEval',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 75,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1', 'eval-2'],
};

const result = toOnlineEvalConfigSpec(detail, 'MultiEval', 'agent', [
'local_eval',
'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-2',
]);

expect(result.evaluators).toHaveLength(2);
expect(result.evaluators[0]).toBe('local_eval');
expect(result.evaluators[1]).toMatch(/^arn:/);
});
});

// ============================================================================
// Template Logical ID Lookup Tests for Online Eval Configs
// ============================================================================

describe('Template Logical ID Lookup for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
MyOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
PrefixedOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'TestProject_PrefixedConfig',
},
},
MyAgentRuntime: {
Type: 'AWS::BedrockAgentCore::Runtime',
Properties: {
AgentRuntimeName: 'TestProject_my_agent',
},
},
MyIAMRole: {
Type: 'AWS::IAM::Role',
Properties: {
RoleName: 'MyRole',
},
},
},
};

it('finds online eval config logical ID by OnlineEvaluationConfigName property', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);
expect(logicalId).toBe('MyOnlineEvalConfig');
});

it('finds prefixed online eval config by full name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'TestProject_PrefixedConfig'
);
expect(logicalId).toBe('PrefixedOnlineEvalConfig');
});

it('finds all online eval config logical IDs by type', () => {
const logicalIds = findLogicalIdsByType(synthTemplate, 'AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(logicalIds).toHaveLength(2);
expect(logicalIds).toContain('MyOnlineEvalConfig');
expect(logicalIds).toContain('PrefixedOnlineEvalConfig');
});

it('returns undefined for non-existent config name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'nonexistent_config'
);
expect(logicalId).toBeUndefined();
});

it('falls back to single online eval config logical ID when name does not match', () => {
const singleConfigTemplate: CfnTemplate = {
Resources: {
OnlyConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'some_config',
},
},
},
};

let logicalId = findLogicalIdByProperty(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'different_name'
);

// Primary lookup fails
expect(logicalId).toBeUndefined();

// Fallback: if there's only one config resource, use it
if (!logicalId) {
const configLogicalIds = findLogicalIdsByType(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig'
);
if (configLogicalIds.length === 1) {
logicalId = configLogicalIds[0];
}
}
expect(logicalId).toBe('OnlyConfig');
});
});

// ============================================================================
// Phase 2 Resource Import List Construction for Online Eval Configs
// ============================================================================

describe('Phase 2: ResourceToImport List Construction for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

it('builds ResourceToImport list for online eval config', () => {
const configName = 'QualityMonitor';
const configId = 'oec-123';

const resourcesToImport: ResourceToImport[] = [];

const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
configName
);

if (logicalId) {
resourcesToImport.push({
resourceType: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
logicalResourceId: logicalId,
resourceIdentifier: { OnlineEvaluationConfigId: configId },
});
}

expect(resourcesToImport).toHaveLength(1);
expect(resourcesToImport[0]!.resourceType).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(resourcesToImport[0]!.logicalResourceId).toBe('OnlineEvalLogicalId');
expect(resourcesToImport[0]!.resourceIdentifier).toEqual({ OnlineEvaluationConfigId: 'oec-123' });
});

it('returns empty list when online eval config not found in template', () => {
const emptyTemplate: CfnTemplate = {
Resources: {
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

const logicalId = findLogicalIdByProperty(
emptyTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);

expect(logicalId).toBeUndefined();
});
});

// ============================================================================
// buildImportTemplate Tests for Online Eval Config Resources
// ============================================================================

describe('buildImportTemplate with Online Eval Config', () => {
it('adds online eval config resource to deployed template with Retain deletion policy', () => {
const deployedTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
},
};

const synthTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
DependsOn: 'ExistingIAMRole',
},
},
};

const importTemplate = buildImportTemplate(deployedTemplate, synthTemplate, ['OnlineEvalLogicalId']);

// Verify online eval config resource was added
expect(importTemplate.Resources.OnlineEvalLogicalId).toBeDefined();
expect(importTemplate.Resources.OnlineEvalLogicalId!.Type).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(importTemplate.Resources.OnlineEvalLogicalId!.DeletionPolicy).toBe('Retain');
expect(importTemplate.Resources.OnlineEvalLogicalId!.UpdateReplacePolicy).toBe('Retain');

// DependsOn should be removed for import
expect(importTemplate.Resources.OnlineEvalLogicalId!.DependsOn).toBeUndefined();

// Original resource should still be there
expect(importTemplate.Resources.ExistingIAMRole).toBeDefined();
});
});
11 changes: 6 additions & 5 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
import { registerImportMemory } from './import-memory';
import { registerImportOnlineEval } from './import-online-eval';
import { registerImportRuntime } from './import-runtime';
import type { Command } from '@commander-js/extra-typings';
import * as fs from 'node:fs';

const green = '\x1b[32m';
const yellow = '\x1b[33m';
const cyan = '\x1b[36m';
const dim = '\x1b[2m';
const reset = '\x1b[0m';
const { green, yellow, cyan, dim, reset } = ANSI;

export const registerImport = (program: Command) => {
const importCmd = program
Expand DownExpand Up@@ -151,4 +150,6 @@ export const registerImport = (program: Command) => {
// Register subcommands for importing individual resource types from AWS
registerImportRuntime(importCmd);
registerImportMemory(importCmd);
registerImportEvaluator(importCmd);
registerImportOnlineEval(importCmd);
};
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
49be7fe
feat(import): add evaluator import subcommand with TUI wizard
jesseturner21 Apr 3, 2026
6f676d9
fix(import): use correct importType for evaluator in TUI flow
jesseturner21 Apr 3, 2026
6ca4030
feat(import): add online eval config import subcommand
jesseturner21 Apr 3, 2026
e21718f
feat(import): add online eval config to TUI import wizard
jesseturner21 Apr 3, 2026
cb4c675
docs: add TUI import wizard screenshots for online eval
jesseturner21 Apr 3, 2026
915b6c2
Revert "docs: add TUI import wizard screenshots for online eval"
jesseturner21 Apr 3, 2026
385f416
refactor(import): extract generic import orchestrator with descriptor…
jesseturner21 Apr 6, 2026
1f1b62c
refactor(aws): extract paginateAll and fetchTags helpers in agentcore…
jesseturner21 Apr 6, 2026
b2b3630
fix(import): resolve evaluator references via deployed state for impo…
jesseturner21 Apr 6, 2026
5839391
fix(import): auto-disable online eval configs to unlock evaluators du…
jesseturner21 Apr 6, 2026
1cadfc7
Revert "fix(import): auto-disable online eval configs to unlock evalu…
jesseturner21 Apr 6, 2026
5bed8ed
fix(import): block evaluator import when referenced by online eval, u…
jesseturner21 Apr 6, 2026
7bf2aee
fix(import): resolve OEC agent reference via deployed state when runt…
jesseturner21 Apr 6, 2026
1506e14
fix(import): strip CDK project prefix from OEC service name when reso…
jesseturner21 Apr 6, 2026
f5cbb56
fix(import): show friendly error for non-existent evaluator ID
jesseturner21 Apr 6, 2026
5f2a213
fix(import): validate ARN resource type for online-eval import
jesseturner21 Apr 6, 2026
612c7ac
refactor(import): address PR review feedback
jesseturner21 Apr 7, 2026
426d782
test(import): remove unreachable empty-level evaluator test
jesseturner21 Apr 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
285 changes: 234 additions & 51 deletions src/cli/aws/agentcore-control.ts

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions src/cli/commands/import/__tests__/import-evaluator.test.ts

Large diffs are not rendered by default.

368 changes: 368 additions & 0 deletions src/cli/commands/import/__tests__/import-online-eval.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,368 @@
/**
* Import Online Eval Config Unit Tests
*
* Covers:
* - extractAgentName: service name parsing
* - toOnlineEvalConfigSpec conversion: happy path, missing sampling, enableOnCreate
* - Template logical ID lookup for online eval configs
* - Phase 2 import resource list construction for online eval configs
*/
import type { GetOnlineEvalConfigResult } from '../../../aws/agentcore-control';
import { extractAgentName, toOnlineEvalConfigSpec } from '../import-online-eval';
import { buildImportTemplate, findLogicalIdByProperty, findLogicalIdsByType } from '../template-utils';
import type { CfnTemplate } from '../template-utils';
import type { ResourceToImport } from '../types';
import { describe, expect, it } from 'vitest';

// ============================================================================
// extractAgentName Tests
// ============================================================================

describe('extractAgentName', () => {
it('extracts agent name from service name with .DEFAULT suffix', () => {
expect(extractAgentName(['my_agent.DEFAULT'])).toBe('my_agent');
});

it('extracts agent name with project prefix pattern', () => {
expect(extractAgentName(['testproject_my_agent.DEFAULT'])).toBe('testproject_my_agent');
});

it('returns full string when no dot suffix', () => {
expect(extractAgentName(['my_agent'])).toBe('my_agent');
});

it('returns undefined for empty array', () => {
expect(extractAgentName([])).toBeUndefined();
});

it('uses first service name when multiple provided', () => {
expect(extractAgentName(['agent_one.DEFAULT', 'agent_two.DEFAULT'])).toBe('agent_one');
});

it('handles service name with multiple dots', () => {
expect(extractAgentName(['my.agent.DEFAULT'])).toBe('my.agent');
});
});

// ============================================================================
// toOnlineEvalConfigSpec Conversion Tests
// ============================================================================

describe('toOnlineEvalConfigSpec', () => {
it('maps online eval config with all fields', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-123',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-123',
configName: 'QualityMonitor',
status: 'ACTIVE',
executionStatus: 'ENABLED',
description: 'Monitor agent quality',
samplingPercentage: 50,
serviceNames: ['my_agent.DEFAULT'],
evaluatorIds: ['eval-456'],
};

const result = toOnlineEvalConfigSpec(detail, 'QualityMonitor', 'my_agent', ['my_evaluator']);

expect(result.name).toBe('QualityMonitor');
expect(result.agent).toBe('my_agent');
expect(result.evaluators).toEqual(['my_evaluator']);
expect(result.samplingRate).toBe(50);
expect(result.description).toBe('Monitor agent quality');
expect(result.enableOnCreate).toBe(true);
});

it('omits enableOnCreate when execution status is DISABLED', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-456',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-456',
configName: 'DisabledConfig',
status: 'ACTIVE',
executionStatus: 'DISABLED',
samplingPercentage: 10,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'DisabledConfig', 'agent', ['eval_one']);

expect(result.enableOnCreate).toBeUndefined();
});

it('omits description when not present', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-789',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-789',
configName: 'NoDesc',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 25,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

const result = toOnlineEvalConfigSpec(detail, 'NoDesc', 'agent', ['eval_one']);

expect(result.description).toBeUndefined();
});

it('throws when sampling percentage is missing', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-no-sampling',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-no-sampling',
configName: 'NoSampling',
status: 'ACTIVE',
executionStatus: 'ENABLED',
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1'],
};

expect(() => toOnlineEvalConfigSpec(detail, 'NoSampling', 'agent', ['eval_one'])).toThrow(
'has no sampling configuration'
);
});

it('supports multiple evaluator references', () => {
const detail: GetOnlineEvalConfigResult = {
configId: 'oec-multi',
configArn: 'arn:aws:bedrock-agentcore:us-west-2:123456789012:online-evaluation-config/oec-multi',
configName: 'MultiEval',
status: 'ACTIVE',
executionStatus: 'ENABLED',
samplingPercentage: 75,
serviceNames: ['agent.DEFAULT'],
evaluatorIds: ['eval-1', 'eval-2'],
};

const result = toOnlineEvalConfigSpec(detail, 'MultiEval', 'agent', [
'local_eval',
'arn:aws:bedrock-agentcore:us-west-2:123456789012:evaluator/eval-2',
]);

expect(result.evaluators).toHaveLength(2);
expect(result.evaluators[0]).toBe('local_eval');
expect(result.evaluators[1]).toMatch(/^arn:/);
});
});

// ============================================================================
// Template Logical ID Lookup Tests for Online Eval Configs
// ============================================================================

describe('Template Logical ID Lookup for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
MyOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
PrefixedOnlineEvalConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'TestProject_PrefixedConfig',
},
},
MyAgentRuntime: {
Type: 'AWS::BedrockAgentCore::Runtime',
Properties: {
AgentRuntimeName: 'TestProject_my_agent',
},
},
MyIAMRole: {
Type: 'AWS::IAM::Role',
Properties: {
RoleName: 'MyRole',
},
},
},
};

it('finds online eval config logical ID by OnlineEvaluationConfigName property', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);
expect(logicalId).toBe('MyOnlineEvalConfig');
});

it('finds prefixed online eval config by full name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'TestProject_PrefixedConfig'
);
expect(logicalId).toBe('PrefixedOnlineEvalConfig');
});

it('finds all online eval config logical IDs by type', () => {
const logicalIds = findLogicalIdsByType(synthTemplate, 'AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(logicalIds).toHaveLength(2);
expect(logicalIds).toContain('MyOnlineEvalConfig');
expect(logicalIds).toContain('PrefixedOnlineEvalConfig');
});

it('returns undefined for non-existent config name', () => {
const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'nonexistent_config'
);
expect(logicalId).toBeUndefined();
});

it('falls back to single online eval config logical ID when name does not match', () => {
const singleConfigTemplate: CfnTemplate = {
Resources: {
OnlyConfig: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'some_config',
},
},
},
};

let logicalId = findLogicalIdByProperty(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'different_name'
);

// Primary lookup fails
expect(logicalId).toBeUndefined();

// Fallback: if there's only one config resource, use it
if (!logicalId) {
const configLogicalIds = findLogicalIdsByType(
singleConfigTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig'
);
if (configLogicalIds.length === 1) {
logicalId = configLogicalIds[0];
}
}
expect(logicalId).toBe('OnlyConfig');
});
});

// ============================================================================
// Phase 2 Resource Import List Construction for Online Eval Configs
// ============================================================================

describe('Phase 2: ResourceToImport List Construction for Online Eval Configs', () => {
const synthTemplate: CfnTemplate = {
Resources: {
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
},
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

it('builds ResourceToImport list for online eval config', () => {
const configName = 'QualityMonitor';
const configId = 'oec-123';

const resourcesToImport: ResourceToImport[] = [];

const logicalId = findLogicalIdByProperty(
synthTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
configName
);

if (logicalId) {
resourcesToImport.push({
resourceType: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
logicalResourceId: logicalId,
resourceIdentifier: { OnlineEvaluationConfigId: configId },
});
}

expect(resourcesToImport).toHaveLength(1);
expect(resourcesToImport[0]!.resourceType).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(resourcesToImport[0]!.logicalResourceId).toBe('OnlineEvalLogicalId');
expect(resourcesToImport[0]!.resourceIdentifier).toEqual({ OnlineEvaluationConfigId: 'oec-123' });
});

it('returns empty list when online eval config not found in template', () => {
const emptyTemplate: CfnTemplate = {
Resources: {
IAMRoleLogicalId: {
Type: 'AWS::IAM::Role',
Properties: {},
},
},
};

const logicalId = findLogicalIdByProperty(
emptyTemplate,
'AWS::BedrockAgentCore::OnlineEvaluationConfig',
'OnlineEvaluationConfigName',
'QualityMonitor'
);

expect(logicalId).toBeUndefined();
});
});

// ============================================================================
// buildImportTemplate Tests for Online Eval Config Resources
// ============================================================================

describe('buildImportTemplate with Online Eval Config', () => {
it('adds online eval config resource to deployed template with Retain deletion policy', () => {
const deployedTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
},
};

const synthTemplate: CfnTemplate = {
Resources: {
ExistingIAMRole: {
Type: 'AWS::IAM::Role',
Properties: { RoleName: 'ExistingRole' },
},
OnlineEvalLogicalId: {
Type: 'AWS::BedrockAgentCore::OnlineEvaluationConfig',
Properties: {
OnlineEvaluationConfigName: 'QualityMonitor',
},
DependsOn: 'ExistingIAMRole',
},
},
};

const importTemplate = buildImportTemplate(deployedTemplate, synthTemplate, ['OnlineEvalLogicalId']);

// Verify online eval config resource was added
expect(importTemplate.Resources.OnlineEvalLogicalId).toBeDefined();
expect(importTemplate.Resources.OnlineEvalLogicalId!.Type).toBe('AWS::BedrockAgentCore::OnlineEvaluationConfig');
expect(importTemplate.Resources.OnlineEvalLogicalId!.DeletionPolicy).toBe('Retain');
expect(importTemplate.Resources.OnlineEvalLogicalId!.UpdateReplacePolicy).toBe('Retain');

// DependsOn should be removed for import
expect(importTemplate.Resources.OnlineEvalLogicalId!.DependsOn).toBeUndefined();

// Original resource should still be there
expect(importTemplate.Resources.ExistingIAMRole).toBeDefined();
});
});
11 changes: 6 additions & 5 deletions src/cli/commands/import/command.ts
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
import { handleImport } from './actions';
import { ANSI } from './constants';
import { registerImportEvaluator } from './import-evaluator';
import { registerImportMemory } from './import-memory';
import { registerImportOnlineEval } from './import-online-eval';
import { registerImportRuntime } from './import-runtime';
import type { Command } from '@commander-js/extra-typings';
import * as fs from 'node:fs';

const green = '\x1b[32m';
const yellow = '\x1b[33m';
const cyan = '\x1b[36m';
const dim = '\x1b[2m';
const reset = '\x1b[0m';
const { green, yellow, cyan, dim, reset } = ANSI;

export const registerImport = (program: Command) => {
const importCmd = program
Expand DownExpand Up@@ -151,4 +150,6 @@ export const registerImport = (program: Command) => {
// Register subcommands for importing individual resource types from AWS
registerImportRuntime(importCmd);
registerImportMemory(importCmd);
registerImportEvaluator(importCmd);
registerImportOnlineEval(importCmd);
};
Loading
Loading